* [Intel-gfx] [PATCH RESEND] drm/i915/gvt: remove unused variable gma_bottom in command parser
@ 2023-05-31 2:04 Zhi Wang
2023-05-31 5:39 ` Zhenyu Wang
` (4 more replies)
0 siblings, 5 replies; 13+ messages in thread
From: Zhi Wang @ 2023-05-31 2:04 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula, intel-gvt-dev
Remove unused variable gma_bottom in scan_workload() and scan_wa_ctx().
commit be1da7070aea ("drm/i915/gvt: vGPU command scanner") introduces
gma_bottom in several functions to calculate the size of the command
buffer. However, some of them are set but actually unused.
When compiling the code with ccflags -Wunused-but-set-variable, gcc
throws warnings.
Remove unused variables to avoid the gcc warnings. Tested via compiling
the code with ccflags -Wunused-but-set-variable.
Fixes: be1da7070aea ("drm/i915/gvt: vGPU command scanner")
Suggested-by: Jani Nikula <jani.nikula@intel.com>
Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
Cc: intel-gvt-dev@lists.freedesktop.org
Signed-off-by: Zhi Wang <zhi.a.wang@intel.com>
---
drivers/gpu/drm/i915/gvt/cmd_parser.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/gvt/cmd_parser.c b/drivers/gpu/drm/i915/gvt/cmd_parser.c
index 3c4ae1da0d41..05f9348b7a9d 100644
--- a/drivers/gpu/drm/i915/gvt/cmd_parser.c
+++ b/drivers/gpu/drm/i915/gvt/cmd_parser.c
@@ -2833,7 +2833,7 @@ static int command_scan(struct parser_exec_state *s,
static int scan_workload(struct intel_vgpu_workload *workload)
{
- unsigned long gma_head, gma_tail, gma_bottom;
+ unsigned long gma_head, gma_tail;
struct parser_exec_state s;
int ret = 0;
@@ -2843,7 +2843,6 @@ static int scan_workload(struct intel_vgpu_workload *workload)
gma_head = workload->rb_start + workload->rb_head;
gma_tail = workload->rb_start + workload->rb_tail;
- gma_bottom = workload->rb_start + _RING_CTL_BUF_SIZE(workload->rb_ctl);
s.buf_type = RING_BUFFER_INSTRUCTION;
s.buf_addr_type = GTT_BUFFER;
@@ -2874,7 +2873,7 @@ static int scan_workload(struct intel_vgpu_workload *workload)
static int scan_wa_ctx(struct intel_shadow_wa_ctx *wa_ctx)
{
- unsigned long gma_head, gma_tail, gma_bottom, ring_size, ring_tail;
+ unsigned long gma_head, gma_tail, ring_size, ring_tail;
struct parser_exec_state s;
int ret = 0;
struct intel_vgpu_workload *workload = container_of(wa_ctx,
@@ -2891,7 +2890,6 @@ static int scan_wa_ctx(struct intel_shadow_wa_ctx *wa_ctx)
PAGE_SIZE);
gma_head = wa_ctx->indirect_ctx.guest_gma;
gma_tail = wa_ctx->indirect_ctx.guest_gma + ring_tail;
- gma_bottom = wa_ctx->indirect_ctx.guest_gma + ring_size;
s.buf_type = RING_BUFFER_INSTRUCTION;
s.buf_addr_type = GTT_BUFFER;
--
2.25.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH RESEND] drm/i915/gvt: remove unused variable gma_bottom in command parser
2023-05-31 2:04 [Intel-gfx] [PATCH RESEND] drm/i915/gvt: remove unused variable gma_bottom in command parser Zhi Wang
@ 2023-05-31 5:39 ` Zhenyu Wang
2023-05-31 9:27 ` Jani Nikula
2023-05-31 9:20 ` Andi Shyti
` (3 subsequent siblings)
4 siblings, 1 reply; 13+ messages in thread
From: Zhenyu Wang @ 2023-05-31 5:39 UTC (permalink / raw)
To: Zhi Wang; +Cc: Jani Nikula, intel-gfx, intel-gvt-dev
[-- Attachment #1: Type: text/plain, Size: 2749 bytes --]
On 2023.05.31 02:04:11 +0000, Zhi Wang wrote:
> Remove unused variable gma_bottom in scan_workload() and scan_wa_ctx().
> commit be1da7070aea ("drm/i915/gvt: vGPU command scanner") introduces
> gma_bottom in several functions to calculate the size of the command
> buffer. However, some of them are set but actually unused.
>
> When compiling the code with ccflags -Wunused-but-set-variable, gcc
> throws warnings.
>
> Remove unused variables to avoid the gcc warnings. Tested via compiling
> the code with ccflags -Wunused-but-set-variable.
>
> Fixes: be1da7070aea ("drm/i915/gvt: vGPU command scanner")
> Suggested-by: Jani Nikula <jani.nikula@intel.com>
> Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
> Cc: intel-gvt-dev@lists.freedesktop.org
> Signed-off-by: Zhi Wang <zhi.a.wang@intel.com>
> ---
Good with me. I think I also caught this before but never send the change..
Reviewed-by: Zhenyu Wang <zhenyuw@linux.intel.com>
> drivers/gpu/drm/i915/gvt/cmd_parser.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gvt/cmd_parser.c b/drivers/gpu/drm/i915/gvt/cmd_parser.c
> index 3c4ae1da0d41..05f9348b7a9d 100644
> --- a/drivers/gpu/drm/i915/gvt/cmd_parser.c
> +++ b/drivers/gpu/drm/i915/gvt/cmd_parser.c
> @@ -2833,7 +2833,7 @@ static int command_scan(struct parser_exec_state *s,
>
> static int scan_workload(struct intel_vgpu_workload *workload)
> {
> - unsigned long gma_head, gma_tail, gma_bottom;
> + unsigned long gma_head, gma_tail;
> struct parser_exec_state s;
> int ret = 0;
>
> @@ -2843,7 +2843,6 @@ static int scan_workload(struct intel_vgpu_workload *workload)
>
> gma_head = workload->rb_start + workload->rb_head;
> gma_tail = workload->rb_start + workload->rb_tail;
> - gma_bottom = workload->rb_start + _RING_CTL_BUF_SIZE(workload->rb_ctl);
>
> s.buf_type = RING_BUFFER_INSTRUCTION;
> s.buf_addr_type = GTT_BUFFER;
> @@ -2874,7 +2873,7 @@ static int scan_workload(struct intel_vgpu_workload *workload)
> static int scan_wa_ctx(struct intel_shadow_wa_ctx *wa_ctx)
> {
>
> - unsigned long gma_head, gma_tail, gma_bottom, ring_size, ring_tail;
> + unsigned long gma_head, gma_tail, ring_size, ring_tail;
> struct parser_exec_state s;
> int ret = 0;
> struct intel_vgpu_workload *workload = container_of(wa_ctx,
> @@ -2891,7 +2890,6 @@ static int scan_wa_ctx(struct intel_shadow_wa_ctx *wa_ctx)
> PAGE_SIZE);
> gma_head = wa_ctx->indirect_ctx.guest_gma;
> gma_tail = wa_ctx->indirect_ctx.guest_gma + ring_tail;
> - gma_bottom = wa_ctx->indirect_ctx.guest_gma + ring_size;
>
> s.buf_type = RING_BUFFER_INSTRUCTION;
> s.buf_addr_type = GTT_BUFFER;
> --
> 2.25.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH RESEND] drm/i915/gvt: remove unused variable gma_bottom in command parser
2023-05-31 2:04 [Intel-gfx] [PATCH RESEND] drm/i915/gvt: remove unused variable gma_bottom in command parser Zhi Wang
2023-05-31 5:39 ` Zhenyu Wang
@ 2023-05-31 9:20 ` Andi Shyti
2023-05-31 16:57 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gvt: remove unused variable gma_bottom in command parser (rev2) Patchwork
` (2 subsequent siblings)
4 siblings, 0 replies; 13+ messages in thread
From: Andi Shyti @ 2023-05-31 9:20 UTC (permalink / raw)
To: Zhi Wang; +Cc: Jani Nikula, intel-gfx, intel-gvt-dev
Hi Zhi,
On Wed, May 31, 2023 at 02:04:11AM +0000, Zhi Wang wrote:
> Remove unused variable gma_bottom in scan_workload() and scan_wa_ctx().
> commit be1da7070aea ("drm/i915/gvt: vGPU command scanner") introduces
> gma_bottom in several functions to calculate the size of the command
> buffer. However, some of them are set but actually unused.
>
> When compiling the code with ccflags -Wunused-but-set-variable, gcc
> throws warnings.
>
> Remove unused variables to avoid the gcc warnings. Tested via compiling
> the code with ccflags -Wunused-but-set-variable.
>
> Fixes: be1da7070aea ("drm/i915/gvt: vGPU command scanner")
> Suggested-by: Jani Nikula <jani.nikula@intel.com>
> Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
> Cc: intel-gvt-dev@lists.freedesktop.org
> Signed-off-by: Zhi Wang <zhi.a.wang@intel.com>
looks good:
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Andi
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH RESEND] drm/i915/gvt: remove unused variable gma_bottom in command parser
2023-05-31 5:39 ` Zhenyu Wang
@ 2023-05-31 9:27 ` Jani Nikula
2023-06-07 9:34 ` Zhenyu Wang
0 siblings, 1 reply; 13+ messages in thread
From: Jani Nikula @ 2023-05-31 9:27 UTC (permalink / raw)
To: Zhenyu Wang, Zhi Wang; +Cc: intel-gfx, intel-gvt-dev
On Wed, 31 May 2023, Zhenyu Wang <zhenyuw@linux.intel.com> wrote:
> On 2023.05.31 02:04:11 +0000, Zhi Wang wrote:
>> Remove unused variable gma_bottom in scan_workload() and scan_wa_ctx().
>> commit be1da7070aea ("drm/i915/gvt: vGPU command scanner") introduces
>> gma_bottom in several functions to calculate the size of the command
>> buffer. However, some of them are set but actually unused.
>>
>> When compiling the code with ccflags -Wunused-but-set-variable, gcc
>> throws warnings.
>>
>> Remove unused variables to avoid the gcc warnings. Tested via compiling
>> the code with ccflags -Wunused-but-set-variable.
>>
>> Fixes: be1da7070aea ("drm/i915/gvt: vGPU command scanner")
>> Suggested-by: Jani Nikula <jani.nikula@intel.com>
>> Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
>> Cc: intel-gvt-dev@lists.freedesktop.org
>> Signed-off-by: Zhi Wang <zhi.a.wang@intel.com>
>> ---
>
> Good with me. I think I also caught this before but never send the change..
> Reviewed-by: Zhenyu Wang <zhenyuw@linux.intel.com>
I'd like to pick this up via drm-intel-next if that's all right.
BR,
Jani.
>
>> drivers/gpu/drm/i915/gvt/cmd_parser.c | 6 ++----
>> 1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gvt/cmd_parser.c b/drivers/gpu/drm/i915/gvt/cmd_parser.c
>> index 3c4ae1da0d41..05f9348b7a9d 100644
>> --- a/drivers/gpu/drm/i915/gvt/cmd_parser.c
>> +++ b/drivers/gpu/drm/i915/gvt/cmd_parser.c
>> @@ -2833,7 +2833,7 @@ static int command_scan(struct parser_exec_state *s,
>>
>> static int scan_workload(struct intel_vgpu_workload *workload)
>> {
>> - unsigned long gma_head, gma_tail, gma_bottom;
>> + unsigned long gma_head, gma_tail;
>> struct parser_exec_state s;
>> int ret = 0;
>>
>> @@ -2843,7 +2843,6 @@ static int scan_workload(struct intel_vgpu_workload *workload)
>>
>> gma_head = workload->rb_start + workload->rb_head;
>> gma_tail = workload->rb_start + workload->rb_tail;
>> - gma_bottom = workload->rb_start + _RING_CTL_BUF_SIZE(workload->rb_ctl);
>>
>> s.buf_type = RING_BUFFER_INSTRUCTION;
>> s.buf_addr_type = GTT_BUFFER;
>> @@ -2874,7 +2873,7 @@ static int scan_workload(struct intel_vgpu_workload *workload)
>> static int scan_wa_ctx(struct intel_shadow_wa_ctx *wa_ctx)
>> {
>>
>> - unsigned long gma_head, gma_tail, gma_bottom, ring_size, ring_tail;
>> + unsigned long gma_head, gma_tail, ring_size, ring_tail;
>> struct parser_exec_state s;
>> int ret = 0;
>> struct intel_vgpu_workload *workload = container_of(wa_ctx,
>> @@ -2891,7 +2890,6 @@ static int scan_wa_ctx(struct intel_shadow_wa_ctx *wa_ctx)
>> PAGE_SIZE);
>> gma_head = wa_ctx->indirect_ctx.guest_gma;
>> gma_tail = wa_ctx->indirect_ctx.guest_gma + ring_tail;
>> - gma_bottom = wa_ctx->indirect_ctx.guest_gma + ring_size;
>>
>> s.buf_type = RING_BUFFER_INSTRUCTION;
>> s.buf_addr_type = GTT_BUFFER;
>> --
>> 2.25.1
>>
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gvt: remove unused variable gma_bottom in command parser (rev2)
2023-05-31 2:04 [Intel-gfx] [PATCH RESEND] drm/i915/gvt: remove unused variable gma_bottom in command parser Zhi Wang
2023-05-31 5:39 ` Zhenyu Wang
2023-05-31 9:20 ` Andi Shyti
@ 2023-05-31 16:57 ` Patchwork
2023-06-02 17:02 ` Jani Nikula
2023-05-31 17:11 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-06-02 5:21 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
4 siblings, 1 reply; 13+ messages in thread
From: Patchwork @ 2023-05-31 16:57 UTC (permalink / raw)
To: Zhi Wang; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/gvt: remove unused variable gma_bottom in command parser (rev2)
URL : https://patchwork.freedesktop.org/series/118512/
State : warning
== Summary ==
Error: dim checkpatch failed
c6878ab01be9 drm/i915/gvt: remove unused variable gma_bottom in command parser
-:63: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Zhi Wang <zhi.wang.linux@gmail.com>' != 'Signed-off-by: Zhi Wang <zhi.a.wang@intel.com>'
total: 0 errors, 1 warnings, 0 checks, 30 lines checked
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gvt: remove unused variable gma_bottom in command parser (rev2)
2023-05-31 2:04 [Intel-gfx] [PATCH RESEND] drm/i915/gvt: remove unused variable gma_bottom in command parser Zhi Wang
` (2 preceding siblings ...)
2023-05-31 16:57 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gvt: remove unused variable gma_bottom in command parser (rev2) Patchwork
@ 2023-05-31 17:11 ` Patchwork
2023-06-02 5:21 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
4 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2023-05-31 17:11 UTC (permalink / raw)
To: Zhi Wang; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 9275 bytes --]
== Series Details ==
Series: drm/i915/gvt: remove unused variable gma_bottom in command parser (rev2)
URL : https://patchwork.freedesktop.org/series/118512/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13207 -> Patchwork_118512v2
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118512v2/index.html
Participating hosts (36 -> 36)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_118512v2:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@kms_flip@basic-flip-vs-wf_vblank@b-dp5:
- {bat-adlp-11}: NOTRUN -> [FAIL][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118512v2/bat-adlp-11/igt@kms_flip@basic-flip-vs-wf_vblank@b-dp5.html
Known issues
------------
Here are the changes found in Patchwork_118512v2 that come from known issues:
### CI changes ###
#### Possible fixes ####
* boot:
- fi-kbl-8809g: [FAIL][2] ([i915#8293] / [i915#8298]) -> [PASS][3]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13207/fi-kbl-8809g/boot.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118512v2/fi-kbl-8809g/boot.html
### IGT changes ###
#### Issues hit ####
* igt@core_hotunplug@unbind-rebind:
- fi-kbl-8809g: NOTRUN -> [ABORT][4] ([i915#8298] / [i915#8299] / [i915#8397])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118512v2/fi-kbl-8809g/igt@core_hotunplug@unbind-rebind.html
* igt@gem_huc_copy@huc-copy:
- fi-kbl-8809g: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#2190])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118512v2/fi-kbl-8809g/igt@gem_huc_copy@huc-copy.html
* igt@i915_selftest@live@slpc:
- bat-rpls-1: NOTRUN -> [DMESG-WARN][6] ([i915#6367])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118512v2/bat-rpls-1/igt@i915_selftest@live@slpc.html
* igt@i915_suspend@basic-s3-without-i915:
- bat-adls-5: [PASS][7] -> [FAIL][8] ([fdo#103375]) +3 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13207/bat-adls-5/igt@i915_suspend@basic-s3-without-i915.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118512v2/bat-adls-5/igt@i915_suspend@basic-s3-without-i915.html
- bat-rpls-1: NOTRUN -> [ABORT][9] ([i915#6687] / [i915#7978])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118512v2/bat-rpls-1/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_addfb_basic@too-high:
- fi-kbl-8809g: NOTRUN -> [FAIL][10] ([i915#8296]) +2 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118512v2/fi-kbl-8809g/igt@kms_addfb_basic@too-high.html
* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- bat-adlp-9: NOTRUN -> [SKIP][11] ([i915#7828])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118512v2/bat-adlp-9/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
* igt@kms_force_connector_basic@force-connector-state:
- fi-kbl-8809g: NOTRUN -> [DMESG-FAIL][12] ([i915#8299])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118512v2/fi-kbl-8809g/igt@kms_force_connector_basic@force-connector-state.html
* igt@kms_force_connector_basic@force-edid:
- fi-kbl-8809g: NOTRUN -> [CRASH][13] ([i915#8299])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118512v2/fi-kbl-8809g/igt@kms_force_connector_basic@force-edid.html
* igt@kms_psr@cursor_plane_move:
- fi-kbl-8809g: NOTRUN -> [SKIP][14] ([fdo#109271]) +59 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118512v2/fi-kbl-8809g/igt@kms_psr@cursor_plane_move.html
* igt@kms_setmode@basic-clone-single-crtc:
- fi-kbl-8809g: NOTRUN -> [SKIP][15] ([fdo#109271] / [i915#4579])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118512v2/fi-kbl-8809g/igt@kms_setmode@basic-clone-single-crtc.html
#### Possible fixes ####
* igt@i915_module_load@load:
- {bat-adlp-11}: [ABORT][16] ([i915#4423] / [i915#8189]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13207/bat-adlp-11/igt@i915_module_load@load.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118512v2/bat-adlp-11/igt@i915_module_load@load.html
* igt@i915_selftest@live@migrate:
- bat-dg2-11: [DMESG-WARN][18] ([i915#7699]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13207/bat-dg2-11/igt@i915_selftest@live@migrate.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118512v2/bat-dg2-11/igt@i915_selftest@live@migrate.html
* igt@i915_selftest@live@requests:
- {bat-mtlp-8}: [DMESG-FAIL][20] ([i915#8497]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13207/bat-mtlp-8/igt@i915_selftest@live@requests.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118512v2/bat-mtlp-8/igt@i915_selftest@live@requests.html
- bat-rpls-1: [ABORT][22] ([i915#7911] / [i915#7920] / [i915#7982]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13207/bat-rpls-1/igt@i915_selftest@live@requests.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118512v2/bat-rpls-1/igt@i915_selftest@live@requests.html
* igt@i915_selftest@live@workarounds:
- bat-adlp-9: [INCOMPLETE][24] ([i915#4983] / [i915#7677] / [i915#7913]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13207/bat-adlp-9/igt@i915_selftest@live@workarounds.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118512v2/bat-adlp-9/igt@i915_selftest@live@workarounds.html
* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-d-dp-1:
- bat-dg2-8: [FAIL][26] ([i915#7932]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13207/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-d-dp-1.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118512v2/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-d-dp-1.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#6121]: https://gitlab.freedesktop.org/drm/intel/issues/6121
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
[i915#6868]: https://gitlab.freedesktop.org/drm/intel/issues/6868
[i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7677]: https://gitlab.freedesktop.org/drm/intel/issues/7677
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7911]: https://gitlab.freedesktop.org/drm/intel/issues/7911
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7920]: https://gitlab.freedesktop.org/drm/intel/issues/7920
[i915#7932]: https://gitlab.freedesktop.org/drm/intel/issues/7932
[i915#7978]: https://gitlab.freedesktop.org/drm/intel/issues/7978
[i915#7982]: https://gitlab.freedesktop.org/drm/intel/issues/7982
[i915#8189]: https://gitlab.freedesktop.org/drm/intel/issues/8189
[i915#8293]: https://gitlab.freedesktop.org/drm/intel/issues/8293
[i915#8296]: https://gitlab.freedesktop.org/drm/intel/issues/8296
[i915#8298]: https://gitlab.freedesktop.org/drm/intel/issues/8298
[i915#8299]: https://gitlab.freedesktop.org/drm/intel/issues/8299
[i915#8397]: https://gitlab.freedesktop.org/drm/intel/issues/8397
[i915#8497]: https://gitlab.freedesktop.org/drm/intel/issues/8497
Build changes
-------------
* Linux: CI_DRM_13207 -> Patchwork_118512v2
CI-20190529: 20190529
CI_DRM_13207: e4b4b268de5e5b01c28b3d24b43453eaec2da37e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7314: ab70dfcdecf93a17fcaddb774855f726325fa0dd @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_118512v2: e4b4b268de5e5b01c28b3d24b43453eaec2da37e @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
b35d36e9dd2b drm/i915/gvt: remove unused variable gma_bottom in command parser
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118512v2/index.html
[-- Attachment #2: Type: text/html, Size: 10183 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gvt: remove unused variable gma_bottom in command parser (rev2)
2023-05-31 2:04 [Intel-gfx] [PATCH RESEND] drm/i915/gvt: remove unused variable gma_bottom in command parser Zhi Wang
` (3 preceding siblings ...)
2023-05-31 17:11 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2023-06-02 5:21 ` Patchwork
4 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2023-06-02 5:21 UTC (permalink / raw)
To: Zhi Wang; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 18374 bytes --]
== Series Details ==
Series: drm/i915/gvt: remove unused variable gma_bottom in command parser (rev2)
URL : https://patchwork.freedesktop.org/series/118512/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13207_full -> Patchwork_118512v2_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_118512v2_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_118512v2_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (7 -> 7)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_118512v2_full:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@gt_timelines:
- shard-apl: [PASS][1] -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13207/shard-apl1/igt@i915_selftest@live@gt_timelines.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118512v2/shard-apl3/igt@i915_selftest@live@gt_timelines.html
* igt@kms_big_fb@linear-16bpp-rotate-180:
- shard-apl: [PASS][3] -> [DMESG-WARN][4] +37 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13207/shard-apl2/igt@kms_big_fb@linear-16bpp-rotate-180.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118512v2/shard-apl2/igt@kms_big_fb@linear-16bpp-rotate-180.html
#### Warnings ####
* igt@kms_plane_alpha_blend@alpha-transparent-fb@pipe-c-dp-1:
- shard-apl: [FAIL][5] ([i915#4573]) -> [DMESG-FAIL][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13207/shard-apl2/igt@kms_plane_alpha_blend@alpha-transparent-fb@pipe-c-dp-1.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118512v2/shard-apl2/igt@kms_plane_alpha_blend@alpha-transparent-fb@pipe-c-dp-1.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@gem_exec_balancer@noheartbeat:
- {shard-dg1}: NOTRUN -> [SKIP][7]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118512v2/shard-dg1-19/igt@gem_exec_balancer@noheartbeat.html
Known issues
------------
Here are the changes found in Patchwork_118512v2_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fair@basic-deadline:
- shard-glk: [PASS][8] -> [FAIL][9] ([i915#2846])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13207/shard-glk3/igt@gem_exec_fair@basic-deadline.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118512v2/shard-glk5/igt@gem_exec_fair@basic-deadline.html
* igt@gem_lmem_swapping@parallel-random-engines:
- shard-glk: NOTRUN -> [SKIP][10] ([fdo#109271] / [i915#4613])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118512v2/shard-glk9/igt@gem_lmem_swapping@parallel-random-engines.html
* igt@gem_pwrite@basic-exhaustion:
- shard-glk: NOTRUN -> [WARN][11] ([i915#2658])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118512v2/shard-glk9/igt@gem_pwrite@basic-exhaustion.html
* igt@gem_userptr_blits@vma-merge:
- shard-glk: NOTRUN -> [FAIL][12] ([i915#3318])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118512v2/shard-glk9/igt@gem_userptr_blits@vma-merge.html
* igt@kms_ccs@pipe-a-crc-primary-rotation-180-4_tiled_dg2_rc_ccs:
- shard-snb: NOTRUN -> [SKIP][13] ([fdo#109271]) +21 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118512v2/shard-snb5/igt@kms_ccs@pipe-a-crc-primary-rotation-180-4_tiled_dg2_rc_ccs.html
* igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_gen12_rc_ccs_cc:
- shard-glk: NOTRUN -> [SKIP][14] ([fdo#109271] / [i915#3886]) +1 similar issue
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118512v2/shard-glk7/igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_content_protection@lic:
- shard-glk: NOTRUN -> [SKIP][15] ([fdo#109271] / [i915#4579]) +8 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118512v2/shard-glk9/igt@kms_content_protection@lic.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-apl: [PASS][16] -> [FAIL][17] ([i915#2346])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13207/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118512v2/shard-apl3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_cursor_legacy@flip-vs-cursor-toggle:
- shard-apl: [PASS][18] -> [DMESG-WARN][19] ([i915#1982])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13207/shard-apl2/igt@kms_cursor_legacy@flip-vs-cursor-toggle.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118512v2/shard-apl2/igt@kms_cursor_legacy@flip-vs-cursor-toggle.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-glk: NOTRUN -> [FAIL][20] ([i915#4767])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118512v2/shard-glk7/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@2x-flip-vs-expired-vblank@bc-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][21] -> [FAIL][22] ([i915#79])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13207/shard-glk5/igt@kms_flip@2x-flip-vs-expired-vblank@bc-hdmi-a1-hdmi-a2.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118512v2/shard-glk3/igt@kms_flip@2x-flip-vs-expired-vblank@bc-hdmi-a1-hdmi-a2.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-gtt:
- shard-glk: NOTRUN -> [SKIP][23] ([fdo#109271]) +116 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118512v2/shard-glk9/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-gtt.html
* igt@kms_plane_scaling@planes-downscale-factor-0-5-unity-scaling@pipe-b-vga-1:
- shard-snb: NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#4579]) +12 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118512v2/shard-snb6/igt@kms_plane_scaling@planes-downscale-factor-0-5-unity-scaling@pipe-b-vga-1.html
* igt@kms_psr2_sf@overlay-plane-update-continuous-sf:
- shard-glk: NOTRUN -> [SKIP][25] ([fdo#109271] / [i915#658]) +2 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118512v2/shard-glk9/igt@kms_psr2_sf@overlay-plane-update-continuous-sf.html
#### Possible fixes ####
* igt@gem_ctx_exec@basic-nohangcheck:
- {shard-tglu}: [FAIL][26] ([i915#6268]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13207/shard-tglu-9/igt@gem_ctx_exec@basic-nohangcheck.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118512v2/shard-tglu-4/igt@gem_ctx_exec@basic-nohangcheck.html
* igt@gem_exec_fair@basic-none@vcs0:
- {shard-rkl}: [FAIL][28] ([i915#2842]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13207/shard-rkl-6/igt@gem_exec_fair@basic-none@vcs0.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118512v2/shard-rkl-6/igt@gem_exec_fair@basic-none@vcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][30] ([i915#2842]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13207/shard-glk1/igt@gem_exec_fair@basic-pace-share@rcs0.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118512v2/shard-glk5/igt@gem_exec_fair@basic-pace-share@rcs0.html
- {shard-tglu}: [FAIL][32] ([i915#2842]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13207/shard-tglu-6/igt@gem_exec_fair@basic-pace-share@rcs0.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118512v2/shard-tglu-8/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gen9_exec_parse@allowed-single:
- shard-glk: [ABORT][34] ([i915#5566]) -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13207/shard-glk2/igt@gen9_exec_parse@allowed-single.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118512v2/shard-glk9/igt@gen9_exec_parse@allowed-single.html
* igt@i915_pm_rc6_residency@rc6-idle@rcs0:
- {shard-dg1}: [FAIL][36] ([i915#3591]) -> [PASS][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13207/shard-dg1-16/igt@i915_pm_rc6_residency@rc6-idle@rcs0.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118512v2/shard-dg1-14/igt@i915_pm_rc6_residency@rc6-idle@rcs0.html
* igt@i915_pm_rpm@dpms-non-lpsp:
- {shard-rkl}: [SKIP][38] ([i915#1397]) -> [PASS][39] +1 similar issue
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13207/shard-rkl-7/igt@i915_pm_rpm@dpms-non-lpsp.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118512v2/shard-rkl-6/igt@i915_pm_rpm@dpms-non-lpsp.html
* igt@i915_suspend@basic-s3-without-i915:
- shard-glk: [INCOMPLETE][40] ([i915#4817]) -> [PASS][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13207/shard-glk7/igt@i915_suspend@basic-s3-without-i915.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118512v2/shard-glk9/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-async-flip:
- {shard-rkl}: [FAIL][42] ([i915#3743]) -> [PASS][43]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13207/shard-rkl-7/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118512v2/shard-rkl-6/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html
* igt@kms_cursor_legacy@single-bo@pipe-b:
- {shard-dg1}: [INCOMPLETE][44] ([i915#8011] / [i915#8347]) -> [PASS][45]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13207/shard-dg1-19/igt@kms_cursor_legacy@single-bo@pipe-b.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118512v2/shard-dg1-15/igt@kms_cursor_legacy@single-bo@pipe-b.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1257]: https://gitlab.freedesktop.org/drm/intel/issues/1257
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3778]: https://gitlab.freedesktop.org/drm/intel/issues/3778
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4573]: https://gitlab.freedesktop.org/drm/intel/issues/4573
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4816]: https://gitlab.freedesktop.org/drm/intel/issues/4816
[i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
[i915#4881]: https://gitlab.freedesktop.org/drm/intel/issues/4881
[i915#4885]: https://gitlab.freedesktop.org/drm/intel/issues/4885
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6806]: https://gitlab.freedesktop.org/drm/intel/issues/6806
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7178]: https://gitlab.freedesktop.org/drm/intel/issues/7178
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#7941]: https://gitlab.freedesktop.org/drm/intel/issues/7941
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8247]: https://gitlab.freedesktop.org/drm/intel/issues/8247
[i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
[i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
[i915#8381]: https://gitlab.freedesktop.org/drm/intel/issues/8381
[i915#8411]: https://gitlab.freedesktop.org/drm/intel/issues/8411
[i915#8414]: https://gitlab.freedesktop.org/drm/intel/issues/8414
[i915#8502]: https://gitlab.freedesktop.org/drm/intel/issues/8502
[i915#8555]: https://gitlab.freedesktop.org/drm/intel/issues/8555
Build changes
-------------
* Linux: CI_DRM_13207 -> Patchwork_118512v2
CI-20190529: 20190529
CI_DRM_13207: e4b4b268de5e5b01c28b3d24b43453eaec2da37e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7314: ab70dfcdecf93a17fcaddb774855f726325fa0dd @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_118512v2: e4b4b268de5e5b01c28b3d24b43453eaec2da37e @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118512v2/index.html
[-- Attachment #2: Type: text/html, Size: 14586 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gvt: remove unused variable gma_bottom in command parser (rev2)
2023-05-31 16:57 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gvt: remove unused variable gma_bottom in command parser (rev2) Patchwork
@ 2023-06-02 17:02 ` Jani Nikula
2023-06-05 14:35 ` Jani Nikula
0 siblings, 1 reply; 13+ messages in thread
From: Jani Nikula @ 2023-06-02 17:02 UTC (permalink / raw)
To: Zhi Wang; +Cc: intel-gfx
On Wed, 31 May 2023, Patchwork <patchwork@emeril.freedesktop.org> wrote:
> == Series Details ==
>
> Series: drm/i915/gvt: remove unused variable gma_bottom in command parser (rev2)
> URL : https://patchwork.freedesktop.org/series/118512/
> State : warning
>
> == Summary ==
>
> Error: dim checkpatch failed
> c6878ab01be9 drm/i915/gvt: remove unused variable gma_bottom in command parser
> -:63: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Zhi Wang <zhi.wang.linux@gmail.com>' != 'Signed-off-by: Zhi Wang <zhi.a.wang@intel.com>'
I can fix this while applying, but please indicate whether you intended
to have From: Zhi Wang <zhi.a.wang@intel.com> or Signed-off-by: Zhi Wang
<zhi.wang.linux@gmail.com>.
BR,
Jani.
>
> total: 0 errors, 1 warnings, 0 checks, 30 lines checked
>
>
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gvt: remove unused variable gma_bottom in command parser (rev2)
2023-06-02 17:02 ` Jani Nikula
@ 2023-06-05 14:35 ` Jani Nikula
2023-06-08 8:14 ` Wang, Zhi A
0 siblings, 1 reply; 13+ messages in thread
From: Jani Nikula @ 2023-06-05 14:35 UTC (permalink / raw)
To: Zhi Wang; +Cc: intel-gfx
On Fri, 02 Jun 2023, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> On Wed, 31 May 2023, Patchwork <patchwork@emeril.freedesktop.org> wrote:
>> == Series Details ==
>>
>> Series: drm/i915/gvt: remove unused variable gma_bottom in command parser (rev2)
>> URL : https://patchwork.freedesktop.org/series/118512/
>> State : warning
>>
>> == Summary ==
>>
>> Error: dim checkpatch failed
>> c6878ab01be9 drm/i915/gvt: remove unused variable gma_bottom in command parser
>> -:63: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Zhi Wang <zhi.wang.linux@gmail.com>' != 'Signed-off-by: Zhi Wang <zhi.a.wang@intel.com>'
>
> I can fix this while applying, but please indicate whether you intended
> to have From: Zhi Wang <zhi.a.wang@intel.com> or Signed-off-by: Zhi Wang
> <zhi.wang.linux@gmail.com>.
Ping. I can't apply this with this warning, and I can't fix
Signed-off-by unless you tell me what to do.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH RESEND] drm/i915/gvt: remove unused variable gma_bottom in command parser
2023-05-31 9:27 ` Jani Nikula
@ 2023-06-07 9:34 ` Zhenyu Wang
0 siblings, 0 replies; 13+ messages in thread
From: Zhenyu Wang @ 2023-06-07 9:34 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx, intel-gvt-dev, Zhi Wang
[-- Attachment #1: Type: text/plain, Size: 1318 bytes --]
On 2023.05.31 12:27:11 +0300, Jani Nikula wrote:
> On Wed, 31 May 2023, Zhenyu Wang <zhenyuw@linux.intel.com> wrote:
> > On 2023.05.31 02:04:11 +0000, Zhi Wang wrote:
> >> Remove unused variable gma_bottom in scan_workload() and scan_wa_ctx().
> >> commit be1da7070aea ("drm/i915/gvt: vGPU command scanner") introduces
> >> gma_bottom in several functions to calculate the size of the command
> >> buffer. However, some of them are set but actually unused.
> >>
> >> When compiling the code with ccflags -Wunused-but-set-variable, gcc
> >> throws warnings.
> >>
> >> Remove unused variables to avoid the gcc warnings. Tested via compiling
> >> the code with ccflags -Wunused-but-set-variable.
> >>
> >> Fixes: be1da7070aea ("drm/i915/gvt: vGPU command scanner")
> >> Suggested-by: Jani Nikula <jani.nikula@intel.com>
> >> Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
> >> Cc: intel-gvt-dev@lists.freedesktop.org
> >> Signed-off-by: Zhi Wang <zhi.a.wang@intel.com>
> >> ---
> >
> > Good with me. I think I also caught this before but never send the change..
> > Reviewed-by: Zhenyu Wang <zhenyuw@linux.intel.com>
>
> I'd like to pick this up via drm-intel-next if that's all right.
>
Sorry for missed this. Pls feel free to do so. I'll sync to check anything left in gvt tree.
Thanks.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gvt: remove unused variable gma_bottom in command parser (rev2)
2023-06-05 14:35 ` Jani Nikula
@ 2023-06-08 8:14 ` Wang, Zhi A
2023-06-08 9:00 ` Jani Nikula
0 siblings, 1 reply; 13+ messages in thread
From: Wang, Zhi A @ 2023-06-08 8:14 UTC (permalink / raw)
To: Jani Nikula, Zhi Wang; +Cc: intel-gfx@lists.freedesktop.org
Hi Jani:
Please take the <zhi.a.wang@intel.com> as my S-O-B since this is a patch about GVT-g. I still don't know why my intel email smtp doesn't work.
Thanks,
Zhi.
-----Original Message-----
From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Jani Nikula
Sent: Monday, June 5, 2023 10:36 PM
To: Zhi Wang <zhi.wang.linux@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gvt: remove unused variable gma_bottom in command parser (rev2)
On Fri, 02 Jun 2023, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> On Wed, 31 May 2023, Patchwork <patchwork@emeril.freedesktop.org> wrote:
>> == Series Details ==
>>
>> Series: drm/i915/gvt: remove unused variable gma_bottom in command parser (rev2)
>> URL : https://patchwork.freedesktop.org/series/118512/
>> State : warning
>>
>> == Summary ==
>>
>> Error: dim checkpatch failed
>> c6878ab01be9 drm/i915/gvt: remove unused variable gma_bottom in
>> command parser
>> -:63: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Zhi Wang <zhi.wang.linux@gmail.com>' != 'Signed-off-by: Zhi Wang <zhi.a.wang@intel.com>'
>
> I can fix this while applying, but please indicate whether you
> intended to have From: Zhi Wang <zhi.a.wang@intel.com> or
> Signed-off-by: Zhi Wang <zhi.wang.linux@gmail.com>.
Ping. I can't apply this with this warning, and I can't fix Signed-off-by unless you tell me what to do.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gvt: remove unused variable gma_bottom in command parser (rev2)
2023-06-08 8:14 ` Wang, Zhi A
@ 2023-06-08 9:00 ` Jani Nikula
2023-06-08 9:04 ` Wang, Zhi A
0 siblings, 1 reply; 13+ messages in thread
From: Jani Nikula @ 2023-06-08 9:00 UTC (permalink / raw)
To: Wang, Zhi A, Zhi Wang; +Cc: intel-gfx@lists.freedesktop.org
On Thu, 08 Jun 2023, "Wang, Zhi A" <zhi.a.wang@intel.com> wrote:
> Please take the <zhi.a.wang@intel.com> as my S-O-B since this is a
> patch about GVT-g. I still don't know why my intel email smtp doesn't
> work.
Thanks, pushed.
You should be able to configure git to set your author From: in the
patch, even when sending the patch email with a different From:.
See e.g. [1].
BR,
Jani.
[1] https://lore.kernel.org/r/20230606191504.18099-2-ville.syrjala@linux.intel.com
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gvt: remove unused variable gma_bottom in command parser (rev2)
2023-06-08 9:00 ` Jani Nikula
@ 2023-06-08 9:04 ` Wang, Zhi A
0 siblings, 0 replies; 13+ messages in thread
From: Wang, Zhi A @ 2023-06-08 9:04 UTC (permalink / raw)
To: Jani Nikula, Zhi Wang; +Cc: intel-gfx@lists.freedesktop.org
Thanks so much for the trick. Learned.
-----Original Message-----
From: Jani Nikula <jani.nikula@linux.intel.com>
Sent: Thursday, June 8, 2023 5:01 PM
To: Wang, Zhi A <zhi.a.wang@intel.com>; Zhi Wang <zhi.wang.linux@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: RE: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gvt: remove unused variable gma_bottom in command parser (rev2)
On Thu, 08 Jun 2023, "Wang, Zhi A" <zhi.a.wang@intel.com> wrote:
> Please take the <zhi.a.wang@intel.com> as my S-O-B since this is a
> patch about GVT-g. I still don't know why my intel email smtp doesn't
> work.
Thanks, pushed.
You should be able to configure git to set your author From: in the patch, even when sending the patch email with a different From:.
See e.g. [1].
BR,
Jani.
[1] https://lore.kernel.org/r/20230606191504.18099-2-ville.syrjala@linux.intel.com
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2023-06-08 9:04 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-31 2:04 [Intel-gfx] [PATCH RESEND] drm/i915/gvt: remove unused variable gma_bottom in command parser Zhi Wang
2023-05-31 5:39 ` Zhenyu Wang
2023-05-31 9:27 ` Jani Nikula
2023-06-07 9:34 ` Zhenyu Wang
2023-05-31 9:20 ` Andi Shyti
2023-05-31 16:57 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gvt: remove unused variable gma_bottom in command parser (rev2) Patchwork
2023-06-02 17:02 ` Jani Nikula
2023-06-05 14:35 ` Jani Nikula
2023-06-08 8:14 ` Wang, Zhi A
2023-06-08 9:00 ` Jani Nikula
2023-06-08 9:04 ` Wang, Zhi A
2023-05-31 17:11 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-06-02 5:21 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox