[Intel-gfx] [PATCH] drm/i915/display : Remove support for interlace mode

[Intel-gfx] [PATCH] drm/i915/display : Remove support for interlace mode

[Ankit Nautiyal]

There are multiple panels with which Interlace mode is seen to cause
flickering (interlacing artifacts) with different platforms.

The issue is seen with both HDMI, DP with CML, CFL, ICL, EHL with
different display models from Acer, Benq, Dell etc.
There are some models where the issue is not seen with same setup.

Due to this, cases where multiple display are configured in clone mode,
sometimes interlaced mode gets picked up in one of the displays
and flickers are seen.

Since its difficult to pin point if issue is due to the HW or due to
panels, removing interlace mode for DP and HDMI till this is
root caused.

Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/8395

Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp.c   | 3 ---
 drivers/gpu/drm/i915/display/intel_hdmi.c | 3 ---
 2 files changed, 6 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index f4192fda1a76..78d8ceb590a3 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -5665,9 +5665,6 @@ intel_dp_init_connector(struct intel_digital_port *dig_port,
 	drm_connector_init(dev, connector, &intel_dp_connector_funcs, type);
 	drm_connector_helper_add(connector, &intel_dp_connector_helper_funcs);
 
-	if (!HAS_GMCH(dev_priv) && DISPLAY_VER(dev_priv) < 12)
-		connector->interlace_allowed = true;
-
 	intel_connector->polled = DRM_CONNECTOR_POLL_HPD;
 
 	intel_dp_aux_init(intel_dp);
diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
index 7ac5e6c5e00d..9b3ea307ef40 100644
--- a/drivers/gpu/drm/i915/display/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
@@ -2998,9 +2998,6 @@ void intel_hdmi_init_connector(struct intel_digital_port *dig_port,
 				    ddc);
 	drm_connector_helper_add(connector, &intel_hdmi_connector_helper_funcs);
 
-	if (DISPLAY_VER(dev_priv) < 12)
-		connector->interlace_allowed = true;
-
 	connector->stereo_allowed = true;
 
 	if (DISPLAY_VER(dev_priv) >= 10)
-- 
2.40.1

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display : Remove support for interlace mode

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 5746 bytes --]

== Series Details ==

Series: drm/i915/display : Remove support for interlace mode
URL   : https://patchwork.freedesktop.org/series/119319/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_13269 -> Patchwork_119319v1
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_119319v1 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_119319v1, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119319v1/index.html

Participating hosts (40 -> 36)
------------------------------

  Missing    (4): fi-kbl-soraka bat-jsl-1 bat-adlp-6 fi-snb-2520m 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_119319v1:

### IGT changes ###

#### Possible regressions ####

  * igt@vgem_basic@unload:
    - bat-jsl-3:          [PASS][1] -> [INCOMPLETE][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13269/bat-jsl-3/igt@vgem_basic@unload.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119319v1/bat-jsl-3/igt@vgem_basic@unload.html

  
Known issues
------------

  Here are the changes found in Patchwork_119319v1 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_selftest@live@gt_engines:
    - bat-atsm-1:         [PASS][3] -> [FAIL][4] ([i915#6268])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13269/bat-atsm-1/igt@i915_selftest@live@gt_engines.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119319v1/bat-atsm-1/igt@i915_selftest@live@gt_engines.html

  * igt@i915_selftest@live@gt_heartbeat:
    - fi-apl-guc:         [PASS][5] -> [DMESG-FAIL][6] ([i915#5334])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13269/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119319v1/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html

  * igt@i915_selftest@live@slpc:
    - bat-mtlp-6:         [PASS][7] -> [DMESG-WARN][8] ([i915#6367])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13269/bat-mtlp-6/igt@i915_selftest@live@slpc.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119319v1/bat-mtlp-6/igt@i915_selftest@live@slpc.html

  * igt@i915_suspend@basic-s3-without-i915:
    - bat-rpls-1:         NOTRUN -> [ABORT][9] ([i915#6687] / [i915#7978])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119319v1/bat-rpls-1/igt@i915_suspend@basic-s3-without-i915.html

  * igt@kms_pipe_crc_basic@nonblocking-crc@pipe-c-dp-1:
    - bat-dg2-8:          [PASS][10] -> [FAIL][11] ([i915#7932])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13269/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc@pipe-c-dp-1.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119319v1/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc@pipe-c-dp-1.html

  
#### Possible fixes ####

  * igt@i915_selftest@live@requests:
    - bat-mtlp-8:         [DMESG-FAIL][12] ([i915#8497]) -> [PASS][13]
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13269/bat-mtlp-8/igt@i915_selftest@live@requests.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119319v1/bat-mtlp-8/igt@i915_selftest@live@requests.html
    - bat-rpls-1:         [ABORT][14] ([i915#7911] / [i915#7920]) -> [PASS][15]
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13269/bat-rpls-1/igt@i915_selftest@live@requests.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119319v1/bat-rpls-1/igt@i915_selftest@live@requests.html
    - bat-mtlp-6:         [DMESG-FAIL][16] ([i915#8497]) -> [PASS][17]
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13269/bat-mtlp-6/igt@i915_selftest@live@requests.html
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119319v1/bat-mtlp-6/igt@i915_selftest@live@requests.html

  
#### Warnings ####

  * igt@i915_module_load@load:
    - bat-adlp-11:        [DMESG-WARN][18] ([i915#4423]) -> [ABORT][19] ([i915#4423])
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13269/bat-adlp-11/igt@i915_module_load@load.html
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119319v1/bat-adlp-11/igt@i915_module_load@load.html

  
  [i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
  [i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
  [i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
  [i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
  [i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
  [i915#7911]: https://gitlab.freedesktop.org/drm/intel/issues/7911
  [i915#7920]: https://gitlab.freedesktop.org/drm/intel/issues/7920
  [i915#7932]: https://gitlab.freedesktop.org/drm/intel/issues/7932
  [i915#7978]: https://gitlab.freedesktop.org/drm/intel/issues/7978
  [i915#8497]: https://gitlab.freedesktop.org/drm/intel/issues/8497


Build changes
-------------

  * Linux: CI_DRM_13269 -> Patchwork_119319v1

  CI-20190529: 20190529
  CI_DRM_13269: c73de42e50dc07f5ae9342b28be76f2ee015e5af @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_7327: 34e48b7d6402c3d7af19a40d8951eae017cf64df @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  Patchwork_119319v1: c73de42e50dc07f5ae9342b28be76f2ee015e5af @ git://anongit.freedesktop.org/gfx-ci/linux


### Linux commits

29546147b8f8 drm/i915/display : Remove support for interlace mode

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119319v1/index.html

[-- Attachment #2: Type: text/html, Size: 6711 bytes --]

Re: [Intel-gfx] [PATCH] drm/i915/display : Remove support for interlace mode

[Ville Syrjälä]

On Wed, Jun 14, 2023 at 09:37:49AM +0530, Ankit Nautiyal wrote:
> There are multiple panels with which Interlace mode is seen to cause
> flickering (interlacing artifacts) with different platforms.
> 
> The issue is seen with both HDMI, DP with CML, CFL, ICL, EHL with
> different display models from Acer, Benq, Dell etc.
> There are some models where the issue is not seen with same setup.
> 
> Due to this, cases where multiple display are configured in clone mode,
> sometimes interlaced mode gets picked up in one of the displays
> and flickers are seen.
> 
> Since its difficult to pin point if issue is due to the HW or due to
> panels, removing interlace mode for DP and HDMI till this is
> root caused.

I though people already confirmewd the problem on non-Intel hw?
So seems pretty clear that it's the displays themselves that are
garbage.

> 
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/8395
> 
> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_dp.c   | 3 ---
>  drivers/gpu/drm/i915/display/intel_hdmi.c | 3 ---
>  2 files changed, 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index f4192fda1a76..78d8ceb590a3 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -5665,9 +5665,6 @@ intel_dp_init_connector(struct intel_digital_port *dig_port,
>  	drm_connector_init(dev, connector, &intel_dp_connector_funcs, type);
>  	drm_connector_helper_add(connector, &intel_dp_connector_helper_funcs);
>  
> -	if (!HAS_GMCH(dev_priv) && DISPLAY_VER(dev_priv) < 12)
> -		connector->interlace_allowed = true;
> -
>  	intel_connector->polled = DRM_CONNECTOR_POLL_HPD;
>  
>  	intel_dp_aux_init(intel_dp);
> diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
> index 7ac5e6c5e00d..9b3ea307ef40 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
> @@ -2998,9 +2998,6 @@ void intel_hdmi_init_connector(struct intel_digital_port *dig_port,
>  				    ddc);
>  	drm_connector_helper_add(connector, &intel_hdmi_connector_helper_funcs);
>  
> -	if (DISPLAY_VER(dev_priv) < 12)
> -		connector->interlace_allowed = true;
> -
>  	connector->stereo_allowed = true;
>  
>  	if (DISPLAY_VER(dev_priv) >= 10)
> -- 
> 2.40.1

-- 
Ville Syrjälä
Intel

Re: [Intel-gfx] [PATCH] drm/i915/display : Remove support for interlace mode

[Jani Nikula]

On Wed, 14 Jun 2023, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Wed, Jun 14, 2023 at 09:37:49AM +0530, Ankit Nautiyal wrote:
>> There are multiple panels with which Interlace mode is seen to cause
>> flickering (interlacing artifacts) with different platforms.
>> 
>> The issue is seen with both HDMI, DP with CML, CFL, ICL, EHL with
>> different display models from Acer, Benq, Dell etc.
>> There are some models where the issue is not seen with same setup.
>> 
>> Due to this, cases where multiple display are configured in clone mode,
>> sometimes interlaced mode gets picked up in one of the displays
>> and flickers are seen.
>> 
>> Since its difficult to pin point if issue is due to the HW or due to
>> panels, removing interlace mode for DP and HDMI till this is
>> root caused.
>
> I though people already confirmewd the problem on non-Intel hw?
> So seems pretty clear that it's the displays themselves that are
> garbage.

Moreover, later means never. If you brush it under the carpet, nobody's
ever going to root cause it.

BR,
Jani.


>
>> 
>> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/8395
>> 
>> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
>> ---
>>  drivers/gpu/drm/i915/display/intel_dp.c   | 3 ---
>>  drivers/gpu/drm/i915/display/intel_hdmi.c | 3 ---
>>  2 files changed, 6 deletions(-)
>> 
>> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
>> index f4192fda1a76..78d8ceb590a3 100644
>> --- a/drivers/gpu/drm/i915/display/intel_dp.c
>> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
>> @@ -5665,9 +5665,6 @@ intel_dp_init_connector(struct intel_digital_port *dig_port,
>>  	drm_connector_init(dev, connector, &intel_dp_connector_funcs, type);
>>  	drm_connector_helper_add(connector, &intel_dp_connector_helper_funcs);
>>  
>> -	if (!HAS_GMCH(dev_priv) && DISPLAY_VER(dev_priv) < 12)
>> -		connector->interlace_allowed = true;
>> -
>>  	intel_connector->polled = DRM_CONNECTOR_POLL_HPD;
>>  
>>  	intel_dp_aux_init(intel_dp);
>> diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
>> index 7ac5e6c5e00d..9b3ea307ef40 100644
>> --- a/drivers/gpu/drm/i915/display/intel_hdmi.c
>> +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
>> @@ -2998,9 +2998,6 @@ void intel_hdmi_init_connector(struct intel_digital_port *dig_port,
>>  				    ddc);
>>  	drm_connector_helper_add(connector, &intel_hdmi_connector_helper_funcs);
>>  
>> -	if (DISPLAY_VER(dev_priv) < 12)
>> -		connector->interlace_allowed = true;
>> -
>>  	connector->stereo_allowed = true;
>>  
>>  	if (DISPLAY_VER(dev_priv) >= 10)
>> -- 
>> 2.40.1

-- 
Jani Nikula, Intel Open Source Graphics Center