* [Intel-gfx] [PATCH 0/2] eventfd: simplify signal helpers
@ 2023-07-13 10:05 Christian Brauner
2023-07-13 10:05 ` [Intel-gfx] [PATCH 1/2] eventfd: simplify eventfd_signal() Christian Brauner
` (6 more replies)
0 siblings, 7 replies; 12+ messages in thread
From: Christian Brauner @ 2023-07-13 10:05 UTC (permalink / raw)
To: linux-fsdevel
Cc: linux-aio, linux-usb, Matthew Rosato, Paul Durrant, Tom Rix,
Jason Wang, dri-devel, Michal Hocko, linux-mm, Kirti Wankhede,
Paolo Bonzini, Jens Axboe, Vineeth Vijayan, Diana Craciun,
Alexander Gordeev, David Airlie, Xuan Zhuo, Shakeel Butt,
Vasily Gorbik, Leon Romanovsky, Harald Freudenberger, Fei Li, x86,
Roman Gushchin, Halil Pasic, Jason Gunthorpe, Ingo Molnar,
intel-gfx, Christian Borntraeger, linux-fpga, Wu Hao, Jason Herne,
Eric Farman, Dave Hansen, Andrew Donnellan, Arnd Bergmann,
linux-s390, Heiko Carstens, Johannes Weiner, linuxppc-dev,
Eric Auger, Borislav Petkov, kvm, Rodrigo Vivi, cgroups,
Thomas Gleixner, virtualization, intel-gvt-dev, io-uring, netdev,
Tony Krowiak, Christian Brauner, Pavel Begunkov,
Sean Christopherson, Oded Gabbay, Muchun Song,
Peter Oberparleiter, linux-kernel, linux-rdma, Benjamin LaHaise,
Michael S. Tsirkin, Sven Schnelle, Daniel Vetter,
Greg Kroah-Hartman, Frederic Barrat, Moritz Fischer,
Vitaly Kuznetsov, David Woodhouse, Xu Yilun
Hey everyone,
This simplifies the eventfd_signal() and eventfd_signal_mask() helpers
by removing the count argument which is effectively unused.
---
---
base-commit: 6be357f00aad4189130147fdc6f568cf776a4909
change-id: 20230713-vfs-eventfd-signal-0b0d167ad6ec
^ permalink raw reply [flat|nested] 12+ messages in thread* [Intel-gfx] [PATCH 1/2] eventfd: simplify eventfd_signal() 2023-07-13 10:05 [Intel-gfx] [PATCH 0/2] eventfd: simplify signal helpers Christian Brauner @ 2023-07-13 10:05 ` Christian Brauner 2023-07-13 13:29 ` Anthony Krowiak 2023-07-13 13:34 ` Oded Gabbay 2023-07-13 10:05 ` [Intel-gfx] [PATCH 2/2] eventfd: simplify eventfd_signal_mask() Christian Brauner ` (5 subsequent siblings) 6 siblings, 2 replies; 12+ messages in thread From: Christian Brauner @ 2023-07-13 10:05 UTC (permalink / raw) To: linux-fsdevel Cc: linux-aio, linux-usb, Matthew Rosato, Paul Durrant, Tom Rix, Jason Wang, dri-devel, Michal Hocko, linux-mm, Kirti Wankhede, Paolo Bonzini, Jens Axboe, Vineeth Vijayan, Diana Craciun, Alexander Gordeev, David Airlie, Xuan Zhuo, Shakeel Butt, Vasily Gorbik, Leon Romanovsky, Harald Freudenberger, Fei Li, x86, Roman Gushchin, Halil Pasic, Jason Gunthorpe, Ingo Molnar, intel-gfx, Christian Borntraeger, linux-fpga, Wu Hao, Jason Herne, Eric Farman, Dave Hansen, Andrew Donnellan, Arnd Bergmann, linux-s390, Heiko Carstens, Johannes Weiner, linuxppc-dev, Eric Auger, Borislav Petkov, kvm, Rodrigo Vivi, cgroups, Thomas Gleixner, virtualization, intel-gvt-dev, io-uring, netdev, Tony Krowiak, Christian Brauner, Pavel Begunkov, Sean Christopherson, Oded Gabbay, Muchun Song, Peter Oberparleiter, linux-kernel, linux-rdma, Benjamin LaHaise, Michael S. Tsirkin, Sven Schnelle, Daniel Vetter, Greg Kroah-Hartman, Frederic Barrat, Moritz Fischer, Vitaly Kuznetsov, David Woodhouse, Xu Yilun Ever since the evenfd type was introduced back in 2007 in commit e1ad7468c77d ("signal/timer/event: eventfd core") the eventfd_signal() function only ever passed 1 as a value for @n. There's no point in keeping that additional argument. Signed-off-by: Christian Brauner <brauner@kernel.org> --- arch/x86/kvm/hyperv.c | 2 +- arch/x86/kvm/xen.c | 2 +- drivers/accel/habanalabs/common/device.c | 2 +- drivers/fpga/dfl.c | 2 +- drivers/gpu/drm/i915/gvt/interrupt.c | 2 +- drivers/infiniband/hw/mlx5/devx.c | 2 +- drivers/misc/ocxl/file.c | 2 +- drivers/s390/cio/vfio_ccw_chp.c | 2 +- drivers/s390/cio/vfio_ccw_drv.c | 4 ++-- drivers/s390/cio/vfio_ccw_ops.c | 6 +++--- drivers/s390/crypto/vfio_ap_ops.c | 2 +- drivers/usb/gadget/function/f_fs.c | 4 ++-- drivers/vdpa/vdpa_user/vduse_dev.c | 6 +++--- drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c | 2 +- drivers/vfio/pci/vfio_pci_core.c | 6 +++--- drivers/vfio/pci/vfio_pci_intrs.c | 12 ++++++------ drivers/vfio/platform/vfio_platform_irq.c | 4 ++-- drivers/vhost/vdpa.c | 4 ++-- drivers/vhost/vhost.c | 10 +++++----- drivers/vhost/vhost.h | 2 +- drivers/virt/acrn/ioeventfd.c | 2 +- fs/aio.c | 2 +- fs/eventfd.c | 9 +++------ include/linux/eventfd.h | 4 ++-- mm/memcontrol.c | 10 +++++----- mm/vmpressure.c | 2 +- samples/vfio-mdev/mtty.c | 4 ++-- virt/kvm/eventfd.c | 4 ++-- 28 files changed, 56 insertions(+), 59 deletions(-) diff --git a/arch/x86/kvm/hyperv.c b/arch/x86/kvm/hyperv.c index b28fd020066f..2f4bd74b482c 100644 --- a/arch/x86/kvm/hyperv.c +++ b/arch/x86/kvm/hyperv.c @@ -2387,7 +2387,7 @@ static u16 kvm_hvcall_signal_event(struct kvm_vcpu *vcpu, struct kvm_hv_hcall *h if (!eventfd) return HV_STATUS_INVALID_PORT_ID; - eventfd_signal(eventfd, 1); + eventfd_signal(eventfd); return HV_STATUS_SUCCESS; } diff --git a/arch/x86/kvm/xen.c b/arch/x86/kvm/xen.c index 40edf4d1974c..a7b62bafd57b 100644 --- a/arch/x86/kvm/xen.c +++ b/arch/x86/kvm/xen.c @@ -2043,7 +2043,7 @@ static bool kvm_xen_hcall_evtchn_send(struct kvm_vcpu *vcpu, u64 param, u64 *r) if (ret < 0 && ret != -ENOTCONN) return false; } else { - eventfd_signal(evtchnfd->deliver.eventfd.ctx, 1); + eventfd_signal(evtchnfd->deliver.eventfd.ctx); } *r = 0; diff --git a/drivers/accel/habanalabs/common/device.c b/drivers/accel/habanalabs/common/device.c index b97339d1f7c6..30357b371d61 100644 --- a/drivers/accel/habanalabs/common/device.c +++ b/drivers/accel/habanalabs/common/device.c @@ -1963,7 +1963,7 @@ static void hl_notifier_event_send(struct hl_notifier_event *notifier_event, u64 notifier_event->events_mask |= event_mask; if (notifier_event->eventfd) - eventfd_signal(notifier_event->eventfd, 1); + eventfd_signal(notifier_event->eventfd); mutex_unlock(¬ifier_event->lock); } diff --git a/drivers/fpga/dfl.c b/drivers/fpga/dfl.c index dd7a783d53b5..e73f88050f08 100644 --- a/drivers/fpga/dfl.c +++ b/drivers/fpga/dfl.c @@ -1872,7 +1872,7 @@ static irqreturn_t dfl_irq_handler(int irq, void *arg) { struct eventfd_ctx *trigger = arg; - eventfd_signal(trigger, 1); + eventfd_signal(trigger); return IRQ_HANDLED; } diff --git a/drivers/gpu/drm/i915/gvt/interrupt.c b/drivers/gpu/drm/i915/gvt/interrupt.c index 68eca023bbc6..3d9e09c2add4 100644 --- a/drivers/gpu/drm/i915/gvt/interrupt.c +++ b/drivers/gpu/drm/i915/gvt/interrupt.c @@ -435,7 +435,7 @@ static int inject_virtual_interrupt(struct intel_vgpu *vgpu) */ if (!test_bit(INTEL_VGPU_STATUS_ATTACHED, vgpu->status)) return -ESRCH; - if (vgpu->msi_trigger && eventfd_signal(vgpu->msi_trigger, 1) != 1) + if (vgpu->msi_trigger && eventfd_signal(vgpu->msi_trigger) != 1) return -EFAULT; return 0; } diff --git a/drivers/infiniband/hw/mlx5/devx.c b/drivers/infiniband/hw/mlx5/devx.c index db5fb196c728..ad50487790ff 100644 --- a/drivers/infiniband/hw/mlx5/devx.c +++ b/drivers/infiniband/hw/mlx5/devx.c @@ -2498,7 +2498,7 @@ static void dispatch_event_fd(struct list_head *fd_list, list_for_each_entry_rcu(item, fd_list, xa_list) { if (item->eventfd) - eventfd_signal(item->eventfd, 1); + eventfd_signal(item->eventfd); else deliver_event(item, data); } diff --git a/drivers/misc/ocxl/file.c b/drivers/misc/ocxl/file.c index 6e63f060e4cc..51766db296ab 100644 --- a/drivers/misc/ocxl/file.c +++ b/drivers/misc/ocxl/file.c @@ -185,7 +185,7 @@ static irqreturn_t irq_handler(void *private) { struct eventfd_ctx *ev_ctx = private; - eventfd_signal(ev_ctx, 1); + eventfd_signal(ev_ctx); return IRQ_HANDLED; } diff --git a/drivers/s390/cio/vfio_ccw_chp.c b/drivers/s390/cio/vfio_ccw_chp.c index d3f3a611f95b..38c176cf6295 100644 --- a/drivers/s390/cio/vfio_ccw_chp.c +++ b/drivers/s390/cio/vfio_ccw_chp.c @@ -115,7 +115,7 @@ static ssize_t vfio_ccw_crw_region_read(struct vfio_ccw_private *private, /* Notify the guest if more CRWs are on our queue */ if (!list_empty(&private->crw) && private->crw_trigger) - eventfd_signal(private->crw_trigger, 1); + eventfd_signal(private->crw_trigger); return ret; } diff --git a/drivers/s390/cio/vfio_ccw_drv.c b/drivers/s390/cio/vfio_ccw_drv.c index 43601816ea4e..bfb35cfce1ef 100644 --- a/drivers/s390/cio/vfio_ccw_drv.c +++ b/drivers/s390/cio/vfio_ccw_drv.c @@ -112,7 +112,7 @@ void vfio_ccw_sch_io_todo(struct work_struct *work) private->state = VFIO_CCW_STATE_IDLE; if (private->io_trigger) - eventfd_signal(private->io_trigger, 1); + eventfd_signal(private->io_trigger); } void vfio_ccw_crw_todo(struct work_struct *work) @@ -122,7 +122,7 @@ void vfio_ccw_crw_todo(struct work_struct *work) private = container_of(work, struct vfio_ccw_private, crw_work); if (!list_empty(&private->crw) && private->crw_trigger) - eventfd_signal(private->crw_trigger, 1); + eventfd_signal(private->crw_trigger); } /* diff --git a/drivers/s390/cio/vfio_ccw_ops.c b/drivers/s390/cio/vfio_ccw_ops.c index 5b53b94f13c7..3df231f6feda 100644 --- a/drivers/s390/cio/vfio_ccw_ops.c +++ b/drivers/s390/cio/vfio_ccw_ops.c @@ -421,7 +421,7 @@ static int vfio_ccw_mdev_set_irqs(struct vfio_ccw_private *private, case VFIO_IRQ_SET_DATA_NONE: { if (*ctx) - eventfd_signal(*ctx, 1); + eventfd_signal(*ctx); return 0; } case VFIO_IRQ_SET_DATA_BOOL: @@ -432,7 +432,7 @@ static int vfio_ccw_mdev_set_irqs(struct vfio_ccw_private *private, return -EFAULT; if (trigger && *ctx) - eventfd_signal(*ctx, 1); + eventfd_signal(*ctx); return 0; } case VFIO_IRQ_SET_DATA_EVENTFD: @@ -612,7 +612,7 @@ static void vfio_ccw_mdev_request(struct vfio_device *vdev, unsigned int count) "Relaying device request to user (#%u)\n", count); - eventfd_signal(private->req_trigger, 1); + eventfd_signal(private->req_trigger); } else if (count == 0) { dev_notice(dev, "No device request channel registered, blocked until released by user\n"); diff --git a/drivers/s390/crypto/vfio_ap_ops.c b/drivers/s390/crypto/vfio_ap_ops.c index b441745b0418..feb88526ac9d 100644 --- a/drivers/s390/crypto/vfio_ap_ops.c +++ b/drivers/s390/crypto/vfio_ap_ops.c @@ -1749,7 +1749,7 @@ static void vfio_ap_mdev_request(struct vfio_device *vdev, unsigned int count) "Relaying device request to user (#%u)\n", count); - eventfd_signal(matrix_mdev->req_trigger, 1); + eventfd_signal(matrix_mdev->req_trigger); } else if (count == 0) { dev_notice(dev, "No device request registered, blocked until released by user\n"); diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c index f41a385a5c42..ceb1aad0c5df 100644 --- a/drivers/usb/gadget/function/f_fs.c +++ b/drivers/usb/gadget/function/f_fs.c @@ -831,7 +831,7 @@ static void ffs_user_copy_worker(struct work_struct *work) io_data->kiocb->ki_complete(io_data->kiocb, ret); if (io_data->ffs->ffs_eventfd && !kiocb_has_eventfd) - eventfd_signal(io_data->ffs->ffs_eventfd, 1); + eventfd_signal(io_data->ffs->ffs_eventfd); if (io_data->read) kfree(io_data->to_free); @@ -2739,7 +2739,7 @@ static void __ffs_event_add(struct ffs_data *ffs, ffs->ev.types[ffs->ev.count++] = type; wake_up_locked(&ffs->ev.waitq); if (ffs->ffs_eventfd) - eventfd_signal(ffs->ffs_eventfd, 1); + eventfd_signal(ffs->ffs_eventfd); } static void ffs_event_add(struct ffs_data *ffs, diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c b/drivers/vdpa/vdpa_user/vduse_dev.c index dc38ed21319d..99b901a9e638 100644 --- a/drivers/vdpa/vdpa_user/vduse_dev.c +++ b/drivers/vdpa/vdpa_user/vduse_dev.c @@ -494,7 +494,7 @@ static void vduse_vq_kick(struct vduse_virtqueue *vq) goto unlock; if (vq->kickfd) - eventfd_signal(vq->kickfd, 1); + eventfd_signal(vq->kickfd); else vq->kicked = true; unlock: @@ -912,7 +912,7 @@ static int vduse_kickfd_setup(struct vduse_dev *dev, eventfd_ctx_put(vq->kickfd); vq->kickfd = ctx; if (vq->ready && vq->kicked && vq->kickfd) { - eventfd_signal(vq->kickfd, 1); + eventfd_signal(vq->kickfd); vq->kicked = false; } spin_unlock(&vq->kick_lock); @@ -961,7 +961,7 @@ static bool vduse_vq_signal_irqfd(struct vduse_virtqueue *vq) spin_lock_irq(&vq->irq_lock); if (vq->ready && vq->cb.trigger) { - eventfd_signal(vq->cb.trigger, 1); + eventfd_signal(vq->cb.trigger); signal = true; } spin_unlock_irq(&vq->irq_lock); diff --git a/drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c b/drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c index c51229fccbd6..d62fbfff20b8 100644 --- a/drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c +++ b/drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c @@ -54,7 +54,7 @@ static irqreturn_t vfio_fsl_mc_irq_handler(int irq_num, void *arg) { struct vfio_fsl_mc_irq *mc_irq = (struct vfio_fsl_mc_irq *)arg; - eventfd_signal(mc_irq->trigger, 1); + eventfd_signal(mc_irq->trigger); return IRQ_HANDLED; } diff --git a/drivers/vfio/pci/vfio_pci_core.c b/drivers/vfio/pci/vfio_pci_core.c index 20d7b69ea6ff..01c8e31db23b 100644 --- a/drivers/vfio/pci/vfio_pci_core.c +++ b/drivers/vfio/pci/vfio_pci_core.c @@ -441,7 +441,7 @@ static int vfio_pci_core_runtime_resume(struct device *dev) */ down_write(&vdev->memory_lock); if (vdev->pm_wake_eventfd_ctx) { - eventfd_signal(vdev->pm_wake_eventfd_ctx, 1); + eventfd_signal(vdev->pm_wake_eventfd_ctx); __vfio_pci_runtime_pm_exit(vdev); } up_write(&vdev->memory_lock); @@ -1861,7 +1861,7 @@ void vfio_pci_core_request(struct vfio_device *core_vdev, unsigned int count) pci_notice_ratelimited(pdev, "Relaying device request to user (#%u)\n", count); - eventfd_signal(vdev->req_trigger, 1); + eventfd_signal(vdev->req_trigger); } else if (count == 0) { pci_warn(pdev, "No device request channel registered, blocked until released by user\n"); @@ -2280,7 +2280,7 @@ pci_ers_result_t vfio_pci_core_aer_err_detected(struct pci_dev *pdev, mutex_lock(&vdev->igate); if (vdev->err_trigger) - eventfd_signal(vdev->err_trigger, 1); + eventfd_signal(vdev->err_trigger); mutex_unlock(&vdev->igate); diff --git a/drivers/vfio/pci/vfio_pci_intrs.c b/drivers/vfio/pci/vfio_pci_intrs.c index cbb4bcbfbf83..237beac83809 100644 --- a/drivers/vfio/pci/vfio_pci_intrs.c +++ b/drivers/vfio/pci/vfio_pci_intrs.c @@ -94,7 +94,7 @@ static void vfio_send_intx_eventfd(void *opaque, void *unused) ctx = vfio_irq_ctx_get(vdev, 0); if (WARN_ON_ONCE(!ctx)) return; - eventfd_signal(ctx->trigger, 1); + eventfd_signal(ctx->trigger); } } @@ -342,7 +342,7 @@ static irqreturn_t vfio_msihandler(int irq, void *arg) { struct eventfd_ctx *trigger = arg; - eventfd_signal(trigger, 1); + eventfd_signal(trigger); return IRQ_HANDLED; } @@ -689,11 +689,11 @@ static int vfio_pci_set_msi_trigger(struct vfio_pci_core_device *vdev, if (!ctx) continue; if (flags & VFIO_IRQ_SET_DATA_NONE) { - eventfd_signal(ctx->trigger, 1); + eventfd_signal(ctx->trigger); } else if (flags & VFIO_IRQ_SET_DATA_BOOL) { uint8_t *bools = data; if (bools[i - start]) - eventfd_signal(ctx->trigger, 1); + eventfd_signal(ctx->trigger); } } return 0; @@ -707,7 +707,7 @@ static int vfio_pci_set_ctx_trigger_single(struct eventfd_ctx **ctx, if (flags & VFIO_IRQ_SET_DATA_NONE) { if (*ctx) { if (count) { - eventfd_signal(*ctx, 1); + eventfd_signal(*ctx); } else { eventfd_ctx_put(*ctx); *ctx = NULL; @@ -722,7 +722,7 @@ static int vfio_pci_set_ctx_trigger_single(struct eventfd_ctx **ctx, trigger = *(uint8_t *)data; if (trigger && *ctx) - eventfd_signal(*ctx, 1); + eventfd_signal(*ctx); return 0; } else if (flags & VFIO_IRQ_SET_DATA_EVENTFD) { diff --git a/drivers/vfio/platform/vfio_platform_irq.c b/drivers/vfio/platform/vfio_platform_irq.c index 665197caed89..61a1bfb68ac7 100644 --- a/drivers/vfio/platform/vfio_platform_irq.c +++ b/drivers/vfio/platform/vfio_platform_irq.c @@ -155,7 +155,7 @@ static irqreturn_t vfio_automasked_irq_handler(int irq, void *dev_id) spin_unlock_irqrestore(&irq_ctx->lock, flags); if (ret == IRQ_HANDLED) - eventfd_signal(irq_ctx->trigger, 1); + eventfd_signal(irq_ctx->trigger); return ret; } @@ -164,7 +164,7 @@ static irqreturn_t vfio_irq_handler(int irq, void *dev_id) { struct vfio_platform_irq *irq_ctx = dev_id; - eventfd_signal(irq_ctx->trigger, 1); + eventfd_signal(irq_ctx->trigger); return IRQ_HANDLED; } diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c index b43e8680eee8..722894a0f124 100644 --- a/drivers/vhost/vdpa.c +++ b/drivers/vhost/vdpa.c @@ -161,7 +161,7 @@ static irqreturn_t vhost_vdpa_virtqueue_cb(void *private) struct eventfd_ctx *call_ctx = vq->call_ctx.ctx; if (call_ctx) - eventfd_signal(call_ctx, 1); + eventfd_signal(call_ctx); return IRQ_HANDLED; } @@ -172,7 +172,7 @@ static irqreturn_t vhost_vdpa_config_cb(void *private) struct eventfd_ctx *config_ctx = v->config_ctx; if (config_ctx) - eventfd_signal(config_ctx, 1); + eventfd_signal(config_ctx); return IRQ_HANDLED; } diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index c71d573f1c94..bee50f153c8e 100644 --- a/drivers/vhost/vhost.c +++ b/drivers/vhost/vhost.c @@ -2250,7 +2250,7 @@ int vhost_log_write(struct vhost_virtqueue *vq, struct vhost_log *log, len -= l; if (!len) { if (vq->log_ctx) - eventfd_signal(vq->log_ctx, 1); + eventfd_signal(vq->log_ctx); return 0; } } @@ -2273,7 +2273,7 @@ static int vhost_update_used_flags(struct vhost_virtqueue *vq) log_used(vq, (used - (void __user *)vq->used), sizeof vq->used->flags); if (vq->log_ctx) - eventfd_signal(vq->log_ctx, 1); + eventfd_signal(vq->log_ctx); } return 0; } @@ -2291,7 +2291,7 @@ static int vhost_update_avail_event(struct vhost_virtqueue *vq) log_used(vq, (used - (void __user *)vq->used), sizeof *vhost_avail_event(vq)); if (vq->log_ctx) - eventfd_signal(vq->log_ctx, 1); + eventfd_signal(vq->log_ctx); } return 0; } @@ -2717,7 +2717,7 @@ int vhost_add_used_n(struct vhost_virtqueue *vq, struct vring_used_elem *heads, log_used(vq, offsetof(struct vring_used, idx), sizeof vq->used->idx); if (vq->log_ctx) - eventfd_signal(vq->log_ctx, 1); + eventfd_signal(vq->log_ctx); } return r; } @@ -2765,7 +2765,7 @@ void vhost_signal(struct vhost_dev *dev, struct vhost_virtqueue *vq) { /* Signal the Guest tell them we used something up. */ if (vq->call_ctx.ctx && vhost_notify(dev, vq)) - eventfd_signal(vq->call_ctx.ctx, 1); + eventfd_signal(vq->call_ctx.ctx); } EXPORT_SYMBOL_GPL(vhost_signal); diff --git a/drivers/vhost/vhost.h b/drivers/vhost/vhost.h index f60d5f7bef94..9e942fcda5c3 100644 --- a/drivers/vhost/vhost.h +++ b/drivers/vhost/vhost.h @@ -249,7 +249,7 @@ void vhost_iotlb_map_free(struct vhost_iotlb *iotlb, #define vq_err(vq, fmt, ...) do { \ pr_debug(pr_fmt(fmt), ##__VA_ARGS__); \ if ((vq)->error_ctx) \ - eventfd_signal((vq)->error_ctx, 1);\ + eventfd_signal((vq)->error_ctx);\ } while (0) enum { diff --git a/drivers/virt/acrn/ioeventfd.c b/drivers/virt/acrn/ioeventfd.c index ac4037e9f947..4e845c6ca0b5 100644 --- a/drivers/virt/acrn/ioeventfd.c +++ b/drivers/virt/acrn/ioeventfd.c @@ -223,7 +223,7 @@ static int acrn_ioeventfd_handler(struct acrn_ioreq_client *client, mutex_lock(&client->vm->ioeventfds_lock); p = hsm_ioeventfd_match(client->vm, addr, val, size, req->type); if (p) - eventfd_signal(p->eventfd, 1); + eventfd_signal(p->eventfd); mutex_unlock(&client->vm->ioeventfds_lock); return 0; diff --git a/fs/aio.c b/fs/aio.c index 77e33619de40..96cf97b19077 100644 --- a/fs/aio.c +++ b/fs/aio.c @@ -1166,7 +1166,7 @@ static void aio_complete(struct aio_kiocb *iocb) * from IRQ context. */ if (iocb->ki_eventfd) - eventfd_signal(iocb->ki_eventfd, 1); + eventfd_signal(iocb->ki_eventfd); /* * We have to order our ring_info tail store above and test diff --git a/fs/eventfd.c b/fs/eventfd.c index 33a918f9566c..dc9e01053235 100644 --- a/fs/eventfd.c +++ b/fs/eventfd.c @@ -74,20 +74,17 @@ __u64 eventfd_signal_mask(struct eventfd_ctx *ctx, __u64 n, __poll_t mask) /** * eventfd_signal - Adds @n to the eventfd counter. * @ctx: [in] Pointer to the eventfd context. - * @n: [in] Value of the counter to be added to the eventfd internal counter. - * The value cannot be negative. * * This function is supposed to be called by the kernel in paths that do not * allow sleeping. In this function we allow the counter to reach the ULLONG_MAX * value, and we signal this as overflow condition by returning a EPOLLERR * to poll(2). * - * Returns the amount by which the counter was incremented. This will be less - * than @n if the counter has overflowed. + * Returns the amount by which the counter was incremented. */ -__u64 eventfd_signal(struct eventfd_ctx *ctx, __u64 n) +__u64 eventfd_signal(struct eventfd_ctx *ctx) { - return eventfd_signal_mask(ctx, n, 0); + return eventfd_signal_mask(ctx, 1, 0); } EXPORT_SYMBOL_GPL(eventfd_signal); diff --git a/include/linux/eventfd.h b/include/linux/eventfd.h index b9d83652c097..562089431551 100644 --- a/include/linux/eventfd.h +++ b/include/linux/eventfd.h @@ -35,7 +35,7 @@ void eventfd_ctx_put(struct eventfd_ctx *ctx); struct file *eventfd_fget(int fd); struct eventfd_ctx *eventfd_ctx_fdget(int fd); struct eventfd_ctx *eventfd_ctx_fileget(struct file *file); -__u64 eventfd_signal(struct eventfd_ctx *ctx, __u64 n); +__u64 eventfd_signal(struct eventfd_ctx *ctx); __u64 eventfd_signal_mask(struct eventfd_ctx *ctx, __u64 n, __poll_t mask); int eventfd_ctx_remove_wait_queue(struct eventfd_ctx *ctx, wait_queue_entry_t *wait, __u64 *cnt); @@ -58,7 +58,7 @@ static inline struct eventfd_ctx *eventfd_ctx_fdget(int fd) return ERR_PTR(-ENOSYS); } -static inline int eventfd_signal(struct eventfd_ctx *ctx, __u64 n) +static inline int eventfd_signal(struct eventfd_ctx *ctx) { return -ENOSYS; } diff --git a/mm/memcontrol.c b/mm/memcontrol.c index e8ca4bdcb03c..891550f575a1 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -4228,7 +4228,7 @@ static void __mem_cgroup_threshold(struct mem_cgroup *memcg, bool swap) * only one element of the array here. */ for (; i >= 0 && unlikely(t->entries[i].threshold > usage); i--) - eventfd_signal(t->entries[i].eventfd, 1); + eventfd_signal(t->entries[i].eventfd); /* i = current_threshold + 1 */ i++; @@ -4240,7 +4240,7 @@ static void __mem_cgroup_threshold(struct mem_cgroup *memcg, bool swap) * only one element of the array here. */ for (; i < t->size && unlikely(t->entries[i].threshold <= usage); i++) - eventfd_signal(t->entries[i].eventfd, 1); + eventfd_signal(t->entries[i].eventfd); /* Update current_threshold */ t->current_threshold = i - 1; @@ -4280,7 +4280,7 @@ static int mem_cgroup_oom_notify_cb(struct mem_cgroup *memcg) spin_lock(&memcg_oom_lock); list_for_each_entry(ev, &memcg->oom_notify, list) - eventfd_signal(ev->eventfd, 1); + eventfd_signal(ev->eventfd); spin_unlock(&memcg_oom_lock); return 0; @@ -4499,7 +4499,7 @@ static int mem_cgroup_oom_register_event(struct mem_cgroup *memcg, /* already in OOM ? */ if (memcg->under_oom) - eventfd_signal(eventfd, 1); + eventfd_signal(eventfd); spin_unlock(&memcg_oom_lock); return 0; @@ -4791,7 +4791,7 @@ static void memcg_event_remove(struct work_struct *work) event->unregister_event(memcg, event->eventfd); /* Notify userspace the event is going away. */ - eventfd_signal(event->eventfd, 1); + eventfd_signal(event->eventfd); eventfd_ctx_put(event->eventfd); kfree(event); diff --git a/mm/vmpressure.c b/mm/vmpressure.c index b52644771cc4..ba4cdef37e42 100644 --- a/mm/vmpressure.c +++ b/mm/vmpressure.c @@ -169,7 +169,7 @@ static bool vmpressure_event(struct vmpressure *vmpr, continue; if (level < ev->level) continue; - eventfd_signal(ev->efd, 1); + eventfd_signal(ev->efd); ret = true; } mutex_unlock(&vmpr->events_lock); diff --git a/samples/vfio-mdev/mtty.c b/samples/vfio-mdev/mtty.c index a60801fb8660..5edcf8d738de 100644 --- a/samples/vfio-mdev/mtty.c +++ b/samples/vfio-mdev/mtty.c @@ -1028,9 +1028,9 @@ static int mtty_trigger_interrupt(struct mdev_state *mdev_state) } if (mdev_state->irq_index == VFIO_PCI_MSI_IRQ_INDEX) - ret = eventfd_signal(mdev_state->msi_evtfd, 1); + ret = eventfd_signal(mdev_state->msi_evtfd); else - ret = eventfd_signal(mdev_state->intx_evtfd, 1); + ret = eventfd_signal(mdev_state->intx_evtfd); #if defined(DEBUG_INTR) pr_info("Intx triggered\n"); diff --git a/virt/kvm/eventfd.c b/virt/kvm/eventfd.c index 89912a17f5d5..c0e230f4c3e9 100644 --- a/virt/kvm/eventfd.c +++ b/virt/kvm/eventfd.c @@ -61,7 +61,7 @@ static void irqfd_resampler_notify(struct kvm_kernel_irqfd_resampler *resampler) list_for_each_entry_srcu(irqfd, &resampler->list, resampler_link, srcu_read_lock_held(&resampler->kvm->irq_srcu)) - eventfd_signal(irqfd->resamplefd, 1); + eventfd_signal(irqfd->resamplefd); } /* @@ -786,7 +786,7 @@ ioeventfd_write(struct kvm_vcpu *vcpu, struct kvm_io_device *this, gpa_t addr, if (!ioeventfd_in_range(p, addr, len, val)) return -EOPNOTSUPP; - eventfd_signal(p->eventfd, 1); + eventfd_signal(p->eventfd); return 0; } -- 2.34.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH 1/2] eventfd: simplify eventfd_signal() 2023-07-13 10:05 ` [Intel-gfx] [PATCH 1/2] eventfd: simplify eventfd_signal() Christian Brauner @ 2023-07-13 13:29 ` Anthony Krowiak 2023-07-13 13:34 ` Oded Gabbay 1 sibling, 0 replies; 12+ messages in thread From: Anthony Krowiak @ 2023-07-13 13:29 UTC (permalink / raw) To: Christian Brauner, linux-fsdevel Cc: linux-aio, linux-usb, Matthew Rosato, Paul Durrant, Tom Rix, Jason Wang, dri-devel, Michal Hocko, linux-mm, Kirti Wankhede, Paolo Bonzini, Jens Axboe, Vineeth Vijayan, Diana Craciun, Alexander Gordeev, David Airlie, Xuan Zhuo, Shakeel Butt, Vasily Gorbik, Leon Romanovsky, Harald Freudenberger, Fei Li, x86, Roman Gushchin, Halil Pasic, Jason Gunthorpe, Ingo Molnar, intel-gfx, Christian Borntraeger, linux-fpga, Wu Hao, netdev, Eric Farman, Dave Hansen, Andrew Donnellan, Arnd Bergmann, linux-s390, Heiko Carstens, Johannes Weiner, linuxppc-dev, Eric Auger, Borislav Petkov, kvm, Rodrigo Vivi, cgroups, Thomas Gleixner, virtualization, intel-gvt-dev, io-uring, Jason Herne, Pavel Begunkov, Sean Christopherson, Oded Gabbay, Muchun Song, Peter Oberparleiter, linux-kernel, linux-rdma, Benjamin LaHaise, Michael S. Tsirkin, Sven Schnelle, Daniel Vetter, Greg Kroah-Hartman, Frederic Barrat, Moritz Fischer, Vitaly Kuznetsov, David Woodhouse, Xu Yilun For vfio_ap_ops.c: Reviewed-by: Tony Krowiak <akrowiak@stny.rr.com> On 7/13/23 6:05 AM, Christian Brauner wrote: > Ever since the evenfd type was introduced back in 2007 in commit > e1ad7468c77d ("signal/timer/event: eventfd core") the eventfd_signal() > function only ever passed 1 as a value for @n. There's no point in > keeping that additional argument. > > Signed-off-by: Christian Brauner <brauner@kernel.org> > --- > arch/x86/kvm/hyperv.c | 2 +- > arch/x86/kvm/xen.c | 2 +- > drivers/accel/habanalabs/common/device.c | 2 +- > drivers/fpga/dfl.c | 2 +- > drivers/gpu/drm/i915/gvt/interrupt.c | 2 +- > drivers/infiniband/hw/mlx5/devx.c | 2 +- > drivers/misc/ocxl/file.c | 2 +- > drivers/s390/cio/vfio_ccw_chp.c | 2 +- > drivers/s390/cio/vfio_ccw_drv.c | 4 ++-- > drivers/s390/cio/vfio_ccw_ops.c | 6 +++--- > drivers/s390/crypto/vfio_ap_ops.c | 2 +- > drivers/usb/gadget/function/f_fs.c | 4 ++-- > drivers/vdpa/vdpa_user/vduse_dev.c | 6 +++--- > drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c | 2 +- > drivers/vfio/pci/vfio_pci_core.c | 6 +++--- > drivers/vfio/pci/vfio_pci_intrs.c | 12 ++++++------ > drivers/vfio/platform/vfio_platform_irq.c | 4 ++-- > drivers/vhost/vdpa.c | 4 ++-- > drivers/vhost/vhost.c | 10 +++++----- > drivers/vhost/vhost.h | 2 +- > drivers/virt/acrn/ioeventfd.c | 2 +- > fs/aio.c | 2 +- > fs/eventfd.c | 9 +++------ > include/linux/eventfd.h | 4 ++-- > mm/memcontrol.c | 10 +++++----- > mm/vmpressure.c | 2 +- > samples/vfio-mdev/mtty.c | 4 ++-- > virt/kvm/eventfd.c | 4 ++-- > 28 files changed, 56 insertions(+), 59 deletions(-) > > diff --git a/arch/x86/kvm/hyperv.c b/arch/x86/kvm/hyperv.c > index b28fd020066f..2f4bd74b482c 100644 > --- a/arch/x86/kvm/hyperv.c > +++ b/arch/x86/kvm/hyperv.c > @@ -2387,7 +2387,7 @@ static u16 kvm_hvcall_signal_event(struct kvm_vcpu *vcpu, struct kvm_hv_hcall *h > if (!eventfd) > return HV_STATUS_INVALID_PORT_ID; > > - eventfd_signal(eventfd, 1); > + eventfd_signal(eventfd); > return HV_STATUS_SUCCESS; > } > > diff --git a/arch/x86/kvm/xen.c b/arch/x86/kvm/xen.c > index 40edf4d1974c..a7b62bafd57b 100644 > --- a/arch/x86/kvm/xen.c > +++ b/arch/x86/kvm/xen.c > @@ -2043,7 +2043,7 @@ static bool kvm_xen_hcall_evtchn_send(struct kvm_vcpu *vcpu, u64 param, u64 *r) > if (ret < 0 && ret != -ENOTCONN) > return false; > } else { > - eventfd_signal(evtchnfd->deliver.eventfd.ctx, 1); > + eventfd_signal(evtchnfd->deliver.eventfd.ctx); > } > > *r = 0; > diff --git a/drivers/accel/habanalabs/common/device.c b/drivers/accel/habanalabs/common/device.c > index b97339d1f7c6..30357b371d61 100644 > --- a/drivers/accel/habanalabs/common/device.c > +++ b/drivers/accel/habanalabs/common/device.c > @@ -1963,7 +1963,7 @@ static void hl_notifier_event_send(struct hl_notifier_event *notifier_event, u64 > notifier_event->events_mask |= event_mask; > > if (notifier_event->eventfd) > - eventfd_signal(notifier_event->eventfd, 1); > + eventfd_signal(notifier_event->eventfd); > > mutex_unlock(¬ifier_event->lock); > } > diff --git a/drivers/fpga/dfl.c b/drivers/fpga/dfl.c > index dd7a783d53b5..e73f88050f08 100644 > --- a/drivers/fpga/dfl.c > +++ b/drivers/fpga/dfl.c > @@ -1872,7 +1872,7 @@ static irqreturn_t dfl_irq_handler(int irq, void *arg) > { > struct eventfd_ctx *trigger = arg; > > - eventfd_signal(trigger, 1); > + eventfd_signal(trigger); > return IRQ_HANDLED; > } > > diff --git a/drivers/gpu/drm/i915/gvt/interrupt.c b/drivers/gpu/drm/i915/gvt/interrupt.c > index 68eca023bbc6..3d9e09c2add4 100644 > --- a/drivers/gpu/drm/i915/gvt/interrupt.c > +++ b/drivers/gpu/drm/i915/gvt/interrupt.c > @@ -435,7 +435,7 @@ static int inject_virtual_interrupt(struct intel_vgpu *vgpu) > */ > if (!test_bit(INTEL_VGPU_STATUS_ATTACHED, vgpu->status)) > return -ESRCH; > - if (vgpu->msi_trigger && eventfd_signal(vgpu->msi_trigger, 1) != 1) > + if (vgpu->msi_trigger && eventfd_signal(vgpu->msi_trigger) != 1) > return -EFAULT; > return 0; > } > diff --git a/drivers/infiniband/hw/mlx5/devx.c b/drivers/infiniband/hw/mlx5/devx.c > index db5fb196c728..ad50487790ff 100644 > --- a/drivers/infiniband/hw/mlx5/devx.c > +++ b/drivers/infiniband/hw/mlx5/devx.c > @@ -2498,7 +2498,7 @@ static void dispatch_event_fd(struct list_head *fd_list, > > list_for_each_entry_rcu(item, fd_list, xa_list) { > if (item->eventfd) > - eventfd_signal(item->eventfd, 1); > + eventfd_signal(item->eventfd); > else > deliver_event(item, data); > } > diff --git a/drivers/misc/ocxl/file.c b/drivers/misc/ocxl/file.c > index 6e63f060e4cc..51766db296ab 100644 > --- a/drivers/misc/ocxl/file.c > +++ b/drivers/misc/ocxl/file.c > @@ -185,7 +185,7 @@ static irqreturn_t irq_handler(void *private) > { > struct eventfd_ctx *ev_ctx = private; > > - eventfd_signal(ev_ctx, 1); > + eventfd_signal(ev_ctx); > return IRQ_HANDLED; > } > > diff --git a/drivers/s390/cio/vfio_ccw_chp.c b/drivers/s390/cio/vfio_ccw_chp.c > index d3f3a611f95b..38c176cf6295 100644 > --- a/drivers/s390/cio/vfio_ccw_chp.c > +++ b/drivers/s390/cio/vfio_ccw_chp.c > @@ -115,7 +115,7 @@ static ssize_t vfio_ccw_crw_region_read(struct vfio_ccw_private *private, > > /* Notify the guest if more CRWs are on our queue */ > if (!list_empty(&private->crw) && private->crw_trigger) > - eventfd_signal(private->crw_trigger, 1); > + eventfd_signal(private->crw_trigger); > > return ret; > } > diff --git a/drivers/s390/cio/vfio_ccw_drv.c b/drivers/s390/cio/vfio_ccw_drv.c > index 43601816ea4e..bfb35cfce1ef 100644 > --- a/drivers/s390/cio/vfio_ccw_drv.c > +++ b/drivers/s390/cio/vfio_ccw_drv.c > @@ -112,7 +112,7 @@ void vfio_ccw_sch_io_todo(struct work_struct *work) > private->state = VFIO_CCW_STATE_IDLE; > > if (private->io_trigger) > - eventfd_signal(private->io_trigger, 1); > + eventfd_signal(private->io_trigger); > } > > void vfio_ccw_crw_todo(struct work_struct *work) > @@ -122,7 +122,7 @@ void vfio_ccw_crw_todo(struct work_struct *work) > private = container_of(work, struct vfio_ccw_private, crw_work); > > if (!list_empty(&private->crw) && private->crw_trigger) > - eventfd_signal(private->crw_trigger, 1); > + eventfd_signal(private->crw_trigger); > } > > /* > diff --git a/drivers/s390/cio/vfio_ccw_ops.c b/drivers/s390/cio/vfio_ccw_ops.c > index 5b53b94f13c7..3df231f6feda 100644 > --- a/drivers/s390/cio/vfio_ccw_ops.c > +++ b/drivers/s390/cio/vfio_ccw_ops.c > @@ -421,7 +421,7 @@ static int vfio_ccw_mdev_set_irqs(struct vfio_ccw_private *private, > case VFIO_IRQ_SET_DATA_NONE: > { > if (*ctx) > - eventfd_signal(*ctx, 1); > + eventfd_signal(*ctx); > return 0; > } > case VFIO_IRQ_SET_DATA_BOOL: > @@ -432,7 +432,7 @@ static int vfio_ccw_mdev_set_irqs(struct vfio_ccw_private *private, > return -EFAULT; > > if (trigger && *ctx) > - eventfd_signal(*ctx, 1); > + eventfd_signal(*ctx); > return 0; > } > case VFIO_IRQ_SET_DATA_EVENTFD: > @@ -612,7 +612,7 @@ static void vfio_ccw_mdev_request(struct vfio_device *vdev, unsigned int count) > "Relaying device request to user (#%u)\n", > count); > > - eventfd_signal(private->req_trigger, 1); > + eventfd_signal(private->req_trigger); > } else if (count == 0) { > dev_notice(dev, > "No device request channel registered, blocked until released by user\n"); > diff --git a/drivers/s390/crypto/vfio_ap_ops.c b/drivers/s390/crypto/vfio_ap_ops.c > index b441745b0418..feb88526ac9d 100644 > --- a/drivers/s390/crypto/vfio_ap_ops.c > +++ b/drivers/s390/crypto/vfio_ap_ops.c > @@ -1749,7 +1749,7 @@ static void vfio_ap_mdev_request(struct vfio_device *vdev, unsigned int count) > "Relaying device request to user (#%u)\n", > count); > > - eventfd_signal(matrix_mdev->req_trigger, 1); > + eventfd_signal(matrix_mdev->req_trigger); > } else if (count == 0) { > dev_notice(dev, > "No device request registered, blocked until released by user\n"); > diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c > index f41a385a5c42..ceb1aad0c5df 100644 > --- a/drivers/usb/gadget/function/f_fs.c > +++ b/drivers/usb/gadget/function/f_fs.c > @@ -831,7 +831,7 @@ static void ffs_user_copy_worker(struct work_struct *work) > io_data->kiocb->ki_complete(io_data->kiocb, ret); > > if (io_data->ffs->ffs_eventfd && !kiocb_has_eventfd) > - eventfd_signal(io_data->ffs->ffs_eventfd, 1); > + eventfd_signal(io_data->ffs->ffs_eventfd); > > if (io_data->read) > kfree(io_data->to_free); > @@ -2739,7 +2739,7 @@ static void __ffs_event_add(struct ffs_data *ffs, > ffs->ev.types[ffs->ev.count++] = type; > wake_up_locked(&ffs->ev.waitq); > if (ffs->ffs_eventfd) > - eventfd_signal(ffs->ffs_eventfd, 1); > + eventfd_signal(ffs->ffs_eventfd); > } > > static void ffs_event_add(struct ffs_data *ffs, > diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c b/drivers/vdpa/vdpa_user/vduse_dev.c > index dc38ed21319d..99b901a9e638 100644 > --- a/drivers/vdpa/vdpa_user/vduse_dev.c > +++ b/drivers/vdpa/vdpa_user/vduse_dev.c > @@ -494,7 +494,7 @@ static void vduse_vq_kick(struct vduse_virtqueue *vq) > goto unlock; > > if (vq->kickfd) > - eventfd_signal(vq->kickfd, 1); > + eventfd_signal(vq->kickfd); > else > vq->kicked = true; > unlock: > @@ -912,7 +912,7 @@ static int vduse_kickfd_setup(struct vduse_dev *dev, > eventfd_ctx_put(vq->kickfd); > vq->kickfd = ctx; > if (vq->ready && vq->kicked && vq->kickfd) { > - eventfd_signal(vq->kickfd, 1); > + eventfd_signal(vq->kickfd); > vq->kicked = false; > } > spin_unlock(&vq->kick_lock); > @@ -961,7 +961,7 @@ static bool vduse_vq_signal_irqfd(struct vduse_virtqueue *vq) > > spin_lock_irq(&vq->irq_lock); > if (vq->ready && vq->cb.trigger) { > - eventfd_signal(vq->cb.trigger, 1); > + eventfd_signal(vq->cb.trigger); > signal = true; > } > spin_unlock_irq(&vq->irq_lock); > diff --git a/drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c b/drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c > index c51229fccbd6..d62fbfff20b8 100644 > --- a/drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c > +++ b/drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c > @@ -54,7 +54,7 @@ static irqreturn_t vfio_fsl_mc_irq_handler(int irq_num, void *arg) > { > struct vfio_fsl_mc_irq *mc_irq = (struct vfio_fsl_mc_irq *)arg; > > - eventfd_signal(mc_irq->trigger, 1); > + eventfd_signal(mc_irq->trigger); > return IRQ_HANDLED; > } > > diff --git a/drivers/vfio/pci/vfio_pci_core.c b/drivers/vfio/pci/vfio_pci_core.c > index 20d7b69ea6ff..01c8e31db23b 100644 > --- a/drivers/vfio/pci/vfio_pci_core.c > +++ b/drivers/vfio/pci/vfio_pci_core.c > @@ -441,7 +441,7 @@ static int vfio_pci_core_runtime_resume(struct device *dev) > */ > down_write(&vdev->memory_lock); > if (vdev->pm_wake_eventfd_ctx) { > - eventfd_signal(vdev->pm_wake_eventfd_ctx, 1); > + eventfd_signal(vdev->pm_wake_eventfd_ctx); > __vfio_pci_runtime_pm_exit(vdev); > } > up_write(&vdev->memory_lock); > @@ -1861,7 +1861,7 @@ void vfio_pci_core_request(struct vfio_device *core_vdev, unsigned int count) > pci_notice_ratelimited(pdev, > "Relaying device request to user (#%u)\n", > count); > - eventfd_signal(vdev->req_trigger, 1); > + eventfd_signal(vdev->req_trigger); > } else if (count == 0) { > pci_warn(pdev, > "No device request channel registered, blocked until released by user\n"); > @@ -2280,7 +2280,7 @@ pci_ers_result_t vfio_pci_core_aer_err_detected(struct pci_dev *pdev, > mutex_lock(&vdev->igate); > > if (vdev->err_trigger) > - eventfd_signal(vdev->err_trigger, 1); > + eventfd_signal(vdev->err_trigger); > > mutex_unlock(&vdev->igate); > > diff --git a/drivers/vfio/pci/vfio_pci_intrs.c b/drivers/vfio/pci/vfio_pci_intrs.c > index cbb4bcbfbf83..237beac83809 100644 > --- a/drivers/vfio/pci/vfio_pci_intrs.c > +++ b/drivers/vfio/pci/vfio_pci_intrs.c > @@ -94,7 +94,7 @@ static void vfio_send_intx_eventfd(void *opaque, void *unused) > ctx = vfio_irq_ctx_get(vdev, 0); > if (WARN_ON_ONCE(!ctx)) > return; > - eventfd_signal(ctx->trigger, 1); > + eventfd_signal(ctx->trigger); > } > } > > @@ -342,7 +342,7 @@ static irqreturn_t vfio_msihandler(int irq, void *arg) > { > struct eventfd_ctx *trigger = arg; > > - eventfd_signal(trigger, 1); > + eventfd_signal(trigger); > return IRQ_HANDLED; > } > > @@ -689,11 +689,11 @@ static int vfio_pci_set_msi_trigger(struct vfio_pci_core_device *vdev, > if (!ctx) > continue; > if (flags & VFIO_IRQ_SET_DATA_NONE) { > - eventfd_signal(ctx->trigger, 1); > + eventfd_signal(ctx->trigger); > } else if (flags & VFIO_IRQ_SET_DATA_BOOL) { > uint8_t *bools = data; > if (bools[i - start]) > - eventfd_signal(ctx->trigger, 1); > + eventfd_signal(ctx->trigger); > } > } > return 0; > @@ -707,7 +707,7 @@ static int vfio_pci_set_ctx_trigger_single(struct eventfd_ctx **ctx, > if (flags & VFIO_IRQ_SET_DATA_NONE) { > if (*ctx) { > if (count) { > - eventfd_signal(*ctx, 1); > + eventfd_signal(*ctx); > } else { > eventfd_ctx_put(*ctx); > *ctx = NULL; > @@ -722,7 +722,7 @@ static int vfio_pci_set_ctx_trigger_single(struct eventfd_ctx **ctx, > > trigger = *(uint8_t *)data; > if (trigger && *ctx) > - eventfd_signal(*ctx, 1); > + eventfd_signal(*ctx); > > return 0; > } else if (flags & VFIO_IRQ_SET_DATA_EVENTFD) { > diff --git a/drivers/vfio/platform/vfio_platform_irq.c b/drivers/vfio/platform/vfio_platform_irq.c > index 665197caed89..61a1bfb68ac7 100644 > --- a/drivers/vfio/platform/vfio_platform_irq.c > +++ b/drivers/vfio/platform/vfio_platform_irq.c > @@ -155,7 +155,7 @@ static irqreturn_t vfio_automasked_irq_handler(int irq, void *dev_id) > spin_unlock_irqrestore(&irq_ctx->lock, flags); > > if (ret == IRQ_HANDLED) > - eventfd_signal(irq_ctx->trigger, 1); > + eventfd_signal(irq_ctx->trigger); > > return ret; > } > @@ -164,7 +164,7 @@ static irqreturn_t vfio_irq_handler(int irq, void *dev_id) > { > struct vfio_platform_irq *irq_ctx = dev_id; > > - eventfd_signal(irq_ctx->trigger, 1); > + eventfd_signal(irq_ctx->trigger); > > return IRQ_HANDLED; > } > diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c > index b43e8680eee8..722894a0f124 100644 > --- a/drivers/vhost/vdpa.c > +++ b/drivers/vhost/vdpa.c > @@ -161,7 +161,7 @@ static irqreturn_t vhost_vdpa_virtqueue_cb(void *private) > struct eventfd_ctx *call_ctx = vq->call_ctx.ctx; > > if (call_ctx) > - eventfd_signal(call_ctx, 1); > + eventfd_signal(call_ctx); > > return IRQ_HANDLED; > } > @@ -172,7 +172,7 @@ static irqreturn_t vhost_vdpa_config_cb(void *private) > struct eventfd_ctx *config_ctx = v->config_ctx; > > if (config_ctx) > - eventfd_signal(config_ctx, 1); > + eventfd_signal(config_ctx); > > return IRQ_HANDLED; > } > diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c > index c71d573f1c94..bee50f153c8e 100644 > --- a/drivers/vhost/vhost.c > +++ b/drivers/vhost/vhost.c > @@ -2250,7 +2250,7 @@ int vhost_log_write(struct vhost_virtqueue *vq, struct vhost_log *log, > len -= l; > if (!len) { > if (vq->log_ctx) > - eventfd_signal(vq->log_ctx, 1); > + eventfd_signal(vq->log_ctx); > return 0; > } > } > @@ -2273,7 +2273,7 @@ static int vhost_update_used_flags(struct vhost_virtqueue *vq) > log_used(vq, (used - (void __user *)vq->used), > sizeof vq->used->flags); > if (vq->log_ctx) > - eventfd_signal(vq->log_ctx, 1); > + eventfd_signal(vq->log_ctx); > } > return 0; > } > @@ -2291,7 +2291,7 @@ static int vhost_update_avail_event(struct vhost_virtqueue *vq) > log_used(vq, (used - (void __user *)vq->used), > sizeof *vhost_avail_event(vq)); > if (vq->log_ctx) > - eventfd_signal(vq->log_ctx, 1); > + eventfd_signal(vq->log_ctx); > } > return 0; > } > @@ -2717,7 +2717,7 @@ int vhost_add_used_n(struct vhost_virtqueue *vq, struct vring_used_elem *heads, > log_used(vq, offsetof(struct vring_used, idx), > sizeof vq->used->idx); > if (vq->log_ctx) > - eventfd_signal(vq->log_ctx, 1); > + eventfd_signal(vq->log_ctx); > } > return r; > } > @@ -2765,7 +2765,7 @@ void vhost_signal(struct vhost_dev *dev, struct vhost_virtqueue *vq) > { > /* Signal the Guest tell them we used something up. */ > if (vq->call_ctx.ctx && vhost_notify(dev, vq)) > - eventfd_signal(vq->call_ctx.ctx, 1); > + eventfd_signal(vq->call_ctx.ctx); > } > EXPORT_SYMBOL_GPL(vhost_signal); > > diff --git a/drivers/vhost/vhost.h b/drivers/vhost/vhost.h > index f60d5f7bef94..9e942fcda5c3 100644 > --- a/drivers/vhost/vhost.h > +++ b/drivers/vhost/vhost.h > @@ -249,7 +249,7 @@ void vhost_iotlb_map_free(struct vhost_iotlb *iotlb, > #define vq_err(vq, fmt, ...) do { \ > pr_debug(pr_fmt(fmt), ##__VA_ARGS__); \ > if ((vq)->error_ctx) \ > - eventfd_signal((vq)->error_ctx, 1);\ > + eventfd_signal((vq)->error_ctx);\ > } while (0) > > enum { > diff --git a/drivers/virt/acrn/ioeventfd.c b/drivers/virt/acrn/ioeventfd.c > index ac4037e9f947..4e845c6ca0b5 100644 > --- a/drivers/virt/acrn/ioeventfd.c > +++ b/drivers/virt/acrn/ioeventfd.c > @@ -223,7 +223,7 @@ static int acrn_ioeventfd_handler(struct acrn_ioreq_client *client, > mutex_lock(&client->vm->ioeventfds_lock); > p = hsm_ioeventfd_match(client->vm, addr, val, size, req->type); > if (p) > - eventfd_signal(p->eventfd, 1); > + eventfd_signal(p->eventfd); > mutex_unlock(&client->vm->ioeventfds_lock); > > return 0; > diff --git a/fs/aio.c b/fs/aio.c > index 77e33619de40..96cf97b19077 100644 > --- a/fs/aio.c > +++ b/fs/aio.c > @@ -1166,7 +1166,7 @@ static void aio_complete(struct aio_kiocb *iocb) > * from IRQ context. > */ > if (iocb->ki_eventfd) > - eventfd_signal(iocb->ki_eventfd, 1); > + eventfd_signal(iocb->ki_eventfd); > > /* > * We have to order our ring_info tail store above and test > diff --git a/fs/eventfd.c b/fs/eventfd.c > index 33a918f9566c..dc9e01053235 100644 > --- a/fs/eventfd.c > +++ b/fs/eventfd.c > @@ -74,20 +74,17 @@ __u64 eventfd_signal_mask(struct eventfd_ctx *ctx, __u64 n, __poll_t mask) > /** > * eventfd_signal - Adds @n to the eventfd counter. > * @ctx: [in] Pointer to the eventfd context. > - * @n: [in] Value of the counter to be added to the eventfd internal counter. > - * The value cannot be negative. > * > * This function is supposed to be called by the kernel in paths that do not > * allow sleeping. In this function we allow the counter to reach the ULLONG_MAX > * value, and we signal this as overflow condition by returning a EPOLLERR > * to poll(2). > * > - * Returns the amount by which the counter was incremented. This will be less > - * than @n if the counter has overflowed. > + * Returns the amount by which the counter was incremented. > */ > -__u64 eventfd_signal(struct eventfd_ctx *ctx, __u64 n) > +__u64 eventfd_signal(struct eventfd_ctx *ctx) > { > - return eventfd_signal_mask(ctx, n, 0); > + return eventfd_signal_mask(ctx, 1, 0); > } > EXPORT_SYMBOL_GPL(eventfd_signal); > > diff --git a/include/linux/eventfd.h b/include/linux/eventfd.h > index b9d83652c097..562089431551 100644 > --- a/include/linux/eventfd.h > +++ b/include/linux/eventfd.h > @@ -35,7 +35,7 @@ void eventfd_ctx_put(struct eventfd_ctx *ctx); > struct file *eventfd_fget(int fd); > struct eventfd_ctx *eventfd_ctx_fdget(int fd); > struct eventfd_ctx *eventfd_ctx_fileget(struct file *file); > -__u64 eventfd_signal(struct eventfd_ctx *ctx, __u64 n); > +__u64 eventfd_signal(struct eventfd_ctx *ctx); > __u64 eventfd_signal_mask(struct eventfd_ctx *ctx, __u64 n, __poll_t mask); > int eventfd_ctx_remove_wait_queue(struct eventfd_ctx *ctx, wait_queue_entry_t *wait, > __u64 *cnt); > @@ -58,7 +58,7 @@ static inline struct eventfd_ctx *eventfd_ctx_fdget(int fd) > return ERR_PTR(-ENOSYS); > } > > -static inline int eventfd_signal(struct eventfd_ctx *ctx, __u64 n) > +static inline int eventfd_signal(struct eventfd_ctx *ctx) > { > return -ENOSYS; > } > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index e8ca4bdcb03c..891550f575a1 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -4228,7 +4228,7 @@ static void __mem_cgroup_threshold(struct mem_cgroup *memcg, bool swap) > * only one element of the array here. > */ > for (; i >= 0 && unlikely(t->entries[i].threshold > usage); i--) > - eventfd_signal(t->entries[i].eventfd, 1); > + eventfd_signal(t->entries[i].eventfd); > > /* i = current_threshold + 1 */ > i++; > @@ -4240,7 +4240,7 @@ static void __mem_cgroup_threshold(struct mem_cgroup *memcg, bool swap) > * only one element of the array here. > */ > for (; i < t->size && unlikely(t->entries[i].threshold <= usage); i++) > - eventfd_signal(t->entries[i].eventfd, 1); > + eventfd_signal(t->entries[i].eventfd); > > /* Update current_threshold */ > t->current_threshold = i - 1; > @@ -4280,7 +4280,7 @@ static int mem_cgroup_oom_notify_cb(struct mem_cgroup *memcg) > spin_lock(&memcg_oom_lock); > > list_for_each_entry(ev, &memcg->oom_notify, list) > - eventfd_signal(ev->eventfd, 1); > + eventfd_signal(ev->eventfd); > > spin_unlock(&memcg_oom_lock); > return 0; > @@ -4499,7 +4499,7 @@ static int mem_cgroup_oom_register_event(struct mem_cgroup *memcg, > > /* already in OOM ? */ > if (memcg->under_oom) > - eventfd_signal(eventfd, 1); > + eventfd_signal(eventfd); > spin_unlock(&memcg_oom_lock); > > return 0; > @@ -4791,7 +4791,7 @@ static void memcg_event_remove(struct work_struct *work) > event->unregister_event(memcg, event->eventfd); > > /* Notify userspace the event is going away. */ > - eventfd_signal(event->eventfd, 1); > + eventfd_signal(event->eventfd); > > eventfd_ctx_put(event->eventfd); > kfree(event); > diff --git a/mm/vmpressure.c b/mm/vmpressure.c > index b52644771cc4..ba4cdef37e42 100644 > --- a/mm/vmpressure.c > +++ b/mm/vmpressure.c > @@ -169,7 +169,7 @@ static bool vmpressure_event(struct vmpressure *vmpr, > continue; > if (level < ev->level) > continue; > - eventfd_signal(ev->efd, 1); > + eventfd_signal(ev->efd); > ret = true; > } > mutex_unlock(&vmpr->events_lock); > diff --git a/samples/vfio-mdev/mtty.c b/samples/vfio-mdev/mtty.c > index a60801fb8660..5edcf8d738de 100644 > --- a/samples/vfio-mdev/mtty.c > +++ b/samples/vfio-mdev/mtty.c > @@ -1028,9 +1028,9 @@ static int mtty_trigger_interrupt(struct mdev_state *mdev_state) > } > > if (mdev_state->irq_index == VFIO_PCI_MSI_IRQ_INDEX) > - ret = eventfd_signal(mdev_state->msi_evtfd, 1); > + ret = eventfd_signal(mdev_state->msi_evtfd); > else > - ret = eventfd_signal(mdev_state->intx_evtfd, 1); > + ret = eventfd_signal(mdev_state->intx_evtfd); > > #if defined(DEBUG_INTR) > pr_info("Intx triggered\n"); > diff --git a/virt/kvm/eventfd.c b/virt/kvm/eventfd.c > index 89912a17f5d5..c0e230f4c3e9 100644 > --- a/virt/kvm/eventfd.c > +++ b/virt/kvm/eventfd.c > @@ -61,7 +61,7 @@ static void irqfd_resampler_notify(struct kvm_kernel_irqfd_resampler *resampler) > > list_for_each_entry_srcu(irqfd, &resampler->list, resampler_link, > srcu_read_lock_held(&resampler->kvm->irq_srcu)) > - eventfd_signal(irqfd->resamplefd, 1); > + eventfd_signal(irqfd->resamplefd); > } > > /* > @@ -786,7 +786,7 @@ ioeventfd_write(struct kvm_vcpu *vcpu, struct kvm_io_device *this, gpa_t addr, > if (!ioeventfd_in_range(p, addr, len, val)) > return -EOPNOTSUPP; > > - eventfd_signal(p->eventfd, 1); > + eventfd_signal(p->eventfd); > return 0; > } > > ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH 1/2] eventfd: simplify eventfd_signal() 2023-07-13 10:05 ` [Intel-gfx] [PATCH 1/2] eventfd: simplify eventfd_signal() Christian Brauner 2023-07-13 13:29 ` Anthony Krowiak @ 2023-07-13 13:34 ` Oded Gabbay 1 sibling, 0 replies; 12+ messages in thread From: Oded Gabbay @ 2023-07-13 13:34 UTC (permalink / raw) To: Christian Brauner Cc: linux-aio, linux-usb, Matthew Rosato, Paul Durrant, Tom Rix, Jason Wang, dri-devel, Michal Hocko, linux-mm, Kirti Wankhede, Paolo Bonzini, Jens Axboe, Vineeth Vijayan, Diana Craciun, Alexander Gordeev, David Airlie, Xuan Zhuo, Shakeel Butt, Vasily Gorbik, Leon Romanovsky, Harald Freudenberger, Fei Li, x86, Roman Gushchin, Halil Pasic, Jason Gunthorpe, Ingo Molnar, intel-gfx, Christian Borntraeger, linux-fpga, Wu Hao, Jason Herne, Eric Farman, Dave Hansen, Andrew Donnellan, Arnd Bergmann, linux-s390, Heiko Carstens, Johannes Weiner, linuxppc-dev, Frederic Barrat, Moritz Fischer, kvm, Rodrigo Vivi, cgroups, Thomas Gleixner, virtualization, intel-gvt-dev, io-uring, netdev, Tony Krowiak, Pavel Begunkov, Eric Auger, Sean Christopherson, Muchun Song, Peter Oberparleiter, linux-kernel, linux-rdma, Benjamin LaHaise, Michael S. Tsirkin, Sven Schnelle, Daniel Vetter, Greg Kroah-Hartman, linux-fsdevel, Borislav Petkov, Vitaly Kuznetsov, David Woodhouse, Xu Yilun On Thu, Jul 13, 2023 at 1:06 PM Christian Brauner <brauner@kernel.org> wrote: > > Ever since the evenfd type was introduced back in 2007 in commit > e1ad7468c77d ("signal/timer/event: eventfd core") the eventfd_signal() > function only ever passed 1 as a value for @n. There's no point in > keeping that additional argument. > > Signed-off-by: Christian Brauner <brauner@kernel.org> > --- > arch/x86/kvm/hyperv.c | 2 +- > arch/x86/kvm/xen.c | 2 +- > drivers/accel/habanalabs/common/device.c | 2 +- > drivers/fpga/dfl.c | 2 +- > drivers/gpu/drm/i915/gvt/interrupt.c | 2 +- > drivers/infiniband/hw/mlx5/devx.c | 2 +- > drivers/misc/ocxl/file.c | 2 +- > drivers/s390/cio/vfio_ccw_chp.c | 2 +- > drivers/s390/cio/vfio_ccw_drv.c | 4 ++-- > drivers/s390/cio/vfio_ccw_ops.c | 6 +++--- > drivers/s390/crypto/vfio_ap_ops.c | 2 +- > drivers/usb/gadget/function/f_fs.c | 4 ++-- > drivers/vdpa/vdpa_user/vduse_dev.c | 6 +++--- > drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c | 2 +- > drivers/vfio/pci/vfio_pci_core.c | 6 +++--- > drivers/vfio/pci/vfio_pci_intrs.c | 12 ++++++------ > drivers/vfio/platform/vfio_platform_irq.c | 4 ++-- > drivers/vhost/vdpa.c | 4 ++-- > drivers/vhost/vhost.c | 10 +++++----- > drivers/vhost/vhost.h | 2 +- > drivers/virt/acrn/ioeventfd.c | 2 +- > fs/aio.c | 2 +- > fs/eventfd.c | 9 +++------ > include/linux/eventfd.h | 4 ++-- > mm/memcontrol.c | 10 +++++----- > mm/vmpressure.c | 2 +- > samples/vfio-mdev/mtty.c | 4 ++-- > virt/kvm/eventfd.c | 4 ++-- > 28 files changed, 56 insertions(+), 59 deletions(-) > > diff --git a/arch/x86/kvm/hyperv.c b/arch/x86/kvm/hyperv.c > index b28fd020066f..2f4bd74b482c 100644 > --- a/arch/x86/kvm/hyperv.c > +++ b/arch/x86/kvm/hyperv.c > @@ -2387,7 +2387,7 @@ static u16 kvm_hvcall_signal_event(struct kvm_vcpu *vcpu, struct kvm_hv_hcall *h > if (!eventfd) > return HV_STATUS_INVALID_PORT_ID; > > - eventfd_signal(eventfd, 1); > + eventfd_signal(eventfd); > return HV_STATUS_SUCCESS; > } > > diff --git a/arch/x86/kvm/xen.c b/arch/x86/kvm/xen.c > index 40edf4d1974c..a7b62bafd57b 100644 > --- a/arch/x86/kvm/xen.c > +++ b/arch/x86/kvm/xen.c > @@ -2043,7 +2043,7 @@ static bool kvm_xen_hcall_evtchn_send(struct kvm_vcpu *vcpu, u64 param, u64 *r) > if (ret < 0 && ret != -ENOTCONN) > return false; > } else { > - eventfd_signal(evtchnfd->deliver.eventfd.ctx, 1); > + eventfd_signal(evtchnfd->deliver.eventfd.ctx); > } > > *r = 0; > diff --git a/drivers/accel/habanalabs/common/device.c b/drivers/accel/habanalabs/common/device.c > index b97339d1f7c6..30357b371d61 100644 > --- a/drivers/accel/habanalabs/common/device.c > +++ b/drivers/accel/habanalabs/common/device.c > @@ -1963,7 +1963,7 @@ static void hl_notifier_event_send(struct hl_notifier_event *notifier_event, u64 > notifier_event->events_mask |= event_mask; > > if (notifier_event->eventfd) > - eventfd_signal(notifier_event->eventfd, 1); > + eventfd_signal(notifier_event->eventfd); > > mutex_unlock(¬ifier_event->lock); > } > diff --git a/drivers/fpga/dfl.c b/drivers/fpga/dfl.c > index dd7a783d53b5..e73f88050f08 100644 > --- a/drivers/fpga/dfl.c > +++ b/drivers/fpga/dfl.c > @@ -1872,7 +1872,7 @@ static irqreturn_t dfl_irq_handler(int irq, void *arg) > { > struct eventfd_ctx *trigger = arg; > > - eventfd_signal(trigger, 1); > + eventfd_signal(trigger); > return IRQ_HANDLED; > } > > diff --git a/drivers/gpu/drm/i915/gvt/interrupt.c b/drivers/gpu/drm/i915/gvt/interrupt.c > index 68eca023bbc6..3d9e09c2add4 100644 > --- a/drivers/gpu/drm/i915/gvt/interrupt.c > +++ b/drivers/gpu/drm/i915/gvt/interrupt.c > @@ -435,7 +435,7 @@ static int inject_virtual_interrupt(struct intel_vgpu *vgpu) > */ > if (!test_bit(INTEL_VGPU_STATUS_ATTACHED, vgpu->status)) > return -ESRCH; > - if (vgpu->msi_trigger && eventfd_signal(vgpu->msi_trigger, 1) != 1) > + if (vgpu->msi_trigger && eventfd_signal(vgpu->msi_trigger) != 1) > return -EFAULT; > return 0; > } > diff --git a/drivers/infiniband/hw/mlx5/devx.c b/drivers/infiniband/hw/mlx5/devx.c > index db5fb196c728..ad50487790ff 100644 > --- a/drivers/infiniband/hw/mlx5/devx.c > +++ b/drivers/infiniband/hw/mlx5/devx.c > @@ -2498,7 +2498,7 @@ static void dispatch_event_fd(struct list_head *fd_list, > > list_for_each_entry_rcu(item, fd_list, xa_list) { > if (item->eventfd) > - eventfd_signal(item->eventfd, 1); > + eventfd_signal(item->eventfd); > else > deliver_event(item, data); > } > diff --git a/drivers/misc/ocxl/file.c b/drivers/misc/ocxl/file.c > index 6e63f060e4cc..51766db296ab 100644 > --- a/drivers/misc/ocxl/file.c > +++ b/drivers/misc/ocxl/file.c > @@ -185,7 +185,7 @@ static irqreturn_t irq_handler(void *private) > { > struct eventfd_ctx *ev_ctx = private; > > - eventfd_signal(ev_ctx, 1); > + eventfd_signal(ev_ctx); > return IRQ_HANDLED; > } > > diff --git a/drivers/s390/cio/vfio_ccw_chp.c b/drivers/s390/cio/vfio_ccw_chp.c > index d3f3a611f95b..38c176cf6295 100644 > --- a/drivers/s390/cio/vfio_ccw_chp.c > +++ b/drivers/s390/cio/vfio_ccw_chp.c > @@ -115,7 +115,7 @@ static ssize_t vfio_ccw_crw_region_read(struct vfio_ccw_private *private, > > /* Notify the guest if more CRWs are on our queue */ > if (!list_empty(&private->crw) && private->crw_trigger) > - eventfd_signal(private->crw_trigger, 1); > + eventfd_signal(private->crw_trigger); > > return ret; > } > diff --git a/drivers/s390/cio/vfio_ccw_drv.c b/drivers/s390/cio/vfio_ccw_drv.c > index 43601816ea4e..bfb35cfce1ef 100644 > --- a/drivers/s390/cio/vfio_ccw_drv.c > +++ b/drivers/s390/cio/vfio_ccw_drv.c > @@ -112,7 +112,7 @@ void vfio_ccw_sch_io_todo(struct work_struct *work) > private->state = VFIO_CCW_STATE_IDLE; > > if (private->io_trigger) > - eventfd_signal(private->io_trigger, 1); > + eventfd_signal(private->io_trigger); > } > > void vfio_ccw_crw_todo(struct work_struct *work) > @@ -122,7 +122,7 @@ void vfio_ccw_crw_todo(struct work_struct *work) > private = container_of(work, struct vfio_ccw_private, crw_work); > > if (!list_empty(&private->crw) && private->crw_trigger) > - eventfd_signal(private->crw_trigger, 1); > + eventfd_signal(private->crw_trigger); > } > > /* > diff --git a/drivers/s390/cio/vfio_ccw_ops.c b/drivers/s390/cio/vfio_ccw_ops.c > index 5b53b94f13c7..3df231f6feda 100644 > --- a/drivers/s390/cio/vfio_ccw_ops.c > +++ b/drivers/s390/cio/vfio_ccw_ops.c > @@ -421,7 +421,7 @@ static int vfio_ccw_mdev_set_irqs(struct vfio_ccw_private *private, > case VFIO_IRQ_SET_DATA_NONE: > { > if (*ctx) > - eventfd_signal(*ctx, 1); > + eventfd_signal(*ctx); > return 0; > } > case VFIO_IRQ_SET_DATA_BOOL: > @@ -432,7 +432,7 @@ static int vfio_ccw_mdev_set_irqs(struct vfio_ccw_private *private, > return -EFAULT; > > if (trigger && *ctx) > - eventfd_signal(*ctx, 1); > + eventfd_signal(*ctx); > return 0; > } > case VFIO_IRQ_SET_DATA_EVENTFD: > @@ -612,7 +612,7 @@ static void vfio_ccw_mdev_request(struct vfio_device *vdev, unsigned int count) > "Relaying device request to user (#%u)\n", > count); > > - eventfd_signal(private->req_trigger, 1); > + eventfd_signal(private->req_trigger); > } else if (count == 0) { > dev_notice(dev, > "No device request channel registered, blocked until released by user\n"); > diff --git a/drivers/s390/crypto/vfio_ap_ops.c b/drivers/s390/crypto/vfio_ap_ops.c > index b441745b0418..feb88526ac9d 100644 > --- a/drivers/s390/crypto/vfio_ap_ops.c > +++ b/drivers/s390/crypto/vfio_ap_ops.c > @@ -1749,7 +1749,7 @@ static void vfio_ap_mdev_request(struct vfio_device *vdev, unsigned int count) > "Relaying device request to user (#%u)\n", > count); > > - eventfd_signal(matrix_mdev->req_trigger, 1); > + eventfd_signal(matrix_mdev->req_trigger); > } else if (count == 0) { > dev_notice(dev, > "No device request registered, blocked until released by user\n"); > diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c > index f41a385a5c42..ceb1aad0c5df 100644 > --- a/drivers/usb/gadget/function/f_fs.c > +++ b/drivers/usb/gadget/function/f_fs.c > @@ -831,7 +831,7 @@ static void ffs_user_copy_worker(struct work_struct *work) > io_data->kiocb->ki_complete(io_data->kiocb, ret); > > if (io_data->ffs->ffs_eventfd && !kiocb_has_eventfd) > - eventfd_signal(io_data->ffs->ffs_eventfd, 1); > + eventfd_signal(io_data->ffs->ffs_eventfd); > > if (io_data->read) > kfree(io_data->to_free); > @@ -2739,7 +2739,7 @@ static void __ffs_event_add(struct ffs_data *ffs, > ffs->ev.types[ffs->ev.count++] = type; > wake_up_locked(&ffs->ev.waitq); > if (ffs->ffs_eventfd) > - eventfd_signal(ffs->ffs_eventfd, 1); > + eventfd_signal(ffs->ffs_eventfd); > } > > static void ffs_event_add(struct ffs_data *ffs, > diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c b/drivers/vdpa/vdpa_user/vduse_dev.c > index dc38ed21319d..99b901a9e638 100644 > --- a/drivers/vdpa/vdpa_user/vduse_dev.c > +++ b/drivers/vdpa/vdpa_user/vduse_dev.c > @@ -494,7 +494,7 @@ static void vduse_vq_kick(struct vduse_virtqueue *vq) > goto unlock; > > if (vq->kickfd) > - eventfd_signal(vq->kickfd, 1); > + eventfd_signal(vq->kickfd); > else > vq->kicked = true; > unlock: > @@ -912,7 +912,7 @@ static int vduse_kickfd_setup(struct vduse_dev *dev, > eventfd_ctx_put(vq->kickfd); > vq->kickfd = ctx; > if (vq->ready && vq->kicked && vq->kickfd) { > - eventfd_signal(vq->kickfd, 1); > + eventfd_signal(vq->kickfd); > vq->kicked = false; > } > spin_unlock(&vq->kick_lock); > @@ -961,7 +961,7 @@ static bool vduse_vq_signal_irqfd(struct vduse_virtqueue *vq) > > spin_lock_irq(&vq->irq_lock); > if (vq->ready && vq->cb.trigger) { > - eventfd_signal(vq->cb.trigger, 1); > + eventfd_signal(vq->cb.trigger); > signal = true; > } > spin_unlock_irq(&vq->irq_lock); > diff --git a/drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c b/drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c > index c51229fccbd6..d62fbfff20b8 100644 > --- a/drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c > +++ b/drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c > @@ -54,7 +54,7 @@ static irqreturn_t vfio_fsl_mc_irq_handler(int irq_num, void *arg) > { > struct vfio_fsl_mc_irq *mc_irq = (struct vfio_fsl_mc_irq *)arg; > > - eventfd_signal(mc_irq->trigger, 1); > + eventfd_signal(mc_irq->trigger); > return IRQ_HANDLED; > } > > diff --git a/drivers/vfio/pci/vfio_pci_core.c b/drivers/vfio/pci/vfio_pci_core.c > index 20d7b69ea6ff..01c8e31db23b 100644 > --- a/drivers/vfio/pci/vfio_pci_core.c > +++ b/drivers/vfio/pci/vfio_pci_core.c > @@ -441,7 +441,7 @@ static int vfio_pci_core_runtime_resume(struct device *dev) > */ > down_write(&vdev->memory_lock); > if (vdev->pm_wake_eventfd_ctx) { > - eventfd_signal(vdev->pm_wake_eventfd_ctx, 1); > + eventfd_signal(vdev->pm_wake_eventfd_ctx); > __vfio_pci_runtime_pm_exit(vdev); > } > up_write(&vdev->memory_lock); > @@ -1861,7 +1861,7 @@ void vfio_pci_core_request(struct vfio_device *core_vdev, unsigned int count) > pci_notice_ratelimited(pdev, > "Relaying device request to user (#%u)\n", > count); > - eventfd_signal(vdev->req_trigger, 1); > + eventfd_signal(vdev->req_trigger); > } else if (count == 0) { > pci_warn(pdev, > "No device request channel registered, blocked until released by user\n"); > @@ -2280,7 +2280,7 @@ pci_ers_result_t vfio_pci_core_aer_err_detected(struct pci_dev *pdev, > mutex_lock(&vdev->igate); > > if (vdev->err_trigger) > - eventfd_signal(vdev->err_trigger, 1); > + eventfd_signal(vdev->err_trigger); > > mutex_unlock(&vdev->igate); > > diff --git a/drivers/vfio/pci/vfio_pci_intrs.c b/drivers/vfio/pci/vfio_pci_intrs.c > index cbb4bcbfbf83..237beac83809 100644 > --- a/drivers/vfio/pci/vfio_pci_intrs.c > +++ b/drivers/vfio/pci/vfio_pci_intrs.c > @@ -94,7 +94,7 @@ static void vfio_send_intx_eventfd(void *opaque, void *unused) > ctx = vfio_irq_ctx_get(vdev, 0); > if (WARN_ON_ONCE(!ctx)) > return; > - eventfd_signal(ctx->trigger, 1); > + eventfd_signal(ctx->trigger); > } > } > > @@ -342,7 +342,7 @@ static irqreturn_t vfio_msihandler(int irq, void *arg) > { > struct eventfd_ctx *trigger = arg; > > - eventfd_signal(trigger, 1); > + eventfd_signal(trigger); > return IRQ_HANDLED; > } > > @@ -689,11 +689,11 @@ static int vfio_pci_set_msi_trigger(struct vfio_pci_core_device *vdev, > if (!ctx) > continue; > if (flags & VFIO_IRQ_SET_DATA_NONE) { > - eventfd_signal(ctx->trigger, 1); > + eventfd_signal(ctx->trigger); > } else if (flags & VFIO_IRQ_SET_DATA_BOOL) { > uint8_t *bools = data; > if (bools[i - start]) > - eventfd_signal(ctx->trigger, 1); > + eventfd_signal(ctx->trigger); > } > } > return 0; > @@ -707,7 +707,7 @@ static int vfio_pci_set_ctx_trigger_single(struct eventfd_ctx **ctx, > if (flags & VFIO_IRQ_SET_DATA_NONE) { > if (*ctx) { > if (count) { > - eventfd_signal(*ctx, 1); > + eventfd_signal(*ctx); > } else { > eventfd_ctx_put(*ctx); > *ctx = NULL; > @@ -722,7 +722,7 @@ static int vfio_pci_set_ctx_trigger_single(struct eventfd_ctx **ctx, > > trigger = *(uint8_t *)data; > if (trigger && *ctx) > - eventfd_signal(*ctx, 1); > + eventfd_signal(*ctx); > > return 0; > } else if (flags & VFIO_IRQ_SET_DATA_EVENTFD) { > diff --git a/drivers/vfio/platform/vfio_platform_irq.c b/drivers/vfio/platform/vfio_platform_irq.c > index 665197caed89..61a1bfb68ac7 100644 > --- a/drivers/vfio/platform/vfio_platform_irq.c > +++ b/drivers/vfio/platform/vfio_platform_irq.c > @@ -155,7 +155,7 @@ static irqreturn_t vfio_automasked_irq_handler(int irq, void *dev_id) > spin_unlock_irqrestore(&irq_ctx->lock, flags); > > if (ret == IRQ_HANDLED) > - eventfd_signal(irq_ctx->trigger, 1); > + eventfd_signal(irq_ctx->trigger); > > return ret; > } > @@ -164,7 +164,7 @@ static irqreturn_t vfio_irq_handler(int irq, void *dev_id) > { > struct vfio_platform_irq *irq_ctx = dev_id; > > - eventfd_signal(irq_ctx->trigger, 1); > + eventfd_signal(irq_ctx->trigger); > > return IRQ_HANDLED; > } > diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c > index b43e8680eee8..722894a0f124 100644 > --- a/drivers/vhost/vdpa.c > +++ b/drivers/vhost/vdpa.c > @@ -161,7 +161,7 @@ static irqreturn_t vhost_vdpa_virtqueue_cb(void *private) > struct eventfd_ctx *call_ctx = vq->call_ctx.ctx; > > if (call_ctx) > - eventfd_signal(call_ctx, 1); > + eventfd_signal(call_ctx); > > return IRQ_HANDLED; > } > @@ -172,7 +172,7 @@ static irqreturn_t vhost_vdpa_config_cb(void *private) > struct eventfd_ctx *config_ctx = v->config_ctx; > > if (config_ctx) > - eventfd_signal(config_ctx, 1); > + eventfd_signal(config_ctx); > > return IRQ_HANDLED; > } > diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c > index c71d573f1c94..bee50f153c8e 100644 > --- a/drivers/vhost/vhost.c > +++ b/drivers/vhost/vhost.c > @@ -2250,7 +2250,7 @@ int vhost_log_write(struct vhost_virtqueue *vq, struct vhost_log *log, > len -= l; > if (!len) { > if (vq->log_ctx) > - eventfd_signal(vq->log_ctx, 1); > + eventfd_signal(vq->log_ctx); > return 0; > } > } > @@ -2273,7 +2273,7 @@ static int vhost_update_used_flags(struct vhost_virtqueue *vq) > log_used(vq, (used - (void __user *)vq->used), > sizeof vq->used->flags); > if (vq->log_ctx) > - eventfd_signal(vq->log_ctx, 1); > + eventfd_signal(vq->log_ctx); > } > return 0; > } > @@ -2291,7 +2291,7 @@ static int vhost_update_avail_event(struct vhost_virtqueue *vq) > log_used(vq, (used - (void __user *)vq->used), > sizeof *vhost_avail_event(vq)); > if (vq->log_ctx) > - eventfd_signal(vq->log_ctx, 1); > + eventfd_signal(vq->log_ctx); > } > return 0; > } > @@ -2717,7 +2717,7 @@ int vhost_add_used_n(struct vhost_virtqueue *vq, struct vring_used_elem *heads, > log_used(vq, offsetof(struct vring_used, idx), > sizeof vq->used->idx); > if (vq->log_ctx) > - eventfd_signal(vq->log_ctx, 1); > + eventfd_signal(vq->log_ctx); > } > return r; > } > @@ -2765,7 +2765,7 @@ void vhost_signal(struct vhost_dev *dev, struct vhost_virtqueue *vq) > { > /* Signal the Guest tell them we used something up. */ > if (vq->call_ctx.ctx && vhost_notify(dev, vq)) > - eventfd_signal(vq->call_ctx.ctx, 1); > + eventfd_signal(vq->call_ctx.ctx); > } > EXPORT_SYMBOL_GPL(vhost_signal); > > diff --git a/drivers/vhost/vhost.h b/drivers/vhost/vhost.h > index f60d5f7bef94..9e942fcda5c3 100644 > --- a/drivers/vhost/vhost.h > +++ b/drivers/vhost/vhost.h > @@ -249,7 +249,7 @@ void vhost_iotlb_map_free(struct vhost_iotlb *iotlb, > #define vq_err(vq, fmt, ...) do { \ > pr_debug(pr_fmt(fmt), ##__VA_ARGS__); \ > if ((vq)->error_ctx) \ > - eventfd_signal((vq)->error_ctx, 1);\ > + eventfd_signal((vq)->error_ctx);\ > } while (0) > > enum { > diff --git a/drivers/virt/acrn/ioeventfd.c b/drivers/virt/acrn/ioeventfd.c > index ac4037e9f947..4e845c6ca0b5 100644 > --- a/drivers/virt/acrn/ioeventfd.c > +++ b/drivers/virt/acrn/ioeventfd.c > @@ -223,7 +223,7 @@ static int acrn_ioeventfd_handler(struct acrn_ioreq_client *client, > mutex_lock(&client->vm->ioeventfds_lock); > p = hsm_ioeventfd_match(client->vm, addr, val, size, req->type); > if (p) > - eventfd_signal(p->eventfd, 1); > + eventfd_signal(p->eventfd); > mutex_unlock(&client->vm->ioeventfds_lock); > > return 0; > diff --git a/fs/aio.c b/fs/aio.c > index 77e33619de40..96cf97b19077 100644 > --- a/fs/aio.c > +++ b/fs/aio.c > @@ -1166,7 +1166,7 @@ static void aio_complete(struct aio_kiocb *iocb) > * from IRQ context. > */ > if (iocb->ki_eventfd) > - eventfd_signal(iocb->ki_eventfd, 1); > + eventfd_signal(iocb->ki_eventfd); > > /* > * We have to order our ring_info tail store above and test > diff --git a/fs/eventfd.c b/fs/eventfd.c > index 33a918f9566c..dc9e01053235 100644 > --- a/fs/eventfd.c > +++ b/fs/eventfd.c > @@ -74,20 +74,17 @@ __u64 eventfd_signal_mask(struct eventfd_ctx *ctx, __u64 n, __poll_t mask) > /** > * eventfd_signal - Adds @n to the eventfd counter. > * @ctx: [in] Pointer to the eventfd context. > - * @n: [in] Value of the counter to be added to the eventfd internal counter. > - * The value cannot be negative. > * > * This function is supposed to be called by the kernel in paths that do not > * allow sleeping. In this function we allow the counter to reach the ULLONG_MAX > * value, and we signal this as overflow condition by returning a EPOLLERR > * to poll(2). > * > - * Returns the amount by which the counter was incremented. This will be less > - * than @n if the counter has overflowed. > + * Returns the amount by which the counter was incremented. > */ > -__u64 eventfd_signal(struct eventfd_ctx *ctx, __u64 n) > +__u64 eventfd_signal(struct eventfd_ctx *ctx) > { > - return eventfd_signal_mask(ctx, n, 0); > + return eventfd_signal_mask(ctx, 1, 0); > } > EXPORT_SYMBOL_GPL(eventfd_signal); > > diff --git a/include/linux/eventfd.h b/include/linux/eventfd.h > index b9d83652c097..562089431551 100644 > --- a/include/linux/eventfd.h > +++ b/include/linux/eventfd.h > @@ -35,7 +35,7 @@ void eventfd_ctx_put(struct eventfd_ctx *ctx); > struct file *eventfd_fget(int fd); > struct eventfd_ctx *eventfd_ctx_fdget(int fd); > struct eventfd_ctx *eventfd_ctx_fileget(struct file *file); > -__u64 eventfd_signal(struct eventfd_ctx *ctx, __u64 n); > +__u64 eventfd_signal(struct eventfd_ctx *ctx); > __u64 eventfd_signal_mask(struct eventfd_ctx *ctx, __u64 n, __poll_t mask); > int eventfd_ctx_remove_wait_queue(struct eventfd_ctx *ctx, wait_queue_entry_t *wait, > __u64 *cnt); > @@ -58,7 +58,7 @@ static inline struct eventfd_ctx *eventfd_ctx_fdget(int fd) > return ERR_PTR(-ENOSYS); > } > > -static inline int eventfd_signal(struct eventfd_ctx *ctx, __u64 n) > +static inline int eventfd_signal(struct eventfd_ctx *ctx) > { > return -ENOSYS; > } > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index e8ca4bdcb03c..891550f575a1 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -4228,7 +4228,7 @@ static void __mem_cgroup_threshold(struct mem_cgroup *memcg, bool swap) > * only one element of the array here. > */ > for (; i >= 0 && unlikely(t->entries[i].threshold > usage); i--) > - eventfd_signal(t->entries[i].eventfd, 1); > + eventfd_signal(t->entries[i].eventfd); > > /* i = current_threshold + 1 */ > i++; > @@ -4240,7 +4240,7 @@ static void __mem_cgroup_threshold(struct mem_cgroup *memcg, bool swap) > * only one element of the array here. > */ > for (; i < t->size && unlikely(t->entries[i].threshold <= usage); i++) > - eventfd_signal(t->entries[i].eventfd, 1); > + eventfd_signal(t->entries[i].eventfd); > > /* Update current_threshold */ > t->current_threshold = i - 1; > @@ -4280,7 +4280,7 @@ static int mem_cgroup_oom_notify_cb(struct mem_cgroup *memcg) > spin_lock(&memcg_oom_lock); > > list_for_each_entry(ev, &memcg->oom_notify, list) > - eventfd_signal(ev->eventfd, 1); > + eventfd_signal(ev->eventfd); > > spin_unlock(&memcg_oom_lock); > return 0; > @@ -4499,7 +4499,7 @@ static int mem_cgroup_oom_register_event(struct mem_cgroup *memcg, > > /* already in OOM ? */ > if (memcg->under_oom) > - eventfd_signal(eventfd, 1); > + eventfd_signal(eventfd); > spin_unlock(&memcg_oom_lock); > > return 0; > @@ -4791,7 +4791,7 @@ static void memcg_event_remove(struct work_struct *work) > event->unregister_event(memcg, event->eventfd); > > /* Notify userspace the event is going away. */ > - eventfd_signal(event->eventfd, 1); > + eventfd_signal(event->eventfd); > > eventfd_ctx_put(event->eventfd); > kfree(event); > diff --git a/mm/vmpressure.c b/mm/vmpressure.c > index b52644771cc4..ba4cdef37e42 100644 > --- a/mm/vmpressure.c > +++ b/mm/vmpressure.c > @@ -169,7 +169,7 @@ static bool vmpressure_event(struct vmpressure *vmpr, > continue; > if (level < ev->level) > continue; > - eventfd_signal(ev->efd, 1); > + eventfd_signal(ev->efd); > ret = true; > } > mutex_unlock(&vmpr->events_lock); > diff --git a/samples/vfio-mdev/mtty.c b/samples/vfio-mdev/mtty.c > index a60801fb8660..5edcf8d738de 100644 > --- a/samples/vfio-mdev/mtty.c > +++ b/samples/vfio-mdev/mtty.c > @@ -1028,9 +1028,9 @@ static int mtty_trigger_interrupt(struct mdev_state *mdev_state) > } > > if (mdev_state->irq_index == VFIO_PCI_MSI_IRQ_INDEX) > - ret = eventfd_signal(mdev_state->msi_evtfd, 1); > + ret = eventfd_signal(mdev_state->msi_evtfd); > else > - ret = eventfd_signal(mdev_state->intx_evtfd, 1); > + ret = eventfd_signal(mdev_state->intx_evtfd); > > #if defined(DEBUG_INTR) > pr_info("Intx triggered\n"); > diff --git a/virt/kvm/eventfd.c b/virt/kvm/eventfd.c > index 89912a17f5d5..c0e230f4c3e9 100644 > --- a/virt/kvm/eventfd.c > +++ b/virt/kvm/eventfd.c > @@ -61,7 +61,7 @@ static void irqfd_resampler_notify(struct kvm_kernel_irqfd_resampler *resampler) > > list_for_each_entry_srcu(irqfd, &resampler->list, resampler_link, > srcu_read_lock_held(&resampler->kvm->irq_srcu)) > - eventfd_signal(irqfd->resamplefd, 1); > + eventfd_signal(irqfd->resamplefd); > } > > /* > @@ -786,7 +786,7 @@ ioeventfd_write(struct kvm_vcpu *vcpu, struct kvm_io_device *this, gpa_t addr, > if (!ioeventfd_in_range(p, addr, len, val)) > return -EOPNOTSUPP; > > - eventfd_signal(p->eventfd, 1); > + eventfd_signal(p->eventfd); > return 0; > } > > > -- > 2.34.1 > For habanalabs (device.c): Reviewed-by: Oded Gabbay <ogabbay@kernel.org> ^ permalink raw reply [flat|nested] 12+ messages in thread
* [Intel-gfx] [PATCH 2/2] eventfd: simplify eventfd_signal_mask() 2023-07-13 10:05 [Intel-gfx] [PATCH 0/2] eventfd: simplify signal helpers Christian Brauner 2023-07-13 10:05 ` [Intel-gfx] [PATCH 1/2] eventfd: simplify eventfd_signal() Christian Brauner @ 2023-07-13 10:05 ` Christian Brauner 2023-07-13 14:33 ` Sean Christopherson 2023-07-13 16:43 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for eventfd: simplify signal helpers Patchwork ` (4 subsequent siblings) 6 siblings, 1 reply; 12+ messages in thread From: Christian Brauner @ 2023-07-13 10:05 UTC (permalink / raw) To: linux-fsdevel Cc: linux-aio, linux-usb, Matthew Rosato, Paul Durrant, Tom Rix, Jason Wang, dri-devel, Michal Hocko, linux-mm, Kirti Wankhede, Paolo Bonzini, Jens Axboe, Vineeth Vijayan, Diana Craciun, Alexander Gordeev, David Airlie, Xuan Zhuo, Shakeel Butt, Vasily Gorbik, Leon Romanovsky, Harald Freudenberger, Fei Li, x86, Roman Gushchin, Halil Pasic, Jason Gunthorpe, Ingo Molnar, intel-gfx, Christian Borntraeger, linux-fpga, Wu Hao, Jason Herne, Eric Farman, Dave Hansen, Andrew Donnellan, Arnd Bergmann, linux-s390, Heiko Carstens, Johannes Weiner, linuxppc-dev, Eric Auger, Borislav Petkov, kvm, Rodrigo Vivi, cgroups, Thomas Gleixner, virtualization, intel-gvt-dev, io-uring, netdev, Tony Krowiak, Christian Brauner, Pavel Begunkov, Sean Christopherson, Oded Gabbay, Muchun Song, Peter Oberparleiter, linux-kernel, linux-rdma, Benjamin LaHaise, Michael S. Tsirkin, Sven Schnelle, Daniel Vetter, Greg Kroah-Hartman, Frederic Barrat, Moritz Fischer, Vitaly Kuznetsov, David Woodhouse, Xu Yilun The eventfd_signal_mask() helper was introduced for io_uring and similar to eventfd_signal() it always passed 1 for @n. So don't bother with that argument at all. Signed-off-by: Christian Brauner <brauner@kernel.org> --- drivers/gpu/drm/i915/gvt/interrupt.c | 2 +- fs/eventfd.c | 9 +++++---- include/linux/eventfd.h | 9 ++++----- io_uring/io_uring.c | 4 ++-- 4 files changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/i915/gvt/interrupt.c b/drivers/gpu/drm/i915/gvt/interrupt.c index 3d9e09c2add4..31aff6f733d4 100644 --- a/drivers/gpu/drm/i915/gvt/interrupt.c +++ b/drivers/gpu/drm/i915/gvt/interrupt.c @@ -435,7 +435,7 @@ static int inject_virtual_interrupt(struct intel_vgpu *vgpu) */ if (!test_bit(INTEL_VGPU_STATUS_ATTACHED, vgpu->status)) return -ESRCH; - if (vgpu->msi_trigger && eventfd_signal(vgpu->msi_trigger) != 1) + if (vgpu->msi_trigger && !eventfd_signal(vgpu->msi_trigger)) return -EFAULT; return 0; } diff --git a/fs/eventfd.c b/fs/eventfd.c index dc9e01053235..077be5da72bd 100644 --- a/fs/eventfd.c +++ b/fs/eventfd.c @@ -43,9 +43,10 @@ struct eventfd_ctx { int id; }; -__u64 eventfd_signal_mask(struct eventfd_ctx *ctx, __u64 n, __poll_t mask) +bool eventfd_signal_mask(struct eventfd_ctx *ctx, __poll_t mask) { unsigned long flags; + __u64 n = 1; /* * Deadlock or stack overflow issues can happen if we recurse here @@ -68,7 +69,7 @@ __u64 eventfd_signal_mask(struct eventfd_ctx *ctx, __u64 n, __poll_t mask) current->in_eventfd = 0; spin_unlock_irqrestore(&ctx->wqh.lock, flags); - return n; + return n == 1; } /** @@ -82,9 +83,9 @@ __u64 eventfd_signal_mask(struct eventfd_ctx *ctx, __u64 n, __poll_t mask) * * Returns the amount by which the counter was incremented. */ -__u64 eventfd_signal(struct eventfd_ctx *ctx) +bool eventfd_signal(struct eventfd_ctx *ctx) { - return eventfd_signal_mask(ctx, 1, 0); + return eventfd_signal_mask(ctx, 0); } EXPORT_SYMBOL_GPL(eventfd_signal); diff --git a/include/linux/eventfd.h b/include/linux/eventfd.h index 562089431551..0155ee25f7c8 100644 --- a/include/linux/eventfd.h +++ b/include/linux/eventfd.h @@ -35,8 +35,8 @@ void eventfd_ctx_put(struct eventfd_ctx *ctx); struct file *eventfd_fget(int fd); struct eventfd_ctx *eventfd_ctx_fdget(int fd); struct eventfd_ctx *eventfd_ctx_fileget(struct file *file); -__u64 eventfd_signal(struct eventfd_ctx *ctx); -__u64 eventfd_signal_mask(struct eventfd_ctx *ctx, __u64 n, __poll_t mask); +bool eventfd_signal(struct eventfd_ctx *ctx); +bool eventfd_signal_mask(struct eventfd_ctx *ctx, __poll_t mask); int eventfd_ctx_remove_wait_queue(struct eventfd_ctx *ctx, wait_queue_entry_t *wait, __u64 *cnt); void eventfd_ctx_do_read(struct eventfd_ctx *ctx, __u64 *cnt); @@ -58,13 +58,12 @@ static inline struct eventfd_ctx *eventfd_ctx_fdget(int fd) return ERR_PTR(-ENOSYS); } -static inline int eventfd_signal(struct eventfd_ctx *ctx) +static inline bool eventfd_signal(struct eventfd_ctx *ctx) { return -ENOSYS; } -static inline int eventfd_signal_mask(struct eventfd_ctx *ctx, __u64 n, - unsigned mask) +static inline bool eventfd_signal_mask(struct eventfd_ctx *ctx, unsigned mask) { return -ENOSYS; } diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c index e8096d502a7c..a9359ef73935 100644 --- a/io_uring/io_uring.c +++ b/io_uring/io_uring.c @@ -537,7 +537,7 @@ static void io_eventfd_ops(struct rcu_head *rcu) int ops = atomic_xchg(&ev_fd->ops, 0); if (ops & BIT(IO_EVENTFD_OP_SIGNAL_BIT)) - eventfd_signal_mask(ev_fd->cq_ev_fd, 1, EPOLL_URING_WAKE); + eventfd_signal_mask(ev_fd->cq_ev_fd, EPOLL_URING_WAKE); /* IO_EVENTFD_OP_FREE_BIT may not be set here depending on callback * ordering in a race but if references are 0 we know we have to free @@ -573,7 +573,7 @@ static void io_eventfd_signal(struct io_ring_ctx *ctx) goto out; if (likely(eventfd_signal_allowed())) { - eventfd_signal_mask(ev_fd->cq_ev_fd, 1, EPOLL_URING_WAKE); + eventfd_signal_mask(ev_fd->cq_ev_fd, EPOLL_URING_WAKE); } else { atomic_inc(&ev_fd->refs); if (!atomic_fetch_or(BIT(IO_EVENTFD_OP_SIGNAL_BIT), &ev_fd->ops)) -- 2.34.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH 2/2] eventfd: simplify eventfd_signal_mask() 2023-07-13 10:05 ` [Intel-gfx] [PATCH 2/2] eventfd: simplify eventfd_signal_mask() Christian Brauner @ 2023-07-13 14:33 ` Sean Christopherson 2023-07-13 14:52 ` Christian Brauner 0 siblings, 1 reply; 12+ messages in thread From: Sean Christopherson @ 2023-07-13 14:33 UTC (permalink / raw) To: Christian Brauner Cc: linux-aio, linux-usb, Matthew Rosato, Paul Durrant, Tom Rix, Jason Wang, dri-devel, Michal Hocko, linux-mm, Kirti Wankhede, Paolo Bonzini, Jens Axboe, Vineeth Vijayan, Diana Craciun, Alexander Gordeev, David Airlie, Xuan Zhuo, Shakeel Butt, Vasily Gorbik, Leon Romanovsky, Harald Freudenberger, Fei Li, x86, Roman Gushchin, Halil Pasic, Jason Gunthorpe, Ingo Molnar, intel-gfx, Christian Borntraeger, linux-fpga, Wu Hao, Jason Herne, Eric Farman, Dave Hansen, Andrew Donnellan, Arnd Bergmann, linux-s390, Heiko Carstens, linuxppc-dev, Frederic Barrat, Moritz Fischer, kvm, Rodrigo Vivi, cgroups, Thomas Gleixner, virtualization, intel-gvt-dev, io-uring, netdev, Tony Krowiak, Pavel Begunkov, Eric Auger, Greg Kroah-Hartman, Oded Gabbay, Muchun Song, Peter Oberparleiter, linux-kernel, linux-rdma, Benjamin LaHaise, Michael S. Tsirkin, Sven Schnelle, Daniel Vetter, Johannes Weiner, linux-fsdevel, Borislav Petkov, Vitaly Kuznetsov, David Woodhouse, Xu Yilun On Thu, Jul 13, 2023, Christian Brauner wrote: > diff --git a/fs/eventfd.c b/fs/eventfd.c > index dc9e01053235..077be5da72bd 100644 > --- a/fs/eventfd.c > +++ b/fs/eventfd.c > @@ -43,9 +43,10 @@ struct eventfd_ctx { > int id; > }; > > -__u64 eventfd_signal_mask(struct eventfd_ctx *ctx, __u64 n, __poll_t mask) > +bool eventfd_signal_mask(struct eventfd_ctx *ctx, __poll_t mask) > { > unsigned long flags; > + __u64 n = 1; > > /* > * Deadlock or stack overflow issues can happen if we recurse here > @@ -68,7 +69,7 @@ __u64 eventfd_signal_mask(struct eventfd_ctx *ctx, __u64 n, __poll_t mask) > current->in_eventfd = 0; > spin_unlock_irqrestore(&ctx->wqh.lock, flags); > > - return n; > + return n == 1; > } ... > @@ -58,13 +58,12 @@ static inline struct eventfd_ctx *eventfd_ctx_fdget(int fd) > return ERR_PTR(-ENOSYS); > } > > -static inline int eventfd_signal(struct eventfd_ctx *ctx) > +static inline bool eventfd_signal(struct eventfd_ctx *ctx) > { > return -ENOSYS; > } > > -static inline int eventfd_signal_mask(struct eventfd_ctx *ctx, __u64 n, > - unsigned mask) > +static inline bool eventfd_signal_mask(struct eventfd_ctx *ctx, unsigned mask) > { > return -ENOSYS; This will morph to "true" for what should be an error case. One option would be to have eventfd_signal_mask() return 0/-errno instead of the count, but looking at all the callers, nothing ever actually consumes the result. KVMGT morphs failure into -EFAULT if (vgpu->msi_trigger && eventfd_signal(vgpu->msi_trigger, 1) != 1) return -EFAULT; but the only caller of that user ignores the return value. if (vgpu_vreg(vgpu, i915_mmio_reg_offset(GEN8_MASTER_IRQ)) & ~GEN8_MASTER_IRQ_CONTROL) inject_virtual_interrupt(vgpu); The sample driver in samples/vfio-mdev/mtty.c uses a similar pattern: prints an error but otherwise ignores the result. So why not return nothing? That will simplify eventfd_signal_mask() a wee bit more, and eliminate that bizarre return value confusion for the ugly stubs, e.g. void eventfd_signal_mask(struct eventfd_ctx *ctx, unsigned mask) { unsigned long flags; /* * Deadlock or stack overflow issues can happen if we recurse here * through waitqueue wakeup handlers. If the caller users potentially * nested waitqueues with custom wakeup handlers, then it should * check eventfd_signal_allowed() before calling this function. If * it returns false, the eventfd_signal() call should be deferred to a * safe context. */ if (WARN_ON_ONCE(current->in_eventfd)) return; spin_lock_irqsave(&ctx->wqh.lock, flags); current->in_eventfd = 1; if (ctx->count < ULLONG_MAX) ctx->count++; if (waitqueue_active(&ctx->wqh)) wake_up_locked_poll(&ctx->wqh, EPOLLIN | mask); current->in_eventfd = 0; spin_unlock_irqrestore(&ctx->wqh.lock, flags); } You could even go further and unify the real and stub versions of eventfd_signal(). ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH 2/2] eventfd: simplify eventfd_signal_mask() 2023-07-13 14:33 ` Sean Christopherson @ 2023-07-13 14:52 ` Christian Brauner 0 siblings, 0 replies; 12+ messages in thread From: Christian Brauner @ 2023-07-13 14:52 UTC (permalink / raw) To: Sean Christopherson Cc: linux-aio, linux-usb, Matthew Rosato, Paul Durrant, Tom Rix, Jason Wang, dri-devel, Michal Hocko, linux-mm, Kirti Wankhede, Paolo Bonzini, Jens Axboe, Vineeth Vijayan, Diana Craciun, Alexander Gordeev, David Airlie, Xuan Zhuo, Shakeel Butt, Vasily Gorbik, Leon Romanovsky, Harald Freudenberger, Fei Li, x86, Roman Gushchin, Halil Pasic, Jason Gunthorpe, Ingo Molnar, intel-gfx, Christian Borntraeger, linux-fpga, Wu Hao, Jason Herne, Eric Farman, Dave Hansen, Andrew Donnellan, Arnd Bergmann, linux-s390, Heiko Carstens, linuxppc-dev, Frederic Barrat, Moritz Fischer, kvm, Rodrigo Vivi, cgroups, Thomas Gleixner, virtualization, intel-gvt-dev, io-uring, netdev, Tony Krowiak, Pavel Begunkov, Eric Auger, Greg Kroah-Hartman, Oded Gabbay, Muchun Song, Peter Oberparleiter, linux-kernel, linux-rdma, Benjamin LaHaise, Michael S. Tsirkin, Sven Schnelle, Daniel Vetter, Johannes Weiner, linux-fsdevel, Borislav Petkov, Vitaly Kuznetsov, David Woodhouse, Xu Yilun On Thu, Jul 13, 2023 at 07:33:05AM -0700, Sean Christopherson wrote: > On Thu, Jul 13, 2023, Christian Brauner wrote: > > diff --git a/fs/eventfd.c b/fs/eventfd.c > > index dc9e01053235..077be5da72bd 100644 > > --- a/fs/eventfd.c > > +++ b/fs/eventfd.c > > @@ -43,9 +43,10 @@ struct eventfd_ctx { > > int id; > > }; > > > > -__u64 eventfd_signal_mask(struct eventfd_ctx *ctx, __u64 n, __poll_t mask) > > +bool eventfd_signal_mask(struct eventfd_ctx *ctx, __poll_t mask) > > { > > unsigned long flags; > > + __u64 n = 1; > > > > /* > > * Deadlock or stack overflow issues can happen if we recurse here > > @@ -68,7 +69,7 @@ __u64 eventfd_signal_mask(struct eventfd_ctx *ctx, __u64 n, __poll_t mask) > > current->in_eventfd = 0; > > spin_unlock_irqrestore(&ctx->wqh.lock, flags); > > > > - return n; > > + return n == 1; > > } > > ... > > > @@ -58,13 +58,12 @@ static inline struct eventfd_ctx *eventfd_ctx_fdget(int fd) > > return ERR_PTR(-ENOSYS); > > } > > > > -static inline int eventfd_signal(struct eventfd_ctx *ctx) > > +static inline bool eventfd_signal(struct eventfd_ctx *ctx) > > { > > return -ENOSYS; > > } > > > > -static inline int eventfd_signal_mask(struct eventfd_ctx *ctx, __u64 n, > > - unsigned mask) > > +static inline bool eventfd_signal_mask(struct eventfd_ctx *ctx, unsigned mask) > > { > > return -ENOSYS; > > This will morph to "true" for what should be an error case. One option would be Ewww, that means it did return -ENOSYS before any of this. > to have eventfd_signal_mask() return 0/-errno instead of the count, but looking > at all the callers, nothing ever actually consumes the result. > > KVMGT morphs failure into -EFAULT > > if (vgpu->msi_trigger && eventfd_signal(vgpu->msi_trigger, 1) != 1) > return -EFAULT; > > but the only caller of that user ignores the return value. > > if (vgpu_vreg(vgpu, i915_mmio_reg_offset(GEN8_MASTER_IRQ)) > & ~GEN8_MASTER_IRQ_CONTROL) > inject_virtual_interrupt(vgpu); > > The sample driver in samples/vfio-mdev/mtty.c uses a similar pattern: prints an > error but otherwise ignores the result. > > So why not return nothing? That will simplify eventfd_signal_mask() a wee bit > more, and eliminate that bizarre return value confusion for the ugly stubs, e.g. Yeah, it used to return an int in the non-eventfd and a __u64 in the eventfd case. > > void eventfd_signal_mask(struct eventfd_ctx *ctx, unsigned mask) > { > unsigned long flags; > > /* > * Deadlock or stack overflow issues can happen if we recurse here > * through waitqueue wakeup handlers. If the caller users potentially > * nested waitqueues with custom wakeup handlers, then it should > * check eventfd_signal_allowed() before calling this function. If > * it returns false, the eventfd_signal() call should be deferred to a > * safe context. > */ > if (WARN_ON_ONCE(current->in_eventfd)) > return; > > spin_lock_irqsave(&ctx->wqh.lock, flags); > current->in_eventfd = 1; > if (ctx->count < ULLONG_MAX) > ctx->count++; > if (waitqueue_active(&ctx->wqh)) > wake_up_locked_poll(&ctx->wqh, EPOLLIN | mask); > current->in_eventfd = 0; > spin_unlock_irqrestore(&ctx->wqh.lock, flags); > } > > You could even go further and unify the real and stub versions of eventfd_signal(). The reason I didn't make eventfd_signal_mask() return void was that it was called from eventfd_signal() which did, I didn't realize the caller didn't actually consume the return value. If we can let both return void it gets simpler. Thanks for that. ^ permalink raw reply [flat|nested] 12+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for eventfd: simplify signal helpers 2023-07-13 10:05 [Intel-gfx] [PATCH 0/2] eventfd: simplify signal helpers Christian Brauner 2023-07-13 10:05 ` [Intel-gfx] [PATCH 1/2] eventfd: simplify eventfd_signal() Christian Brauner 2023-07-13 10:05 ` [Intel-gfx] [PATCH 2/2] eventfd: simplify eventfd_signal_mask() Christian Brauner @ 2023-07-13 16:43 ` Patchwork 2023-07-13 16:43 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork ` (3 subsequent siblings) 6 siblings, 0 replies; 12+ messages in thread From: Patchwork @ 2023-07-13 16:43 UTC (permalink / raw) To: Christian Brauner; +Cc: intel-gfx == Series Details == Series: eventfd: simplify signal helpers URL : https://patchwork.freedesktop.org/series/120668/ State : warning == Summary == Error: dim checkpatch failed aae8a1d97489 eventfd: simplify eventfd_signal() -:436: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 32) #436: FILE: drivers/vhost/vhost.h:251: if ((vq)->error_ctx) \ + eventfd_signal((vq)->error_ctx);\ total: 0 errors, 1 warnings, 0 checks, 439 lines checked 6b3c28be92b7 eventfd: simplify eventfd_signal_mask() -:89: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #89: FILE: include/linux/eventfd.h:66: +static inline bool eventfd_signal_mask(struct eventfd_ctx *ctx, unsigned mask) total: 0 errors, 1 warnings, 0 checks, 79 lines checked ^ permalink raw reply [flat|nested] 12+ messages in thread
* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for eventfd: simplify signal helpers 2023-07-13 10:05 [Intel-gfx] [PATCH 0/2] eventfd: simplify signal helpers Christian Brauner ` (2 preceding siblings ...) 2023-07-13 16:43 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for eventfd: simplify signal helpers Patchwork @ 2023-07-13 16:43 ` Patchwork 2023-07-13 16:57 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork ` (2 subsequent siblings) 6 siblings, 0 replies; 12+ messages in thread From: Patchwork @ 2023-07-13 16:43 UTC (permalink / raw) To: Christian Brauner; +Cc: intel-gfx == Series Details == Series: eventfd: simplify signal helpers URL : https://patchwork.freedesktop.org/series/120668/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. ^ permalink raw reply [flat|nested] 12+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for eventfd: simplify signal helpers 2023-07-13 10:05 [Intel-gfx] [PATCH 0/2] eventfd: simplify signal helpers Christian Brauner ` (3 preceding siblings ...) 2023-07-13 16:43 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork @ 2023-07-13 16:57 ` Patchwork 2023-07-13 17:10 ` [Intel-gfx] [PATCH 0/2] " Alex Williamson 2023-07-13 21:43 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork 6 siblings, 0 replies; 12+ messages in thread From: Patchwork @ 2023-07-13 16:57 UTC (permalink / raw) To: Christian Brauner; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 7792 bytes --] == Series Details == Series: eventfd: simplify signal helpers URL : https://patchwork.freedesktop.org/series/120668/ State : success == Summary == CI Bug Log - changes from CI_DRM_13383 -> Patchwork_120668v1 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/index.html Participating hosts (42 -> 41) ------------------------------ Missing (1): fi-snb-2520m Known issues ------------ Here are the changes found in Patchwork_120668v1 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@core_auth@basic-auth: - bat-adlp-11: NOTRUN -> [ABORT][1] ([i915#4423] / [i915#8011]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/bat-adlp-11/igt@core_auth@basic-auth.html * igt@i915_pm_rpm@basic-pci-d3-state: - fi-cfl-8700k: [PASS][2] -> [FAIL][3] ([i915#7940]) [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13383/fi-cfl-8700k/igt@i915_pm_rpm@basic-pci-d3-state.html [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/fi-cfl-8700k/igt@i915_pm_rpm@basic-pci-d3-state.html * igt@i915_pm_rpm@basic-rte: - fi-kbl-x1275: [PASS][4] -> [FAIL][5] ([i915#8843]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13383/fi-kbl-x1275/igt@i915_pm_rpm@basic-rte.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/fi-kbl-x1275/igt@i915_pm_rpm@basic-rte.html - bat-adlp-9: [PASS][6] -> [ABORT][7] ([i915#7977] / [i915#8668]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13383/bat-adlp-9/igt@i915_pm_rpm@basic-rte.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/bat-adlp-9/igt@i915_pm_rpm@basic-rte.html * igt@i915_selftest@live@requests: - bat-mtlp-6: [PASS][8] -> [DMESG-FAIL][9] ([i915#7269]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13383/bat-mtlp-6/igt@i915_selftest@live@requests.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/bat-mtlp-6/igt@i915_selftest@live@requests.html * igt@i915_selftest@live@reset: - bat-rpls-1: [PASS][10] -> [ABORT][11] ([i915#4983] / [i915#7461] / [i915#8347] / [i915#8384]) [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13383/bat-rpls-1/igt@i915_selftest@live@reset.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/bat-rpls-1/igt@i915_selftest@live@reset.html - bat-rpls-2: [PASS][12] -> [ABORT][13] ([i915#4983] / [i915#7461] / [i915#7913] / [i915#8347]) [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13383/bat-rpls-2/igt@i915_selftest@live@reset.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/bat-rpls-2/igt@i915_selftest@live@reset.html * igt@kms_chamelium_hpd@common-hpd-after-suspend: - bat-adlm-1: NOTRUN -> [SKIP][14] ([i915#7828]) [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/bat-adlm-1/igt@kms_chamelium_hpd@common-hpd-after-suspend.html * igt@kms_pipe_crc_basic@suspend-read-crc: - bat-adlm-1: NOTRUN -> [SKIP][15] ([i915#1845]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/bat-adlm-1/igt@kms_pipe_crc_basic@suspend-read-crc.html #### Possible fixes #### * igt@i915_pm_rpm@module-reload: - fi-skl-guc: [FAIL][16] ([i915#7940]) -> [PASS][17] [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13383/fi-skl-guc/igt@i915_pm_rpm@module-reload.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/fi-skl-guc/igt@i915_pm_rpm@module-reload.html * igt@i915_selftest@live@execlists: - fi-kbl-soraka: [INCOMPLETE][18] ([i915#7156] / [i915#7913]) -> [PASS][19] [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13383/fi-kbl-soraka/igt@i915_selftest@live@execlists.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/fi-kbl-soraka/igt@i915_selftest@live@execlists.html * igt@i915_selftest@live@gt_mocs: - bat-mtlp-6: [DMESG-FAIL][20] ([i915#7059]) -> [PASS][21] [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13383/bat-mtlp-6/igt@i915_selftest@live@gt_mocs.html [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/bat-mtlp-6/igt@i915_selftest@live@gt_mocs.html * igt@i915_selftest@live@migrate: - bat-atsm-1: [DMESG-FAIL][22] ([i915#7699] / [i915#7913]) -> [PASS][23] [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13383/bat-atsm-1/igt@i915_selftest@live@migrate.html [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/bat-atsm-1/igt@i915_selftest@live@migrate.html * igt@i915_selftest@live@workarounds: - bat-adlm-1: [INCOMPLETE][24] ([i915#4983] / [i915#7677]) -> [PASS][25] [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13383/bat-adlm-1/igt@i915_selftest@live@workarounds.html [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/bat-adlm-1/igt@i915_selftest@live@workarounds.html #### Warnings #### * igt@i915_module_load@load: - bat-adlp-11: [ABORT][26] ([i915#4423]) -> [DMESG-WARN][27] ([i915#4423]) [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13383/bat-adlp-11/igt@i915_module_load@load.html [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/bat-adlp-11/igt@i915_module_load@load.html * igt@kms_psr@primary_page_flip: - bat-rplp-1: [SKIP][28] ([i915#1072]) -> [ABORT][29] ([i915#8860]) [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13383/bat-rplp-1/igt@kms_psr@primary_page_flip.html [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/bat-rplp-1/igt@kms_psr@primary_page_flip.html [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072 [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845 [i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423 [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983 [i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059 [i915#7156]: https://gitlab.freedesktop.org/drm/intel/issues/7156 [i915#7269]: https://gitlab.freedesktop.org/drm/intel/issues/7269 [i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461 [i915#7677]: https://gitlab.freedesktop.org/drm/intel/issues/7677 [i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699 [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828 [i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913 [i915#7940]: https://gitlab.freedesktop.org/drm/intel/issues/7940 [i915#7977]: https://gitlab.freedesktop.org/drm/intel/issues/7977 [i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011 [i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347 [i915#8384]: https://gitlab.freedesktop.org/drm/intel/issues/8384 [i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668 [i915#8843]: https://gitlab.freedesktop.org/drm/intel/issues/8843 [i915#8860]: https://gitlab.freedesktop.org/drm/intel/issues/8860 Build changes ------------- * Linux: CI_DRM_13383 -> Patchwork_120668v1 CI-20190529: 20190529 CI_DRM_13383: d08a48cfbc24191eb55119f6931e0b3aad5ca673 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_7386: 54dc25efaf10d87962f95be9b1d1a8f0f907912b @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_120668v1: d08a48cfbc24191eb55119f6931e0b3aad5ca673 @ git://anongit.freedesktop.org/gfx-ci/linux ### Linux commits bfd70b00ef5b eventfd: simplify eventfd_signal_mask() 01379f104ffe eventfd: simplify eventfd_signal() == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/index.html [-- Attachment #2: Type: text/html, Size: 9367 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH 0/2] eventfd: simplify signal helpers 2023-07-13 10:05 [Intel-gfx] [PATCH 0/2] eventfd: simplify signal helpers Christian Brauner ` (4 preceding siblings ...) 2023-07-13 16:57 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork @ 2023-07-13 17:10 ` Alex Williamson 2023-07-13 21:43 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork 6 siblings, 0 replies; 12+ messages in thread From: Alex Williamson @ 2023-07-13 17:10 UTC (permalink / raw) To: Christian Brauner Cc: linux-aio, Muchun Song, Tony Krowiak, Matthew Rosato, Paul Durrant, Tom Rix, Jason Wang, Roman Gushchin, dri-devel, Michal Hocko, Heiko Carstens, linux-mm, Kirti Wankhede, Vineeth Vijayan, Diana Craciun, Borislav Petkov, Alexander Gordeev, Fei Li, Xuan Zhuo, Arnd Bergmann, Leon Romanovsky, jaz, linux-rdma, x86, Halil Pasic, Jason Gunthorpe, Ingo Molnar, Moritz Fischer, Frederic Barrat, Xu Yilun, Christian Borntraeger, linux-fpga, Wu Hao, Jason Herne, Eric Farman, Dave Hansen, Andrew Donnellan, Vasily Gorbik, linux-s390, Greg Kroah-Hartman, intel-gfx, Sean Christopherson, Eric Auger, Rodrigo Vivi, Harald Freudenberger, kvm, Paolo Bonzini, cgroups, Thomas Gleixner, virtualization, intel-gvt-dev, io-uring, Jens Axboe, netdev, Oded Gabbay, linux-usb, Peter Oberparleiter, linux-kernel, Benjamin LaHaise, Michael S. Tsirkin, Sven Schnelle, Johannes Weiner, linux-fsdevel, Shakeel Butt, Vitaly Kuznetsov, David Woodhouse, linuxppc-dev, Pavel Begunkov On Thu, 13 Jul 2023 12:05:36 +0200 Christian Brauner <brauner@kernel.org> wrote: > Hey everyone, > > This simplifies the eventfd_signal() and eventfd_signal_mask() helpers > by removing the count argument which is effectively unused. We have a patch under review which does in fact make use of the signaling value: https://lore.kernel.org/all/20230630155936.3015595-1-jaz@semihalf.com/ Thanks, Alex ^ permalink raw reply [flat|nested] 12+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for eventfd: simplify signal helpers 2023-07-13 10:05 [Intel-gfx] [PATCH 0/2] eventfd: simplify signal helpers Christian Brauner ` (5 preceding siblings ...) 2023-07-13 17:10 ` [Intel-gfx] [PATCH 0/2] " Alex Williamson @ 2023-07-13 21:43 ` Patchwork 6 siblings, 0 replies; 12+ messages in thread From: Patchwork @ 2023-07-13 21:43 UTC (permalink / raw) To: Christian Brauner; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 33013 bytes --] == Series Details == Series: eventfd: simplify signal helpers URL : https://patchwork.freedesktop.org/series/120668/ State : success == Summary == CI Bug Log - changes from CI_DRM_13383_full -> Patchwork_120668v1_full ==================================================== Summary ------- **SUCCESS** No regressions found. Participating hosts (10 -> 10) ------------------------------ No changes in participating hosts New tests --------- New tests have been introduced between CI_DRM_13383_full and Patchwork_120668v1_full: ### New IGT tests (1) ### * igt@kms_invalid_mode@bad-htotal@hdmi-a-2-pipe-d: - Statuses : 1 pass(s) - Exec time: [0.0] s Known issues ------------ Here are the changes found in Patchwork_120668v1_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@drm_fdinfo@busy-hang@bcs0: - shard-dg2: NOTRUN -> [SKIP][1] ([i915#8414]) +9 similar issues [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-dg2-11/igt@drm_fdinfo@busy-hang@bcs0.html * igt@drm_fdinfo@most-busy-idle-check-all@rcs0: - shard-rkl: [PASS][2] -> [FAIL][3] ([i915#7742]) [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13383/shard-rkl-7/igt@drm_fdinfo@most-busy-idle-check-all@rcs0.html [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-rkl-1/igt@drm_fdinfo@most-busy-idle-check-all@rcs0.html * igt@gem_basic@multigpu-create-close: - shard-dg2: NOTRUN -> [SKIP][4] ([i915#7697]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-dg2-11/igt@gem_basic@multigpu-create-close.html * igt@gem_caching@writes: - shard-mtlp: NOTRUN -> [SKIP][5] ([i915#4873]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-mtlp-4/igt@gem_caching@writes.html * igt@gem_exec_balancer@bonded-sync: - shard-dg2: NOTRUN -> [SKIP][6] ([i915#4771]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-dg2-11/igt@gem_exec_balancer@bonded-sync.html * igt@gem_exec_fair@basic-pace-share@rcs0: - shard-tglu: [PASS][7] -> [FAIL][8] ([i915#2842]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13383/shard-tglu-6/igt@gem_exec_fair@basic-pace-share@rcs0.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-tglu-7/igt@gem_exec_fair@basic-pace-share@rcs0.html * igt@gem_exec_fair@basic-pace@vecs0: - shard-rkl: [PASS][9] -> [FAIL][10] ([i915#2842]) +2 similar issues [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13383/shard-rkl-6/igt@gem_exec_fair@basic-pace@vecs0.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-rkl-2/igt@gem_exec_fair@basic-pace@vecs0.html * igt@gem_exec_flush@basic-uc-set-default: - shard-dg2: NOTRUN -> [SKIP][11] ([i915#3539]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-dg2-11/igt@gem_exec_flush@basic-uc-set-default.html * igt@gem_exec_reloc@basic-gtt-read: - shard-dg2: NOTRUN -> [SKIP][12] ([i915#3281]) +1 similar issue [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-dg2-11/igt@gem_exec_reloc@basic-gtt-read.html * igt@gem_exec_schedule@pi-ringfull@ccs0: - shard-mtlp: [PASS][13] -> [DMESG-WARN][14] ([i915#1982]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13383/shard-mtlp-7/igt@gem_exec_schedule@pi-ringfull@ccs0.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-mtlp-6/igt@gem_exec_schedule@pi-ringfull@ccs0.html * igt@gem_exec_whisper@basic-contexts-priority-all: - shard-mtlp: [PASS][15] -> [ABORT][16] ([i915#8131]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13383/shard-mtlp-5/igt@gem_exec_whisper@basic-contexts-priority-all.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-mtlp-8/igt@gem_exec_whisper@basic-contexts-priority-all.html * igt@gem_media_vme: - shard-dg2: NOTRUN -> [SKIP][17] ([i915#284]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-dg2-11/igt@gem_media_vme.html * igt@gem_mmap_wc@close: - shard-dg2: NOTRUN -> [SKIP][18] ([i915#4083]) +3 similar issues [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-dg2-11/igt@gem_mmap_wc@close.html * igt@gem_pxp@reject-modify-context-protection-off-1: - shard-dg2: NOTRUN -> [SKIP][19] ([i915#4270]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-dg2-11/igt@gem_pxp@reject-modify-context-protection-off-1.html * igt@gem_userptr_blits@coherency-unsync: - shard-dg2: NOTRUN -> [SKIP][20] ([i915#3297]) [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-dg2-11/igt@gem_userptr_blits@coherency-unsync.html * igt@gem_userptr_blits@forbidden-operations: - shard-dg2: NOTRUN -> [SKIP][21] ([i915#3282]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-dg2-11/igt@gem_userptr_blits@forbidden-operations.html * igt@gem_userptr_blits@map-fixed-invalidate-overlap: - shard-dg2: NOTRUN -> [SKIP][22] ([i915#3297] / [i915#4880]) [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-dg2-11/igt@gem_userptr_blits@map-fixed-invalidate-overlap.html * igt@gen9_exec_parse@unaligned-jump: - shard-dg2: NOTRUN -> [SKIP][23] ([i915#2856]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-dg2-11/igt@gen9_exec_parse@unaligned-jump.html * igt@i915_pm_rpm@cursor-dpms: - shard-tglu: [PASS][24] -> [FAIL][25] ([i915#7940]) +1 similar issue [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13383/shard-tglu-7/igt@i915_pm_rpm@cursor-dpms.html [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-tglu-4/igt@i915_pm_rpm@cursor-dpms.html * igt@i915_pm_rpm@modeset-lpsp-stress: - shard-dg2: [PASS][26] -> [SKIP][27] ([i915#1397]) [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13383/shard-dg2-12/igt@i915_pm_rpm@modeset-lpsp-stress.html [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-dg2-2/igt@i915_pm_rpm@modeset-lpsp-stress.html * igt@i915_pm_rpm@modeset-non-lpsp: - shard-rkl: [PASS][28] -> [SKIP][29] ([i915#1397]) +1 similar issue [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13383/shard-rkl-2/igt@i915_pm_rpm@modeset-non-lpsp.html [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-rkl-7/igt@i915_pm_rpm@modeset-non-lpsp.html * igt@i915_selftest@live@gt_mocs: - shard-mtlp: [PASS][30] -> [DMESG-FAIL][31] ([i915#7059]) [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13383/shard-mtlp-2/igt@i915_selftest@live@gt_mocs.html [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-mtlp-6/igt@i915_selftest@live@gt_mocs.html * igt@i915_selftest@live@requests: - shard-mtlp: [PASS][32] -> [DMESG-FAIL][33] ([i915#8497]) [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13383/shard-mtlp-2/igt@i915_selftest@live@requests.html [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-mtlp-6/igt@i915_selftest@live@requests.html * igt@kms_addfb_basic@tile-pitch-mismatch: - shard-dg2: NOTRUN -> [SKIP][34] ([i915#4212]) [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-dg2-11/igt@kms_addfb_basic@tile-pitch-mismatch.html * igt@kms_async_flips@crc@pipe-a-hdmi-a-2: - shard-rkl: NOTRUN -> [FAIL][35] ([i915#8247]) +1 similar issue [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-rkl-4/igt@kms_async_flips@crc@pipe-a-hdmi-a-2.html * igt@kms_big_fb@4-tiled-64bpp-rotate-180: - shard-mtlp: [PASS][36] -> [FAIL][37] ([i915#5138]) [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13383/shard-mtlp-1/igt@kms_big_fb@4-tiled-64bpp-rotate-180.html [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-mtlp-3/igt@kms_big_fb@4-tiled-64bpp-rotate-180.html * igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-async-flip: - shard-mtlp: [PASS][38] -> [FAIL][39] ([i915#3743]) [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13383/shard-mtlp-1/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-mtlp-7/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html * igt@kms_big_fb@y-tiled-8bpp-rotate-180: - shard-dg2: NOTRUN -> [SKIP][40] ([i915#5190]) +1 similar issue [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-dg2-11/igt@kms_big_fb@y-tiled-8bpp-rotate-180.html * igt@kms_big_fb@yf-tiled-64bpp-rotate-180: - shard-dg2: NOTRUN -> [SKIP][41] ([i915#4538] / [i915#5190]) +1 similar issue [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-dg2-11/igt@kms_big_fb@yf-tiled-64bpp-rotate-180.html * igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_rc_ccs_cc: - shard-mtlp: NOTRUN -> [SKIP][42] ([i915#3886] / [i915#6095]) +2 similar issues [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-mtlp-4/igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_rc_ccs_cc.html * igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_ccs: - shard-dg2: NOTRUN -> [SKIP][43] ([i915#3689] / [i915#5354]) +8 similar issues [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-dg2-11/igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_ccs.html * igt@kms_ccs@pipe-d-ccs-on-another-bo-y_tiled_gen12_rc_ccs: - shard-mtlp: NOTRUN -> [SKIP][44] ([i915#6095]) +1 similar issue [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-mtlp-4/igt@kms_ccs@pipe-d-ccs-on-another-bo-y_tiled_gen12_rc_ccs.html * igt@kms_cdclk@plane-scaling@pipe-c-hdmi-a-3: - shard-dg2: NOTRUN -> [SKIP][45] ([i915#4087]) +3 similar issues [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-dg2-6/igt@kms_cdclk@plane-scaling@pipe-c-hdmi-a-3.html * igt@kms_chamelium_edid@dp-edid-change-during-suspend: - shard-dg2: NOTRUN -> [SKIP][46] ([i915#7828]) +2 similar issues [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-dg2-11/igt@kms_chamelium_edid@dp-edid-change-during-suspend.html * igt@kms_chamelium_hpd@vga-hpd-without-ddc: - shard-mtlp: NOTRUN -> [SKIP][47] ([i915#7828]) [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-mtlp-4/igt@kms_chamelium_hpd@vga-hpd-without-ddc.html * igt@kms_color@deep-color: - shard-rkl: NOTRUN -> [SKIP][48] ([i915#3555]) [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-rkl-2/igt@kms_color@deep-color.html * igt@kms_content_protection@atomic-dpms: - shard-dg2: NOTRUN -> [SKIP][49] ([i915#7118]) [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-dg2-10/igt@kms_content_protection@atomic-dpms.html * igt@kms_cursor_crc@cursor-offscreen-max-size: - shard-dg2: NOTRUN -> [SKIP][50] ([i915#3555]) +1 similar issue [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-dg2-11/igt@kms_cursor_crc@cursor-offscreen-max-size.html * igt@kms_cursor_legacy@cursorb-vs-flipa-atomic-transitions-varying-size: - shard-dg2: NOTRUN -> [SKIP][51] ([fdo#109274] / [i915#5354]) [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-dg2-11/igt@kms_cursor_legacy@cursorb-vs-flipa-atomic-transitions-varying-size.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions: - shard-glk: [PASS][52] -> [FAIL][53] ([i915#2346]) [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13383/shard-glk8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-glk2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html * igt@kms_dsc@dsc-basic: - shard-dg2: NOTRUN -> [SKIP][54] ([i915#3555] / [i915#3840]) [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-dg2-11/igt@kms_dsc@dsc-basic.html * igt@kms_fbcon_fbt@psr-suspend: - shard-dg2: NOTRUN -> [SKIP][55] ([i915#3469]) [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-dg2-11/igt@kms_fbcon_fbt@psr-suspend.html * igt@kms_flip@flip-vs-suspend-interruptible@a-hdmi-a3: - shard-dg2: [PASS][56] -> [FAIL][57] ([fdo#103375]) +2 similar issues [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13383/shard-dg2-7/igt@kms_flip@flip-vs-suspend-interruptible@a-hdmi-a3.html [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-dg2-5/igt@kms_flip@flip-vs-suspend-interruptible@a-hdmi-a3.html * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-gtt: - shard-mtlp: NOTRUN -> [SKIP][58] ([i915#8708]) [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-mtlp-2/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-gtt.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-pwrite: - shard-dg2: NOTRUN -> [SKIP][59] ([i915#3458]) +2 similar issues [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-dg2-11/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-pwrite.html * igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-pwrite: - shard-dg2: NOTRUN -> [SKIP][60] ([i915#5354]) +7 similar issues [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-dg2-11/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-pwrite.html * igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-mmap-gtt: - shard-dg2: NOTRUN -> [SKIP][61] ([i915#8708]) +3 similar issues [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-dg2-11/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-mmap-gtt.html * igt@kms_frontbuffer_tracking@psr-2p-primscrn-shrfb-plflip-blt: - shard-mtlp: NOTRUN -> [SKIP][62] ([i915#1825]) +3 similar issues [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-mtlp-4/igt@kms_frontbuffer_tracking@psr-2p-primscrn-shrfb-plflip-blt.html * igt@kms_hdr@bpc-switch-dpms: - shard-dg2: NOTRUN -> [SKIP][63] ([i915#3555] / [i915#8228]) [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-dg2-10/igt@kms_hdr@bpc-switch-dpms.html * igt@kms_pipe_b_c_ivb@disable-pipe-b-enable-pipe-c: - shard-dg2: NOTRUN -> [SKIP][64] ([fdo#109289]) [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-dg2-11/igt@kms_pipe_b_c_ivb@disable-pipe-b-enable-pipe-c.html * igt@kms_plane_scaling@2x-scaler-multi-pipe: - shard-mtlp: NOTRUN -> [SKIP][65] ([i915#3546]) [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-mtlp-4/igt@kms_plane_scaling@2x-scaler-multi-pipe.html * igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-d-dp-4: - shard-dg2: NOTRUN -> [SKIP][66] ([i915#5176]) +11 similar issues [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-dg2-11/igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-d-dp-4.html * igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-25@pipe-b-hdmi-a-1: - shard-rkl: NOTRUN -> [SKIP][67] ([i915#5176]) +3 similar issues [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-rkl-7/igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-25@pipe-b-hdmi-a-1.html * igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-rotation@pipe-b-hdmi-a-1: - shard-snb: NOTRUN -> [SKIP][68] ([fdo#109271]) +19 similar issues [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-snb1/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-rotation@pipe-b-hdmi-a-1.html * igt@kms_plane_scaling@planes-downscale-factor-0-25@pipe-d-hdmi-a-2: - shard-dg2: NOTRUN -> [SKIP][69] ([i915#5235]) +19 similar issues [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-dg2-2/igt@kms_plane_scaling@planes-downscale-factor-0-25@pipe-d-hdmi-a-2.html * igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-b-hdmi-a-2: - shard-rkl: NOTRUN -> [SKIP][70] ([i915#5235]) +7 similar issues [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-rkl-1/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-b-hdmi-a-2.html * igt@kms_psr@psr2_dpms: - shard-dg2: NOTRUN -> [SKIP][71] ([i915#1072]) +1 similar issue [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-dg2-11/igt@kms_psr@psr2_dpms.html * igt@prime_udl: - shard-dg2: NOTRUN -> [SKIP][72] ([fdo#109291]) [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-dg2-11/igt@prime_udl.html * igt@tools_test@sysfs_l3_parity: - shard-dg2: NOTRUN -> [SKIP][73] ([i915#4818]) [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-dg2-11/igt@tools_test@sysfs_l3_parity.html * igt@v3d/v3d_submit_cl@bad-bo: - shard-dg2: NOTRUN -> [SKIP][74] ([i915#2575]) +2 similar issues [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-dg2-11/igt@v3d/v3d_submit_cl@bad-bo.html * igt@vc4/vc4_purgeable_bo@mark-willneed: - shard-dg2: NOTRUN -> [SKIP][75] ([i915#7711]) +1 similar issue [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-dg2-11/igt@vc4/vc4_purgeable_bo@mark-willneed.html #### Possible fixes #### * igt@gem_create@hog-create@smem0: - shard-dg2: [FAIL][76] ([i915#5892] / [i915#8758]) -> [PASS][77] [76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13383/shard-dg2-12/igt@gem_create@hog-create@smem0.html [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-dg2-2/igt@gem_create@hog-create@smem0.html * igt@gem_exec_fair@basic-none@bcs0: - shard-rkl: [FAIL][78] ([i915#2842]) -> [PASS][79] +1 similar issue [78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13383/shard-rkl-7/igt@gem_exec_fair@basic-none@bcs0.html [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-rkl-4/igt@gem_exec_fair@basic-none@bcs0.html * igt@gem_exec_whisper@basic-contexts-forked-all: - shard-mtlp: [TIMEOUT][80] ([i915#8628]) -> [PASS][81] [80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13383/shard-mtlp-3/igt@gem_exec_whisper@basic-contexts-forked-all.html [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-mtlp-5/igt@gem_exec_whisper@basic-contexts-forked-all.html * igt@gem_lmem_swapping@smem-oom@lmem0: - shard-dg2: [TIMEOUT][82] ([i915#5493]) -> [PASS][83] [82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13383/shard-dg2-1/igt@gem_lmem_swapping@smem-oom@lmem0.html [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-dg2-8/igt@gem_lmem_swapping@smem-oom@lmem0.html * igt@i915_module_load@reload-with-fault-injection: - shard-dg2: [DMESG-WARN][84] ([i915#7061]) -> [PASS][85] [84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13383/shard-dg2-8/igt@i915_module_load@reload-with-fault-injection.html [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-dg2-1/igt@i915_module_load@reload-with-fault-injection.html * igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a: - {shard-dg1}: [SKIP][86] ([i915#1937]) -> [PASS][87] [86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13383/shard-dg1-16/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-dg1-19/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html * igt@i915_pm_rc6_residency@rc6-idle@vecs0: - {shard-dg1}: [FAIL][88] ([i915#3591]) -> [PASS][89] [88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13383/shard-dg1-15/igt@i915_pm_rc6_residency@rc6-idle@vecs0.html [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-dg1-15/igt@i915_pm_rc6_residency@rc6-idle@vecs0.html * igt@i915_pm_rpm@dpms-mode-unset-non-lpsp: - shard-dg2: [SKIP][90] ([i915#1397]) -> [PASS][91] +3 similar issues [90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13383/shard-dg2-12/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-dg2-2/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html * igt@i915_pm_rpm@dpms-non-lpsp: - shard-rkl: [SKIP][92] ([i915#1397]) -> [PASS][93] +2 similar issues [92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13383/shard-rkl-7/igt@i915_pm_rpm@dpms-non-lpsp.html [93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-rkl-2/igt@i915_pm_rpm@dpms-non-lpsp.html * igt@i915_pm_rpm@gem-execbuf-stress@smem0: - {shard-dg1}: [FAIL][94] ([i915#7940]) -> [PASS][95] [94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13383/shard-dg1-14/igt@i915_pm_rpm@gem-execbuf-stress@smem0.html [95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-dg1-12/igt@i915_pm_rpm@gem-execbuf-stress@smem0.html * igt@i915_pm_rpm@gem-execbuf@smem0: - shard-tglu: [FAIL][96] ([i915#7940]) -> [PASS][97] [96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13383/shard-tglu-4/igt@i915_pm_rpm@gem-execbuf@smem0.html [97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-tglu-9/igt@i915_pm_rpm@gem-execbuf@smem0.html * igt@kms_async_flips@alternate-sync-async-flip@pipe-a-edp-1: - shard-mtlp: [FAIL][98] ([i915#2521]) -> [PASS][99] [98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13383/shard-mtlp-5/igt@kms_async_flips@alternate-sync-async-flip@pipe-a-edp-1.html [99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-mtlp-8/igt@kms_async_flips@alternate-sync-async-flip@pipe-a-edp-1.html * igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip: - shard-mtlp: [FAIL][100] ([i915#3743]) -> [PASS][101] +2 similar issues [100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13383/shard-mtlp-6/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html [101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-mtlp-7/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html * igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip: - shard-mtlp: [FAIL][102] ([i915#5138]) -> [PASS][103] +1 similar issue [102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13383/shard-mtlp-4/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip.html [103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-mtlp-8/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size: - shard-apl: [FAIL][104] ([i915#2346]) -> [PASS][105] [104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13383/shard-apl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html [105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-apl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2: - shard-glk: [FAIL][106] ([i915#79]) -> [PASS][107] [106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13383/shard-glk8/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2.html [107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-glk9/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2.html * igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend: - shard-dg2: [FAIL][108] ([fdo#103375]) -> [PASS][109] +1 similar issue [108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13383/shard-dg2-5/igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend.html [109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-dg2-3/igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend.html #### Warnings #### * igt@device_reset@unbind-reset-rebind: - shard-dg2: [ABORT][110] ([i915#5507] / [i915#7461] / [i915#8260]) -> [ABORT][111] ([i915#5507] / [i915#8260]) [110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13383/shard-dg2-3/igt@device_reset@unbind-reset-rebind.html [111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-dg2-11/igt@device_reset@unbind-reset-rebind.html * igt@i915_suspend@fence-restore-untiled: - shard-snb: [DMESG-FAIL][112] ([fdo#103375]) -> [DMESG-WARN][113] ([i915#8841]) [112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13383/shard-snb7/igt@i915_suspend@fence-restore-untiled.html [113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-snb6/igt@i915_suspend@fence-restore-untiled.html * igt@kms_content_protection@mei_interface: - shard-dg2: [SKIP][114] ([i915#7118]) -> [SKIP][115] ([i915#7118] / [i915#7162]) [114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13383/shard-dg2-6/igt@kms_content_protection@mei_interface.html [115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-dg2-12/igt@kms_content_protection@mei_interface.html * igt@kms_fbcon_fbt@psr-suspend: - shard-rkl: [SKIP][116] ([fdo#110189] / [i915#3955]) -> [SKIP][117] ([i915#3955]) [116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13383/shard-rkl-2/igt@kms_fbcon_fbt@psr-suspend.html [117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-rkl-4/igt@kms_fbcon_fbt@psr-suspend.html * igt@kms_force_connector_basic@force-load-detect: - shard-rkl: [SKIP][118] ([fdo#109285] / [i915#4098]) -> [SKIP][119] ([fdo#109285]) [118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13383/shard-rkl-1/igt@kms_force_connector_basic@force-load-detect.html [119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-rkl-6/igt@kms_force_connector_basic@force-load-detect.html * igt@kms_multipipe_modeset@basic-max-pipe-crc-check: - shard-rkl: [SKIP][120] ([i915#4070] / [i915#4816]) -> [SKIP][121] ([i915#4816]) [120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13383/shard-rkl-1/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html [121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/shard-rkl-4/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274 [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285 [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289 [fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291 [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189 [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072 [i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397 [i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825 [i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346 [i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521 [i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575 [i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284 [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842 [i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856 [i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281 [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282 [i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297 [i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458 [i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469 [i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539 [i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546 [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555 [i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591 [i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689 [i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743 [i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840 [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886 [i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955 [i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070 [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078 [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083 [i915#4087]: https://gitlab.freedesktop.org/drm/intel/issues/4087 [i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098 [i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212 [i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270 [i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538 [i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771 [i915#4816]: https://gitlab.freedesktop.org/drm/intel/issues/4816 [i915#4818]: https://gitlab.freedesktop.org/drm/intel/issues/4818 [i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873 [i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880 [i915#5138]: https://gitlab.freedesktop.org/drm/intel/issues/5138 [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176 [i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190 [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235 [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354 [i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493 [i915#5507]: https://gitlab.freedesktop.org/drm/intel/issues/5507 [i915#5892]: https://gitlab.freedesktop.org/drm/intel/issues/5892 [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095 [i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059 [i915#7061]: https://gitlab.freedesktop.org/drm/intel/issues/7061 [i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118 [i915#7162]: https://gitlab.freedesktop.org/drm/intel/issues/7162 [i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461 [i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697 [i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711 [i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742 [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828 [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79 [i915#7940]: https://gitlab.freedesktop.org/drm/intel/issues/7940 [i915#8131]: https://gitlab.freedesktop.org/drm/intel/issues/8131 [i915#8228]: https://gitlab.freedesktop.org/drm/intel/issues/8228 [i915#8247]: https://gitlab.freedesktop.org/drm/intel/issues/8247 [i915#8260]: https://gitlab.freedesktop.org/drm/intel/issues/8260 [i915#8414]: https://gitlab.freedesktop.org/drm/intel/issues/8414 [i915#8497]: https://gitlab.freedesktop.org/drm/intel/issues/8497 [i915#8502]: https://gitlab.freedesktop.org/drm/intel/issues/8502 [i915#8628]: https://gitlab.freedesktop.org/drm/intel/issues/8628 [i915#8708]: https://gitlab.freedesktop.org/drm/intel/issues/8708 [i915#8758]: https://gitlab.freedesktop.org/drm/intel/issues/8758 [i915#8841]: https://gitlab.freedesktop.org/drm/intel/issues/8841 Build changes ------------- * Linux: CI_DRM_13383 -> Patchwork_120668v1 CI-20190529: 20190529 CI_DRM_13383: d08a48cfbc24191eb55119f6931e0b3aad5ca673 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_7386: 54dc25efaf10d87962f95be9b1d1a8f0f907912b @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_120668v1: d08a48cfbc24191eb55119f6931e0b3aad5ca673 @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120668v1/index.html [-- Attachment #2: Type: text/html, Size: 37652 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2023-07-13 21:43 UTC | newest] Thread overview: 12+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-07-13 10:05 [Intel-gfx] [PATCH 0/2] eventfd: simplify signal helpers Christian Brauner 2023-07-13 10:05 ` [Intel-gfx] [PATCH 1/2] eventfd: simplify eventfd_signal() Christian Brauner 2023-07-13 13:29 ` Anthony Krowiak 2023-07-13 13:34 ` Oded Gabbay 2023-07-13 10:05 ` [Intel-gfx] [PATCH 2/2] eventfd: simplify eventfd_signal_mask() Christian Brauner 2023-07-13 14:33 ` Sean Christopherson 2023-07-13 14:52 ` Christian Brauner 2023-07-13 16:43 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for eventfd: simplify signal helpers Patchwork 2023-07-13 16:43 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork 2023-07-13 16:57 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2023-07-13 17:10 ` [Intel-gfx] [PATCH 0/2] " Alex Williamson 2023-07-13 21:43 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox