* [Intel-gfx] [PATCH] dma-buf/dma-resv: Stop leaking on krealloc() failure
@ 2023-07-13 19:47 Ville Syrjala
2023-07-13 20:50 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Ville Syrjala @ 2023-07-13 19:47 UTC (permalink / raw)
To: dri-devel
Cc: linaro-mm-sig, intel-gfx, linux-media, Sumit Semwal,
Christian König
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Currently dma_resv_get_fences() will leak the previously
allocated array if the fence iteration got restarted and
the krealloc_array() fails.
Free the old array by hand, and make sure we still clear
the returned *fences so the caller won't end up accessing
freed memory. Some (but not all) of the callers of
dma_resv_get_fences() seem to still trawl through the
array even when dma_resv_get_fences() failed. And let's
zero out *num_fences as well for good measure.
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: Christian König <christian.koenig@amd.com>
Cc: linux-media@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: linaro-mm-sig@lists.linaro.org
Fixes: d3c80698c9f5 ("dma-buf: use new iterator in dma_resv_get_fences v3")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/dma-buf/dma-resv.c | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/drivers/dma-buf/dma-resv.c b/drivers/dma-buf/dma-resv.c
index b6f71eb00866..38b4110378de 100644
--- a/drivers/dma-buf/dma-resv.c
+++ b/drivers/dma-buf/dma-resv.c
@@ -571,6 +571,7 @@ int dma_resv_get_fences(struct dma_resv *obj, enum dma_resv_usage usage,
dma_resv_for_each_fence_unlocked(&cursor, fence) {
if (dma_resv_iter_is_restarted(&cursor)) {
+ struct dma_fence **new_fences;
unsigned int count;
while (*num_fences)
@@ -579,13 +580,17 @@ int dma_resv_get_fences(struct dma_resv *obj, enum dma_resv_usage usage,
count = cursor.num_fences + 1;
/* Eventually re-allocate the array */
- *fences = krealloc_array(*fences, count,
- sizeof(void *),
- GFP_KERNEL);
- if (count && !*fences) {
+ new_fences = krealloc_array(*fences, count,
+ sizeof(void *),
+ GFP_KERNEL);
+ if (count && !new_fences) {
+ kfree(*fences);
+ *fences = NULL;
+ *num_fences = 0;
dma_resv_iter_end(&cursor);
return -ENOMEM;
}
+ *fences = new_fences;
}
(*fences)[(*num_fences)++] = dma_fence_get(fence);
--
2.39.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for dma-buf/dma-resv: Stop leaking on krealloc() failure
2023-07-13 19:47 [Intel-gfx] [PATCH] dma-buf/dma-resv: Stop leaking on krealloc() failure Ville Syrjala
@ 2023-07-13 20:50 ` Patchwork
2023-07-14 1:38 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2023-07-14 6:56 ` [Intel-gfx] [PATCH] " Christian König
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2023-07-13 20:50 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 8686 bytes --]
== Series Details ==
Series: dma-buf/dma-resv: Stop leaking on krealloc() failure
URL : https://patchwork.freedesktop.org/series/120699/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13384 -> Patchwork_120699v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/index.html
Participating hosts (42 -> 41)
------------------------------
Missing (1): fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_120699v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@dmabuf@all-tests@dma_fence:
- bat-atsm-1: [PASS][1] -> [DMESG-FAIL][2] ([i915#8189])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/bat-atsm-1/igt@dmabuf@all-tests@dma_fence.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/bat-atsm-1/igt@dmabuf@all-tests@dma_fence.html
* igt@dmabuf@all-tests@sanitycheck:
- bat-atsm-1: [PASS][3] -> [ABORT][4] ([i915#7699])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/bat-atsm-1/igt@dmabuf@all-tests@sanitycheck.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/bat-atsm-1/igt@dmabuf@all-tests@sanitycheck.html
* igt@i915_pm_rpm@module-reload:
- fi-tgl-1115g4: [PASS][5] -> [FAIL][6] ([i915#7940])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/fi-tgl-1115g4/igt@i915_pm_rpm@module-reload.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/fi-tgl-1115g4/igt@i915_pm_rpm@module-reload.html
- fi-skl-guc: [PASS][7] -> [FAIL][8] ([i915#7940])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/fi-skl-guc/igt@i915_pm_rpm@module-reload.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/fi-skl-guc/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live@requests:
- bat-mtlp-8: [PASS][9] -> [DMESG-FAIL][10] ([i915#7269])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/bat-mtlp-8/igt@i915_selftest@live@requests.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/bat-mtlp-8/igt@i915_selftest@live@requests.html
* igt@i915_selftest@live@slpc:
- bat-mtlp-6: [PASS][11] -> [DMESG-WARN][12] ([i915#6367])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/bat-mtlp-6/igt@i915_selftest@live@slpc.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/bat-mtlp-6/igt@i915_selftest@live@slpc.html
- bat-rpls-2: NOTRUN -> [DMESG-WARN][13] ([i915#6367])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/bat-rpls-2/igt@i915_selftest@live@slpc.html
* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- bat-rpls-2: NOTRUN -> [SKIP][14] ([i915#7828])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/bat-rpls-2/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
- bat-jsl-3: NOTRUN -> [SKIP][15] ([i915#7828])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/bat-jsl-3/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:
- bat-dg2-11: NOTRUN -> [SKIP][16] ([i915#1845] / [i915#5354]) +3 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/bat-dg2-11/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html
* igt@kms_pipe_crc_basic@suspend-read-crc:
- bat-rpls-2: NOTRUN -> [SKIP][17] ([i915#1845])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/bat-rpls-2/igt@kms_pipe_crc_basic@suspend-read-crc.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s0@smem:
- bat-jsl-3: [ABORT][18] ([i915#5122]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/bat-jsl-3/igt@gem_exec_suspend@basic-s0@smem.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/bat-jsl-3/igt@gem_exec_suspend@basic-s0@smem.html
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-cfl-8700k: [FAIL][20] ([i915#7940]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/fi-cfl-8700k/igt@i915_pm_rpm@basic-pci-d3-state.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/fi-cfl-8700k/igt@i915_pm_rpm@basic-pci-d3-state.html
* igt@i915_pm_rpm@basic-rte:
- fi-skl-guc: [FAIL][22] ([i915#7940]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/fi-skl-guc/igt@i915_pm_rpm@basic-rte.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/fi-skl-guc/igt@i915_pm_rpm@basic-rte.html
- fi-kbl-7567u: [FAIL][24] ([i915#7940]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/fi-kbl-7567u/igt@i915_pm_rpm@basic-rte.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/fi-kbl-7567u/igt@i915_pm_rpm@basic-rte.html
* igt@i915_pm_rpm@module-reload:
- fi-rkl-11600: [FAIL][26] ([i915#7940]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/fi-rkl-11600/igt@i915_pm_rpm@module-reload.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/fi-rkl-11600/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live@gt_heartbeat:
- fi-kbl-soraka: [DMESG-FAIL][28] ([i915#5334] / [i915#7872]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@reset:
- bat-rpls-2: [ABORT][30] ([i915#4983] / [i915#7461] / [i915#7913] / [i915#7981] / [i915#8347]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/bat-rpls-2/igt@i915_selftest@live@reset.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/bat-rpls-2/igt@i915_selftest@live@reset.html
* igt@i915_suspend@basic-s3-without-i915:
- bat-jsl-3: [FAIL][32] ([fdo#103375]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/bat-jsl-3/igt@i915_suspend@basic-s3-without-i915.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/bat-jsl-3/igt@i915_suspend@basic-s3-without-i915.html
#### Warnings ####
* igt@i915_pm_rpm@basic-rte:
- fi-kbl-8809g: [FAIL][34] ([i915#8843]) -> [FAIL][35] ([i915#7940])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/fi-kbl-8809g/igt@i915_pm_rpm@basic-rte.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/fi-kbl-8809g/igt@i915_pm_rpm@basic-rte.html
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#7269]: https://gitlab.freedesktop.org/drm/intel/issues/7269
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7872]: https://gitlab.freedesktop.org/drm/intel/issues/7872
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7940]: https://gitlab.freedesktop.org/drm/intel/issues/7940
[i915#7981]: https://gitlab.freedesktop.org/drm/intel/issues/7981
[i915#8189]: https://gitlab.freedesktop.org/drm/intel/issues/8189
[i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
[i915#8843]: https://gitlab.freedesktop.org/drm/intel/issues/8843
Build changes
-------------
* Linux: CI_DRM_13384 -> Patchwork_120699v1
CI-20190529: 20190529
CI_DRM_13384: ea8d81bf649580240f0b944b85521d2a091d8ebc @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7386: 54dc25efaf10d87962f95be9b1d1a8f0f907912b @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_120699v1: ea8d81bf649580240f0b944b85521d2a091d8ebc @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
48001eda3d3e dma-buf/dma-resv: Stop leaking on krealloc() failure
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/index.html
[-- Attachment #2: Type: text/html, Size: 10353 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for dma-buf/dma-resv: Stop leaking on krealloc() failure
2023-07-13 19:47 [Intel-gfx] [PATCH] dma-buf/dma-resv: Stop leaking on krealloc() failure Ville Syrjala
2023-07-13 20:50 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2023-07-14 1:38 ` Patchwork
2023-07-14 6:56 ` [Intel-gfx] [PATCH] " Christian König
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2023-07-14 1:38 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 33885 bytes --]
== Series Details ==
Series: dma-buf/dma-resv: Stop leaking on krealloc() failure
URL : https://patchwork.freedesktop.org/series/120699/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13384_full -> Patchwork_120699v1_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_120699v1_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_120699v1_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_120699v1_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_busy@extended-modeset-hang-newfb@pipe-a:
- shard-snb: NOTRUN -> [ABORT][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-snb7/igt@kms_busy@extended-modeset-hang-newfb@pipe-a.html
Known issues
------------
Here are the changes found in Patchwork_120699v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_basic@multigpu-create-close:
- shard-dg2: NOTRUN -> [SKIP][2] ([i915#7697])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-dg2-1/igt@gem_basic@multigpu-create-close.html
* igt@gem_create@create-ext-set-pat:
- shard-snb: NOTRUN -> [FAIL][3] ([i915#8621])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-snb2/igt@gem_create@create-ext-set-pat.html
* igt@gem_create@hog-create@smem0:
- shard-dg2: [PASS][4] -> [FAIL][5] ([i915#5892] / [i915#8758])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/shard-dg2-10/igt@gem_create@hog-create@smem0.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-dg2-11/igt@gem_create@hog-create@smem0.html
* igt@gem_ctx_exec@basic-nohangcheck:
- shard-tglu: [PASS][6] -> [FAIL][7] ([i915#6268])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/shard-tglu-5/igt@gem_ctx_exec@basic-nohangcheck.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-tglu-9/igt@gem_ctx_exec@basic-nohangcheck.html
* igt@gem_ctx_persistence@engines-mixed:
- shard-snb: NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#1099]) +2 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-snb2/igt@gem_ctx_persistence@engines-mixed.html
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [PASS][9] -> [FAIL][10] ([i915#2842])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/shard-apl4/igt@gem_exec_fair@basic-none-solo@rcs0.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-apl7/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@gem_exec_fair@basic-none@bcs0:
- shard-rkl: [PASS][11] -> [FAIL][12] ([i915#2842]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/shard-rkl-1/igt@gem_exec_fair@basic-none@bcs0.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-rkl-4/igt@gem_exec_fair@basic-none@bcs0.html
* igt@gem_exec_fair@basic-pace-solo:
- shard-mtlp: NOTRUN -> [SKIP][13] ([i915#4473])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-mtlp-8/igt@gem_exec_fair@basic-pace-solo.html
* igt@gem_exec_flush@basic-uc-set-default:
- shard-dg2: NOTRUN -> [SKIP][14] ([i915#3539])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-dg2-1/igt@gem_exec_flush@basic-uc-set-default.html
* igt@gem_exec_suspend@basic-s3@lmem0:
- shard-dg2: [PASS][15] -> [FAIL][16] ([fdo#103375]) +3 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/shard-dg2-10/igt@gem_exec_suspend@basic-s3@lmem0.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-dg2-5/igt@gem_exec_suspend@basic-s3@lmem0.html
* igt@gem_exec_suspend@basic-s4-devices@lmem0:
- shard-dg2: NOTRUN -> [ABORT][17] ([i915#7975] / [i915#8213])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-dg2-1/igt@gem_exec_suspend@basic-s4-devices@lmem0.html
* igt@gem_lmem_swapping@heavy-verify-random-ccs:
- shard-glk: NOTRUN -> [SKIP][18] ([fdo#109271] / [i915#4613])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-glk4/igt@gem_lmem_swapping@heavy-verify-random-ccs.html
* igt@gem_mmap_wc@read:
- shard-dg2: NOTRUN -> [SKIP][19] ([i915#4083])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-dg2-1/igt@gem_mmap_wc@read.html
* igt@gem_pxp@reject-modify-context-protection-off-1:
- shard-dg2: NOTRUN -> [SKIP][20] ([i915#4270])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-dg2-1/igt@gem_pxp@reject-modify-context-protection-off-1.html
* igt@gem_userptr_blits@coherency-unsync:
- shard-dg2: NOTRUN -> [SKIP][21] ([i915#3297])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-dg2-1/igt@gem_userptr_blits@coherency-unsync.html
* igt@gem_userptr_blits@forbidden-operations:
- shard-dg2: NOTRUN -> [SKIP][22] ([i915#3282])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-dg2-1/igt@gem_userptr_blits@forbidden-operations.html
* igt@i915_pm_dc@dc5-dpms-negative:
- shard-mtlp: NOTRUN -> [SKIP][23] ([i915#8018])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-mtlp-8/igt@i915_pm_dc@dc5-dpms-negative.html
* igt@i915_pm_rpm@gem-execbuf-stress@extra-wait-smem0:
- shard-tglu: [PASS][24] -> [FAIL][25] ([i915#7940]) +1 similar issue
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/shard-tglu-4/igt@i915_pm_rpm@gem-execbuf-stress@extra-wait-smem0.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-tglu-2/igt@i915_pm_rpm@gem-execbuf-stress@extra-wait-smem0.html
* igt@i915_pm_rpm@modeset-non-lpsp-stress:
- shard-dg2: [PASS][26] -> [SKIP][27] ([i915#1397]) +2 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/shard-dg2-6/igt@i915_pm_rpm@modeset-non-lpsp-stress.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-dg2-12/igt@i915_pm_rpm@modeset-non-lpsp-stress.html
- shard-rkl: [PASS][28] -> [SKIP][29] ([i915#1397]) +2 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/shard-rkl-6/igt@i915_pm_rpm@modeset-non-lpsp-stress.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-rkl-7/igt@i915_pm_rpm@modeset-non-lpsp-stress.html
* igt@i915_suspend@basic-s3-without-i915:
- shard-rkl: [PASS][30] -> [FAIL][31] ([fdo#103375])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/shard-rkl-2/igt@i915_suspend@basic-s3-without-i915.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-rkl-6/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_addfb_basic@tile-pitch-mismatch:
- shard-dg2: NOTRUN -> [SKIP][32] ([i915#4212])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-dg2-1/igt@kms_addfb_basic@tile-pitch-mismatch.html
* igt@kms_big_fb@4-tiled-64bpp-rotate-180:
- shard-mtlp: [PASS][33] -> [FAIL][34] ([i915#5138])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/shard-mtlp-5/igt@kms_big_fb@4-tiled-64bpp-rotate-180.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-mtlp-6/igt@kms_big_fb@4-tiled-64bpp-rotate-180.html
* igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_rc_ccs_cc:
- shard-mtlp: NOTRUN -> [SKIP][35] ([i915#3886] / [i915#6095]) +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-mtlp-2/igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_rc_ccs_cc:
- shard-glk: NOTRUN -> [SKIP][36] ([fdo#109271] / [i915#3886]) +2 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-glk4/igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-bad-aux-stride-yf_tiled_ccs:
- shard-dg2: NOTRUN -> [SKIP][37] ([i915#3689] / [i915#5354]) +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-dg2-1/igt@kms_ccs@pipe-c-bad-aux-stride-yf_tiled_ccs.html
* igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_rc_ccs_cc:
- shard-snb: NOTRUN -> [SKIP][38] ([fdo#109271]) +281 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-snb2/igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-d-bad-aux-stride-4_tiled_mtl_mc_ccs:
- shard-glk: NOTRUN -> [SKIP][39] ([fdo#109271]) +35 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-glk4/igt@kms_ccs@pipe-d-bad-aux-stride-4_tiled_mtl_mc_ccs.html
* igt@kms_ccs@pipe-d-ccs-on-another-bo-y_tiled_gen12_rc_ccs:
- shard-mtlp: NOTRUN -> [SKIP][40] ([i915#6095]) +2 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-mtlp-2/igt@kms_ccs@pipe-d-ccs-on-another-bo-y_tiled_gen12_rc_ccs.html
* igt@kms_chamelium_hpd@vga-hpd-without-ddc:
- shard-mtlp: NOTRUN -> [SKIP][41] ([i915#7828])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-mtlp-2/igt@kms_chamelium_hpd@vga-hpd-without-ddc.html
* igt@kms_content_protection@legacy:
- shard-dg2: NOTRUN -> [SKIP][42] ([i915#7118]) +1 similar issue
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-dg2-8/igt@kms_content_protection@legacy.html
* igt@kms_content_protection@lic@pipe-a-dp-2:
- shard-dg2: NOTRUN -> [TIMEOUT][43] ([i915#7173])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-dg2-12/igt@kms_content_protection@lic@pipe-a-dp-2.html
* igt@kms_cursor_crc@cursor-suspend@pipe-b-vga-1:
- shard-snb: NOTRUN -> [DMESG-WARN][44] ([i915#8841]) +2 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-snb2/igt@kms_cursor_crc@cursor-suspend@pipe-b-vga-1.html
* igt@kms_cursor_legacy@cursor-vs-flip-toggle:
- shard-mtlp: [PASS][45] -> [FAIL][46] ([i915#8248])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/shard-mtlp-8/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-mtlp-8/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
* igt@kms_cursor_legacy@cursorb-vs-flipa-atomic-transitions-varying-size:
- shard-dg2: NOTRUN -> [SKIP][47] ([fdo#109274] / [i915#5354])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-dg2-1/igt@kms_cursor_legacy@cursorb-vs-flipa-atomic-transitions-varying-size.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-apl: [PASS][48] -> [FAIL][49] ([i915#2346])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/shard-apl2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-apl3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_fbcon_fbt@psr-suspend:
- shard-dg2: NOTRUN -> [SKIP][50] ([i915#3469])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-dg2-1/igt@kms_fbcon_fbt@psr-suspend.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
- shard-snb: NOTRUN -> [SKIP][51] ([fdo#109271] / [fdo#111767]) +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-snb4/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-dp1:
- shard-apl: [PASS][52] -> [FAIL][53] ([i915#79])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/shard-apl7/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-dp1.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-apl6/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-dp1.html
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-gtt:
- shard-mtlp: NOTRUN -> [SKIP][54] ([i915#8708])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-mtlp-8/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@fbc-rgb565-draw-blt:
- shard-dg2: [PASS][55] -> [FAIL][56] ([i915#6880])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/shard-dg2-5/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-blt.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-dg2-6/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-pwrite:
- shard-dg2: NOTRUN -> [SKIP][57] ([i915#3458]) +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-dg2-1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-mmap-gtt:
- shard-dg2: NOTRUN -> [SKIP][58] ([i915#8708]) +1 similar issue
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-dg2-1/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-shrfb-plflip-blt:
- shard-mtlp: NOTRUN -> [SKIP][59] ([i915#1825]) +4 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-mtlp-2/igt@kms_frontbuffer_tracking@psr-2p-primscrn-shrfb-plflip-blt.html
* igt@kms_hdr@static-toggle-suspend:
- shard-dg2: NOTRUN -> [SKIP][60] ([i915#3555] / [i915#8228]) +1 similar issue
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-dg2-6/igt@kms_hdr@static-toggle-suspend.html
* igt@kms_plane_scaling@2x-scaler-multi-pipe:
- shard-mtlp: NOTRUN -> [SKIP][61] ([i915#3546])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-mtlp-2/igt@kms_plane_scaling@2x-scaler-multi-pipe.html
* igt@kms_plane_scaling@intel-max-src-size:
- shard-dg2: NOTRUN -> [SKIP][62] ([i915#6953])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-dg2-2/igt@kms_plane_scaling@intel-max-src-size.html
* igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-25@pipe-a-hdmi-a-3:
- shard-dg2: NOTRUN -> [SKIP][63] ([i915#5176]) +3 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-dg2-1/igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-25@pipe-a-hdmi-a-3.html
* igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-75@pipe-a-hdmi-a-1:
- shard-rkl: NOTRUN -> [SKIP][64] ([i915#5176]) +5 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-rkl-7/igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-75@pipe-a-hdmi-a-1.html
* igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-20x20@pipe-b-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][65] ([i915#5235]) +3 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-rkl-1/igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-20x20@pipe-b-hdmi-a-2.html
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-a-hdmi-a-3:
- shard-dg2: NOTRUN -> [SKIP][66] ([i915#5235]) +15 similar issues
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-dg2-6/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-a-hdmi-a-3.html
* igt@kms_setmode@basic@pipe-a-vga-1:
- shard-snb: NOTRUN -> [FAIL][67] ([i915#5465]) +1 similar issue
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-snb2/igt@kms_setmode@basic@pipe-a-vga-1.html
* igt@kms_writeback@writeback-invalid-parameters:
- shard-glk: NOTRUN -> [SKIP][68] ([fdo#109271] / [i915#2437])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-glk4/igt@kms_writeback@writeback-invalid-parameters.html
* igt@perf@unprivileged-single-ctx-counters:
- shard-mtlp: NOTRUN -> [SKIP][69] ([fdo#109289])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-mtlp-8/igt@perf@unprivileged-single-ctx-counters.html
* igt@prime_udl:
- shard-dg2: NOTRUN -> [SKIP][70] ([fdo#109291])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-dg2-1/igt@prime_udl.html
* igt@v3d/v3d_submit_cl@valid-multisync-submission:
- shard-mtlp: NOTRUN -> [SKIP][71] ([i915#2575])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-mtlp-8/igt@v3d/v3d_submit_cl@valid-multisync-submission.html
* igt@v3d/v3d_submit_csd@bad-multisync-out-sync:
- shard-dg2: NOTRUN -> [SKIP][72] ([i915#2575]) +1 similar issue
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-dg2-1/igt@v3d/v3d_submit_csd@bad-multisync-out-sync.html
#### Possible fixes ####
* igt@gem_exec_fair@basic-deadline:
- shard-glk: [FAIL][73] ([i915#2846]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/shard-glk3/igt@gem_exec_fair@basic-deadline.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-glk3/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][75] ([i915#2842]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/shard-glk1/igt@gem_exec_fair@basic-pace-share@rcs0.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-glk6/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-rkl: [FAIL][77] ([i915#2842]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/shard-rkl-7/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-rkl-1/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_ppgtt@blt-vs-render-ctx0:
- shard-snb: [DMESG-FAIL][79] ([i915#8295]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/shard-snb1/igt@gem_ppgtt@blt-vs-render-ctx0.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-snb2/igt@gem_ppgtt@blt-vs-render-ctx0.html
* igt@gen9_exec_parse@allowed-single:
- shard-glk: [ABORT][81] ([i915#5566]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/shard-glk1/igt@gen9_exec_parse@allowed-single.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-glk4/igt@gen9_exec_parse@allowed-single.html
* igt@i915_pipe_stress@stress-xrgb8888-untiled:
- shard-mtlp: [FAIL][83] ([i915#8691]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/shard-mtlp-8/igt@i915_pipe_stress@stress-xrgb8888-untiled.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-mtlp-4/igt@i915_pipe_stress@stress-xrgb8888-untiled.html
* igt@i915_pm_rc6_residency@rc6-idle@vcs0:
- {shard-dg1}: [FAIL][85] ([i915#3591]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/shard-dg1-15/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-dg1-14/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html
* igt@i915_pm_rpm@cursor:
- shard-tglu: [FAIL][87] ([i915#7940]) -> [PASS][88] +1 similar issue
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/shard-tglu-4/igt@i915_pm_rpm@cursor.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-tglu-2/igt@i915_pm_rpm@cursor.html
* igt@i915_pm_rpm@dpms-mode-unset-non-lpsp:
- shard-dg2: [SKIP][89] ([i915#1397]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/shard-dg2-10/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-dg2-11/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html
* igt@i915_pm_rpm@modeset-lpsp:
- shard-rkl: [SKIP][91] ([i915#1397]) -> [PASS][92]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/shard-rkl-2/igt@i915_pm_rpm@modeset-lpsp.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-rkl-7/igt@i915_pm_rpm@modeset-lpsp.html
* igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait:
- {shard-dg1}: [SKIP][93] ([i915#1397]) -> [PASS][94] +1 similar issue
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/shard-dg1-19/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-dg1-12/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html
* igt@i915_pm_rpm@system-suspend-execbuf:
- {shard-dg1}: [FAIL][95] ([i915#7940]) -> [PASS][96] +1 similar issue
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/shard-dg1-18/igt@i915_pm_rpm@system-suspend-execbuf.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-dg1-17/igt@i915_pm_rpm@system-suspend-execbuf.html
* igt@i915_selftest@live@gt_heartbeat:
- shard-apl: [DMESG-FAIL][97] ([i915#5334]) -> [PASS][98]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/shard-apl6/igt@i915_selftest@live@gt_heartbeat.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-apl1/igt@i915_selftest@live@gt_heartbeat.html
* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-async-flip:
- shard-mtlp: [FAIL][99] ([i915#3743]) -> [PASS][100]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/shard-mtlp-8/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-mtlp-6/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-apl: [FAIL][101] ([i915#2346]) -> [PASS][102]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/shard-apl2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-apl3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a1:
- shard-glk: [FAIL][103] ([i915#79]) -> [PASS][104] +1 similar issue
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/shard-glk6/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a1.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-glk8/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a1.html
* igt@kms_flip@flip-vs-suspend@b-hdmi-a3:
- shard-dg2: [FAIL][105] ([fdo#103375]) -> [PASS][106]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/shard-dg2-5/igt@kms_flip@flip-vs-suspend@b-hdmi-a3.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-dg2-6/igt@kms_flip@flip-vs-suspend@b-hdmi-a3.html
* igt@kms_flip@wf_vblank-ts-check@a-vga1:
- shard-snb: [ABORT][107] -> [PASS][108]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/shard-snb7/igt@kms_flip@wf_vblank-ts-check@a-vga1.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-snb7/igt@kms_flip@wf_vblank-ts-check@a-vga1.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-blt:
- shard-dg2: [FAIL][109] ([i915#6880]) -> [PASS][110] +1 similar issue
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/shard-dg2-7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-blt.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-dg2-11/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-blt.html
* igt@kms_sysfs_edid_timing:
- shard-dg2: [FAIL][111] ([IGT#2]) -> [PASS][112]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/shard-dg2-7/igt@kms_sysfs_edid_timing.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-dg2-11/igt@kms_sysfs_edid_timing.html
* igt@perf@non-zero-reason@0-rcs0:
- shard-dg2: [FAIL][113] ([i915#7484]) -> [PASS][114]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/shard-dg2-3/igt@perf@non-zero-reason@0-rcs0.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-dg2-2/igt@perf@non-zero-reason@0-rcs0.html
* igt@perf_pmu@busy-double-start@rcs0:
- shard-mtlp: [FAIL][115] ([i915#4349]) -> [PASS][116]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/shard-mtlp-2/igt@perf_pmu@busy-double-start@rcs0.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-mtlp-1/igt@perf_pmu@busy-double-start@rcs0.html
#### Warnings ####
* igt@kms_content_protection@content_type_change:
- shard-dg2: [SKIP][117] ([i915#7118]) -> [SKIP][118] ([i915#7118] / [i915#7162])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/shard-dg2-6/igt@kms_content_protection@content_type_change.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-dg2-12/igt@kms_content_protection@content_type_change.html
* igt@kms_content_protection@mei_interface:
- shard-dg2: [SKIP][119] ([i915#7118] / [i915#7162]) -> [SKIP][120] ([i915#7118])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/shard-dg2-12/igt@kms_content_protection@mei_interface.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-dg2-10/igt@kms_content_protection@mei_interface.html
* igt@kms_fbcon_fbt@psr-suspend:
- shard-rkl: [SKIP][121] ([i915#3955]) -> [SKIP][122] ([fdo#110189] / [i915#3955])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/shard-rkl-4/igt@kms_fbcon_fbt@psr-suspend.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-rkl-2/igt@kms_fbcon_fbt@psr-suspend.html
* igt@kms_force_connector_basic@force-load-detect:
- shard-rkl: [SKIP][123] ([fdo#109285] / [i915#4098]) -> [SKIP][124] ([fdo#109285])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/shard-rkl-2/igt@kms_force_connector_basic@force-load-detect.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-rkl-7/igt@kms_force_connector_basic@force-load-detect.html
* igt@prime_mmap@test_aperture_limit@test_aperture_limit-smem:
- shard-dg2: [INCOMPLETE][125] ([i915#5493]) -> [CRASH][126] ([i915#7331])
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13384/shard-dg2-8/igt@prime_mmap@test_aperture_limit@test_aperture_limit-smem.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/shard-dg2-5/igt@prime_mmap@test_aperture_limit@test_aperture_limit-smem.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#2]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/2
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111767]: https://bugs.freedesktop.org/show_bug.cgi?id=111767
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4473]: https://gitlab.freedesktop.org/drm/intel/issues/4473
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#5138]: https://gitlab.freedesktop.org/drm/intel/issues/5138
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5465]: https://gitlab.freedesktop.org/drm/intel/issues/5465
[i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#5892]: https://gitlab.freedesktop.org/drm/intel/issues/5892
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6880]: https://gitlab.freedesktop.org/drm/intel/issues/6880
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7162]: https://gitlab.freedesktop.org/drm/intel/issues/7162
[i915#7173]: https://gitlab.freedesktop.org/drm/intel/issues/7173
[i915#7331]: https://gitlab.freedesktop.org/drm/intel/issues/7331
[i915#7484]: https://gitlab.freedesktop.org/drm/intel/issues/7484
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#7940]: https://gitlab.freedesktop.org/drm/intel/issues/7940
[i915#7962]: https://gitlab.freedesktop.org/drm/intel/issues/7962
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
[i915#8018]: https://gitlab.freedesktop.org/drm/intel/issues/8018
[i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213
[i915#8228]: https://gitlab.freedesktop.org/drm/intel/issues/8228
[i915#8248]: https://gitlab.freedesktop.org/drm/intel/issues/8248
[i915#8295]: https://gitlab.freedesktop.org/drm/intel/issues/8295
[i915#8502]: https://gitlab.freedesktop.org/drm/intel/issues/8502
[i915#8621]: https://gitlab.freedesktop.org/drm/intel/issues/8621
[i915#8661]: https://gitlab.freedesktop.org/drm/intel/issues/8661
[i915#8691]: https://gitlab.freedesktop.org/drm/intel/issues/8691
[i915#8708]: https://gitlab.freedesktop.org/drm/intel/issues/8708
[i915#8709]: https://gitlab.freedesktop.org/drm/intel/issues/8709
[i915#8758]: https://gitlab.freedesktop.org/drm/intel/issues/8758
[i915#8841]: https://gitlab.freedesktop.org/drm/intel/issues/8841
Build changes
-------------
* Linux: CI_DRM_13384 -> Patchwork_120699v1
CI-20190529: 20190529
CI_DRM_13384: ea8d81bf649580240f0b944b85521d2a091d8ebc @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7386: 54dc25efaf10d87962f95be9b1d1a8f0f907912b @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_120699v1: ea8d81bf649580240f0b944b85521d2a091d8ebc @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120699v1/index.html
[-- Attachment #2: Type: text/html, Size: 38376 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [PATCH] dma-buf/dma-resv: Stop leaking on krealloc() failure
2023-07-13 19:47 [Intel-gfx] [PATCH] dma-buf/dma-resv: Stop leaking on krealloc() failure Ville Syrjala
2023-07-13 20:50 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2023-07-14 1:38 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
@ 2023-07-14 6:56 ` Christian König
2023-07-14 18:42 ` Ville Syrjälä
2 siblings, 1 reply; 5+ messages in thread
From: Christian König @ 2023-07-14 6:56 UTC (permalink / raw)
To: Ville Syrjala, dri-devel
Cc: linaro-mm-sig, intel-gfx, Sumit Semwal, linux-media
Am 13.07.23 um 21:47 schrieb Ville Syrjala:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Currently dma_resv_get_fences() will leak the previously
> allocated array if the fence iteration got restarted and
> the krealloc_array() fails.
>
> Free the old array by hand, and make sure we still clear
> the returned *fences so the caller won't end up accessing
> freed memory. Some (but not all) of the callers of
> dma_resv_get_fences() seem to still trawl through the
> array even when dma_resv_get_fences() failed. And let's
> zero out *num_fences as well for good measure.
>
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Cc: Christian König <christian.koenig@amd.com>
> Cc: linux-media@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: linaro-mm-sig@lists.linaro.org
> Fixes: d3c80698c9f5 ("dma-buf: use new iterator in dma_resv_get_fences v3")
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Good catch, Reviewed-by: Christian König <christian.koenig@amd.com>
Should I add a CC: stable and push to drm-misc-fixes?
Thanks,
Christian.
> ---
> drivers/dma-buf/dma-resv.c | 13 +++++++++----
> 1 file changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/dma-buf/dma-resv.c b/drivers/dma-buf/dma-resv.c
> index b6f71eb00866..38b4110378de 100644
> --- a/drivers/dma-buf/dma-resv.c
> +++ b/drivers/dma-buf/dma-resv.c
> @@ -571,6 +571,7 @@ int dma_resv_get_fences(struct dma_resv *obj, enum dma_resv_usage usage,
> dma_resv_for_each_fence_unlocked(&cursor, fence) {
>
> if (dma_resv_iter_is_restarted(&cursor)) {
> + struct dma_fence **new_fences;
> unsigned int count;
>
> while (*num_fences)
> @@ -579,13 +580,17 @@ int dma_resv_get_fences(struct dma_resv *obj, enum dma_resv_usage usage,
> count = cursor.num_fences + 1;
>
> /* Eventually re-allocate the array */
> - *fences = krealloc_array(*fences, count,
> - sizeof(void *),
> - GFP_KERNEL);
> - if (count && !*fences) {
> + new_fences = krealloc_array(*fences, count,
> + sizeof(void *),
> + GFP_KERNEL);
> + if (count && !new_fences) {
> + kfree(*fences);
> + *fences = NULL;
> + *num_fences = 0;
> dma_resv_iter_end(&cursor);
> return -ENOMEM;
> }
> + *fences = new_fences;
> }
>
> (*fences)[(*num_fences)++] = dma_fence_get(fence);
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [PATCH] dma-buf/dma-resv: Stop leaking on krealloc() failure
2023-07-14 6:56 ` [Intel-gfx] [PATCH] " Christian König
@ 2023-07-14 18:42 ` Ville Syrjälä
0 siblings, 0 replies; 5+ messages in thread
From: Ville Syrjälä @ 2023-07-14 18:42 UTC (permalink / raw)
To: Christian König
Cc: linaro-mm-sig, intel-gfx, Sumit Semwal, dri-devel, linux-media
On Fri, Jul 14, 2023 at 08:56:15AM +0200, Christian König wrote:
> Am 13.07.23 um 21:47 schrieb Ville Syrjala:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Currently dma_resv_get_fences() will leak the previously
> > allocated array if the fence iteration got restarted and
> > the krealloc_array() fails.
> >
> > Free the old array by hand, and make sure we still clear
> > the returned *fences so the caller won't end up accessing
> > freed memory. Some (but not all) of the callers of
> > dma_resv_get_fences() seem to still trawl through the
> > array even when dma_resv_get_fences() failed. And let's
> > zero out *num_fences as well for good measure.
> >
> > Cc: Sumit Semwal <sumit.semwal@linaro.org>
> > Cc: Christian König <christian.koenig@amd.com>
> > Cc: linux-media@vger.kernel.org
> > Cc: dri-devel@lists.freedesktop.org
> > Cc: linaro-mm-sig@lists.linaro.org
> > Fixes: d3c80698c9f5 ("dma-buf: use new iterator in dma_resv_get_fences v3")
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Good catch, Reviewed-by: Christian König <christian.koenig@amd.com>
>
> Should I add a CC: stable and push to drm-misc-fixes?
Sure, if you don't mind. Thanks.
>
> Thanks,
> Christian.
>
> > ---
> > drivers/dma-buf/dma-resv.c | 13 +++++++++----
> > 1 file changed, 9 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/dma-buf/dma-resv.c b/drivers/dma-buf/dma-resv.c
> > index b6f71eb00866..38b4110378de 100644
> > --- a/drivers/dma-buf/dma-resv.c
> > +++ b/drivers/dma-buf/dma-resv.c
> > @@ -571,6 +571,7 @@ int dma_resv_get_fences(struct dma_resv *obj, enum dma_resv_usage usage,
> > dma_resv_for_each_fence_unlocked(&cursor, fence) {
> >
> > if (dma_resv_iter_is_restarted(&cursor)) {
> > + struct dma_fence **new_fences;
> > unsigned int count;
> >
> > while (*num_fences)
> > @@ -579,13 +580,17 @@ int dma_resv_get_fences(struct dma_resv *obj, enum dma_resv_usage usage,
> > count = cursor.num_fences + 1;
> >
> > /* Eventually re-allocate the array */
> > - *fences = krealloc_array(*fences, count,
> > - sizeof(void *),
> > - GFP_KERNEL);
> > - if (count && !*fences) {
> > + new_fences = krealloc_array(*fences, count,
> > + sizeof(void *),
> > + GFP_KERNEL);
> > + if (count && !new_fences) {
> > + kfree(*fences);
> > + *fences = NULL;
> > + *num_fences = 0;
> > dma_resv_iter_end(&cursor);
> > return -ENOMEM;
> > }
> > + *fences = new_fences;
> > }
> >
> > (*fences)[(*num_fences)++] = dma_fence_get(fence);
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-07-14 18:42 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-13 19:47 [Intel-gfx] [PATCH] dma-buf/dma-resv: Stop leaking on krealloc() failure Ville Syrjala
2023-07-13 20:50 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2023-07-14 1:38 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2023-07-14 6:56 ` [Intel-gfx] [PATCH] " Christian König
2023-07-14 18:42 ` Ville Syrjälä
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox