* [Intel-gfx] [PATCH v2] drm/i915/overlay: Remove redundant drm_rect_visible() use @ 2023-03-25 17:27 Arthur Grillo 2023-03-25 18:10 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/overlay: Remove redundant drm_rect_visible() use (rev2) Patchwork 2024-03-04 11:13 ` [PATCH v2] drm/i915/overlay: Remove redundant drm_rect_visible() use Ville Syrjälä 0 siblings, 2 replies; 3+ messages in thread From: Arthur Grillo @ 2023-03-25 17:27 UTC (permalink / raw) To: intel-gfx, dri-devel Cc: tales.aparecida, lucas.demarchi, mairacanal, daniel, rodrigo.vivi, andrealmeid, airlied, Arthur Grillo The drm_rect_intersect() already returns if the intersection is visible or not, so the use of drm_rect_visible() is duplicate. Signed-off-by: Arthur Grillo <arthurgrillo@riseup.net> --- v1->v2: https://lore.kernel.org/all/20230324142533.6357-1-arthurgrillo@riseup.net/ - Split the if condition. --- drivers/gpu/drm/i915/display/intel_overlay.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_overlay.c b/drivers/gpu/drm/i915/display/intel_overlay.c index c12bdca8da9b..d55153587cae 100644 --- a/drivers/gpu/drm/i915/display/intel_overlay.c +++ b/drivers/gpu/drm/i915/display/intel_overlay.c @@ -966,10 +966,11 @@ static int check_overlay_dst(struct intel_overlay *overlay, rec->dst_width, rec->dst_height); clipped = req; - drm_rect_intersect(&clipped, &crtc_state->pipe_src); - if (!drm_rect_visible(&clipped) || - !drm_rect_equals(&clipped, &req)) + if (!drm_rect_intersect(&clipped, &crtc_state->pipe_src)) + return -EINVAL; + + if (!drm_rect_equals(&clipped, &req)) return -EINVAL; return 0; -- 2.39.2 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/overlay: Remove redundant drm_rect_visible() use (rev2) 2023-03-25 17:27 [Intel-gfx] [PATCH v2] drm/i915/overlay: Remove redundant drm_rect_visible() use Arthur Grillo @ 2023-03-25 18:10 ` Patchwork 2024-03-04 11:13 ` [PATCH v2] drm/i915/overlay: Remove redundant drm_rect_visible() use Ville Syrjälä 1 sibling, 0 replies; 3+ messages in thread From: Patchwork @ 2023-03-25 18:10 UTC (permalink / raw) To: Arthur Grillo; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 5659 bytes --] == Series Details == Series: drm/i915/overlay: Remove redundant drm_rect_visible() use (rev2) URL : https://patchwork.freedesktop.org/series/115605/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12914 -> Patchwork_115605v2 ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_115605v2 absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_115605v2, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115605v2/index.html Participating hosts (38 -> 37) ------------------------------ Missing (1): fi-snb-2520m Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_115605v2: ### IGT changes ### #### Possible regressions #### * igt@kms_pipe_crc_basic@compare-crc-sanitycheck@pipe-d-dp-1: - bat-dg2-8: [PASS][1] -> [FAIL][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12914/bat-dg2-8/igt@kms_pipe_crc_basic@compare-crc-sanitycheck@pipe-d-dp-1.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115605v2/bat-dg2-8/igt@kms_pipe_crc_basic@compare-crc-sanitycheck@pipe-d-dp-1.html Known issues ------------ Here are the changes found in Patchwork_115605v2 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@i915_selftest@live@gt_heartbeat: - fi-cfl-8109u: [PASS][3] -> [DMESG-FAIL][4] ([i915#5334]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12914/fi-cfl-8109u/igt@i915_selftest@live@gt_heartbeat.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115605v2/fi-cfl-8109u/igt@i915_selftest@live@gt_heartbeat.html - fi-apl-guc: [PASS][5] -> [DMESG-FAIL][6] ([i915#5334]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12914/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115605v2/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html * igt@i915_selftest@live@gt_lrc: - bat-dg2-11: [PASS][7] -> [INCOMPLETE][8] ([i915#7609] / [i915#7913]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12914/bat-dg2-11/igt@i915_selftest@live@gt_lrc.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115605v2/bat-dg2-11/igt@i915_selftest@live@gt_lrc.html * igt@i915_selftest@live@requests: - bat-rpls-1: [PASS][9] -> [ABORT][10] ([i915#4983] / [i915#7911]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12914/bat-rpls-1/igt@i915_selftest@live@requests.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115605v2/bat-rpls-1/igt@i915_selftest@live@requests.html * igt@kms_pipe_crc_basic@read-crc: - bat-dg2-11: NOTRUN -> [SKIP][11] ([i915#5354]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115605v2/bat-dg2-11/igt@kms_pipe_crc_basic@read-crc.html #### Possible fixes #### * igt@gem_exec_suspend@basic-s0@smem: - bat-dg1-5: [FAIL][12] ([fdo#103375]) -> [PASS][13] +7 similar issues [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12914/bat-dg1-5/igt@gem_exec_suspend@basic-s0@smem.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115605v2/bat-dg1-5/igt@gem_exec_suspend@basic-s0@smem.html * igt@i915_selftest@live@gt_heartbeat: - fi-kbl-soraka: [DMESG-FAIL][14] ([i915#5334] / [i915#7872]) -> [PASS][15] [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12914/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115605v2/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html #### Warnings #### * igt@i915_selftest@live@slpc: - bat-rpls-2: [DMESG-FAIL][16] ([i915#6367] / [i915#7913] / [i915#7996]) -> [DMESG-FAIL][17] ([i915#6997] / [i915#7913]) [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12914/bat-rpls-2/igt@i915_selftest@live@slpc.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115605v2/bat-rpls-2/igt@i915_selftest@live@slpc.html [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375 [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983 [i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334 [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354 [i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367 [i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997 [i915#7609]: https://gitlab.freedesktop.org/drm/intel/issues/7609 [i915#7872]: https://gitlab.freedesktop.org/drm/intel/issues/7872 [i915#7911]: https://gitlab.freedesktop.org/drm/intel/issues/7911 [i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913 [i915#7996]: https://gitlab.freedesktop.org/drm/intel/issues/7996 Build changes ------------- * Linux: CI_DRM_12914 -> Patchwork_115605v2 CI-20190529: 20190529 CI_DRM_12914: 6e5f96153989e454041848f66a5227be9bd0bbc3 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_7218: 8036123f781059c54a31240756794b17bd3d15dc @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_115605v2: 6e5f96153989e454041848f66a5227be9bd0bbc3 @ git://anongit.freedesktop.org/gfx-ci/linux ### Linux commits 604a657923ac drm/i915/overlay: Remove redundant drm_rect_visible() use == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115605v2/index.html [-- Attachment #2: Type: text/html, Size: 6737 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] drm/i915/overlay: Remove redundant drm_rect_visible() use 2023-03-25 17:27 [Intel-gfx] [PATCH v2] drm/i915/overlay: Remove redundant drm_rect_visible() use Arthur Grillo 2023-03-25 18:10 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/overlay: Remove redundant drm_rect_visible() use (rev2) Patchwork @ 2024-03-04 11:13 ` Ville Syrjälä 1 sibling, 0 replies; 3+ messages in thread From: Ville Syrjälä @ 2024-03-04 11:13 UTC (permalink / raw) To: Arthur Grillo Cc: intel-gfx, dri-devel, mairacanal, andrealmeid, tales.aparecida, daniel, airlied, jani.nikula, joonas.lahtinen, rodrigo.vivi, tvrtko.ursulin, lucas.demarchi On Sat, Mar 25, 2023 at 02:27:19PM -0300, Arthur Grillo wrote: > The drm_rect_intersect() already returns if the intersection is visible > or not, so the use of drm_rect_visible() is duplicate. > > Signed-off-by: Arthur Grillo <arthurgrillo@riseup.net> Sorry, looks like I completely missed this. Now push the drm-intel-next. Thanks. > --- > v1->v2: https://lore.kernel.org/all/20230324142533.6357-1-arthurgrillo@riseup.net/ > - Split the if condition. > --- > drivers/gpu/drm/i915/display/intel_overlay.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_overlay.c b/drivers/gpu/drm/i915/display/intel_overlay.c > index c12bdca8da9b..d55153587cae 100644 > --- a/drivers/gpu/drm/i915/display/intel_overlay.c > +++ b/drivers/gpu/drm/i915/display/intel_overlay.c > @@ -966,10 +966,11 @@ static int check_overlay_dst(struct intel_overlay *overlay, > rec->dst_width, rec->dst_height); > > clipped = req; > - drm_rect_intersect(&clipped, &crtc_state->pipe_src); > > - if (!drm_rect_visible(&clipped) || > - !drm_rect_equals(&clipped, &req)) > + if (!drm_rect_intersect(&clipped, &crtc_state->pipe_src)) > + return -EINVAL; > + > + if (!drm_rect_equals(&clipped, &req)) > return -EINVAL; > > return 0; > -- > 2.39.2 -- Ville Syrjälä Intel ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-03-04 11:13 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-03-25 17:27 [Intel-gfx] [PATCH v2] drm/i915/overlay: Remove redundant drm_rect_visible() use Arthur Grillo 2023-03-25 18:10 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/overlay: Remove redundant drm_rect_visible() use (rev2) Patchwork 2024-03-04 11:13 ` [PATCH v2] drm/i915/overlay: Remove redundant drm_rect_visible() use Ville Syrjälä
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox