Re: [PATCH v5 1/5] drm/i915/display: Make intel_dp_aux_fw_sync_len available for PSR code

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Fri, Mar 08, 2024 at 01:00:35PM +0200, Jouni Högander wrote:
> ALPM AUX-Wake fast wake sync pulse count is needed by PSR to calculate IO
> wake and fast wake lines. Convert intel_dp_aux_fw_sync_len as non-static
> to make it available for PSR code.
> 
> v2: use int instead of u8
> 
> Signed-off-by: Jouni Högander <jouni.hogander@intel.com>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_dp_aux.c | 2 +-
>  drivers/gpu/drm/i915/display/intel_dp_aux.h | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c b/drivers/gpu/drm/i915/display/intel_dp_aux.c
> index 4f4a0e3b3114..7e69be100d90 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_aux.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c
> @@ -143,7 +143,7 @@ static int intel_dp_aux_sync_len(void)
>  	return precharge + preamble;
>  }
>  
> -static int intel_dp_aux_fw_sync_len(void)
> +int intel_dp_aux_fw_sync_len(void)
>  {
>  	int precharge = 10; /* 10-16 */
>  	int preamble = 8;
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.h b/drivers/gpu/drm/i915/display/intel_dp_aux.h
> index 8447f3e601fe..76d1f2ed7c2f 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_aux.h
> +++ b/drivers/gpu/drm/i915/display/intel_dp_aux.h
> @@ -20,5 +20,6 @@ enum aux_ch intel_dp_aux_ch(struct intel_encoder *encoder);
>  
>  void intel_dp_aux_irq_handler(struct drm_i915_private *i915);
>  u32 intel_dp_aux_pack(const u8 *src, int src_bytes);
> +int intel_dp_aux_fw_sync_len(void);
>  
>  #endif /* __INTEL_DP_AUX_H__ */
> -- 
> 2.34.1

-- 
Ville Syrjälä
Intel