Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@linux.intel.com>
To: Nirmoy Das <nirmoy.das@linux.intel.com>
Cc: Andi Shyti <andi.shyti@linux.intel.com>,
	intel-gfx <intel-gfx@lists.freedesktop.org>,
	Chris Wilson <chris.p.wilson@linux.intel.com>,
	Nirmoy Das <nirmoy.das@intel.com>,
	Lionel Landwerlin <lionel.g.landwerlin@intel.com>,
	Andi Shyti <andi.shyti@kernel.org>
Subject: Re: [PATCH v2 2/2] drm/i915/gem: Calculate object page offset for partial memory mapping
Date: Thu, 11 Apr 2024 16:26:28 +0200	[thread overview]
Message-ID: <ZhfzFM2Lh-OBAmw2@ashyti-mobl2.lan> (raw)
In-Reply-To: <fd76d2fc-7906-4adc-9413-598c5768f991@linux.intel.com>

Hi Nirmoy,

On Thu, Apr 11, 2024 at 04:18:41PM +0200, Nirmoy Das wrote:
> Hi Andi,
> 
> On 3/29/2024 5:39 PM, Andi Shyti wrote:
> > To enable partial memory mapping of GPU virtual memory, it's
> > necessary to introduce an offset to the object's memory
> > (obj->mm.pages) scatterlist. This adjustment compensates for
> > instances when userspace mappings do not start from the beginning
> > of the object.
> 
> I quickly tried https://gitlab.freedesktop.org/llandwerlin/igt-gpu-tools/-/tree/wip/gem_mmap_offset-partial-unmap?ref_type=heads
> that didn't work for GTT.
> 
> Please make sure a proper IGT test is available for this as this looks very
> risky change.

Yes, I have igt's ready and a new v3.

Thanks for trying this out.

Andi

  reply	other threads:[~2024-04-11 14:26 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-29 16:39 [PATCH v2 0/2] Add support for partial mapping Andi Shyti
2024-03-29 16:39 ` [PATCH v2 1/2] drm/i915/gem: Increment vma offset when mapping fb objects Andi Shyti
2024-03-29 16:39 ` [PATCH v2 2/2] drm/i915/gem: Calculate object page offset for partial memory mapping Andi Shyti
2024-04-11 14:18   ` Nirmoy Das
2024-04-11 14:26     ` Andi Shyti [this message]
2024-03-29 18:15 ` ✗ Fi.CI.CHECKPATCH: warning for Add support for partial mapping Patchwork
2024-03-29 18:28 ` ✓ Fi.CI.BAT: success " Patchwork
2024-03-30 20:11 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-04-09 15:12 ` ✗ Fi.CI.CHECKPATCH: warning for Add support for partial mapping (rev2) Patchwork
2024-04-09 15:23 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-04-11 15:24 ` ✗ Fi.CI.CHECKPATCH: warning for Add support for partial mapping (rev3) Patchwork
2024-04-11 15:31 ` ✓ Fi.CI.BAT: success " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2024-08-14 13:48 [PATCH v2 0/2] Allow partial memory mapping for cpu memory Andi Shyti
2024-08-14 13:48 ` [PATCH v2 2/2] drm/i915/gem: Calculate object page offset for partial memory mapping Andi Shyti
2024-08-14 13:48 ` Andi Shyti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZhfzFM2Lh-OBAmw2@ashyti-mobl2.lan \
    --to=andi.shyti@linux.intel.com \
    --cc=andi.shyti@kernel.org \
    --cc=chris.p.wilson@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=lionel.g.landwerlin@intel.com \
    --cc=nirmoy.das@intel.com \
    --cc=nirmoy.das@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox