From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org,
intel-gvt-dev@lists.freedesktop.org, rodrigo.vivi@intel.com
Subject: Re: [PATCH 6/6] drm/i915: remove unused HSW_STEREO_3D_CTL register macros
Date: Fri, 7 Jun 2024 14:35:55 +0300 [thread overview]
Message-ID: <ZmLwmxPly3lKZRhp@intel.com> (raw)
In-Reply-To: <991806d10ff182220c0b2f4681ee5a76a1b3ef8b.1717757337.git.jani.nikula@intel.com>
On Fri, Jun 07, 2024 at 01:51:29PM +0300, Jani Nikula wrote:
> Remove the unused HSW_STEREO_3D_CTL register macros.
I don't enjoy having to trawl the specs to find registers.
So I prefer to keep everything that isn't actually wrong.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/i915_reg.h | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index 2d834c32a3fa..127b113189ef 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -3385,12 +3385,6 @@
> #define ADL_TVIDEO_DIP_AS_SDP_DATA(dev_priv, trans, i) _MMIO_TRANS2(dev_priv, trans,\
> _ADL_VIDEO_DIP_AS_DATA_A + (i) * 4)
>
> -#define _HSW_STEREO_3D_CTL_A 0x70020
> -#define S3D_ENABLE (1 << 31)
> -#define _HSW_STEREO_3D_CTL_B 0x71020
> -
> -#define HSW_STEREO_3D_CTL(trans) _MMIO_PIPE2(dev_priv, trans, _HSW_STEREO_3D_CTL_A)
> -
> #define _PCH_TRANS_HTOTAL_B 0xe1000
> #define _PCH_TRANS_HBLANK_B 0xe1004
> #define _PCH_TRANS_HSYNC_B 0xe1008
> --
> 2.39.2
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2024-06-07 11:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-07 10:51 [PATCH 0/6] drm/i915: gvt register macro cleanups, unused macro removals Jani Nikula
2024-06-07 10:51 ` [PATCH 1/6] drm/i915/gvt: remove the unused end parameter from calc_index() Jani Nikula
2024-06-07 10:51 ` [PATCH 2/6] drm/i915/gvt: use proper i915_reg_t for calc_index() parameters Jani Nikula
2024-06-07 10:51 ` [PATCH 3/6] drm/i915/gvt: rename range variable to stride Jani Nikula
2024-06-07 10:51 ` [PATCH 4/6] drm/i915/gvt: do not use implict dev_priv in DSPSURF_TO_PIPE() Jani Nikula
2024-06-07 10:51 ` [PATCH 5/6] drm/i915: remove unused pipe/plane B register macros Jani Nikula
2024-06-07 11:34 ` Ville Syrjälä
2024-06-07 12:12 ` Jani Nikula
2024-06-07 13:42 ` Ville Syrjälä
2024-06-07 10:51 ` [PATCH 6/6] drm/i915: remove unused HSW_STEREO_3D_CTL " Jani Nikula
2024-06-07 11:35 ` Ville Syrjälä [this message]
2024-06-07 12:21 ` Jani Nikula
2024-06-07 13:41 ` Rodrigo Vivi
2024-06-07 13:44 ` Ville Syrjälä
2024-06-07 15:09 ` Jani Nikula
2024-06-07 13:32 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: gvt register macro cleanups, unused macro removals Patchwork
2024-06-07 13:40 ` ✓ Fi.CI.BAT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZmLwmxPly3lKZRhp@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox