Re: [PATCH 6/6] drm/i915: remove unused HSW_STEREO_3D_CTL register macros

[Jani Nikula <jani.nikula@intel.com>]

On Fri, 07 Jun 2024, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Fri, Jun 07, 2024 at 01:51:29PM +0300, Jani Nikula wrote:
>> Remove the unused HSW_STEREO_3D_CTL register macros.
>
> I don't enjoy having to trawl the specs to find registers.
> So I prefer to keep everything that isn't actually wrong.

Shall I apply this [1] then?

BR,
Jani.


[1] https://lore.kernel.org/r/76f980f5ed3638746c6b58dec7d0bd8c43a37987.1717514638.git.jani.nikula@intel.com


>
>> 
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>>  drivers/gpu/drm/i915/i915_reg.h | 6 ------
>>  1 file changed, 6 deletions(-)
>> 
>> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
>> index 2d834c32a3fa..127b113189ef 100644
>> --- a/drivers/gpu/drm/i915/i915_reg.h
>> +++ b/drivers/gpu/drm/i915/i915_reg.h
>> @@ -3385,12 +3385,6 @@
>>  #define ADL_TVIDEO_DIP_AS_SDP_DATA(dev_priv, trans, i)	_MMIO_TRANS2(dev_priv, trans,\
>>  							     _ADL_VIDEO_DIP_AS_DATA_A + (i) * 4)
>>  
>> -#define _HSW_STEREO_3D_CTL_A		0x70020
>> -#define   S3D_ENABLE			(1 << 31)
>> -#define _HSW_STEREO_3D_CTL_B		0x71020
>> -
>> -#define HSW_STEREO_3D_CTL(trans)	_MMIO_PIPE2(dev_priv, trans, _HSW_STEREO_3D_CTL_A)
>> -
>>  #define _PCH_TRANS_HTOTAL_B          0xe1000
>>  #define _PCH_TRANS_HBLANK_B          0xe1004
>>  #define _PCH_TRANS_HSYNC_B           0xe1008
>> -- 
>> 2.39.2

-- 
Jani Nikula, Intel