From: Andi Shyti <andi.shyti@linux.intel.com>
To: "Cavitt, Jonathan" <jonathan.cavitt@intel.com>
Cc: Andi Shyti <andi.shyti@linux.intel.com>,
intel-gfx <intel-gfx@lists.freedesktop.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Jann Horn <jannh@chromium.org>,
Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
"Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
Tvrtko Ursulin <tursulin@ursulin.net>,
Jann Horn <jannh@google.com>,
Chris Wilson <chris.p.wilson@linux.intel.com>,
"Niemiec, Krzysztof" <krzysztof.niemiec@intel.com>,
Andi Shyti <andi.shyti@kernel.org>,
"Auld, Matthew" <matthew.auld@intel.com>
Subject: Re: [PATCH 2/2] drm/i915/gem: Fix Virtual Memory mapping boundaries calculation
Date: Mon, 5 Aug 2024 11:39:55 +0200 [thread overview]
Message-ID: <ZrCd64EG4Ez83xZP@ashyti-mobl2.lan> (raw)
In-Reply-To: <CH0PR11MB54442106B9FB0353403DC109E5B32@CH0PR11MB5444.namprd11.prod.outlook.com>
Hi Jonathan,
...
> > + set_address_limits(area, vma, obj_offset, &start, &end);
> > +
> > + pfn = (ggtt->gmadr.start + i915_ggtt_offset(vma)) >> PAGE_SHIFT;
> > + pfn += (start - area->vm_start) >> PAGE_SHIFT;
> > + pfn += obj_offset - vma->gtt_view.partial.offset;
>
> I don't know how viable it would be, but maybe we could
> calculate pfn as a part of set_address_limits?
I was a bit afraid of dumping a massive parameter list...
> Just a suggestion, not blocking
... but now that I'm looking at it more carefully, it would be
just two parameters more (&pfn and ggtt->gmadr.start) and would
be cleaner. Will send a v2.
> Reviewed-by: Jonathan Cavitt <Jonathan.cavitt@intel.com>
> -Jonathan Cavitt
Thanks!
Andi
next prev parent reply other threads:[~2024-08-05 9:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-02 8:38 [PATCH 0/2] Fix mmap memory boundary calculation Andi Shyti
2024-08-02 8:38 ` [PATCH 1/2] drm/i915/gem: Adjust vma offset for framebuffer mmap offset Andi Shyti
2024-08-02 17:08 ` Cavitt, Jonathan
2024-08-05 21:12 ` Rodrigo Vivi
2024-08-02 8:38 ` [PATCH 2/2] drm/i915/gem: Fix Virtual Memory mapping boundaries calculation Andi Shyti
2024-08-02 8:43 ` Jann Horn
2024-08-02 17:25 ` Cavitt, Jonathan
2024-08-05 9:39 ` Andi Shyti [this message]
2024-08-02 9:04 ` ✗ Fi.CI.CHECKPATCH: warning for Fix mmap memory boundary calculation Patchwork
2024-08-02 9:20 ` ✓ Fi.CI.BAT: success " Patchwork
2024-08-02 19:57 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZrCd64EG4Ez83xZP@ashyti-mobl2.lan \
--to=andi.shyti@linux.intel.com \
--cc=andi.shyti@kernel.org \
--cc=chris.p.wilson@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=jannh@chromium.org \
--cc=jannh@google.com \
--cc=jonathan.cavitt@intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=krzysztof.niemiec@intel.com \
--cc=matthew.auld@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=tursulin@ursulin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox