Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@linux.intel.com>
To: Nitin Gote <nitin.r.gote@intel.com>
Cc: intel-gfx@lists.freedesktop.org, chris.p.wilson@intel.com,
	nirmoy.das@intel.com
Subject: Re: [PATCH v2] drm/i915/gt: Use ENGINE_TRACE for tracing.
Date: Thu, 24 Oct 2024 13:33:01 +0200	[thread overview]
Message-ID: <ZxowbeezaaS_v21C@ashyti-mobl2.lan> (raw)
In-Reply-To: <20241024103917.3231206-1-nitin.r.gote@intel.com>

Hi Nitin,

On Thu, Oct 24, 2024 at 04:09:17PM +0530, Nitin Gote wrote:
> There is ENGINE_TRACE() macro which introduce engine name
> with GEM tracing in i915. So, it will be good to use ENGINE_TRACE()
> over drm_err() drm_device based logging for engine debug log.
> 
> v2: Bit more specific in commit description (Andi)
> 
> Signed-off-by: Nitin Gote <nitin.r.gote@intel.com>

Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>

Thanks,
Andi

  reply	other threads:[~2024-10-24 11:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-24 10:39 [PATCH v2] drm/i915/gt: Use ENGINE_TRACE for tracing Nitin Gote
2024-10-24 11:33 ` Andi Shyti [this message]
2024-10-24 11:53 ` ✗ Fi.CI.BAT: failure for drm/i915/gt: Use ENGINE_TRACE for tracing. (rev3) Patchwork
2024-10-24 17:28 ` ✓ Fi.CI.BAT: success for drm/i915/gt: Use ENGINE_TRACE for tracing. (rev4) Patchwork
2024-10-24 18:40 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-10-24 18:58 ` [PATCH v2] drm/i915/gt: Use ENGINE_TRACE for tracing Matt Roper
2024-10-25  8:02   ` Tvrtko Ursulin
2024-10-25 11:21     ` Andi Shyti
2024-10-25 16:08       ` Tvrtko Ursulin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZxowbeezaaS_v21C@ashyti-mobl2.lan \
    --to=andi.shyti@linux.intel.com \
    --cc=chris.p.wilson@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=nirmoy.das@intel.com \
    --cc=nitin.r.gote@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox