Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] drm/i915/gt: Use ENGINE_TRACE for tracing.
@ 2024-10-24 10:39 Nitin Gote
  2024-10-24 11:33 ` Andi Shyti
                   ` (4 more replies)
  0 siblings, 5 replies; 9+ messages in thread
From: Nitin Gote @ 2024-10-24 10:39 UTC (permalink / raw)
  To: intel-gfx, andi.shyti; +Cc: chris.p.wilson, nirmoy.das, Nitin Gote

There is ENGINE_TRACE() macro which introduce engine name
with GEM tracing in i915. So, it will be good to use ENGINE_TRACE()
over drm_err() drm_device based logging for engine debug log.

v2: Bit more specific in commit description (Andi)

Signed-off-by: Nitin Gote <nitin.r.gote@intel.com>
---
 .../gpu/drm/i915/gt/intel_ring_submission.c   | 20 +++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_ring_submission.c b/drivers/gpu/drm/i915/gt/intel_ring_submission.c
index 32f3b52a183a..74d6a2b703ac 100644
--- a/drivers/gpu/drm/i915/gt/intel_ring_submission.c
+++ b/drivers/gpu/drm/i915/gt/intel_ring_submission.c
@@ -282,16 +282,16 @@ static int xcs_resume(struct intel_engine_cs *engine)
 	return 0;
 
 err:
-	drm_err(&engine->i915->drm,
-		"%s initialization failed; "
-		"ctl %08x (valid? %d) head %08x [%08x] tail %08x [%08x] start %08x [expected %08x]\n",
-		engine->name,
-		ENGINE_READ(engine, RING_CTL),
-		ENGINE_READ(engine, RING_CTL) & RING_VALID,
-		ENGINE_READ(engine, RING_HEAD), ring->head,
-		ENGINE_READ(engine, RING_TAIL), ring->tail,
-		ENGINE_READ(engine, RING_START),
-		i915_ggtt_offset(ring->vma));
+	ENGINE_TRACE(engine,
+		     "initialization failed; "
+		     "ctl %08x (valid? %d) head %08x [%08x] tail %08x [%08x] start %08x [expected %08x]\n",
+		     ENGINE_READ(engine, RING_CTL),
+		     ENGINE_READ(engine, RING_CTL) & RING_VALID,
+		     ENGINE_READ(engine, RING_HEAD), ring->head,
+		     ENGINE_READ(engine, RING_TAIL), ring->tail,
+		     ENGINE_READ(engine, RING_START),
+		     i915_ggtt_offset(ring->vma));
+	GEM_TRACE_DUMP();
 	return -EIO;
 }
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2024-10-25 16:08 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-24 10:39 [PATCH v2] drm/i915/gt: Use ENGINE_TRACE for tracing Nitin Gote
2024-10-24 11:33 ` Andi Shyti
2024-10-24 11:53 ` ✗ Fi.CI.BAT: failure for drm/i915/gt: Use ENGINE_TRACE for tracing. (rev3) Patchwork
2024-10-24 17:28 ` ✓ Fi.CI.BAT: success for drm/i915/gt: Use ENGINE_TRACE for tracing. (rev4) Patchwork
2024-10-24 18:40 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-10-24 18:58 ` [PATCH v2] drm/i915/gt: Use ENGINE_TRACE for tracing Matt Roper
2024-10-25  8:02   ` Tvrtko Ursulin
2024-10-25 11:21     ` Andi Shyti
2024-10-25 16:08       ` Tvrtko Ursulin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox