From: Imre Deak <imre.deak@intel.com>
To: Abel Vesa <abel.vesa@linaro.org>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Karol Herbst <kherbst@redhat.com>, Lyude Paul <lyude@redhat.com>,
Danilo Krummrich <dakr@redhat.com>,
Jani Nikula <jani.nikula@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Tvrtko Ursulin <tursulin@ursulin.net>,
Rob Clark <robdclark@gmail.com>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Johan Hovold <johan@kernel.org>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
nouveau@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
intel-xe@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
freedreno@lists.freedesktop.org
Subject: Re: [PATCH RFC 3/4] drm/i915/dp: Use the generic helper to control LTTPR transparent mode
Date: Thu, 31 Oct 2024 23:08:35 +0200 [thread overview]
Message-ID: <ZyPx0917iWCeLqVA@ideak-desk.fi.intel.com> (raw)
In-Reply-To: <20241031-drm-dp-msm-add-lttpr-transparent-mode-set-v1-3-cafbb9855f40@linaro.org>
On Thu, Oct 31, 2024 at 05:12:47PM +0200, Abel Vesa wrote:
> LTTPRs operating modes are defined by the DisplayPort standard and the
> generic framework now provides a helper to switch between them.
> So use the drm generic helper instead as it makes the code a bit cleaner.
>
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
Acked-by: Imre Deak <imre.deak@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp_link_training.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c b/drivers/gpu/drm/i915/display/intel_dp_link_training.c
> index 397cc4ebae526a416fcda9c74f57a8f9f803ce3b..0038608d29219ff1423a649089a38980e95b87e4 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_link_training.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_link_training.c
> @@ -118,7 +118,7 @@ intel_dp_set_lttpr_transparent_mode(struct intel_dp *intel_dp, bool enable)
> u8 val = enable ? DP_PHY_REPEATER_MODE_TRANSPARENT :
> DP_PHY_REPEATER_MODE_NON_TRANSPARENT;
>
> - if (drm_dp_dpcd_write(&intel_dp->aux, DP_PHY_REPEATER_MODE, &val, 1) != 1)
> + if (drm_dp_lttpr_set_transparent_mode(&intel_dp->aux, enable) != 1)
> return false;
>
> intel_dp->lttpr_common_caps[DP_PHY_REPEATER_MODE -
>
> --
> 2.34.1
>
next prev parent reply other threads:[~2024-10-31 21:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-31 15:12 [PATCH RFC 0/4] drm/dp: Rework LTTPR transparent mode handling and add support to msm driver Abel Vesa
2024-10-31 15:12 ` [PATCH RFC 1/4] drm/dp: Add helper to set LTTPRs in transparent mode Abel Vesa
2024-10-31 21:05 ` Imre Deak
2024-11-01 9:22 ` Jani Nikula
2024-11-01 13:43 ` Imre Deak
2024-11-01 20:12 ` Dmitry Baryshkov
2024-10-31 15:12 ` [PATCH RFC 2/4] drm/nouveau/dp: Use the generic helper to control LTTPR " Abel Vesa
2024-10-31 16:44 ` Dmitry Baryshkov
2024-12-11 9:08 ` Abel Vesa
2024-10-31 15:12 ` [PATCH RFC 3/4] drm/i915/dp: " Abel Vesa
2024-10-31 21:08 ` Imre Deak [this message]
2024-10-31 15:12 ` [PATCH RFC 4/4] drm/msm/dp: Add support for LTTPR handling Abel Vesa
2024-10-31 16:54 ` Dmitry Baryshkov
2024-12-11 9:08 ` Abel Vesa
2024-12-11 9:55 ` Dmitry Baryshkov
2024-12-11 10:52 ` Abel Vesa
2024-11-04 10:56 ` ✗ Fi.CI.SPARSE: warning for drm/dp: Rework LTTPR transparent mode handling and add support to msm driver Patchwork
2024-11-04 12:15 ` ✓ Fi.CI.BAT: success " Patchwork
2024-11-04 20:38 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZyPx0917iWCeLqVA@ideak-desk.fi.intel.com \
--to=imre.deak@intel.com \
--cc=abel.vesa@linaro.org \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=dakr@redhat.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=johan@kernel.org \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kherbst@redhat.com \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marijn.suijten@somainline.org \
--cc=mripard@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=quic_abhinavk@quicinc.com \
--cc=robdclark@gmail.com \
--cc=rodrigo.vivi@intel.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
--cc=tursulin@ursulin.net \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox