Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915: Enable PSR2 in next iteration of suspend-resume/S0ix cycling
@ 2019-11-24 16:04 Gaurav K Singh
  2019-11-24 16:04 ` [Intel-gfx] " Gaurav K Singh
                   ` (6 more replies)
  0 siblings, 7 replies; 11+ messages in thread
From: Gaurav K Singh @ 2019-11-24 16:04 UTC (permalink / raw)
  To: intel-gfx

In case of CRC mismatch, panel generates IRQ_HD and
PSR2 gets disabled by i915 driver. Due to this, PSR2 will
only be enabled back only if system is rebooted or cold boot.
So, in cases of suspend resume stress test and S0ix stress test,
when we encounter this CRC issue on a particular iteration,
once PSR2 is disabled,it remains disabled throughout all the
cycling iterations until the system is rebooted.

Keeping this in mind, many times users do not reboot their system and
they just keep lid off/on or suspend/resume. In these scenarios
in case of CRC issue, panel will become non-PSR2 which will eventually
drain out battery.

In order to fix this behavior, did not set the "sink_not_reliable" flag
to be true, so that intel_psr_compute_config() can pass in case of a
normal modeset which will lead to enabling PSR2 again in next iteration
of suspend/resume or S0ix cycle(without reboot).

Tested this patch and works fine on Gen9 Intel chromebook, PSR2 was
enabled back in next iteration, no other sideeffects observed.

Signed-off-by: Gaurav K Singh <gaurav.k.singh@intel.com>
---
 drivers/gpu/drm/i915/display/intel_psr.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index c1d133362b76..8465d0fc2214 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -1420,10 +1420,9 @@ void intel_psr_short_pulse(struct intel_dp *intel_dp)
 	if (val & ~errors)
 		DRM_ERROR("PSR_ERROR_STATUS unhandled errors %x\n",
 			  val & ~errors);
-	if (val & errors) {
+	if (val & errors)
 		intel_psr_disable_locked(intel_dp);
-		psr->sink_not_reliable = true;
-	}
+
 	/* clear status register */
 	drm_dp_dpcd_writeb(&intel_dp->aux, DP_PSR_ERROR_STATUS, val);
 exit:
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 11+ messages in thread
end of thread, other threads:[~2019-12-05  6:22 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-24 16:04 [PATCH] drm/i915: Enable PSR2 in next iteration of suspend-resume/S0ix cycling Gaurav K Singh
2019-11-24 16:04 ` [Intel-gfx] " Gaurav K Singh
2019-11-24 17:02 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-11-24 17:02   ` [Intel-gfx] " Patchwork
2019-11-24 21:35 ` ✓ Fi.CI.IGT: " Patchwork
2019-11-24 21:35   ` [Intel-gfx] " Patchwork
2019-11-25 21:59 ` [PATCH] " Souza, Jose
2019-11-25 21:59   ` [Intel-gfx] " Souza, Jose
2019-12-05  5:52 ` [Intel-gfx] [PATCH] [v2] drm/i915: Do not mark as sink as not reliable to PSR runtime errors Gaurav K Singh
2019-12-05  6:00 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Enable PSR2 in next iteration of suspend-resume/S0ix cycling (rev2) Patchwork
2019-12-05  6:22 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox