From: Oscar Mateo <oscar.mateo@intel.com>
To: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/4 v3] drm/i915/guc: Keep the ctx_pool_vaddr mapped, for easy access
Date: Fri, 3 Mar 2017 08:44:58 -0800 [thread overview]
Message-ID: <a26f786d-6553-7666-a888-2f4d1656343d@intel.com> (raw)
In-Reply-To: <1488451300.3102.1.camel@linux.intel.com>
On 03/02/2017 02:41 AM, Joonas Lahtinen wrote:
> On pe, 2017-02-24 at 06:01 -0800, Oscar Mateo wrote:
>> The GuC descriptor is big in size. If we use a local definition of
>> guc_desc we have a chance to overflow stack, so avoid it.
>>
>> Also, Chris abhors scatterlists :)
>>
>> v2: Rebased, helper function to retrieve the context descriptor,
>> s/ctx_pool_vma/ctx_pool/
>>
>> v3: Zero out guc_context_desc before initialization
>>
>> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
>> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>> Signed-off-by: Oscar Mateo <oscar.mateo@intel.com>
>> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>
> The first three patches would be rather ready for merging, right?
>
> Regards, Joonas
Hmmmm... not really :(
They sit on top of your patch with the reworked doorbells, so there will
be merge conflicts. Also, your comment regarding the log extras really
belongs to the third patch (and while playing with GuC I have found
another problem with this third patch).
I believe I'll meet you IRL/AFK, so we can agree on a merge strategy
then :)
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-03-04 0:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-24 14:01 [PATCH 0/4] Various improvements around the GuC topic Oscar Mateo
2017-02-24 14:01 ` [PATCH 1/4 v3] drm/i915/guc: Keep the ctx_pool_vaddr mapped, for easy access Oscar Mateo
2017-03-02 10:41 ` Joonas Lahtinen
2017-03-03 16:44 ` Oscar Mateo [this message]
2017-02-24 14:01 ` [PATCH 2/4 v2] drm/i915/guc: Add onion teardown to the GuC setup Oscar Mateo
2017-03-01 12:32 ` Joonas Lahtinen
2017-02-24 14:01 ` [PATCH 3/4] drm/i915/guc: s/ads_vma/addon Oscar Mateo
2017-02-28 8:04 ` Joonas Lahtinen
2017-03-07 15:07 ` Michal Wajdeczko
2017-03-08 13:48 ` Oscar Mateo
2017-02-24 14:01 ` [PATCH 4/4] drm/i915/guc: Break out the GuC log "extras" Oscar Mateo
2017-03-01 12:37 ` Joonas Lahtinen
2017-03-03 16:47 ` Oscar Mateo
2017-03-07 15:13 ` Michal Wajdeczko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a26f786d-6553-7666-a888-2f4d1656343d@intel.com \
--to=oscar.mateo@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox