From: Oscar Mateo <oscar.mateo@intel.com>
To: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 4/4] drm/i915/guc: Break out the GuC log "extras"
Date: Fri, 3 Mar 2017 08:47:44 -0800 [thread overview]
Message-ID: <f90e0761-4350-b694-3d2f-dcf281cfaedd@intel.com> (raw)
In-Reply-To: <1488371841.3122.7.camel@linux.intel.com>
On 03/01/2017 04:37 AM, Joonas Lahtinen wrote:
> On pe, 2017-02-24 at 06:01 -0800, Oscar Mateo wrote:
>> When initializing the GuC log struct, there is an object we need to
>> allocate always, since the GuC needs its address at fw load time.
>> The rest are "extras", in the sense that we only need them if we
>> actually enable GuC logging. Make that distinction explicit by
>> subdividing further the intel_guc_log struct.
>>
>> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
>> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>> Signed-off-by: Oscar Mateo <oscar.mateo@intel.com>
> I'm not sure about calling them extras. How about runtime?
Agree, runtime sounds much better. I'll refresh the patch.
> Also, I'm not quite sure if the abstractions are currently correct
> (despite the names), logging seems to control overall guc interrups,
> for example (i915_guc_log_unregister func).
>
Hmmm... GuC interrupts are a mess, I agree (for the moment the only
Guc2Host interrupts we handle are log-related ones, so I imagine that's
the reason, but this could very easily change in the future). I'll try
to fix this either as part of patch 3 or in a separate patch.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-03-04 0:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-24 14:01 [PATCH 0/4] Various improvements around the GuC topic Oscar Mateo
2017-02-24 14:01 ` [PATCH 1/4 v3] drm/i915/guc: Keep the ctx_pool_vaddr mapped, for easy access Oscar Mateo
2017-03-02 10:41 ` Joonas Lahtinen
2017-03-03 16:44 ` Oscar Mateo
2017-02-24 14:01 ` [PATCH 2/4 v2] drm/i915/guc: Add onion teardown to the GuC setup Oscar Mateo
2017-03-01 12:32 ` Joonas Lahtinen
2017-02-24 14:01 ` [PATCH 3/4] drm/i915/guc: s/ads_vma/addon Oscar Mateo
2017-02-28 8:04 ` Joonas Lahtinen
2017-03-07 15:07 ` Michal Wajdeczko
2017-03-08 13:48 ` Oscar Mateo
2017-02-24 14:01 ` [PATCH 4/4] drm/i915/guc: Break out the GuC log "extras" Oscar Mateo
2017-03-01 12:37 ` Joonas Lahtinen
2017-03-03 16:47 ` Oscar Mateo [this message]
2017-03-07 15:13 ` Michal Wajdeczko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f90e0761-4350-b694-3d2f-dcf281cfaedd@intel.com \
--to=oscar.mateo@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox