Re: [Intel-gfx] [PATCH] drm/i915: Remove unwanted pointer unpacking

[Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>]

On 27/09/2022 06:40, Niranjana Vishwanathapura wrote:
> In await_fence_array(), unpacking syncobj pointer is not needed.
> Remove it.
> 
> Signed-off-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
> ---
>   drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 5 -----
>   1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> index cd75b0ca2555..8f5796cf9c9c 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> @@ -2954,11 +2954,6 @@ await_fence_array(struct i915_execbuffer *eb,
>   	int err;
>   
>   	for (n = 0; n < eb->num_fences; n++) {
> -		struct drm_syncobj *syncobj;
> -		unsigned int flags;
> -
> -		syncobj = ptr_unpack_bits(eb->fences[n].syncobj, &flags, 2);
> -

Seems it was left hanging unused since 13149e8bafc4 ("drm/i915: add 
syncobj timeline support").

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko

>   		if (!eb->fences[n].dma_fence)
>   			continue;
>