Re: [PATCH 5/5] drm/i915/vrr: Use optimized guardband whenever VRR TG is active

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Fri, Oct 17, 2025 at 06:05:04PM +0530, Ankit Nautiyal wrote:
> Currently the guardband is optimized only for platforms where the
> VRR timing generator is always ON.
> 
> Extend the usage of optimized guardband to all VRR supporting platforms.
> 
> v2: Drop check for `crtc_state->vrr.enable` and just return true
>     unconditionally from intel_vrr_use_optimized_guardband(). (Ville)
> 
> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_vrr.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c b/drivers/gpu/drm/i915/display/intel_vrr.c
> index 3da84a247193..92fb72b56f16 100644
> --- a/drivers/gpu/drm/i915/display/intel_vrr.c
> +++ b/drivers/gpu/drm/i915/display/intel_vrr.c
> @@ -468,8 +468,6 @@ int intel_vrr_compute_optimized_guardband(struct intel_crtc_state *crtc_state)
>  
>  static bool intel_vrr_use_optimized_guardband(const struct intel_crtc_state *crtc_state)
>  {
> -	struct intel_display *display = to_intel_display(crtc_state);
> -
>  	/*
>  	 * #TODO: Enable optimized guardband for HDMI
>  	 * For HDMI lot of infoframes are transmitted a line or two after vsync.
> @@ -479,7 +477,7 @@ static bool intel_vrr_use_optimized_guardband(const struct intel_crtc_state *crt
>  	if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI))
>  		return false;
>  
> -	return intel_vrr_always_use_vrr_tg(display);
> +	return true;
>  }
>  
>  void intel_vrr_compute_guardband(struct intel_crtc_state *crtc_state)
> -- 
> 2.45.2

-- 
Ville Syrjälä
Intel