Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: <intel-gfx@lists.freedesktop.org>
Cc: Ben Dooks <ben.dooks@codethink.co.uk>
Subject: Re: [CI] drm/i915/guc: make 'guc_hw_reg_state' static as it isn't exported
Date: Fri, 9 Jan 2026 11:13:55 -0500	[thread overview]
Message-ID: <aWEpQ094QyvO2xCk@intel.com> (raw)
In-Reply-To: <20260108201202.59250-2-rodrigo.vivi@intel.com>

On Thu, Jan 08, 2026 at 03:12:03PM -0500, Rodrigo Vivi wrote:
> From: Ben Dooks <ben.dooks@codethink.co.uk>
> 
> The guc_hw_reg_state array is not exported, so make it static.
> Fixes the following sparse warning:
> drivers/gpu/drm/i915/i915_gpu_error.c:692:3: warning: symbol 'guc_hw_reg_state' was not declared. Should it be static?
> 
> Fixes: ba391a102ec11 ("drm/i915/guc: Include the GuC registers in the error state")

next time, consider also Cc'ing the original author to speed up things:

Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

pushing right now to drm-intel-next

> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  drivers/gpu/drm/i915/i915_gpu_error.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
> index 7582ef34bf3f..303d8d9b7775 100644
> --- a/drivers/gpu/drm/i915/i915_gpu_error.c
> +++ b/drivers/gpu/drm/i915/i915_gpu_error.c
> @@ -686,7 +686,7 @@ static void err_print_guc_ctb(struct drm_i915_error_state_buf *m,
>  }
>  
>  /* This list includes registers that are useful in debugging GuC hangs. */
> -const struct {
> +static const struct {
>  	u32 start;
>  	u32 count;
>  } guc_hw_reg_state[] = {
> -- 
> 2.52.0
> 

      parent reply	other threads:[~2026-01-09 16:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-08 20:12 [CI] drm/i915/guc: make 'guc_hw_reg_state' static as it isn't exported Rodrigo Vivi
2026-01-08 23:11 ` ✓ i915.CI.BAT: success for drm/i915/guc: make 'guc_hw_reg_state' static as it isn't exported (rev2) Patchwork
2026-01-09  2:19 ` ✗ i915.CI.Full: failure " Patchwork
2026-01-09 16:13 ` Rodrigo Vivi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aWEpQ094QyvO2xCk@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=ben.dooks@codethink.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox