Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [CI] drm/i915/guc: make 'guc_hw_reg_state' static as it isn't exported
@ 2026-01-08 20:12 Rodrigo Vivi
  2026-01-08 23:11 ` ✓ i915.CI.BAT: success for drm/i915/guc: make 'guc_hw_reg_state' static as it isn't exported (rev2) Patchwork
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Rodrigo Vivi @ 2026-01-08 20:12 UTC (permalink / raw)
  To: intel-gfx; +Cc: Ben Dooks, Rodrigo Vivi

From: Ben Dooks <ben.dooks@codethink.co.uk>

The guc_hw_reg_state array is not exported, so make it static.
Fixes the following sparse warning:
drivers/gpu/drm/i915/i915_gpu_error.c:692:3: warning: symbol 'guc_hw_reg_state' was not declared. Should it be static?

Fixes: ba391a102ec11 ("drm/i915/guc: Include the GuC registers in the error state")
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/i915/i915_gpu_error.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
index 7582ef34bf3f..303d8d9b7775 100644
--- a/drivers/gpu/drm/i915/i915_gpu_error.c
+++ b/drivers/gpu/drm/i915/i915_gpu_error.c
@@ -686,7 +686,7 @@ static void err_print_guc_ctb(struct drm_i915_error_state_buf *m,
 }
 
 /* This list includes registers that are useful in debugging GuC hangs. */
-const struct {
+static const struct {
 	u32 start;
 	u32 count;
 } guc_hw_reg_state[] = {
-- 
2.52.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-01-09 16:14 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-08 20:12 [CI] drm/i915/guc: make 'guc_hw_reg_state' static as it isn't exported Rodrigo Vivi
2026-01-08 23:11 ` ✓ i915.CI.BAT: success for drm/i915/guc: make 'guc_hw_reg_state' static as it isn't exported (rev2) Patchwork
2026-01-09  2:19 ` ✗ i915.CI.Full: failure " Patchwork
2026-01-09 16:13 ` [CI] drm/i915/guc: make 'guc_hw_reg_state' static as it isn't exported Rodrigo Vivi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox