Re: [PATCH 1/2] drm/i915/dp: Make intel_dp_can_join() static

[Imre Deak <imre.deak@intel.com>]

On Thu, Feb 05, 2026 at 02:06:22PM +0530, Ankit Nautiyal wrote:
> intel_dp_can_join() was previously exposed in intel_dp.h, but after the
> recent joiner refactor it is only used internally via
> intel_dp_joiner_candidate_valid(). It no longer needs external
> visibility, so make it static and drop the prototype from intel_dp.h.
> 
> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>

Reviewed-by: Imre Deak <imre.deak@intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_dp.c | 1 +
>  drivers/gpu/drm/i915/display/intel_dp.h | 2 --
>  2 files changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index e2fd01d1a1e4..4f5b89f80e55 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -1396,6 +1396,7 @@ bool intel_dp_has_dsc(const struct intel_connector *connector)
>  	return true;
>  }
>  
> +static
>  bool intel_dp_can_join(struct intel_display *display,
>  		       int num_joined_pipes)
>  {
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.h b/drivers/gpu/drm/i915/display/intel_dp.h
> index ff527b351de0..cbd7fcd3789f 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.h
> +++ b/drivers/gpu/drm/i915/display/intel_dp.h
> @@ -222,8 +222,6 @@ int intel_dp_compute_config_late(struct intel_encoder *encoder,
>  int intel_dp_sdp_min_guardband(const struct intel_crtc_state *crtc_state,
>  			       bool assume_all_enabled);
>  int intel_dp_max_hdisplay_per_pipe(struct intel_display *display);
> -bool intel_dp_can_join(struct intel_display *display,
> -		       int num_joined_pipes);
>  bool intel_dp_dotclk_valid(struct intel_display *display,
>  			   int target_clock,
>  			   int htotal,
> -- 
> 2.45.2
>