From: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 1/2] drm/i915/guc: fix GuC suspend/resume
Date: Tue, 27 Nov 2018 11:34:46 -0800 [thread overview]
Message-ID: <ad7d4c57-0075-e9e8-6874-6e3c1b060a8c@intel.com> (raw)
In-Reply-To: <op.zs3cv9onxaggs7@mwajdecz-mobl1.ger.corp.intel.com>
On 26/11/2018 06:51, Michal Wajdeczko wrote:
> On Wed, 17 Oct 2018 00:46:47 +0200, Daniele Ceraolo Spurio
> <daniele.ceraolospurio@intel.com> wrote:
>
> /snip/
>
>> diff --git a/drivers/gpu/drm/i915/intel_guc_fwif.h
>> b/drivers/gpu/drm/i915/intel_guc_fwif.h
>> index 8382d591c784..1a853cc627e3 100644
>> --- a/drivers/gpu/drm/i915/intel_guc_fwif.h
>> +++ b/drivers/gpu/drm/i915/intel_guc_fwif.h
>> @@ -687,6 +687,13 @@ enum intel_guc_report_status {
>> INTEL_GUC_REPORT_STATUS_COMPLETE = 0x4,
>> };
>> +enum intel_guc_sleep_state_status {
>> + INTEL_GUC_SLEEP_STATE_SUCCESS = 0x0,
>> + INTEL_GUC_SLEEP_STATE_PREEMPT_TO_IDLE_FAILED = 0x1,
>> + INTEL_GUC_SLEEP_STATE_ENGINE_RESET_FAILED = 0x2
>> +};
>
> btw, it used to be 0,1,2 but from some time fw defines above as:
>
> INTEL_GUC_SLEEP_STATE_SUCCESS = 0x1,
> INTEL_GUC_SLEEP_STATE_PREEMPT_TO_IDLE_FAILED = 0x2,
> INTEL_GUC_SLEEP_STATE_ENGINE_RESET_FAILED = 0x3,
>
> Michal
Yeah, I think I had already mentioned in some reply that the newer
firmware does suspend/resume differently, but I haven't looked at the
details. I'm not even sure if polling the register will still be required.
Daniele
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-11-27 19:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 22:46 [PATCH v2 1/2] drm/i915/guc: fix GuC suspend/resume Daniele Ceraolo Spurio
2018-10-16 22:46 ` [PATCH v2 2/2] HAX enable GuC for CI Daniele Ceraolo Spurio
2018-10-16 23:28 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/2] drm/i915/guc: fix GuC suspend/resume Patchwork
2018-10-16 23:53 ` ✗ Fi.CI.BAT: failure " Patchwork
2018-10-17 16:40 ` [PATCH v2 1/2] " Michal Wajdeczko
2018-10-17 20:32 ` Chris Wilson
2018-11-26 14:51 ` Michal Wajdeczko
2018-11-27 19:34 ` Daniele Ceraolo Spurio [this message]
2018-11-28 19:55 ` Daniele Ceraolo Spurio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad7d4c57-0075-e9e8-6874-6e3c1b060a8c@intel.com \
--to=daniele.ceraolospurio@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=michal.wajdeczko@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox