Re: [Intel-gfx] [PATCH v7 6/8] drm/i915/uapi/pxp: Fix UAPI spec comments and add GET_PARAM for PXP

["Teres Alexis, Alan Previn" <alan.previn.teres.alexis@intel.com>]

Hi Lionel, does this patch work for you?

On Mon, 2023-04-10 at 10:22 -0700, Ceraolo Spurio, Daniele wrote:
> On 4/6/2023 10:44 AM, Alan Previn wrote:
alan:snip

> > +/*
> > + * Query the status of PXP support in i915.
> > + *
> > + * The query can fail in the following scenarios with the listed error codes:
> > + *  -ENODEV = PXP support is not available on the GPU device or in the kernel
> > + *            due to missing component drivers or kernel configs.
> > + * If the IOCTL is successful, the returned parameter will be set to one of the
> > + * following values:
> > + *   0 = PXP support maybe available but underlying SOC fusing, BIOS or firmware
> > + *       configuration is unknown and a PXP-context-creation would be required
> > + *       for final verification of feature availibility.
> 
> Would it be useful to add:
> 
> 1 = PXP support is available
> 
> And start returning that after we've successfully created our first 
> session? Not sure if userspace would use this though, since they still 
> need to handle the 0 case anyway.
> I'm also ok with this patch as-is, as long as you get an ack from the 
> userspace drivers for this interface behavior:
> 
> Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> 
> Daniele

alan:snip