From: Chris Wilson <chris@chris-wilson.co.uk>
To: Keith Packard <keithp@keithp.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/lvds: Always use the presence pin for LVDS on PCH
Date: Thu, 09 Feb 2012 17:33:23 +0000 [thread overview]
Message-ID: <aefc95$34r1in@orsmga001.jf.intel.com> (raw)
In-Reply-To: <86pqdoc4lc.fsf@sumi.keithp.com>
On Thu, 09 Feb 2012 09:13:35 -0800, Keith Packard <keithp@keithp.com> wrote:
> <#part sign=pgpmime>
> On Thu, 9 Feb 2012 09:35:53 +0000, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > With the introduction of the PCH, we gained an LVDS presence pin but we
> > continued to use the existing logic that asserted that LVDS was only
> > supported on certain mobile chipsets. However, there are desktop
> > IronLake systems with LVDS attached which we fail to detect. So for PCH,
> > trust the LVDS presence pin and quirk all the lying manufacturers.
>
> Uh. I don't see where this is using the LVDS presence pin. Am I just
> missing something?
That code already existed in intel_lvds_init():
if (HAS_PCH_SPLIT(dev)) {
if (I915_READ(PCH_LVDS) & LVDS_DETECTED) == 0)
return false
...
}
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-02-09 17:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-09 9:35 [PATCH] drm/i915/lvds: Always use the presence pin for LVDS on PCH Chris Wilson
2012-02-09 17:13 ` Keith Packard
2012-02-09 17:33 ` Chris Wilson [this message]
2012-02-09 18:23 ` Keith Packard
2012-02-15 15:47 ` Daniel Vetter
2012-02-09 18:19 ` Eugeni Dodonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='aefc95$34r1in@orsmga001.jf.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=keithp@keithp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox