From: Daniel Vetter <daniel@ffwll.ch>
To: Keith Packard <keithp@keithp.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/lvds: Always use the presence pin for LVDS on PCH
Date: Wed, 15 Feb 2012 16:47:13 +0100 [thread overview]
Message-ID: <20120215154713.GA26578@phenom.ffwll.local> (raw)
In-Reply-To: <86k43vdfx2.fsf@sumi.keithp.com>
On Thu, Feb 09, 2012 at 10:23:37AM -0800, Keith Packard wrote:
> <#part sign=pgpmime>
> On Thu, 09 Feb 2012 17:33:23 +0000, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> >
> > That code already existed in intel_lvds_init():
> > if (HAS_PCH_SPLIT(dev)) {
> > if (I915_READ(PCH_LVDS) & LVDS_DETECTED) == 0)
> > return false
> > ...
> > }
>
> Tricky. Do we have any idea how reliable this pin is? We've had such bad
> luck in the past...
It's imo guaranteed to blow up somewhere, but we already have the no_lvds
quirk infrastructure in place for that. Bug reporter confirmed that this
patch works for him, so I've decided to include this into the current
-next cycle to get feedback (and no_lvds quirk patches) as early as
possible.
Thanks for the patch and review.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
next prev parent reply other threads:[~2012-02-15 15:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-09 9:35 [PATCH] drm/i915/lvds: Always use the presence pin for LVDS on PCH Chris Wilson
2012-02-09 17:13 ` Keith Packard
2012-02-09 17:33 ` Chris Wilson
2012-02-09 18:23 ` Keith Packard
2012-02-15 15:47 ` Daniel Vetter [this message]
2012-02-09 18:19 ` Eugeni Dodonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120215154713.GA26578@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=keithp@keithp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox