From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Cc: Eugeni Dodonov <eugeni.dodonov@intel.com>
Subject: Re: [PATCH 1/1] drm/i915: allow to select rc6 modes via kernel parameter
Date: Sat, 11 Feb 2012 19:57:02 +0000 [thread overview]
Message-ID: <aefc95$35gmtv@orsmga001.jf.intel.com> (raw)
In-Reply-To: <1328988212-5356-1-git-send-email-eugeni.dodonov@intel.com>
On Sat, 11 Feb 2012 17:23:32 -0200, Eugeni Dodonov <eugeni.dodonov@intel.com> wrote:
> This allows to select which rc6 modes are to be used via kernel parameter,
> via a bitmask parameter. E.g.:
>
> - to enable rc6, i915_enable_rc6=1
> - to enable rc6 and deep rc6, i915_enable_rc6=3
> - to enable rc6 and deepest rc6, use i915_enable_rc6=5
> - to enable rc6, deep and deepest rc6, use i915_enable_rc6=7
>
> Please keep in mind that the deepest RC6 state really should NOT be used
> by default, as it could potentially worsen the issues with deep RC6. So do
> enable it only when you know what you are doing. However, having it around
> could help solving possible future rc6-related issues and their debugging
> on user machines.
>
> Note that this changes behavior - previously, value of 1 would enable both
> RC6 and deep RC6. Now it should only enable RC6 and deep/deepest RC6
> stages must be enabled manually.
>
> v2: address Chris Wilson comments and clean up the code.
Wow, that comment is superb! Definitely a standard we should try to
achieve everywhere.
> Signed-off-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
References: https://bugs.freedesktop.org/show_bug.cgi?id=42579
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-02-11 19:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-11 12:34 [PATCH 0/2] Another chapter in RC6 saga Eugeni Dodonov
2012-02-11 12:34 ` [PATCH 1/2] drm/i915: allow to select rc6 modes via kernel parameter Eugeni Dodonov
2012-02-11 12:56 ` Chris Wilson
2012-02-11 18:13 ` Kai Krakow
2012-02-11 19:09 ` Eugeni Dodonov
2012-02-11 19:23 ` [PATCH 1/1] " Eugeni Dodonov
2012-02-11 19:57 ` Chris Wilson [this message]
2012-02-12 20:52 ` Ben Widawsky
2012-02-12 23:16 ` Eugeni Dodonov
2012-02-13 8:33 ` Ben Widawsky
2012-02-13 11:37 ` Eugeni Dodonov
2012-02-11 12:34 ` [PATCH 2/2] drm/i915: enable plain RC6 on Sandy Bridge by default Eugeni Dodonov
2012-02-11 12:59 ` Chris Wilson
2012-02-11 19:24 ` Eugeni Dodonov
2012-02-12 10:16 ` Kai Krakow
2012-02-12 20:10 ` Keith Packard
2012-02-13 0:34 ` Eugeni Dodonov
2012-02-14 4:01 ` Keith Packard
-- strict thread matches above, loose matches on Subject: below --
2012-02-08 21:04 For the ones affected by RC6 issues Eugeni Dodonov
2012-02-08 21:04 ` [PATCH 1/1] drm/i915: allow to select rc6 modes via kernel parameter Eugeni Dodonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='aefc95$35gmtv@orsmga001.jf.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=eugeni.dodonov@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox