Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@linux.intel.com>
To: Krzysztof Karas <krzysztof.karas@intel.com>
Cc: intel-gfx@lists.freedesktop.org,
	Andi Shyti <andi.shyti@linux.intel.com>,
	Sebastian Brzezinka <sebastian.brzezinka@intel.com>,
	Krzysztof Niemiec <krzysztof.niemiec@intel.com>,
	Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
Subject: Re: [PATCH v10 1/2] drm/i915/selftests: Prevent userspace mapping invalidation
Date: Fri, 8 May 2026 11:41:14 +0200	[thread overview]
Message-ID: <af2vusysmtwp2bzU@ashyti-mobl2.lan> (raw)
In-Reply-To: <20260508080214.1979686-2-krzysztof.karas@intel.com>

Hi Krzysztof,

...

> +static struct mm_struct *
> +get_mm(int u_pid_nr)

This fits in one line, no need to break it.

I'm not a big fan of the name "get_mm()". It's too generic and
sounds like a library function.

With the two above changed:

Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>

On the other hand I don't want to ask for v11: if it's OK with
you I would bring the lines together and change the function to
get_selftest_mm() before merging.

Let me know,
Andi

  parent reply	other threads:[~2026-05-08  9:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-08  8:02 [PATCH v10 0/2] drm/i915/selftests: Use safe userspace memory for mappings Krzysztof Karas
2026-05-08  8:02 ` [PATCH v10 1/2] drm/i915/selftests: Prevent userspace mapping invalidation Krzysztof Karas
2026-05-08  8:53   ` Janusz Krzysztofik
2026-05-08  9:15   ` Sebastian Brzezinka
2026-05-08  9:41   ` Andi Shyti [this message]
2026-05-11  8:34     ` Krzysztof Karas
2026-05-08  9:42   ` Michał Grzelak
2026-05-08  8:02 ` [PATCH v10 2/2] drm/i915/selftests: Run vma tests only if current->mm is present Krzysztof Karas
2026-05-08  9:44   ` Michał Grzelak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=af2vusysmtwp2bzU@ashyti-mobl2.lan \
    --to=andi.shyti@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=janusz.krzysztofik@linux.intel.com \
    --cc=krzysztof.karas@intel.com \
    --cc=krzysztof.niemiec@intel.com \
    --cc=sebastian.brzezinka@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox