From: Chris Wilson <chris@chris-wilson.co.uk>
To: Mika Kuoppala <mika.kuoppala@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Clear FORCEWAKE when taking over from BIOS
Date: Fri, 19 Oct 2012 09:02:10 +0100 [thread overview]
Message-ID: <b94cdc$70ukpd@fmsmga001.fm.intel.com> (raw)
In-Reply-To: <87bofzylh2.fsf@gaia.fi.intel.com>
On Fri, 19 Oct 2012 10:22:49 +0300, Mika Kuoppala <mika.kuoppala@linux.intel.com> wrote:
> Would it be possible to call in here:
>
> if (HAS_FORCE_WAKE(dev))
> dev_priv->gt.force_wake_put(dev_priv);
>
> and get rid of the per gen forcewake resets?
No. Perhaps I would have better gone with intel_gt_sanitize(), as the
purpose is not to undo our own settings of the forcewake but undo that
of nefarious foreign interests such as the BIOS. As such we need to
explicitly clear the register rather than clear a bit.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-10-19 8:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-17 6:17 [drm:__gen6_gt_force_wake_mt_get] *ERROR* Timed out waiting for forcewake old ack to clear.? Oleksij Rempel
2012-10-17 22:44 ` Ben Widawsky
2012-10-17 22:58 ` Chris Wilson
2012-10-18 10:46 ` [PATCH] drm/i915: Clear FORCEWAKE when taking over from BIOS Chris Wilson
2012-10-19 7:22 ` Mika Kuoppala
2012-10-19 8:02 ` Chris Wilson [this message]
2012-10-19 9:10 ` Mika Kuoppala
2012-10-19 16:45 ` Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='b94cdc$70ukpd@fmsmga001.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox