public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Jesse Barnes <jbarnes@virtuousgeek.org>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 4/4] drm/i915: don't rewrite the GTT on resume v4
Date: Fri, 02 Nov 2012 17:13:56 +0000	[thread overview]
Message-ID: <b94cdc$76lsmd@fmsmga001.fm.intel.com> (raw)
In-Reply-To: <1351874380-7861-4-git-send-email-jbarnes@virtuousgeek.org>

On Fri,  2 Nov 2012 09:39:40 -0700, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> The BIOS shouldn't be touching this memory across suspend/resume, so
> just leave it alone.  This saves us ~6ms on resume on my T420 (retested
> with write combined PTEs).
> 
> v2: change gtt restore default on pre-gen4 (Chris)
>     move needs_gtt_restore flag into dev_priv
> v3: make sure we restore GTT on resume from hibernate (Daniel)
>     use opregion support as the cutoff for restore from resume (Chris)
> v4: use a better check for opregion (Chris)
> 
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>

Ignoring the mistake in patch 2,
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

  reply	other threads:[~2012-11-02 17:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-02 16:39 [PATCH 1/4] drm/i915: don't block resume on fb console resume v2 Jesse Barnes
2012-11-02 16:39 ` [PATCH 2/4] drm/i915: put ring frequency and turbo setup into a work queue v4 Jesse Barnes
2012-11-02 16:39 ` [PATCH 3/4] drm/i915: protect RPS/RC6 related accesses (including PCU) with a new mutex Jesse Barnes
2012-11-02 16:39 ` [PATCH 4/4] drm/i915: don't rewrite the GTT on resume v4 Jesse Barnes
2012-11-02 17:13   ` Chris Wilson [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-11-02 18:13 [PATCH 1/4] drm/i915: don't block resume on fb console resume v2 Jesse Barnes
2012-11-02 18:14 ` [PATCH 4/4] drm/i915: don't rewrite the GTT on resume v4 Jesse Barnes
2012-11-02 22:55   ` Daniel Vetter
2012-11-02 23:28     ` Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='b94cdc$76lsmd@fmsmga001.fm.intel.com' \
    --to=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jbarnes@virtuousgeek.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox