From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 4/4] drm/i915: don't rewrite the GTT on resume v4
Date: Fri, 2 Nov 2012 16:28:31 -0700 [thread overview]
Message-ID: <20121102162831.400a9e30@jbarnes-desktop> (raw)
In-Reply-To: <20121102225504.GN5755@phenom.ffwll.local>
On Fri, 2 Nov 2012 23:55:04 +0100
Daniel Vetter <daniel@ffwll.ch> wrote:
> On Fri, Nov 02, 2012 at 11:14:02AM -0700, Jesse Barnes wrote:
> > The BIOS shouldn't be touching this memory across suspend/resume, so
> > just leave it alone. This saves us ~6ms on resume on my T420 (retested
> > with write combined PTEs).
> >
> > v2: change gtt restore default on pre-gen4 (Chris)
> > move needs_gtt_restore flag into dev_priv
> > v3: make sure we restore GTT on resume from hibernate (Daniel)
> > use opregion support as the cutoff for restore from resume (Chris)
> > v4: use a better check for opregion (Chris)
> >
> > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
>
> Merged, with some bikeshed applied, and the less-than-careful locking
> switch in patch 3 fixed. Please check whether I haven't botched it up.
Hm I even changed the name of the rps struct to catch all the cases at
compile time. Maybe I sent out an old version or forgot a git add...
thanks for fixing it up.
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2012-11-02 23:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-02 18:13 [PATCH 1/4] drm/i915: don't block resume on fb console resume v2 Jesse Barnes
2012-11-02 18:14 ` [PATCH 2/4] drm/i915: put ring frequency and turbo setup into a work queue v5 Jesse Barnes
2012-11-02 18:14 ` [PATCH 3/4] drm/i915: protect RPS/RC6 related accesses (including PCU) with a new mutex Jesse Barnes
2012-11-02 18:14 ` [PATCH 4/4] drm/i915: don't rewrite the GTT on resume v4 Jesse Barnes
2012-11-02 22:55 ` Daniel Vetter
2012-11-02 23:28 ` Jesse Barnes [this message]
2012-11-03 16:33 ` [PATCH 1/4] drm/i915: don't block resume on fb console resume v2 Keith Packard
-- strict thread matches above, loose matches on Subject: below --
2012-11-02 16:39 Jesse Barnes
2012-11-02 16:39 ` [PATCH 4/4] drm/i915: don't rewrite the GTT on resume v4 Jesse Barnes
2012-11-02 17:13 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121102162831.400a9e30@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox