From: Chris Wilson <chris@chris-wilson.co.uk>
To: "Alex,Shi" <alex.shi@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] Disable frame buffer compression on ironlake
Date: Fri, 19 Nov 2010 08:47:27 +0000 [thread overview]
Message-ID: <b9dded$h4p1s9@orsmga002.jf.intel.com> (raw)
In-Reply-To: <1290132003.16282.44.camel@debian>
On Fri, 19 Nov 2010 10:00:03 +0800, "Alex,Shi" <alex.shi@intel.com> wrote:
> Open fbc will cause about 1 Watts power increase on ironlake
> for bltk-office/player benchmark. So just disable it and left
> code here to waiting for better solution.
FBC is disabled through the chicken bits, so I am really curious to know
where the power saving is coming from. I just want to verify that we have
not made a fundamental mistake in our FBC logic that is consuming more
power than is necessary across all platforms.
In terms of code clarity, we should leave a note as to why we explicitly
disable fbc, e.g.: .has_fbc = 0, /* hardware support is buggy */
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2010-11-19 8:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-19 2:00 [PATCH] Disable frame buffer compression on ironlake Alex,Shi
2010-11-19 8:47 ` Chris Wilson [this message]
2010-11-19 19:36 ` Jesse Barnes
2010-11-19 10:05 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='b9dded$h4p1s9@orsmga002.jf.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=alex.shi@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox