* [PATCH i-g-t] i915/perf_pmu: Add trailing '\n' to an igt_assert_f
@ 2019-02-02 22:36 Chris Wilson
2019-02-04 9:14 ` Tvrtko Ursulin
0 siblings, 1 reply; 2+ messages in thread
From: Chris Wilson @ 2019-02-02 22:36 UTC (permalink / raw)
To: intel-gfx; +Cc: igt-dev
A missing newline at the end of an assert, so add it for clarity in the
error message.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
tests/i915/perf_pmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/i915/perf_pmu.c b/tests/i915/perf_pmu.c
index 391378139..c3993c417 100644
--- a/tests/i915/perf_pmu.c
+++ b/tests/i915/perf_pmu.c
@@ -707,7 +707,7 @@ sema_wait(int gem_fd, const struct intel_execution_engine2 *e,
} while (!obj_ptr[1]);
igt_assert_f(igt_wait(pmu_read_single(fd) != val[0], 10, 1),
- "sampling failed to start withing 10ms");
+ "sampling failed to start withing 10ms\n");
val[0] = __pmu_read_single(fd, &ts[0]);
slept = measured_usleep(batch_duration_ns / 1000);
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH i-g-t] i915/perf_pmu: Add trailing '\n' to an igt_assert_f
2019-02-02 22:36 [PATCH i-g-t] i915/perf_pmu: Add trailing '\n' to an igt_assert_f Chris Wilson
@ 2019-02-04 9:14 ` Tvrtko Ursulin
0 siblings, 0 replies; 2+ messages in thread
From: Tvrtko Ursulin @ 2019-02-04 9:14 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: igt-dev
On 02/02/2019 22:36, Chris Wilson wrote:
> A missing newline at the end of an assert, so add it for clarity in the
> error message.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> tests/i915/perf_pmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/i915/perf_pmu.c b/tests/i915/perf_pmu.c
> index 391378139..c3993c417 100644
> --- a/tests/i915/perf_pmu.c
> +++ b/tests/i915/perf_pmu.c
> @@ -707,7 +707,7 @@ sema_wait(int gem_fd, const struct intel_execution_engine2 *e,
> } while (!obj_ptr[1]);
>
> igt_assert_f(igt_wait(pmu_read_single(fd) != val[0], 10, 1),
> - "sampling failed to start withing 10ms");
> + "sampling failed to start withing 10ms\n");
>
> val[0] = __pmu_read_single(fd, &ts[0]);
> slept = measured_usleep(batch_duration_ns / 1000);
>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-04 9:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-02 22:36 [PATCH i-g-t] i915/perf_pmu: Add trailing '\n' to an igt_assert_f Chris Wilson
2019-02-04 9:14 ` Tvrtko Ursulin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox