Re: [PATCH] drm/i915/dsi: Make Lenovo Yoga Tab 3 X90F DMI match less strict

[Hans de Goede <hdegoede@redhat.com>]

Hi,

On 8/23/24 9:41 PM, Rodrigo Vivi wrote:
> On Fri, Aug 23, 2024 at 07:34:39PM +0200, Hans de Goede wrote:
>> Hi,
>>
>> On 8/23/24 10:22 AM, Jani Nikula wrote:
>>> On Fri, 23 Aug 2024, Hans de Goede <hdegoede@redhat.com> wrote:
>>>> There are 2G and 4G RAM versions of the Lenovo Yoga Tab 3 X90F and it
>>>> turns out that the 2G version has a DMI product name of
>>>> "CHERRYVIEW D1 PLATFORM" where as the 4G version has
>>>> "CHERRYVIEW C0 PLATFORM". The sys-vendor + product-version check are
>>>> unique enough that the product-name check is not necessary.
>>>>
>>>> Drop the product-name check so that the existing DMI match for the 4G
>>>> RAM version also matches the 2G RAM version.
>>>>
>>>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>>>
>>> I'll take your word for it.
>>>
>>> Acked-by: Jani Nikula <jani.nikula@intel.com>
>>
>> Thank you.
>>
>> I was going to push this directly to drm-intel-fixes, but reading:
>>
>> https://drm.pages.freedesktop.org/maintainer-tools/repositories/drm-intel.html#repository-and-branches
>>
>> It seems that I should push this to drm-intel-next and then cherry-pick
>> it into drm-intel-fixes ?
> 
> Just push to drm-intel-next and let the fixes tag take care of its magic:
> 
> Fixes: f6f4a0862bde ("drm/i915/vlv_dsi: Add DMI quirk for backlight control issues on Lenovo Yoga Tab 3 (v2)")
> 
> The cherry-pick to -fixes branches is handled weekly by whoever maintainer
> is tacking care of that round. Usually the 'Fixes' tag will be enough to ensure
> it gets propagated. But on the lack of the fixes tag of if you noticed something was missed,
> then just ping us.

Thanks. I've pushed this to drm-intel-next now with the fixes tag added.

Regards,

Hans




>>>> ---
>>>>  drivers/gpu/drm/i915/display/vlv_dsi.c | 1 -
>>>>  1 file changed, 1 deletion(-)
>>>>
>>>> diff --git a/drivers/gpu/drm/i915/display/vlv_dsi.c b/drivers/gpu/drm/i915/display/vlv_dsi.c
>>>> index 40b3ffd534d3..6cebcc87ef14 100644
>>>> --- a/drivers/gpu/drm/i915/display/vlv_dsi.c
>>>> +++ b/drivers/gpu/drm/i915/display/vlv_dsi.c
>>>> @@ -1874,7 +1874,6 @@ static const struct dmi_system_id vlv_dsi_dmi_quirk_table[] = {
>>>>  		/* Lenovo Yoga Tab 3 Pro YT3-X90F */
>>>>  		.matches = {
>>>>  			DMI_MATCH(DMI_SYS_VENDOR, "Intel Corporation"),
>>>> -			DMI_MATCH(DMI_PRODUCT_NAME, "CHERRYVIEW D1 PLATFORM"),
>>>>  			DMI_MATCH(DMI_PRODUCT_VERSION, "Blade3-10A-001"),
>>>>  		},
>>>>  		.driver_data = (void *)vlv_dsi_lenovo_yoga_tab3_backlight_fixup,
>>>
>>
>