Re: [PATCH 2/2] drm/xe: Respect pin_params.alignment for GGTT

["Juha-Pekka Heikkilä" <juhapekka.heikkila@gmail.com>]

look all ok.

Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>

On 30/04/2026 18.46, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Fix __xe_pin_fb_vma_ggtt() to actually respect the GGTT alignment
> specified by the display code. Misalignment can cause GTT faults
> etc.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>   drivers/gpu/drm/xe/display/xe_fb_pin.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/display/xe_fb_pin.c b/drivers/gpu/drm/xe/display/xe_fb_pin.c
> index 3e8114fbfbaa..8d0067f908c5 100644
> --- a/drivers/gpu/drm/xe/display/xe_fb_pin.c
> +++ b/drivers/gpu/drm/xe/display/xe_fb_pin.c
> @@ -286,7 +286,7 @@ static int __xe_pin_fb_vma_ggtt(struct drm_gem_object *obj,
>   	 */
>   	guard(xe_pm_runtime_noresume)(xe);
>   
> -	align = XE_PAGE_SIZE;
> +	align = max(XE_PAGE_SIZE, pin_params->alignment);
>   	if (xe_bo_is_vram(bo) && xe->info.vram_flags & XE_VRAM_FLAGS_NEED64K)
>   		align = max(align, SZ_64K);
>