Re: [PATCH 1/2] drm/xe: Use fb cached min alignment

["Juha-Pekka Heikkilä" <juhapekka.heikkila@gmail.com>]

look all ok.

Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>

On 30/04/2026 18.46, Ville Syrjala wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
> 
> Instead of just looking at the first plane use the fb cached overall
> minimum alignment.
> 
> This aligns with how the i915 version of intel_plane_pin_fb works.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
> [vsyrjala: Rebase due to pin_params]
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>   drivers/gpu/drm/xe/display/xe_fb_pin.c | 10 +++++++++-
>   1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/display/xe_fb_pin.c b/drivers/gpu/drm/xe/display/xe_fb_pin.c
> index 948446346c53..3e8114fbfbaa 100644
> --- a/drivers/gpu/drm/xe/display/xe_fb_pin.c
> +++ b/drivers/gpu/drm/xe/display/xe_fb_pin.c
> @@ -459,6 +459,14 @@ static bool reuse_vma(struct intel_plane_state *new_plane_state,
>   	return true;
>   }
>   
> +static unsigned int
> +intel_plane_fb_min_alignment(const struct intel_plane_state *plane_state)
> +{
> +	const struct intel_framebuffer *fb = to_intel_framebuffer(plane_state->hw.fb);
> +
> +	return fb->min_alignment;
> +}
> +
>   int intel_plane_pin_fb(struct intel_plane_state *new_plane_state,
>   		       const struct intel_plane_state *old_plane_state)
>   {
> @@ -469,7 +477,7 @@ int intel_plane_pin_fb(struct intel_plane_state *new_plane_state,
>   	struct intel_plane *plane = to_intel_plane(new_plane_state->uapi.plane);
>   	struct intel_fb_pin_params pin_params = {
>   		.view = &new_plane_state->view.gtt,
> -		.alignment = plane->min_alignment(plane, fb, 0),
> +		.alignment = intel_plane_fb_min_alignment(new_plane_state),
>   		.needs_cpu_lmem_access = intel_fb_needs_cpu_access(fb),
>   	};
>