From: Chris Wilson <chris@chris-wilson.co.uk>
To: daniel@ffwll.ch
Cc: intel-gfx@lists.freedesktop.org, Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH] drm/i915: enable MI_WTF bit; I mean MI_FLUSH
Date: Thu, 19 Jan 2012 10:33:10 +0000 [thread overview]
Message-ID: <c55c5d$1n8ckr@AZSMGA002.ch.intel.com> (raw)
In-Reply-To: <1326948957-16911-1-git-send-email-ben@bwidawsk.net>
On Wed, 18 Jan 2012 20:55:57 -0800, Ben Widawsky <ben@bwidawsk.net> wrote:
> We've seen a few patches now which switch the flush enable bit from bit
> 11 to bit 12 (as the documentation suggests it should be). However this
> turned out to be problematic for us.
>
> The simulator has shed some light for us. It's not bit 11, and it's not
> bit 12; it's both. Instead of renaming the bits according to the docs
> since we're still really not sure, I've decided to just make the
> MI_FLUSH_ENABLE be both bits. As an aside, the simulator still makes a
> distinction for these two bits, however the error message doesn't seem
> to.
>
> I don't believe this is actually required for the simulator to be
> function, but it does produce an annoying error message every time
> MI_FLUSH is used without this.
As were changing this to a value that is still inconsistent with the
specs, can we please put a note here as to why this value was chosen and
caveat lector.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-01-19 10:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-19 4:52 [PATCH] drm/i915: enable MI_WTF bit; I mean MI_FLUSH Ben Widawsky
2012-01-19 4:55 ` Ben Widawsky
2012-01-19 10:33 ` Chris Wilson [this message]
2012-01-19 10:35 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='c55c5d$1n8ckr@AZSMGA002.ch.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=ben@bwidawsk.net \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox