Re: [Intel-gfx] [PATCH v3 2/3] drm/i915/drm: Fix comment for YUV420 qp table declaration

["Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>]

On 7/3/2023 3:42 PM, Suraj Kandpal wrote:
> Fix comment for YUV420 qp table declaration of max value

YCbCr420 instead of YUV420, as used  in other patches.

> where the min value is 4 and the max value is 12/15/18
> depending on bpc.
>
> Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
> ---
>   drivers/gpu/drm/i915/display/intel_qp_tables.c | 10 +++++++---
>   1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_qp_tables.c b/drivers/gpu/drm/i915/display/intel_qp_tables.c
> index 6e86c0971d24..7997d673def7 100644
> --- a/drivers/gpu/drm/i915/display/intel_qp_tables.c
> +++ b/drivers/gpu/drm/i915/display/intel_qp_tables.c
> @@ -17,13 +17,17 @@
>   /* from BPP 6 to 36 in steps of 0.5 */
>   #define RC_RANGE_QP444_12BPC_MAX_NUM_BPP	61
>   
> -/* from BPP 6 to 24 in steps of 0.5 */
> +/* For YUV420 the bits_per_pixel sent in PPS params

Same as above.

With this fixed, this is:

Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>

> + * is double the target bpp. The below values represent
> + * the target bpp.
> + */
> +/* from BPP 4 to 12 in steps of 0.5 */
>   #define RC_RANGE_QP420_8BPC_MAX_NUM_BPP		17
>   
> -/* from BPP 6 to 30 in steps of 0.5 */
> +/* from BPP 4 to 15 in steps of 0.5 */
>   #define RC_RANGE_QP420_10BPC_MAX_NUM_BPP	23
>   
> -/* from BPP 6 to 36 in steps of 0.5 */
> +/* from BPP 4 to 18 in steps of 0.5 */
>   #define RC_RANGE_QP420_12BPC_MAX_NUM_BPP	29
>   
>   /*