Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3 0/3] Enable Wa_14019159160 and  Wa_16019325821 for MTL
@ 2024-01-04 18:05 John.C.Harrison
  2024-01-04 18:05 ` [PATCH v3 1/3] drm/i915: Enable Wa_16019325821 John.C.Harrison
                   ` (19 more replies)
  0 siblings, 20 replies; 25+ messages in thread
From: John.C.Harrison @ 2024-01-04 18:05 UTC (permalink / raw)
  To: Intel-GFX; +Cc: DRI-Devel

From: John Harrison <John.C.Harrison@Intel.com>

Enable Wa_14019159160 and  Wa_16019325821 for MTL

RCS/CCS workarounds for MTL.

v2: Fix bug in WA KLV implementation (offset not being reset to start
of list). Add better comment to prep patch about how KLVs can be added.
Add a module parameter override and disable the w/a by default as it
causes performance regressions and is only required by very specific
workloads.
v3: Rebase to latest tree. Drop module parameter as performance
regression is apparently not detectable after all and a bunch of more
common workloads have been seen to hit the issue.

Signed-off-by: John Harrison <John.C.Harrison@Intel.com>


John Harrison (3):
  drm/i915: Enable Wa_16019325821
  drm/i915/guc: Add support for w/a KLVs
  drm/i915/guc: Enable Wa_14019159160

 drivers/gpu/drm/i915/gt/gen8_engine_cs.c      | 22 +++--
 drivers/gpu/drm/i915/gt/intel_engine_types.h  |  8 +-
 .../gpu/drm/i915/gt/uc/abi/guc_errors_abi.h   |  1 +
 drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h |  7 ++
 drivers/gpu/drm/i915/gt/uc/intel_guc.c        |  5 ++
 drivers/gpu/drm/i915/gt/uc/intel_guc.h        |  2 +
 drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c    | 89 ++++++++++++++++++-
 drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c     |  6 ++
 drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h   |  8 +-
 .../gpu/drm/i915/gt/uc/intel_guc_submission.c |  8 +-
 10 files changed, 141 insertions(+), 15 deletions(-)

-- 
2.41.0


^ permalink raw reply	[flat|nested] 25+ messages in thread
* [PATCH v3 0/3] Enable Wa_14019159160 and  Wa_16019325821 for MTL
@ 2024-02-23 20:56 John.C.Harrison
  2024-02-23 20:56 ` [PATCH v3 3/3] drm/i915/guc: Enable Wa_14019159160 John.C.Harrison
  0 siblings, 1 reply; 25+ messages in thread
From: John.C.Harrison @ 2024-02-23 20:56 UTC (permalink / raw)
  To: Intel-GFX; +Cc: DRI-Devel, John Harrison

From: John Harrison <John.C.Harrison@Intel.com>

Enable Wa_14019159160 and  Wa_16019325821 for MTL

RCS/CCS workarounds for MTL.

v2: Fix bug in WA KLV implementation (offset not being reset to start
of list). Add better comment to prep patch about how KLVs can be added.
Add a module parameter override and disable the w/a by default as it
causes performance regressions and is only required by very specific
workloads.
v3: Rebase to latest tree. Drop module parameter as performance
regression is apparently not detectable after all and a bunch of more
common workloads have been seen to hit the issue.

Signed-off-by: John Harrison <John.C.Harrison@Intel.com>


John Harrison (3):
  drm/i915: Enable Wa_16019325821
  drm/i915/guc: Add support for w/a KLVs
  drm/i915/guc: Enable Wa_14019159160

 drivers/gpu/drm/i915/gt/gen8_engine_cs.c      | 22 +++--
 drivers/gpu/drm/i915/gt/intel_engine_types.h  |  8 +-
 .../gpu/drm/i915/gt/uc/abi/guc_errors_abi.h   |  1 +
 drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h |  7 ++
 drivers/gpu/drm/i915/gt/uc/intel_guc.c        |  5 ++
 drivers/gpu/drm/i915/gt/uc/intel_guc.h        |  2 +
 drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c    | 89 ++++++++++++++++++-
 drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c     |  6 ++
 drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h   |  8 +-
 .../gpu/drm/i915/gt/uc/intel_guc_submission.c |  8 +-
 10 files changed, 141 insertions(+), 15 deletions(-)

-- 
2.43.0


^ permalink raw reply	[flat|nested] 25+ messages in thread
* [PATCH v3 0/3] Enable Wa_14019159160 and  Wa_16019325821 for MTL
@ 2023-12-21  1:57 John.C.Harrison
  2023-12-21  1:57 ` [PATCH v3 3/3] drm/i915/guc: Enable Wa_14019159160 John.C.Harrison
  0 siblings, 1 reply; 25+ messages in thread
From: John.C.Harrison @ 2023-12-21  1:57 UTC (permalink / raw)
  To: Intel-GFX; +Cc: DRI-Devel

From: John Harrison <John.C.Harrison@Intel.com>

Enable Wa_14019159160 and  Wa_16019325821 for MTL

RCS/CCS workarounds for MTL.

v2: Fix bug in WA KLV implementation (offset not being reset to start
of list). Add better comment to prep patch about how KLVs can be added.
Add a module parameter override and disable the w/a by default as it
causes performance regressions and is only required by very specific
workloads.
v3: Rebase to latest tree. Drop module parameter as performance
regression is apparently not detectable after all and a bunch of more
common workloads have been seen to hit the issue.

Signed-off-by: John Harrison <John.C.Harrison@Intel.com>


John Harrison (3):
  drm/i915: Enable Wa_16019325821
  drm/i915/guc: Add support for w/a KLVs
  drm/i915/guc: Enable Wa_14019159160

 drivers/gpu/drm/i915/gt/gen8_engine_cs.c      | 22 +++--
 drivers/gpu/drm/i915/gt/intel_engine_types.h  |  8 +-
 .../gpu/drm/i915/gt/uc/abi/guc_errors_abi.h   |  1 +
 drivers/gpu/drm/i915/gt/uc/abi/guc_klvs_abi.h |  7 ++
 drivers/gpu/drm/i915/gt/uc/intel_guc.c        |  5 ++
 drivers/gpu/drm/i915/gt/uc/intel_guc.h        |  2 +
 drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c    | 89 ++++++++++++++++++-
 drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c     |  6 ++
 drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h   |  8 +-
 .../gpu/drm/i915/gt/uc/intel_guc_submission.c |  8 +-
 10 files changed, 141 insertions(+), 15 deletions(-)

-- 
2.41.0


^ permalink raw reply	[flat|nested] 25+ messages in thread

end of thread, other threads:[~2024-02-27  0:06 UTC | newest]

Thread overview: 25+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-04 18:05 [PATCH v3 0/3] Enable Wa_14019159160 and Wa_16019325821 for MTL John.C.Harrison
2024-01-04 18:05 ` [PATCH v3 1/3] drm/i915: Enable Wa_16019325821 John.C.Harrison
2024-01-04 18:05 ` [PATCH v3 2/3] drm/i915/guc: Add support for w/a KLVs John.C.Harrison
2024-01-04 18:05 ` [PATCH v3 3/3] drm/i915/guc: Enable Wa_14019159160 John.C.Harrison
2024-02-26 13:25   ` Nilawar, Badal
2024-02-27  0:06     ` John Harrison
2024-01-04 22:08 ` ✗ Fi.CI.CHECKPATCH: warning for Enable Wa_14019159160 and Wa_16019325821 for MTL (rev3) Patchwork
2024-01-04 22:08 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-01-04 22:22 ` ✓ Fi.CI.BAT: success " Patchwork
2024-01-05  0:28 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-01-16 23:06 ` ✗ Fi.CI.CHECKPATCH: warning for Enable Wa_14019159160 and Wa_16019325821 for MTL (rev4) Patchwork
2024-01-16 23:06 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-01-16 23:21 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-01-17 19:57 ` ✗ Fi.CI.CHECKPATCH: warning for Enable Wa_14019159160 and Wa_16019325821 for MTL (rev5) Patchwork
2024-01-17 19:57 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-01-17 20:16 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-01-17 22:22 ` ✗ Fi.CI.CHECKPATCH: warning for Enable Wa_14019159160 and Wa_16019325821 for MTL (rev6) Patchwork
2024-01-17 22:22 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-01-17 22:40 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-01-18  1:54 ` ✗ Fi.CI.CHECKPATCH: warning for Enable Wa_14019159160 and Wa_16019325821 for MTL (rev7) Patchwork
2024-01-18  1:54 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-01-18  2:07 ` ✓ Fi.CI.BAT: success " Patchwork
2024-01-18  4:22 ` ✗ Fi.CI.IGT: failure " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2024-02-23 20:56 [PATCH v3 0/3] Enable Wa_14019159160 and Wa_16019325821 for MTL John.C.Harrison
2024-02-23 20:56 ` [PATCH v3 3/3] drm/i915/guc: Enable Wa_14019159160 John.C.Harrison
2023-12-21  1:57 [PATCH v3 0/3] Enable Wa_14019159160 and Wa_16019325821 for MTL John.C.Harrison
2023-12-21  1:57 ` [PATCH v3 3/3] drm/i915/guc: Enable Wa_14019159160 John.C.Harrison

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox