* [Intel-gfx] [PATCH] drm/i915/ddi: add use_edp_hobl() and use_edp_low_vswing() helpers
@ 2021-12-03 13:13 Jani Nikula
2021-12-03 13:36 ` Souza, Jose
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Jani Nikula @ 2021-12-03 13:13 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
Localize HOBL and low vswing VBT lookups to a couple of small helpers,
and get rid of a bunch of local variables.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
.../drm/i915/display/intel_ddi_buf_trans.c | 94 +++++++------------
1 file changed, 36 insertions(+), 58 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c b/drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c
index 78cd8f77b49d..4ecbfa625891 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c
@@ -1032,6 +1032,21 @@ bool is_hobl_buf_trans(const struct intel_ddi_buf_trans *table)
return table == &tgl_combo_phy_trans_edp_hbr2_hobl;
}
+static bool use_edp_hobl(struct intel_encoder *encoder)
+{
+ struct drm_i915_private *i915 = to_i915(encoder->base.dev);
+ struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
+
+ return i915->vbt.edp.hobl && !intel_dp->hobl_failed;
+}
+
+static bool use_edp_low_vswing(struct intel_encoder *encoder)
+{
+ struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
+
+ return dev_priv->vbt.edp.low_vswing;
+}
+
static const struct intel_ddi_buf_trans *
intel_get_buf_trans(const struct intel_ddi_buf_trans *trans, int *num_entries)
{
@@ -1057,14 +1072,12 @@ bdw_get_buf_trans(struct intel_encoder *encoder,
const struct intel_crtc_state *crtc_state,
int *n_entries)
{
- struct drm_i915_private *i915 = to_i915(encoder->base.dev);
-
if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_ANALOG))
return intel_get_buf_trans(&bdw_trans_fdi, n_entries);
else if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI))
return intel_get_buf_trans(&bdw_trans_hdmi, n_entries);
else if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_EDP) &&
- i915->vbt.edp.low_vswing)
+ use_edp_low_vswing(encoder))
return intel_get_buf_trans(&bdw_trans_edp, n_entries);
else
return intel_get_buf_trans(&bdw_trans_dp, n_entries);
@@ -1094,12 +1107,10 @@ skl_y_get_buf_trans(struct intel_encoder *encoder,
const struct intel_crtc_state *crtc_state,
int *n_entries)
{
- struct drm_i915_private *i915 = to_i915(encoder->base.dev);
-
if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI))
return intel_get_buf_trans(&skl_y_trans_hdmi, n_entries);
else if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_EDP) &&
- i915->vbt.edp.low_vswing)
+ use_edp_low_vswing(encoder))
return _skl_get_buf_trans_dp(encoder, &skl_y_trans_edp, n_entries);
else
return _skl_get_buf_trans_dp(encoder, &skl_y_trans_dp, n_entries);
@@ -1110,12 +1121,10 @@ skl_u_get_buf_trans(struct intel_encoder *encoder,
const struct intel_crtc_state *crtc_state,
int *n_entries)
{
- struct drm_i915_private *i915 = to_i915(encoder->base.dev);
-
if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI))
return intel_get_buf_trans(&skl_trans_hdmi, n_entries);
else if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_EDP) &&
- i915->vbt.edp.low_vswing)
+ use_edp_low_vswing(encoder))
return _skl_get_buf_trans_dp(encoder, &skl_u_trans_edp, n_entries);
else
return _skl_get_buf_trans_dp(encoder, &skl_u_trans_dp, n_entries);
@@ -1126,12 +1135,10 @@ skl_get_buf_trans(struct intel_encoder *encoder,
const struct intel_crtc_state *crtc_state,
int *n_entries)
{
- struct drm_i915_private *i915 = to_i915(encoder->base.dev);
-
if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI))
return intel_get_buf_trans(&skl_trans_hdmi, n_entries);
else if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_EDP) &&
- i915->vbt.edp.low_vswing)
+ use_edp_low_vswing(encoder))
return _skl_get_buf_trans_dp(encoder, &skl_trans_edp, n_entries);
else
return _skl_get_buf_trans_dp(encoder, &skl_trans_dp, n_entries);
@@ -1142,12 +1149,10 @@ kbl_y_get_buf_trans(struct intel_encoder *encoder,
const struct intel_crtc_state *crtc_state,
int *n_entries)
{
- struct drm_i915_private *i915 = to_i915(encoder->base.dev);
-
if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI))
return intel_get_buf_trans(&skl_y_trans_hdmi, n_entries);
else if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_EDP) &&
- i915->vbt.edp.low_vswing)
+ use_edp_low_vswing(encoder))
return _skl_get_buf_trans_dp(encoder, &skl_y_trans_edp, n_entries);
else
return _skl_get_buf_trans_dp(encoder, &kbl_y_trans_dp, n_entries);
@@ -1158,12 +1163,10 @@ kbl_u_get_buf_trans(struct intel_encoder *encoder,
const struct intel_crtc_state *crtc_state,
int *n_entries)
{
- struct drm_i915_private *i915 = to_i915(encoder->base.dev);
-
if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI))
return intel_get_buf_trans(&skl_trans_hdmi, n_entries);
else if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_EDP) &&
- i915->vbt.edp.low_vswing)
+ use_edp_low_vswing(encoder))
return _skl_get_buf_trans_dp(encoder, &skl_u_trans_edp, n_entries);
else
return _skl_get_buf_trans_dp(encoder, &kbl_u_trans_dp, n_entries);
@@ -1174,12 +1177,10 @@ kbl_get_buf_trans(struct intel_encoder *encoder,
const struct intel_crtc_state *crtc_state,
int *n_entries)
{
- struct drm_i915_private *i915 = to_i915(encoder->base.dev);
-
if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI))
return intel_get_buf_trans(&skl_trans_hdmi, n_entries);
else if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_EDP) &&
- i915->vbt.edp.low_vswing)
+ use_edp_low_vswing(encoder))
return _skl_get_buf_trans_dp(encoder, &skl_trans_edp, n_entries);
else
return _skl_get_buf_trans_dp(encoder, &kbl_trans_dp, n_entries);
@@ -1190,12 +1191,10 @@ bxt_get_buf_trans(struct intel_encoder *encoder,
const struct intel_crtc_state *crtc_state,
int *n_entries)
{
- struct drm_i915_private *i915 = to_i915(encoder->base.dev);
-
if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI))
return intel_get_buf_trans(&bxt_trans_hdmi, n_entries);
else if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_EDP) &&
- i915->vbt.edp.low_vswing)
+ use_edp_low_vswing(encoder))
return intel_get_buf_trans(&bxt_trans_edp, n_entries);
else
return intel_get_buf_trans(&bxt_trans_dp, n_entries);
@@ -1215,12 +1214,10 @@ icl_get_combo_buf_trans_edp(struct intel_encoder *encoder,
const struct intel_crtc_state *crtc_state,
int *n_entries)
{
- struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
-
if (crtc_state->port_clock > 540000) {
return intel_get_buf_trans(&icl_combo_phy_trans_dp_hbr2_edp_hbr3,
n_entries);
- } else if (dev_priv->vbt.edp.low_vswing) {
+ } else if (use_edp_low_vswing(encoder)) {
return intel_get_buf_trans(&icl_combo_phy_trans_edp_hbr2,
n_entries);
}
@@ -1282,12 +1279,10 @@ ehl_get_combo_buf_trans(struct intel_encoder *encoder,
const struct intel_crtc_state *crtc_state,
int *n_entries)
{
- struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
-
if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI))
return intel_get_buf_trans(&icl_combo_phy_trans_hdmi, n_entries);
else if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_EDP) &&
- dev_priv->vbt.edp.low_vswing)
+ use_edp_low_vswing(encoder))
return ehl_get_combo_buf_trans_edp(encoder, crtc_state, n_entries);
else
return intel_get_buf_trans(&ehl_combo_phy_trans_dp, n_entries);
@@ -1309,12 +1304,10 @@ jsl_get_combo_buf_trans(struct intel_encoder *encoder,
const struct intel_crtc_state *crtc_state,
int *n_entries)
{
- struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
-
if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI))
return intel_get_buf_trans(&icl_combo_phy_trans_hdmi, n_entries);
else if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_EDP) &&
- dev_priv->vbt.edp.low_vswing)
+ use_edp_low_vswing(encoder))
return jsl_get_combo_buf_trans_edp(encoder, crtc_state, n_entries);
else
return intel_get_buf_trans(&icl_combo_phy_trans_dp_hbr2_edp_hbr3, n_entries);
@@ -1346,16 +1339,13 @@ tgl_get_combo_buf_trans_edp(struct intel_encoder *encoder,
const struct intel_crtc_state *crtc_state,
int *n_entries)
{
- struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
- struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
-
if (crtc_state->port_clock > 540000) {
return intel_get_buf_trans(&icl_combo_phy_trans_dp_hbr2_edp_hbr3,
n_entries);
- } else if (dev_priv->vbt.edp.hobl && !intel_dp->hobl_failed) {
+ } else if (use_edp_hobl(encoder)) {
return intel_get_buf_trans(&tgl_combo_phy_trans_edp_hbr2_hobl,
n_entries);
- } else if (dev_priv->vbt.edp.low_vswing) {
+ } else if (use_edp_low_vswing(encoder)) {
return intel_get_buf_trans(&icl_combo_phy_trans_edp_hbr2,
n_entries);
}
@@ -1394,16 +1384,13 @@ dg1_get_combo_buf_trans_edp(struct intel_encoder *encoder,
const struct intel_crtc_state *crtc_state,
int *n_entries)
{
- struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
- struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
-
if (crtc_state->port_clock > 540000)
return intel_get_buf_trans(&icl_combo_phy_trans_dp_hbr2_edp_hbr3,
n_entries);
- else if (dev_priv->vbt.edp.hobl && !intel_dp->hobl_failed)
+ else if (use_edp_hobl(encoder))
return intel_get_buf_trans(&tgl_combo_phy_trans_edp_hbr2_hobl,
n_entries);
- else if (dev_priv->vbt.edp.low_vswing)
+ else if (use_edp_low_vswing(encoder))
return intel_get_buf_trans(&icl_combo_phy_trans_edp_hbr2,
n_entries);
else
@@ -1439,16 +1426,13 @@ rkl_get_combo_buf_trans_edp(struct intel_encoder *encoder,
const struct intel_crtc_state *crtc_state,
int *n_entries)
{
- struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
- struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
-
if (crtc_state->port_clock > 540000) {
return intel_get_buf_trans(&icl_combo_phy_trans_dp_hbr2_edp_hbr3,
n_entries);
- } else if (dev_priv->vbt.edp.hobl && !intel_dp->hobl_failed) {
+ } else if (use_edp_hobl(encoder)) {
return intel_get_buf_trans(&tgl_combo_phy_trans_edp_hbr2_hobl,
n_entries);
- } else if (dev_priv->vbt.edp.low_vswing) {
+ } else if (use_edp_low_vswing(encoder)) {
return intel_get_buf_trans(&icl_combo_phy_trans_edp_hbr2,
n_entries);
}
@@ -1485,14 +1469,11 @@ adls_get_combo_buf_trans_edp(struct intel_encoder *encoder,
const struct intel_crtc_state *crtc_state,
int *n_entries)
{
- struct drm_i915_private *i915 = to_i915(encoder->base.dev);
- struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
-
if (crtc_state->port_clock > 540000)
return intel_get_buf_trans(&adls_combo_phy_trans_edp_hbr3, n_entries);
- else if (i915->vbt.edp.hobl && !intel_dp->hobl_failed)
+ else if (use_edp_hobl(encoder))
return intel_get_buf_trans(&tgl_combo_phy_trans_edp_hbr2_hobl, n_entries);
- else if (i915->vbt.edp.low_vswing)
+ else if (use_edp_low_vswing(encoder))
return intel_get_buf_trans(&adls_combo_phy_trans_edp_hbr2, n_entries);
else
return adls_get_combo_buf_trans_dp(encoder, crtc_state, n_entries);
@@ -1527,16 +1508,13 @@ adlp_get_combo_buf_trans_edp(struct intel_encoder *encoder,
const struct intel_crtc_state *crtc_state,
int *n_entries)
{
- struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
- struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
-
if (crtc_state->port_clock > 540000) {
return intel_get_buf_trans(&adlp_combo_phy_trans_edp_hbr3,
n_entries);
- } else if (dev_priv->vbt.edp.hobl && !intel_dp->hobl_failed) {
+ } else if (use_edp_hobl(encoder)) {
return intel_get_buf_trans(&tgl_combo_phy_trans_edp_hbr2_hobl,
n_entries);
- } else if (dev_priv->vbt.edp.low_vswing) {
+ } else if (use_edp_low_vswing(encoder)) {
return intel_get_buf_trans(&adlp_combo_phy_trans_edp_up_to_hbr2,
n_entries);
}
--
2.30.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Intel-gfx] [PATCH] drm/i915/ddi: add use_edp_hobl() and use_edp_low_vswing() helpers 2021-12-03 13:13 [Intel-gfx] [PATCH] drm/i915/ddi: add use_edp_hobl() and use_edp_low_vswing() helpers Jani Nikula @ 2021-12-03 13:36 ` Souza, Jose 2021-12-08 10:16 ` Jani Nikula 2021-12-03 15:13 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2021-12-03 21:40 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2 siblings, 1 reply; 5+ messages in thread From: Souza, Jose @ 2021-12-03 13:36 UTC (permalink / raw) To: Nikula, Jani, intel-gfx@lists.freedesktop.org On Fri, 2021-12-03 at 15:13 +0200, Jani Nikula wrote: > Localize HOBL and low vswing VBT lookups to a couple of small helpers, > and get rid of a bunch of local variables. Reviewed-by: José Roberto de Souza <jose.souza@intel.com> > > Signed-off-by: Jani Nikula <jani.nikula@intel.com> > --- > .../drm/i915/display/intel_ddi_buf_trans.c | 94 +++++++------------ > 1 file changed, 36 insertions(+), 58 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c b/drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c > index 78cd8f77b49d..4ecbfa625891 100644 > --- a/drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c > +++ b/drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c > @@ -1032,6 +1032,21 @@ bool is_hobl_buf_trans(const struct intel_ddi_buf_trans *table) > return table == &tgl_combo_phy_trans_edp_hbr2_hobl; > } > > +static bool use_edp_hobl(struct intel_encoder *encoder) > +{ > + struct drm_i915_private *i915 = to_i915(encoder->base.dev); > + struct intel_dp *intel_dp = enc_to_intel_dp(encoder); > + > + return i915->vbt.edp.hobl && !intel_dp->hobl_failed; > +} > + > +static bool use_edp_low_vswing(struct intel_encoder *encoder) > +{ > + struct drm_i915_private *dev_priv = to_i915(encoder->base.dev); > + > + return dev_priv->vbt.edp.low_vswing; > +} > + > static const struct intel_ddi_buf_trans * > intel_get_buf_trans(const struct intel_ddi_buf_trans *trans, int *num_entries) > { > @@ -1057,14 +1072,12 @@ bdw_get_buf_trans(struct intel_encoder *encoder, > const struct intel_crtc_state *crtc_state, > int *n_entries) > { > - struct drm_i915_private *i915 = to_i915(encoder->base.dev); > - > if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_ANALOG)) > return intel_get_buf_trans(&bdw_trans_fdi, n_entries); > else if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI)) > return intel_get_buf_trans(&bdw_trans_hdmi, n_entries); > else if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_EDP) && > - i915->vbt.edp.low_vswing) > + use_edp_low_vswing(encoder)) > return intel_get_buf_trans(&bdw_trans_edp, n_entries); > else > return intel_get_buf_trans(&bdw_trans_dp, n_entries); > @@ -1094,12 +1107,10 @@ skl_y_get_buf_trans(struct intel_encoder *encoder, > const struct intel_crtc_state *crtc_state, > int *n_entries) > { > - struct drm_i915_private *i915 = to_i915(encoder->base.dev); > - > if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI)) > return intel_get_buf_trans(&skl_y_trans_hdmi, n_entries); > else if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_EDP) && > - i915->vbt.edp.low_vswing) > + use_edp_low_vswing(encoder)) > return _skl_get_buf_trans_dp(encoder, &skl_y_trans_edp, n_entries); > else > return _skl_get_buf_trans_dp(encoder, &skl_y_trans_dp, n_entries); > @@ -1110,12 +1121,10 @@ skl_u_get_buf_trans(struct intel_encoder *encoder, > const struct intel_crtc_state *crtc_state, > int *n_entries) > { > - struct drm_i915_private *i915 = to_i915(encoder->base.dev); > - > if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI)) > return intel_get_buf_trans(&skl_trans_hdmi, n_entries); > else if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_EDP) && > - i915->vbt.edp.low_vswing) > + use_edp_low_vswing(encoder)) > return _skl_get_buf_trans_dp(encoder, &skl_u_trans_edp, n_entries); > else > return _skl_get_buf_trans_dp(encoder, &skl_u_trans_dp, n_entries); > @@ -1126,12 +1135,10 @@ skl_get_buf_trans(struct intel_encoder *encoder, > const struct intel_crtc_state *crtc_state, > int *n_entries) > { > - struct drm_i915_private *i915 = to_i915(encoder->base.dev); > - > if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI)) > return intel_get_buf_trans(&skl_trans_hdmi, n_entries); > else if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_EDP) && > - i915->vbt.edp.low_vswing) > + use_edp_low_vswing(encoder)) > return _skl_get_buf_trans_dp(encoder, &skl_trans_edp, n_entries); > else > return _skl_get_buf_trans_dp(encoder, &skl_trans_dp, n_entries); > @@ -1142,12 +1149,10 @@ kbl_y_get_buf_trans(struct intel_encoder *encoder, > const struct intel_crtc_state *crtc_state, > int *n_entries) > { > - struct drm_i915_private *i915 = to_i915(encoder->base.dev); > - > if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI)) > return intel_get_buf_trans(&skl_y_trans_hdmi, n_entries); > else if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_EDP) && > - i915->vbt.edp.low_vswing) > + use_edp_low_vswing(encoder)) > return _skl_get_buf_trans_dp(encoder, &skl_y_trans_edp, n_entries); > else > return _skl_get_buf_trans_dp(encoder, &kbl_y_trans_dp, n_entries); > @@ -1158,12 +1163,10 @@ kbl_u_get_buf_trans(struct intel_encoder *encoder, > const struct intel_crtc_state *crtc_state, > int *n_entries) > { > - struct drm_i915_private *i915 = to_i915(encoder->base.dev); > - > if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI)) > return intel_get_buf_trans(&skl_trans_hdmi, n_entries); > else if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_EDP) && > - i915->vbt.edp.low_vswing) > + use_edp_low_vswing(encoder)) > return _skl_get_buf_trans_dp(encoder, &skl_u_trans_edp, n_entries); > else > return _skl_get_buf_trans_dp(encoder, &kbl_u_trans_dp, n_entries); > @@ -1174,12 +1177,10 @@ kbl_get_buf_trans(struct intel_encoder *encoder, > const struct intel_crtc_state *crtc_state, > int *n_entries) > { > - struct drm_i915_private *i915 = to_i915(encoder->base.dev); > - > if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI)) > return intel_get_buf_trans(&skl_trans_hdmi, n_entries); > else if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_EDP) && > - i915->vbt.edp.low_vswing) > + use_edp_low_vswing(encoder)) > return _skl_get_buf_trans_dp(encoder, &skl_trans_edp, n_entries); > else > return _skl_get_buf_trans_dp(encoder, &kbl_trans_dp, n_entries); > @@ -1190,12 +1191,10 @@ bxt_get_buf_trans(struct intel_encoder *encoder, > const struct intel_crtc_state *crtc_state, > int *n_entries) > { > - struct drm_i915_private *i915 = to_i915(encoder->base.dev); > - > if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI)) > return intel_get_buf_trans(&bxt_trans_hdmi, n_entries); > else if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_EDP) && > - i915->vbt.edp.low_vswing) > + use_edp_low_vswing(encoder)) > return intel_get_buf_trans(&bxt_trans_edp, n_entries); > else > return intel_get_buf_trans(&bxt_trans_dp, n_entries); > @@ -1215,12 +1214,10 @@ icl_get_combo_buf_trans_edp(struct intel_encoder *encoder, > const struct intel_crtc_state *crtc_state, > int *n_entries) > { > - struct drm_i915_private *dev_priv = to_i915(encoder->base.dev); > - > if (crtc_state->port_clock > 540000) { > return intel_get_buf_trans(&icl_combo_phy_trans_dp_hbr2_edp_hbr3, > n_entries); > - } else if (dev_priv->vbt.edp.low_vswing) { > + } else if (use_edp_low_vswing(encoder)) { > return intel_get_buf_trans(&icl_combo_phy_trans_edp_hbr2, > n_entries); > } > @@ -1282,12 +1279,10 @@ ehl_get_combo_buf_trans(struct intel_encoder *encoder, > const struct intel_crtc_state *crtc_state, > int *n_entries) > { > - struct drm_i915_private *dev_priv = to_i915(encoder->base.dev); > - > if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI)) > return intel_get_buf_trans(&icl_combo_phy_trans_hdmi, n_entries); > else if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_EDP) && > - dev_priv->vbt.edp.low_vswing) > + use_edp_low_vswing(encoder)) > return ehl_get_combo_buf_trans_edp(encoder, crtc_state, n_entries); > else > return intel_get_buf_trans(&ehl_combo_phy_trans_dp, n_entries); > @@ -1309,12 +1304,10 @@ jsl_get_combo_buf_trans(struct intel_encoder *encoder, > const struct intel_crtc_state *crtc_state, > int *n_entries) > { > - struct drm_i915_private *dev_priv = to_i915(encoder->base.dev); > - > if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI)) > return intel_get_buf_trans(&icl_combo_phy_trans_hdmi, n_entries); > else if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_EDP) && > - dev_priv->vbt.edp.low_vswing) > + use_edp_low_vswing(encoder)) > return jsl_get_combo_buf_trans_edp(encoder, crtc_state, n_entries); > else > return intel_get_buf_trans(&icl_combo_phy_trans_dp_hbr2_edp_hbr3, n_entries); > @@ -1346,16 +1339,13 @@ tgl_get_combo_buf_trans_edp(struct intel_encoder *encoder, > const struct intel_crtc_state *crtc_state, > int *n_entries) > { > - struct drm_i915_private *dev_priv = to_i915(encoder->base.dev); > - struct intel_dp *intel_dp = enc_to_intel_dp(encoder); > - > if (crtc_state->port_clock > 540000) { > return intel_get_buf_trans(&icl_combo_phy_trans_dp_hbr2_edp_hbr3, > n_entries); > - } else if (dev_priv->vbt.edp.hobl && !intel_dp->hobl_failed) { > + } else if (use_edp_hobl(encoder)) { > return intel_get_buf_trans(&tgl_combo_phy_trans_edp_hbr2_hobl, > n_entries); > - } else if (dev_priv->vbt.edp.low_vswing) { > + } else if (use_edp_low_vswing(encoder)) { > return intel_get_buf_trans(&icl_combo_phy_trans_edp_hbr2, > n_entries); > } > @@ -1394,16 +1384,13 @@ dg1_get_combo_buf_trans_edp(struct intel_encoder *encoder, > const struct intel_crtc_state *crtc_state, > int *n_entries) > { > - struct drm_i915_private *dev_priv = to_i915(encoder->base.dev); > - struct intel_dp *intel_dp = enc_to_intel_dp(encoder); > - > if (crtc_state->port_clock > 540000) > return intel_get_buf_trans(&icl_combo_phy_trans_dp_hbr2_edp_hbr3, > n_entries); > - else if (dev_priv->vbt.edp.hobl && !intel_dp->hobl_failed) > + else if (use_edp_hobl(encoder)) > return intel_get_buf_trans(&tgl_combo_phy_trans_edp_hbr2_hobl, > n_entries); > - else if (dev_priv->vbt.edp.low_vswing) > + else if (use_edp_low_vswing(encoder)) > return intel_get_buf_trans(&icl_combo_phy_trans_edp_hbr2, > n_entries); > else > @@ -1439,16 +1426,13 @@ rkl_get_combo_buf_trans_edp(struct intel_encoder *encoder, > const struct intel_crtc_state *crtc_state, > int *n_entries) > { > - struct drm_i915_private *dev_priv = to_i915(encoder->base.dev); > - struct intel_dp *intel_dp = enc_to_intel_dp(encoder); > - > if (crtc_state->port_clock > 540000) { > return intel_get_buf_trans(&icl_combo_phy_trans_dp_hbr2_edp_hbr3, > n_entries); > - } else if (dev_priv->vbt.edp.hobl && !intel_dp->hobl_failed) { > + } else if (use_edp_hobl(encoder)) { > return intel_get_buf_trans(&tgl_combo_phy_trans_edp_hbr2_hobl, > n_entries); > - } else if (dev_priv->vbt.edp.low_vswing) { > + } else if (use_edp_low_vswing(encoder)) { > return intel_get_buf_trans(&icl_combo_phy_trans_edp_hbr2, > n_entries); > } > @@ -1485,14 +1469,11 @@ adls_get_combo_buf_trans_edp(struct intel_encoder *encoder, > const struct intel_crtc_state *crtc_state, > int *n_entries) > { > - struct drm_i915_private *i915 = to_i915(encoder->base.dev); > - struct intel_dp *intel_dp = enc_to_intel_dp(encoder); > - > if (crtc_state->port_clock > 540000) > return intel_get_buf_trans(&adls_combo_phy_trans_edp_hbr3, n_entries); > - else if (i915->vbt.edp.hobl && !intel_dp->hobl_failed) > + else if (use_edp_hobl(encoder)) > return intel_get_buf_trans(&tgl_combo_phy_trans_edp_hbr2_hobl, n_entries); > - else if (i915->vbt.edp.low_vswing) > + else if (use_edp_low_vswing(encoder)) > return intel_get_buf_trans(&adls_combo_phy_trans_edp_hbr2, n_entries); > else > return adls_get_combo_buf_trans_dp(encoder, crtc_state, n_entries); > @@ -1527,16 +1508,13 @@ adlp_get_combo_buf_trans_edp(struct intel_encoder *encoder, > const struct intel_crtc_state *crtc_state, > int *n_entries) > { > - struct drm_i915_private *dev_priv = to_i915(encoder->base.dev); > - struct intel_dp *intel_dp = enc_to_intel_dp(encoder); > - > if (crtc_state->port_clock > 540000) { > return intel_get_buf_trans(&adlp_combo_phy_trans_edp_hbr3, > n_entries); > - } else if (dev_priv->vbt.edp.hobl && !intel_dp->hobl_failed) { > + } else if (use_edp_hobl(encoder)) { > return intel_get_buf_trans(&tgl_combo_phy_trans_edp_hbr2_hobl, > n_entries); > - } else if (dev_priv->vbt.edp.low_vswing) { > + } else if (use_edp_low_vswing(encoder)) { > return intel_get_buf_trans(&adlp_combo_phy_trans_edp_up_to_hbr2, > n_entries); > } ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/ddi: add use_edp_hobl() and use_edp_low_vswing() helpers 2021-12-03 13:36 ` Souza, Jose @ 2021-12-08 10:16 ` Jani Nikula 0 siblings, 0 replies; 5+ messages in thread From: Jani Nikula @ 2021-12-08 10:16 UTC (permalink / raw) To: Souza, Jose, intel-gfx@lists.freedesktop.org On Fri, 03 Dec 2021, "Souza, Jose" <jose.souza@intel.com> wrote: > On Fri, 2021-12-03 at 15:13 +0200, Jani Nikula wrote: >> Localize HOBL and low vswing VBT lookups to a couple of small helpers, >> and get rid of a bunch of local variables. > > Reviewed-by: José Roberto de Souza <jose.souza@intel.com> Thanks, pushed. > >> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com> >> --- >> .../drm/i915/display/intel_ddi_buf_trans.c | 94 +++++++------------ >> 1 file changed, 36 insertions(+), 58 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c b/drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c >> index 78cd8f77b49d..4ecbfa625891 100644 >> --- a/drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c >> +++ b/drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c >> @@ -1032,6 +1032,21 @@ bool is_hobl_buf_trans(const struct intel_ddi_buf_trans *table) >> return table == &tgl_combo_phy_trans_edp_hbr2_hobl; >> } >> >> +static bool use_edp_hobl(struct intel_encoder *encoder) >> +{ >> + struct drm_i915_private *i915 = to_i915(encoder->base.dev); >> + struct intel_dp *intel_dp = enc_to_intel_dp(encoder); >> + >> + return i915->vbt.edp.hobl && !intel_dp->hobl_failed; >> +} >> + >> +static bool use_edp_low_vswing(struct intel_encoder *encoder) >> +{ >> + struct drm_i915_private *dev_priv = to_i915(encoder->base.dev); >> + >> + return dev_priv->vbt.edp.low_vswing; >> +} >> + >> static const struct intel_ddi_buf_trans * >> intel_get_buf_trans(const struct intel_ddi_buf_trans *trans, int *num_entries) >> { >> @@ -1057,14 +1072,12 @@ bdw_get_buf_trans(struct intel_encoder *encoder, >> const struct intel_crtc_state *crtc_state, >> int *n_entries) >> { >> - struct drm_i915_private *i915 = to_i915(encoder->base.dev); >> - >> if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_ANALOG)) >> return intel_get_buf_trans(&bdw_trans_fdi, n_entries); >> else if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI)) >> return intel_get_buf_trans(&bdw_trans_hdmi, n_entries); >> else if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_EDP) && >> - i915->vbt.edp.low_vswing) >> + use_edp_low_vswing(encoder)) >> return intel_get_buf_trans(&bdw_trans_edp, n_entries); >> else >> return intel_get_buf_trans(&bdw_trans_dp, n_entries); >> @@ -1094,12 +1107,10 @@ skl_y_get_buf_trans(struct intel_encoder *encoder, >> const struct intel_crtc_state *crtc_state, >> int *n_entries) >> { >> - struct drm_i915_private *i915 = to_i915(encoder->base.dev); >> - >> if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI)) >> return intel_get_buf_trans(&skl_y_trans_hdmi, n_entries); >> else if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_EDP) && >> - i915->vbt.edp.low_vswing) >> + use_edp_low_vswing(encoder)) >> return _skl_get_buf_trans_dp(encoder, &skl_y_trans_edp, n_entries); >> else >> return _skl_get_buf_trans_dp(encoder, &skl_y_trans_dp, n_entries); >> @@ -1110,12 +1121,10 @@ skl_u_get_buf_trans(struct intel_encoder *encoder, >> const struct intel_crtc_state *crtc_state, >> int *n_entries) >> { >> - struct drm_i915_private *i915 = to_i915(encoder->base.dev); >> - >> if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI)) >> return intel_get_buf_trans(&skl_trans_hdmi, n_entries); >> else if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_EDP) && >> - i915->vbt.edp.low_vswing) >> + use_edp_low_vswing(encoder)) >> return _skl_get_buf_trans_dp(encoder, &skl_u_trans_edp, n_entries); >> else >> return _skl_get_buf_trans_dp(encoder, &skl_u_trans_dp, n_entries); >> @@ -1126,12 +1135,10 @@ skl_get_buf_trans(struct intel_encoder *encoder, >> const struct intel_crtc_state *crtc_state, >> int *n_entries) >> { >> - struct drm_i915_private *i915 = to_i915(encoder->base.dev); >> - >> if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI)) >> return intel_get_buf_trans(&skl_trans_hdmi, n_entries); >> else if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_EDP) && >> - i915->vbt.edp.low_vswing) >> + use_edp_low_vswing(encoder)) >> return _skl_get_buf_trans_dp(encoder, &skl_trans_edp, n_entries); >> else >> return _skl_get_buf_trans_dp(encoder, &skl_trans_dp, n_entries); >> @@ -1142,12 +1149,10 @@ kbl_y_get_buf_trans(struct intel_encoder *encoder, >> const struct intel_crtc_state *crtc_state, >> int *n_entries) >> { >> - struct drm_i915_private *i915 = to_i915(encoder->base.dev); >> - >> if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI)) >> return intel_get_buf_trans(&skl_y_trans_hdmi, n_entries); >> else if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_EDP) && >> - i915->vbt.edp.low_vswing) >> + use_edp_low_vswing(encoder)) >> return _skl_get_buf_trans_dp(encoder, &skl_y_trans_edp, n_entries); >> else >> return _skl_get_buf_trans_dp(encoder, &kbl_y_trans_dp, n_entries); >> @@ -1158,12 +1163,10 @@ kbl_u_get_buf_trans(struct intel_encoder *encoder, >> const struct intel_crtc_state *crtc_state, >> int *n_entries) >> { >> - struct drm_i915_private *i915 = to_i915(encoder->base.dev); >> - >> if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI)) >> return intel_get_buf_trans(&skl_trans_hdmi, n_entries); >> else if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_EDP) && >> - i915->vbt.edp.low_vswing) >> + use_edp_low_vswing(encoder)) >> return _skl_get_buf_trans_dp(encoder, &skl_u_trans_edp, n_entries); >> else >> return _skl_get_buf_trans_dp(encoder, &kbl_u_trans_dp, n_entries); >> @@ -1174,12 +1177,10 @@ kbl_get_buf_trans(struct intel_encoder *encoder, >> const struct intel_crtc_state *crtc_state, >> int *n_entries) >> { >> - struct drm_i915_private *i915 = to_i915(encoder->base.dev); >> - >> if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI)) >> return intel_get_buf_trans(&skl_trans_hdmi, n_entries); >> else if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_EDP) && >> - i915->vbt.edp.low_vswing) >> + use_edp_low_vswing(encoder)) >> return _skl_get_buf_trans_dp(encoder, &skl_trans_edp, n_entries); >> else >> return _skl_get_buf_trans_dp(encoder, &kbl_trans_dp, n_entries); >> @@ -1190,12 +1191,10 @@ bxt_get_buf_trans(struct intel_encoder *encoder, >> const struct intel_crtc_state *crtc_state, >> int *n_entries) >> { >> - struct drm_i915_private *i915 = to_i915(encoder->base.dev); >> - >> if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI)) >> return intel_get_buf_trans(&bxt_trans_hdmi, n_entries); >> else if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_EDP) && >> - i915->vbt.edp.low_vswing) >> + use_edp_low_vswing(encoder)) >> return intel_get_buf_trans(&bxt_trans_edp, n_entries); >> else >> return intel_get_buf_trans(&bxt_trans_dp, n_entries); >> @@ -1215,12 +1214,10 @@ icl_get_combo_buf_trans_edp(struct intel_encoder *encoder, >> const struct intel_crtc_state *crtc_state, >> int *n_entries) >> { >> - struct drm_i915_private *dev_priv = to_i915(encoder->base.dev); >> - >> if (crtc_state->port_clock > 540000) { >> return intel_get_buf_trans(&icl_combo_phy_trans_dp_hbr2_edp_hbr3, >> n_entries); >> - } else if (dev_priv->vbt.edp.low_vswing) { >> + } else if (use_edp_low_vswing(encoder)) { >> return intel_get_buf_trans(&icl_combo_phy_trans_edp_hbr2, >> n_entries); >> } >> @@ -1282,12 +1279,10 @@ ehl_get_combo_buf_trans(struct intel_encoder *encoder, >> const struct intel_crtc_state *crtc_state, >> int *n_entries) >> { >> - struct drm_i915_private *dev_priv = to_i915(encoder->base.dev); >> - >> if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI)) >> return intel_get_buf_trans(&icl_combo_phy_trans_hdmi, n_entries); >> else if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_EDP) && >> - dev_priv->vbt.edp.low_vswing) >> + use_edp_low_vswing(encoder)) >> return ehl_get_combo_buf_trans_edp(encoder, crtc_state, n_entries); >> else >> return intel_get_buf_trans(&ehl_combo_phy_trans_dp, n_entries); >> @@ -1309,12 +1304,10 @@ jsl_get_combo_buf_trans(struct intel_encoder *encoder, >> const struct intel_crtc_state *crtc_state, >> int *n_entries) >> { >> - struct drm_i915_private *dev_priv = to_i915(encoder->base.dev); >> - >> if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI)) >> return intel_get_buf_trans(&icl_combo_phy_trans_hdmi, n_entries); >> else if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_EDP) && >> - dev_priv->vbt.edp.low_vswing) >> + use_edp_low_vswing(encoder)) >> return jsl_get_combo_buf_trans_edp(encoder, crtc_state, n_entries); >> else >> return intel_get_buf_trans(&icl_combo_phy_trans_dp_hbr2_edp_hbr3, n_entries); >> @@ -1346,16 +1339,13 @@ tgl_get_combo_buf_trans_edp(struct intel_encoder *encoder, >> const struct intel_crtc_state *crtc_state, >> int *n_entries) >> { >> - struct drm_i915_private *dev_priv = to_i915(encoder->base.dev); >> - struct intel_dp *intel_dp = enc_to_intel_dp(encoder); >> - >> if (crtc_state->port_clock > 540000) { >> return intel_get_buf_trans(&icl_combo_phy_trans_dp_hbr2_edp_hbr3, >> n_entries); >> - } else if (dev_priv->vbt.edp.hobl && !intel_dp->hobl_failed) { >> + } else if (use_edp_hobl(encoder)) { >> return intel_get_buf_trans(&tgl_combo_phy_trans_edp_hbr2_hobl, >> n_entries); >> - } else if (dev_priv->vbt.edp.low_vswing) { >> + } else if (use_edp_low_vswing(encoder)) { >> return intel_get_buf_trans(&icl_combo_phy_trans_edp_hbr2, >> n_entries); >> } >> @@ -1394,16 +1384,13 @@ dg1_get_combo_buf_trans_edp(struct intel_encoder *encoder, >> const struct intel_crtc_state *crtc_state, >> int *n_entries) >> { >> - struct drm_i915_private *dev_priv = to_i915(encoder->base.dev); >> - struct intel_dp *intel_dp = enc_to_intel_dp(encoder); >> - >> if (crtc_state->port_clock > 540000) >> return intel_get_buf_trans(&icl_combo_phy_trans_dp_hbr2_edp_hbr3, >> n_entries); >> - else if (dev_priv->vbt.edp.hobl && !intel_dp->hobl_failed) >> + else if (use_edp_hobl(encoder)) >> return intel_get_buf_trans(&tgl_combo_phy_trans_edp_hbr2_hobl, >> n_entries); >> - else if (dev_priv->vbt.edp.low_vswing) >> + else if (use_edp_low_vswing(encoder)) >> return intel_get_buf_trans(&icl_combo_phy_trans_edp_hbr2, >> n_entries); >> else >> @@ -1439,16 +1426,13 @@ rkl_get_combo_buf_trans_edp(struct intel_encoder *encoder, >> const struct intel_crtc_state *crtc_state, >> int *n_entries) >> { >> - struct drm_i915_private *dev_priv = to_i915(encoder->base.dev); >> - struct intel_dp *intel_dp = enc_to_intel_dp(encoder); >> - >> if (crtc_state->port_clock > 540000) { >> return intel_get_buf_trans(&icl_combo_phy_trans_dp_hbr2_edp_hbr3, >> n_entries); >> - } else if (dev_priv->vbt.edp.hobl && !intel_dp->hobl_failed) { >> + } else if (use_edp_hobl(encoder)) { >> return intel_get_buf_trans(&tgl_combo_phy_trans_edp_hbr2_hobl, >> n_entries); >> - } else if (dev_priv->vbt.edp.low_vswing) { >> + } else if (use_edp_low_vswing(encoder)) { >> return intel_get_buf_trans(&icl_combo_phy_trans_edp_hbr2, >> n_entries); >> } >> @@ -1485,14 +1469,11 @@ adls_get_combo_buf_trans_edp(struct intel_encoder *encoder, >> const struct intel_crtc_state *crtc_state, >> int *n_entries) >> { >> - struct drm_i915_private *i915 = to_i915(encoder->base.dev); >> - struct intel_dp *intel_dp = enc_to_intel_dp(encoder); >> - >> if (crtc_state->port_clock > 540000) >> return intel_get_buf_trans(&adls_combo_phy_trans_edp_hbr3, n_entries); >> - else if (i915->vbt.edp.hobl && !intel_dp->hobl_failed) >> + else if (use_edp_hobl(encoder)) >> return intel_get_buf_trans(&tgl_combo_phy_trans_edp_hbr2_hobl, n_entries); >> - else if (i915->vbt.edp.low_vswing) >> + else if (use_edp_low_vswing(encoder)) >> return intel_get_buf_trans(&adls_combo_phy_trans_edp_hbr2, n_entries); >> else >> return adls_get_combo_buf_trans_dp(encoder, crtc_state, n_entries); >> @@ -1527,16 +1508,13 @@ adlp_get_combo_buf_trans_edp(struct intel_encoder *encoder, >> const struct intel_crtc_state *crtc_state, >> int *n_entries) >> { >> - struct drm_i915_private *dev_priv = to_i915(encoder->base.dev); >> - struct intel_dp *intel_dp = enc_to_intel_dp(encoder); >> - >> if (crtc_state->port_clock > 540000) { >> return intel_get_buf_trans(&adlp_combo_phy_trans_edp_hbr3, >> n_entries); >> - } else if (dev_priv->vbt.edp.hobl && !intel_dp->hobl_failed) { >> + } else if (use_edp_hobl(encoder)) { >> return intel_get_buf_trans(&tgl_combo_phy_trans_edp_hbr2_hobl, >> n_entries); >> - } else if (dev_priv->vbt.edp.low_vswing) { >> + } else if (use_edp_low_vswing(encoder)) { >> return intel_get_buf_trans(&adlp_combo_phy_trans_edp_up_to_hbr2, >> n_entries); >> } > -- Jani Nikula, Intel Open Source Graphics Center ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/ddi: add use_edp_hobl() and use_edp_low_vswing() helpers 2021-12-03 13:13 [Intel-gfx] [PATCH] drm/i915/ddi: add use_edp_hobl() and use_edp_low_vswing() helpers Jani Nikula 2021-12-03 13:36 ` Souza, Jose @ 2021-12-03 15:13 ` Patchwork 2021-12-03 21:40 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2 siblings, 0 replies; 5+ messages in thread From: Patchwork @ 2021-12-03 15:13 UTC (permalink / raw) To: Jani Nikula; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 3828 bytes --] == Series Details == Series: drm/i915/ddi: add use_edp_hobl() and use_edp_low_vswing() helpers URL : https://patchwork.freedesktop.org/series/97547/ State : success == Summary == CI Bug Log - changes from CI_DRM_10961 -> Patchwork_21745 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/index.html Participating hosts (42 -> 33) ------------------------------ Missing (9): fi-ilk-m540 bat-dg1-6 bat-dg1-5 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus bat-jsl-2 bat-jsl-1 Known issues ------------ Here are the changes found in Patchwork_21745 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@amdgpu/amd_basic@cs-gfx: - fi-rkl-guc: NOTRUN -> [SKIP][1] ([fdo#109315]) +17 similar issues [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/fi-rkl-guc/igt@amdgpu/amd_basic@cs-gfx.html * igt@amdgpu/amd_basic@semaphore: - fi-bsw-nick: NOTRUN -> [SKIP][2] ([fdo#109271]) +17 similar issues [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/fi-bsw-nick/igt@amdgpu/amd_basic@semaphore.html #### Possible fixes #### * igt@i915_selftest@live@gt_engines: - fi-rkl-guc: [INCOMPLETE][3] ([i915#4432]) -> [PASS][4] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/fi-rkl-guc/igt@i915_selftest@live@gt_engines.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/fi-rkl-guc/igt@i915_selftest@live@gt_engines.html * igt@i915_selftest@live@late_gt_pm: - fi-bsw-nick: [DMESG-FAIL][5] ([i915#2927] / [i915#3428]) -> [PASS][6] [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/fi-bsw-nick/igt@i915_selftest@live@late_gt_pm.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/fi-bsw-nick/igt@i915_selftest@live@late_gt_pm.html * igt@kms_frontbuffer_tracking@basic: - fi-cml-u2: [DMESG-WARN][7] ([i915#4269]) -> [PASS][8] [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/fi-cml-u2/igt@kms_frontbuffer_tracking@basic.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/fi-cml-u2/igt@kms_frontbuffer_tracking@basic.html #### Warnings #### * igt@kms_psr@primary_page_flip: - fi-skl-6600u: [INCOMPLETE][9] ([i915#198] / [i915#4547]) -> [INCOMPLETE][10] ([i915#198]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/fi-skl-6600u/igt@kms_psr@primary_page_flip.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/fi-skl-6600u/igt@kms_psr@primary_page_flip.html [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315 [i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198 [i915#2927]: https://gitlab.freedesktop.org/drm/intel/issues/2927 [i915#3428]: https://gitlab.freedesktop.org/drm/intel/issues/3428 [i915#4269]: https://gitlab.freedesktop.org/drm/intel/issues/4269 [i915#4432]: https://gitlab.freedesktop.org/drm/intel/issues/4432 [i915#4547]: https://gitlab.freedesktop.org/drm/intel/issues/4547 Build changes ------------- * Linux: CI_DRM_10961 -> Patchwork_21745 CI-20190529: 20190529 CI_DRM_10961: e7bbdc541b4748718cd6ce8b839f3db335f3a0fc @ git://anongit.freedesktop.org/gfx-ci/linux IGT_6299: 0933b7ccdb2bb054b6a8154171e35315d84299b7 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_21745: 914a84c9e0dd1dcc52d4d9107a02dc9e83e43d00 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 914a84c9e0dd drm/i915/ddi: add use_edp_hobl() and use_edp_low_vswing() helpers == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/index.html [-- Attachment #2: Type: text/html, Size: 4631 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/ddi: add use_edp_hobl() and use_edp_low_vswing() helpers 2021-12-03 13:13 [Intel-gfx] [PATCH] drm/i915/ddi: add use_edp_hobl() and use_edp_low_vswing() helpers Jani Nikula 2021-12-03 13:36 ` Souza, Jose 2021-12-03 15:13 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork @ 2021-12-03 21:40 ` Patchwork 2 siblings, 0 replies; 5+ messages in thread From: Patchwork @ 2021-12-03 21:40 UTC (permalink / raw) To: Jani Nikula; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 30288 bytes --] == Series Details == Series: drm/i915/ddi: add use_edp_hobl() and use_edp_low_vswing() helpers URL : https://patchwork.freedesktop.org/series/97547/ State : success == Summary == CI Bug Log - changes from CI_DRM_10961_full -> Patchwork_21745_full ==================================================== Summary ------- **SUCCESS** No regressions found. Participating hosts (10 -> 10) ------------------------------ No changes in participating hosts Known issues ------------ Here are the changes found in Patchwork_21745_full that come from known issues: ### CI changes ### #### Possible fixes #### * boot: - shard-apl: ([PASS][1], [PASS][2], [PASS][3], [PASS][4], [PASS][5], [PASS][6], [PASS][7], [PASS][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [FAIL][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25]) ([i915#4386]) -> ([PASS][26], [PASS][27], [PASS][28], [PASS][29], [PASS][30], [PASS][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [PASS][50]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-apl3/boot.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-apl4/boot.html [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-apl4/boot.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-apl4/boot.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-apl4/boot.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-apl4/boot.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-apl6/boot.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-apl6/boot.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-apl6/boot.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-apl7/boot.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-apl7/boot.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-apl8/boot.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-apl8/boot.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-apl8/boot.html [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-apl1/boot.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-apl1/boot.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-apl1/boot.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-apl1/boot.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-apl2/boot.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-apl2/boot.html [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-apl2/boot.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-apl2/boot.html [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-apl3/boot.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-apl3/boot.html [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-apl3/boot.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-apl6/boot.html [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-apl7/boot.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-apl6/boot.html [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-apl7/boot.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-apl7/boot.html [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-apl8/boot.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-apl6/boot.html [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-apl8/boot.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-apl4/boot.html [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-apl4/boot.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-apl8/boot.html [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-apl4/boot.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-apl8/boot.html [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-apl3/boot.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-apl3/boot.html [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-apl3/boot.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-apl3/boot.html [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-apl2/boot.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-apl2/boot.html [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-apl2/boot.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-apl2/boot.html [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-apl1/boot.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-apl1/boot.html [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-apl1/boot.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-apl1/boot.html ### IGT changes ### #### Issues hit #### * igt@feature_discovery@psr2: - shard-iclb: [PASS][51] -> [SKIP][52] ([i915#658]) [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-iclb2/igt@feature_discovery@psr2.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-iclb1/igt@feature_discovery@psr2.html * igt@gem_eio@in-flight-contexts-1us: - shard-snb: [PASS][53] -> [FAIL][54] ([i915#4409]) [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-snb2/igt@gem_eio@in-flight-contexts-1us.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-snb6/igt@gem_eio@in-flight-contexts-1us.html * igt@gem_exec_create@forked@smem: - shard-glk: [PASS][55] -> [DMESG-WARN][56] ([i915#118]) +1 similar issue [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-glk6/igt@gem_exec_create@forked@smem.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-glk9/igt@gem_exec_create@forked@smem.html * igt@gem_exec_fair@basic-none-share@rcs0: - shard-apl: [PASS][57] -> [SKIP][58] ([fdo#109271]) [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-apl7/igt@gem_exec_fair@basic-none-share@rcs0.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-apl2/igt@gem_exec_fair@basic-none-share@rcs0.html * igt@gem_exec_fair@basic-pace-share@rcs0: - shard-tglb: [PASS][59] -> [FAIL][60] ([i915#2842]) [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-tglb5/igt@gem_exec_fair@basic-pace-share@rcs0.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-tglb3/igt@gem_exec_fair@basic-pace-share@rcs0.html * igt@gem_exec_params@secure-non-master: - shard-tglb: NOTRUN -> [SKIP][61] ([fdo#112283]) [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-tglb5/igt@gem_exec_params@secure-non-master.html * igt@gem_lmem_swapping@heavy-multi: - shard-kbl: NOTRUN -> [SKIP][62] ([fdo#109271] / [i915#4613]) [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-kbl2/igt@gem_lmem_swapping@heavy-multi.html * igt@gem_lmem_swapping@random-engines: - shard-apl: NOTRUN -> [SKIP][63] ([fdo#109271] / [i915#4613]) [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-apl4/igt@gem_lmem_swapping@random-engines.html * igt@gem_pread@exhaustion: - shard-apl: NOTRUN -> [WARN][64] ([i915#2658]) [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-apl7/igt@gem_pread@exhaustion.html * igt@gem_userptr_blits@input-checking: - shard-iclb: NOTRUN -> [DMESG-WARN][65] ([i915#3002]) [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-iclb5/igt@gem_userptr_blits@input-checking.html * igt@i915_selftest@live@hangcheck: - shard-snb: [PASS][66] -> [INCOMPLETE][67] ([i915#3921]) [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-snb5/igt@i915_selftest@live@hangcheck.html [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-snb4/igt@i915_selftest@live@hangcheck.html * igt@i915_suspend@sysfs-reader: - shard-kbl: NOTRUN -> [INCOMPLETE][68] ([i915#3614]) [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-kbl4/igt@i915_suspend@sysfs-reader.html * igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip: - shard-apl: NOTRUN -> [SKIP][69] ([fdo#109271] / [i915#3777]) +1 similar issue [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-apl4/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip.html * igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip: - shard-kbl: NOTRUN -> [SKIP][70] ([fdo#109271] / [i915#3777]) [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-kbl4/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip.html * igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-async-flip: - shard-skl: NOTRUN -> [FAIL][71] ([i915#3743]) [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-skl7/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-async-flip.html * igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs: - shard-glk: NOTRUN -> [SKIP][72] ([fdo#109271] / [i915#3886]) [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-glk5/igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs.html * igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_ccs: - shard-tglb: NOTRUN -> [SKIP][73] ([i915#3689]) +1 similar issue [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-tglb2/igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_ccs.html * igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_mc_ccs: - shard-kbl: NOTRUN -> [SKIP][74] ([fdo#109271] / [i915#3886]) +5 similar issues [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-kbl3/igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_mc_ccs.html * igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc: - shard-apl: NOTRUN -> [SKIP][75] ([fdo#109271] / [i915#3886]) +5 similar issues [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-apl4/igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc.html * igt@kms_ccs@pipe-c-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs: - shard-skl: NOTRUN -> [SKIP][76] ([fdo#109271] / [i915#3886]) +1 similar issue [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-skl7/igt@kms_ccs@pipe-c-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs.html * igt@kms_chamelium@vga-edid-read: - shard-apl: NOTRUN -> [SKIP][77] ([fdo#109271] / [fdo#111827]) +6 similar issues [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-apl7/igt@kms_chamelium@vga-edid-read.html * igt@kms_color@pipe-c-ctm-0-25: - shard-skl: [PASS][78] -> [DMESG-WARN][79] ([i915#1982]) [78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-skl8/igt@kms_color@pipe-c-ctm-0-25.html [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-skl3/igt@kms_color@pipe-c-ctm-0-25.html * igt@kms_color_chamelium@pipe-a-ctm-0-5: - shard-iclb: NOTRUN -> [SKIP][80] ([fdo#109284] / [fdo#111827]) [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-iclb5/igt@kms_color_chamelium@pipe-a-ctm-0-5.html * igt@kms_color_chamelium@pipe-a-ctm-limited-range: - shard-glk: NOTRUN -> [SKIP][81] ([fdo#109271] / [fdo#111827]) +3 similar issues [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-glk5/igt@kms_color_chamelium@pipe-a-ctm-limited-range.html * igt@kms_color_chamelium@pipe-b-gamma: - shard-tglb: NOTRUN -> [SKIP][82] ([fdo#109284] / [fdo#111827]) +1 similar issue [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-tglb5/igt@kms_color_chamelium@pipe-b-gamma.html * igt@kms_color_chamelium@pipe-c-ctm-green-to-red: - shard-skl: NOTRUN -> [SKIP][83] ([fdo#109271] / [fdo#111827]) +2 similar issues [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-skl7/igt@kms_color_chamelium@pipe-c-ctm-green-to-red.html * igt@kms_color_chamelium@pipe-c-gamma: - shard-kbl: NOTRUN -> [SKIP][84] ([fdo#109271] / [fdo#111827]) +8 similar issues [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-kbl3/igt@kms_color_chamelium@pipe-c-gamma.html * igt@kms_content_protection@atomic-dpms: - shard-kbl: NOTRUN -> [TIMEOUT][85] ([i915#1319]) +1 similar issue [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-kbl6/igt@kms_content_protection@atomic-dpms.html * igt@kms_content_protection@dp-mst-lic-type-1: - shard-tglb: NOTRUN -> [SKIP][86] ([i915#3116]) [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-tglb5/igt@kms_content_protection@dp-mst-lic-type-1.html * igt@kms_content_protection@srm: - shard-apl: NOTRUN -> [TIMEOUT][87] ([i915#1319]) [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-apl2/igt@kms_content_protection@srm.html * igt@kms_content_protection@uevent: - shard-apl: NOTRUN -> [FAIL][88] ([i915#2105]) [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-apl7/igt@kms_content_protection@uevent.html * igt@kms_cursor_crc@pipe-b-cursor-32x10-sliding: - shard-iclb: NOTRUN -> [SKIP][89] ([fdo#109278]) [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-iclb5/igt@kms_cursor_crc@pipe-b-cursor-32x10-sliding.html * igt@kms_cursor_crc@pipe-d-cursor-256x256-random: - shard-glk: NOTRUN -> [SKIP][90] ([fdo#109271]) +32 similar issues [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-glk5/igt@kms_cursor_crc@pipe-d-cursor-256x256-random.html * igt@kms_fbcon_fbt@fbc-suspend: - shard-kbl: [PASS][91] -> [INCOMPLETE][92] ([i915#180] / [i915#636]) [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-kbl3/igt@kms_fbcon_fbt@fbc-suspend.html [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-kbl6/igt@kms_fbcon_fbt@fbc-suspend.html * igt@kms_flip@plain-flip-ts-check@a-edp1: - shard-skl: [PASS][93] -> [FAIL][94] ([i915#2122]) [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-skl10/igt@kms_flip@plain-flip-ts-check@a-edp1.html [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-skl4/igt@kms_flip@plain-flip-ts-check@a-edp1.html * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-move: - shard-tglb: NOTRUN -> [SKIP][95] ([fdo#111825]) +4 similar issues [95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-move.html * igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-mmap-cpu: - shard-skl: NOTRUN -> [SKIP][96] ([fdo#109271]) +44 similar issues [96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-skl7/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-mmap-cpu.html * igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-mmap-gtt: - shard-kbl: NOTRUN -> [SKIP][97] ([fdo#109271]) +121 similar issues [97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-kbl2/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-mmap-gtt.html * igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max: - shard-apl: NOTRUN -> [FAIL][98] ([fdo#108145] / [i915#265]) [98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-apl4/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max.html * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc: - shard-skl: [PASS][99] -> [FAIL][100] ([fdo#108145] / [i915#265]) [99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-skl4/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html [100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-skl1/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html * igt@kms_plane_alpha_blend@pipe-c-alpha-basic: - shard-kbl: NOTRUN -> [FAIL][101] ([fdo#108145] / [i915#265]) +1 similar issue [101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-kbl4/igt@kms_plane_alpha_blend@pipe-c-alpha-basic.html * igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb: - shard-kbl: NOTRUN -> [FAIL][102] ([i915#265]) [102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-kbl6/igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb.html - shard-skl: NOTRUN -> [FAIL][103] ([i915#265]) [103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-skl7/igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb.html * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1: - shard-tglb: NOTRUN -> [SKIP][104] ([i915#2920]) +1 similar issue [104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-tglb2/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1.html * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3: - shard-apl: NOTRUN -> [SKIP][105] ([fdo#109271] / [i915#658]) [105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-apl7/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3.html * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4: - shard-skl: NOTRUN -> [SKIP][106] ([fdo#109271] / [i915#658]) [106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-skl7/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4.html * igt@kms_psr2_sf@plane-move-sf-dmg-area-2: - shard-glk: NOTRUN -> [SKIP][107] ([fdo#109271] / [i915#658]) [107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-glk5/igt@kms_psr2_sf@plane-move-sf-dmg-area-2.html * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5: - shard-kbl: NOTRUN -> [SKIP][108] ([fdo#109271] / [i915#658]) +3 similar issues [108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-kbl4/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5.html * igt@kms_psr@psr2_primary_mmap_gtt: - shard-iclb: [PASS][109] -> [SKIP][110] ([fdo#109441]) +1 similar issue [109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html [110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-iclb8/igt@kms_psr@psr2_primary_mmap_gtt.html * igt@kms_vblank@pipe-d-wait-idle: - shard-skl: NOTRUN -> [SKIP][111] ([fdo#109271] / [i915#533]) [111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-skl9/igt@kms_vblank@pipe-d-wait-idle.html * igt@nouveau_crc@pipe-c-source-rg: - shard-iclb: NOTRUN -> [SKIP][112] ([i915#2530]) [112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-iclb5/igt@nouveau_crc@pipe-c-source-rg.html * igt@perf@polling-parameterized: - shard-glk: [PASS][113] -> [FAIL][114] ([i915#1542]) [113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-glk1/igt@perf@polling-parameterized.html [114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-glk3/igt@perf@polling-parameterized.html * igt@perf_pmu@rc6-suspend: - shard-kbl: [PASS][115] -> [DMESG-WARN][116] ([i915#180]) +2 similar issues [115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-kbl3/igt@perf_pmu@rc6-suspend.html [116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-kbl6/igt@perf_pmu@rc6-suspend.html - shard-apl: [PASS][117] -> [DMESG-WARN][118] ([i915#180]) [117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-apl8/igt@perf_pmu@rc6-suspend.html [118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-apl8/igt@perf_pmu@rc6-suspend.html * igt@prime_nv_api@i915_nv_reimport_twice_check_flink_name: - shard-apl: NOTRUN -> [SKIP][119] ([fdo#109271]) +106 similar issues [119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-apl7/igt@prime_nv_api@i915_nv_reimport_twice_check_flink_name.html * igt@prime_vgem@basic-userptr: - shard-tglb: NOTRUN -> [SKIP][120] ([i915#3301]) [120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-tglb5/igt@prime_vgem@basic-userptr.html * igt@sysfs_clients@busy: - shard-apl: NOTRUN -> [SKIP][121] ([fdo#109271] / [i915#2994]) [121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-apl2/igt@sysfs_clients@busy.html - shard-kbl: NOTRUN -> [SKIP][122] ([fdo#109271] / [i915#2994]) [122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-kbl4/igt@sysfs_clients@busy.html #### Possible fixes #### * igt@drm_read@short-buffer-block: - {shard-rkl}: [SKIP][123] ([i915#4098]) -> [PASS][124] [123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-rkl-1/igt@drm_read@short-buffer-block.html [124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-rkl-6/igt@drm_read@short-buffer-block.html * igt@fbdev@info: - {shard-rkl}: [SKIP][125] ([i915#2582]) -> [PASS][126] [125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-rkl-1/igt@fbdev@info.html [126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-rkl-6/igt@fbdev@info.html * igt@gem_ctx_isolation@preservation-s3@rcs0: - shard-kbl: [INCOMPLETE][127] ([i915#794]) -> [PASS][128] [127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-kbl4/igt@gem_ctx_isolation@preservation-s3@rcs0.html [128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-kbl3/igt@gem_ctx_isolation@preservation-s3@rcs0.html * igt@gem_exec_fair@basic-deadline: - shard-glk: [FAIL][129] ([i915#2846]) -> [PASS][130] [129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-glk2/igt@gem_exec_fair@basic-deadline.html [130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-glk3/igt@gem_exec_fair@basic-deadline.html * igt@gem_exec_fair@basic-none@rcs0: - shard-glk: [FAIL][131] ([i915#2842]) -> [PASS][132] [131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-glk3/igt@gem_exec_fair@basic-none@rcs0.html [132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-glk5/igt@gem_exec_fair@basic-none@rcs0.html * igt@gem_exec_fair@basic-none@vcs0: - shard-apl: [FAIL][133] ([i915#2842]) -> [PASS][134] [133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-apl6/igt@gem_exec_fair@basic-none@vcs0.html [134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-apl8/igt@gem_exec_fair@basic-none@vcs0.html * igt@gem_exec_fair@basic-pace@vcs1: - shard-tglb: [FAIL][135] ([i915#2842]) -> [PASS][136] +2 similar issues [135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-tglb3/igt@gem_exec_fair@basic-pace@vcs1.html [136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-tglb1/igt@gem_exec_fair@basic-pace@vcs1.html * igt@gen9_exec_parse@allowed-all: - shard-glk: [DMESG-WARN][137] ([i915#1436] / [i915#716]) -> [PASS][138] [137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-glk3/igt@gen9_exec_parse@allowed-all.html [138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-glk5/igt@gen9_exec_parse@allowed-all.html * igt@i915_pm_dc@dc6-psr: - {shard-rkl}: [SKIP][139] ([i915#658]) -> [PASS][140] [139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-rkl-2/igt@i915_pm_dc@dc6-psr.html [140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-rkl-6/igt@i915_pm_dc@dc6-psr.html * igt@i915_pm_rpm@gem-execbuf: - {shard-rkl}: [SKIP][141] ([fdo#109308]) -> [PASS][142] [141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-rkl-1/igt@i915_pm_rpm@gem-execbuf.html [142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-rkl-6/igt@i915_pm_rpm@gem-execbuf.html * igt@i915_pm_rps@reset: - {shard-rkl}: [FAIL][143] ([i915#4016]) -> [PASS][144] [143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-rkl-1/igt@i915_pm_rps@reset.html [144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-rkl-1/igt@i915_pm_rps@reset.html * igt@i915_suspend@debugfs-reader: - shard-kbl: [DMESG-WARN][145] ([i915#180]) -> [PASS][146] +1 similar issue [145]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-kbl1/igt@i915_suspend@debugfs-reader.html [146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-kbl4/igt@i915_suspend@debugfs-reader.html * igt@kms_atomic@plane-primary-legacy: - {shard-rkl}: [SKIP][147] ([i915#1845]) -> [PASS][148] +17 similar issues [147]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-rkl-1/igt@kms_atomic@plane-primary-legacy.html [148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-rkl-6/igt@kms_atomic@plane-primary-legacy.html * igt@kms_color@pipe-b-legacy-gamma-reset: - {shard-rkl}: [SKIP][149] ([i915#1849] / [i915#4070]) -> [PASS][150] +1 similar issue [149]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-rkl-1/igt@kms_color@pipe-b-legacy-gamma-reset.html [150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-rkl-6/igt@kms_color@pipe-b-legacy-gamma-reset.html * igt@kms_cursor_crc@pipe-a-cursor-256x85-sliding: - {shard-rkl}: [SKIP][151] ([fdo#112022] / [i915#4070]) -> [PASS][152] +8 similar issues [151]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-rkl-1/igt@kms_cursor_crc@pipe-a-cursor-256x85-sliding.html [152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-rkl-6/igt@kms_cursor_crc@pipe-a-cursor-256x85-sliding.html * igt@kms_cursor_crc@pipe-a-cursor-64x64-rapid-movement: - {shard-rkl}: ([SKIP][153], [SKIP][154]) ([fdo#112022] / [i915#4070]) -> [PASS][155] [153]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-rkl-4/igt@kms_cursor_crc@pipe-a-cursor-64x64-rapid-movement.html [154]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-rkl-2/igt@kms_cursor_crc@pipe-a-cursor-64x64-rapid-movement.html [155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-rkl-6/igt@kms_cursor_crc@pipe-a-cursor-64x64-rapid-movement.html * igt@kms_cursor_legacy@basic-flip-after-cursor-legacy: - {shard-rkl}: ([SKIP][156], [SKIP][157]) ([fdo#111825] / [i915#4070]) -> [PASS][158] +1 similar issue [156]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-rkl-4/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html [157]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-rkl-1/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html [158]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-rkl-6/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html * igt@kms_cursor_legacy@flip-vs-cursor-legacy: - shard-skl: [FAIL][159] ([i915#2346]) -> [PASS][160] [159]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-skl3/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html [160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-skl9/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html * igt@kms_cursor_legacy@flip-vs-cursor-varying-size: - {shard-rkl}: [SKIP][161] ([fdo#111825] / [i915#4070]) -> [PASS][162] +2 similar issues [161]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-rkl-1/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html [162]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-rkl-6/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html * igt@kms_draw_crc@draw-method-rgb565-mmap-wc-untiled: - {shard-rkl}: [SKIP][163] ([fdo#111314]) -> [PASS][164] +1 similar issue [163]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-rkl-1/igt@kms_draw_crc@draw-method-rgb565-mmap-wc-untiled.html [164]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-rkl-6/igt@kms_draw_crc@draw-method-rgb565-mmap-wc-untiled.html * igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1: - shard-tglb: [FAIL][165] ([i915#2122]) -> [PASS][166] [165]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-tglb2/igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1.html [166]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-tglb3/igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1.html * igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1: - shard-skl: [FAIL][167] ([i915#2122]) -> [PASS][168] +2 similar issues [167]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-skl6/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html [168]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/shard-skl6/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html * igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-cpu: - {shard-rkl}: [SKIP][169] ([i915#1849]) -> [PASS][170] +26 similar issues [169]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10961/shard-rkl-1/ == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21745/index.html [-- Attachment #2: Type: text/html, Size: 33499 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-12-08 10:16 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2021-12-03 13:13 [Intel-gfx] [PATCH] drm/i915/ddi: add use_edp_hobl() and use_edp_low_vswing() helpers Jani Nikula 2021-12-03 13:36 ` Souza, Jose 2021-12-08 10:16 ` Jani Nikula 2021-12-03 15:13 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2021-12-03 21:40 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox