* [PATCH] drm/i915/psr: Disable PSR2 on Xiaomi Book Pro 14 2026 as a quirk
@ 2026-04-17 4:49 Jouni Högander
2026-04-17 7:52 ` Kahola, Mika
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jouni Högander @ 2026-04-17 4:49 UTC (permalink / raw)
To: intel-gfx, intel-xe; +Cc: Jouni Högander
Add new quirk (QUIRK_DISABLE_PSR2) for disabling PSR2 as a quirk for
problematic setups. Apply this newly added quirk on Xiaomi Book Pro 14 2026.
Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/work_items/7677
Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
---
drivers/gpu/drm/i915/display/intel_psr.c | 6 ++++++
drivers/gpu/drm/i915/display/intel_quirks.c | 9 +++++++++
drivers/gpu/drm/i915/display/intel_quirks.h | 1 +
3 files changed, 16 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index b4ca5843d098..19b3b9d52eb9 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -695,6 +695,12 @@ static void _psr_init_dpcd(struct intel_dp *intel_dp, struct intel_connector *co
connector->dp.psr_caps.sync_latency = intel_dp_get_sink_sync_latency(intel_dp);
+ if (intel_has_quirk(display, QUIRK_DISABLE_PSR2)) {
+ drm_dbg_kms(display->drm,
+ "PSR2 support not currently available for this setup\n");
+ return;
+ }
+
if (DISPLAY_VER(display) >= 9 &&
connector->dp.psr_caps.dpcd[0] >= DP_PSR2_WITH_Y_COORD_IS_SUPPORTED) {
bool y_req = connector->dp.psr_caps.dpcd[1] &
diff --git a/drivers/gpu/drm/i915/display/intel_quirks.c b/drivers/gpu/drm/i915/display/intel_quirks.c
index 883f297d4b83..229e0025a06c 100644
--- a/drivers/gpu/drm/i915/display/intel_quirks.c
+++ b/drivers/gpu/drm/i915/display/intel_quirks.c
@@ -94,6 +94,12 @@ static void quirk_disable_edp_panel_replay(struct intel_dp *intel_dp)
drm_info(display->drm, "Applying disable Panel Replay quirk\n");
}
+static void quirk_disable_psr2(struct intel_display *display)
+{
+ intel_set_quirk(display, QUIRK_DISABLE_PSR2);
+ drm_info(display->drm, "Applying disable PSR2 quirk\n");
+}
+
struct intel_quirk {
int device;
int subsystem_vendor;
@@ -250,6 +256,9 @@ static struct intel_quirk intel_quirks[] = {
/* Dell XPS 13 7390 2-in-1 */
{ 0x8a52, 0x1028, 0x08b0, quirk_edp_limit_rate_hbr2 },
+
+ /* Xiaomi Book Pro 14 2026 */
+ { 0xb081, 0x1d72, 0x2424, quirk_disable_psr2 },
};
static const struct intel_dpcd_quirk intel_dpcd_quirks[] = {
diff --git a/drivers/gpu/drm/i915/display/intel_quirks.h b/drivers/gpu/drm/i915/display/intel_quirks.h
index 83214eb94b0c..970a4fe52faf 100644
--- a/drivers/gpu/drm/i915/display/intel_quirks.h
+++ b/drivers/gpu/drm/i915/display/intel_quirks.h
@@ -22,6 +22,7 @@ enum intel_quirk_id {
QUIRK_FW_SYNC_LEN,
QUIRK_EDP_LIMIT_RATE_HBR2,
QUIRK_DISABLE_EDP_PANEL_REPLAY,
+ QUIRK_DISABLE_PSR2,
};
void intel_init_quirks(struct intel_display *display);
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH] drm/i915/psr: Disable PSR2 on Xiaomi Book Pro 14 2026 as a quirk
2026-04-17 4:49 [PATCH] drm/i915/psr: Disable PSR2 on Xiaomi Book Pro 14 2026 as a quirk Jouni Högander
@ 2026-04-17 7:52 ` Kahola, Mika
2026-04-17 8:30 ` Jani Nikula
2026-04-20 13:29 ` ✗ i915.CI.BAT: failure for " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Kahola, Mika @ 2026-04-17 7:52 UTC (permalink / raw)
To: Hogander, Jouni, intel-gfx@lists.freedesktop.org,
intel-xe@lists.freedesktop.org
Cc: Hogander, Jouni
> -----Original Message-----
> From: Intel-xe <intel-xe-bounces@lists.freedesktop.org> On Behalf Of Jouni Högander
> Sent: Friday, 17 April 2026 7.49
> To: intel-gfx@lists.freedesktop.org; intel-xe@lists.freedesktop.org
> Cc: Hogander, Jouni <jouni.hogander@intel.com>
> Subject: [PATCH] drm/i915/psr: Disable PSR2 on Xiaomi Book Pro 14 2026 as a quirk
>
> Add new quirk (QUIRK_DISABLE_PSR2) for disabling PSR2 as a quirk for problematic setups. Apply this newly added quirk on
> Xiaomi Book Pro 14 2026.
>
> Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/work_items/7677
LGTM,
Reviewed-by: Mika Kahola <mika.kahola@intel.com>
> Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_psr.c | 6 ++++++
> drivers/gpu/drm/i915/display/intel_quirks.c | 9 +++++++++ drivers/gpu/drm/i915/display/intel_quirks.h | 1 +
> 3 files changed, 16 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
> index b4ca5843d098..19b3b9d52eb9 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.c
> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> @@ -695,6 +695,12 @@ static void _psr_init_dpcd(struct intel_dp *intel_dp, struct intel_connector *co
>
> connector->dp.psr_caps.sync_latency = intel_dp_get_sink_sync_latency(intel_dp);
>
> + if (intel_has_quirk(display, QUIRK_DISABLE_PSR2)) {
> + drm_dbg_kms(display->drm,
> + "PSR2 support not currently available for this setup\n");
> + return;
> + }
> +
> if (DISPLAY_VER(display) >= 9 &&
> connector->dp.psr_caps.dpcd[0] >= DP_PSR2_WITH_Y_COORD_IS_SUPPORTED) {
> bool y_req = connector->dp.psr_caps.dpcd[1] & diff --git a/drivers/gpu/drm/i915/display/intel_quirks.c
> b/drivers/gpu/drm/i915/display/intel_quirks.c
> index 883f297d4b83..229e0025a06c 100644
> --- a/drivers/gpu/drm/i915/display/intel_quirks.c
> +++ b/drivers/gpu/drm/i915/display/intel_quirks.c
> @@ -94,6 +94,12 @@ static void quirk_disable_edp_panel_replay(struct intel_dp *intel_dp)
> drm_info(display->drm, "Applying disable Panel Replay quirk\n"); }
>
> +static void quirk_disable_psr2(struct intel_display *display) {
> + intel_set_quirk(display, QUIRK_DISABLE_PSR2);
> + drm_info(display->drm, "Applying disable PSR2 quirk\n"); }
> +
> struct intel_quirk {
> int device;
> int subsystem_vendor;
> @@ -250,6 +256,9 @@ static struct intel_quirk intel_quirks[] = {
>
> /* Dell XPS 13 7390 2-in-1 */
> { 0x8a52, 0x1028, 0x08b0, quirk_edp_limit_rate_hbr2 },
> +
> + /* Xiaomi Book Pro 14 2026 */
> + { 0xb081, 0x1d72, 0x2424, quirk_disable_psr2 },
> };
>
> static const struct intel_dpcd_quirk intel_dpcd_quirks[] = { diff --git a/drivers/gpu/drm/i915/display/intel_quirks.h
> b/drivers/gpu/drm/i915/display/intel_quirks.h
> index 83214eb94b0c..970a4fe52faf 100644
> --- a/drivers/gpu/drm/i915/display/intel_quirks.h
> +++ b/drivers/gpu/drm/i915/display/intel_quirks.h
> @@ -22,6 +22,7 @@ enum intel_quirk_id {
> QUIRK_FW_SYNC_LEN,
> QUIRK_EDP_LIMIT_RATE_HBR2,
> QUIRK_DISABLE_EDP_PANEL_REPLAY,
> + QUIRK_DISABLE_PSR2,
> };
>
> void intel_init_quirks(struct intel_display *display);
> --
> 2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/i915/psr: Disable PSR2 on Xiaomi Book Pro 14 2026 as a quirk
2026-04-17 4:49 [PATCH] drm/i915/psr: Disable PSR2 on Xiaomi Book Pro 14 2026 as a quirk Jouni Högander
2026-04-17 7:52 ` Kahola, Mika
@ 2026-04-17 8:30 ` Jani Nikula
2026-04-20 13:29 ` ✗ i915.CI.BAT: failure for " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Jani Nikula @ 2026-04-17 8:30 UTC (permalink / raw)
To: Jouni Högander, intel-gfx, intel-xe; +Cc: Jouni Högander
On Fri, 17 Apr 2026, Jouni Högander <jouni.hogander@intel.com> wrote:
> Add new quirk (QUIRK_DISABLE_PSR2) for disabling PSR2 as a quirk for
> problematic setups. Apply this newly added quirk on Xiaomi Book Pro 14 2026.
>
> Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/work_items/7677
> Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_psr.c | 6 ++++++
> drivers/gpu/drm/i915/display/intel_quirks.c | 9 +++++++++
> drivers/gpu/drm/i915/display/intel_quirks.h | 1 +
> 3 files changed, 16 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
> index b4ca5843d098..19b3b9d52eb9 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.c
> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> @@ -695,6 +695,12 @@ static void _psr_init_dpcd(struct intel_dp *intel_dp, struct intel_connector *co
>
> connector->dp.psr_caps.sync_latency = intel_dp_get_sink_sync_latency(intel_dp);
>
> + if (intel_has_quirk(display, QUIRK_DISABLE_PSR2)) {
> + drm_dbg_kms(display->drm,
> + "PSR2 support not currently available for this setup\n");
I think the logging when matching at intel_quirks.c should be
sufficient.
> + return;
> + }
> +
> if (DISPLAY_VER(display) >= 9 &&
> connector->dp.psr_caps.dpcd[0] >= DP_PSR2_WITH_Y_COORD_IS_SUPPORTED) {
> bool y_req = connector->dp.psr_caps.dpcd[1] &
> diff --git a/drivers/gpu/drm/i915/display/intel_quirks.c b/drivers/gpu/drm/i915/display/intel_quirks.c
> index 883f297d4b83..229e0025a06c 100644
> --- a/drivers/gpu/drm/i915/display/intel_quirks.c
> +++ b/drivers/gpu/drm/i915/display/intel_quirks.c
> @@ -94,6 +94,12 @@ static void quirk_disable_edp_panel_replay(struct intel_dp *intel_dp)
> drm_info(display->drm, "Applying disable Panel Replay quirk\n");
> }
>
> +static void quirk_disable_psr2(struct intel_display *display)
> +{
> + intel_set_quirk(display, QUIRK_DISABLE_PSR2);
> + drm_info(display->drm, "Applying disable PSR2 quirk\n");
Maybe "applying quirk" isn't the most informative? Perhaps combine
something from the other message here?
BR,
Jani.
> +}
> +
> struct intel_quirk {
> int device;
> int subsystem_vendor;
> @@ -250,6 +256,9 @@ static struct intel_quirk intel_quirks[] = {
>
> /* Dell XPS 13 7390 2-in-1 */
> { 0x8a52, 0x1028, 0x08b0, quirk_edp_limit_rate_hbr2 },
> +
> + /* Xiaomi Book Pro 14 2026 */
> + { 0xb081, 0x1d72, 0x2424, quirk_disable_psr2 },
> };
>
> static const struct intel_dpcd_quirk intel_dpcd_quirks[] = {
> diff --git a/drivers/gpu/drm/i915/display/intel_quirks.h b/drivers/gpu/drm/i915/display/intel_quirks.h
> index 83214eb94b0c..970a4fe52faf 100644
> --- a/drivers/gpu/drm/i915/display/intel_quirks.h
> +++ b/drivers/gpu/drm/i915/display/intel_quirks.h
> @@ -22,6 +22,7 @@ enum intel_quirk_id {
> QUIRK_FW_SYNC_LEN,
> QUIRK_EDP_LIMIT_RATE_HBR2,
> QUIRK_DISABLE_EDP_PANEL_REPLAY,
> + QUIRK_DISABLE_PSR2,
> };
>
> void intel_init_quirks(struct intel_display *display);
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 4+ messages in thread
* ✗ i915.CI.BAT: failure for drm/i915/psr: Disable PSR2 on Xiaomi Book Pro 14 2026 as a quirk
2026-04-17 4:49 [PATCH] drm/i915/psr: Disable PSR2 on Xiaomi Book Pro 14 2026 as a quirk Jouni Högander
2026-04-17 7:52 ` Kahola, Mika
2026-04-17 8:30 ` Jani Nikula
@ 2026-04-20 13:29 ` Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2026-04-20 13:29 UTC (permalink / raw)
To: Jouni Högander; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 6078 bytes --]
== Series Details ==
Series: drm/i915/psr: Disable PSR2 on Xiaomi Book Pro 14 2026 as a quirk
URL : https://patchwork.freedesktop.org/series/165035/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_18348 -> Patchwork_165035v1
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_165035v1 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_165035v1, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_165035v1/index.html
Participating hosts (42 -> 40)
------------------------------
Missing (2): bat-dg2-13 fi-snb-2520m
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_165035v1:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@objects:
- bat-arlh-3: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_18348/bat-arlh-3/igt@i915_selftest@live@objects.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_165035v1/bat-arlh-3/igt@i915_selftest@live@objects.html
Known issues
------------
Here are the changes found in Patchwork_165035v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live:
- bat-mtlp-8: [PASS][3] -> [DMESG-FAIL][4] ([i915#12061]) +1 other test dmesg-fail
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_18348/bat-mtlp-8/igt@i915_selftest@live.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_165035v1/bat-mtlp-8/igt@i915_selftest@live.html
* igt@i915_selftest@live@workarounds:
- bat-dg2-9: [PASS][5] -> [DMESG-FAIL][6] ([i915#12061]) +1 other test dmesg-fail
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_18348/bat-dg2-9/igt@i915_selftest@live@workarounds.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_165035v1/bat-dg2-9/igt@i915_selftest@live@workarounds.html
- bat-dg2-14: [PASS][7] -> [DMESG-FAIL][8] ([i915#12061]) +1 other test dmesg-fail
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_18348/bat-dg2-14/igt@i915_selftest@live@workarounds.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_165035v1/bat-dg2-14/igt@i915_selftest@live@workarounds.html
#### Possible fixes ####
* igt@gem_exec_fence@basic-await@bcs0:
- bat-dg2-9: [FAIL][9] ([i915#15263]) -> [PASS][10] +1 other test pass
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_18348/bat-dg2-9/igt@gem_exec_fence@basic-await@bcs0.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_165035v1/bat-dg2-9/igt@gem_exec_fence@basic-await@bcs0.html
* igt@i915_selftest@live@sanitycheck:
- fi-kbl-7567u: [DMESG-WARN][11] ([i915#13735]) -> [PASS][12] +79 other tests pass
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_18348/fi-kbl-7567u/igt@i915_selftest@live@sanitycheck.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_165035v1/fi-kbl-7567u/igt@i915_selftest@live@sanitycheck.html
* igt@i915_selftest@live@workarounds:
- bat-arlh-3: [DMESG-FAIL][13] ([i915#12061]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_18348/bat-arlh-3/igt@i915_selftest@live@workarounds.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_165035v1/bat-arlh-3/igt@i915_selftest@live@workarounds.html
- bat-arls-5: [DMESG-FAIL][15] ([i915#12061]) -> [PASS][16] +1 other test pass
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_18348/bat-arls-5/igt@i915_selftest@live@workarounds.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_165035v1/bat-arls-5/igt@i915_selftest@live@workarounds.html
* igt@kms_busy@basic@flip:
- fi-kbl-7567u: [DMESG-WARN][17] ([i915#13735] / [i915#180]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_18348/fi-kbl-7567u/igt@kms_busy@basic@flip.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_165035v1/fi-kbl-7567u/igt@kms_busy@basic@flip.html
* igt@kms_pm_rpm@basic-pci-d3-state:
- fi-kbl-7567u: [DMESG-WARN][19] ([i915#13735] / [i915#15673] / [i915#180]) -> [PASS][20] +52 other tests pass
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_18348/fi-kbl-7567u/igt@kms_pm_rpm@basic-pci-d3-state.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_165035v1/fi-kbl-7567u/igt@kms_pm_rpm@basic-pci-d3-state.html
#### Warnings ####
* igt@i915_selftest@live:
- bat-arlh-3: [DMESG-FAIL][21] ([i915#12061]) -> [INCOMPLETE][22] ([i915#15622])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_18348/bat-arlh-3/igt@i915_selftest@live.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_165035v1/bat-arlh-3/igt@i915_selftest@live.html
[i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061
[i915#13735]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13735
[i915#15263]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/15263
[i915#15622]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/15622
[i915#15673]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/15673
[i915#180]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/180
Build changes
-------------
* Linux: CI_DRM_18348 -> Patchwork_165035v1
CI-20190529: 20190529
CI_DRM_18348: 3b9ca4c40814c96c38986ae2ba6651e43757ca5f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_8863: 5b279a8b71dc1672099205a1a9e8135c7c7fadb5 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_165035v1: 3b9ca4c40814c96c38986ae2ba6651e43757ca5f @ git://anongit.freedesktop.org/gfx-ci/linux
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_165035v1/index.html
[-- Attachment #2: Type: text/html, Size: 7502 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-04-20 13:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-17 4:49 [PATCH] drm/i915/psr: Disable PSR2 on Xiaomi Book Pro 14 2026 as a quirk Jouni Högander
2026-04-17 7:52 ` Kahola, Mika
2026-04-17 8:30 ` Jani Nikula
2026-04-20 13:29 ` ✗ i915.CI.BAT: failure for " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox