Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Brzezinka <sebastian.brzezinka@intel.com>
To: <intel-gfx@lists.freedesktop.org>
Cc: <andi.shyti@linux.intel.com>, <chris.p.wilson@intel.com>,
	<krzysztof.karas@intel.com>, <krzysztof.niemiec@intel.com>,
	"Sebastian Brzezinka" <sebastian.brzezinka@intel.com>
Subject: [PATCH v6 0/3] drm/i915/selftests: fix stolen reset test races
Date: Wed, 18 Nov 2026 14:02:17 +0100	[thread overview]
Message-ID: <cover.1795006734.git.sebastian.brzezinka@intel.com> (raw)

The stolen reset selftests (igt_reset_device_stolen and
igt_reset_engines_stolen) poison the unused stolen pages, reset the GPU
and check that those pages did not change. This series fixes two races
in the test itself. Neither one is a GPU reset problem.

v5 -> v6:
- Split the series into 3 patches (Krzysztof)
- Drop the poisoned bitmap, it was redundant (Sashiko)
- Use raw_insert_page when available, like
  i915_vma_coredump_create() (Sashiko)
- Take error_mutex only around the sampling loops, not across the
  reset, to avoid a deadlock with the GuC CT worker (Sashiko)

v4 -> v5:
- Hold stolen_lock across the reset too
- Add a patch that takes ggtt->error_mutex in the test

Sebastian Brzezinka (3):
  drm/i915/selftests: Fix unlocked mm.stolen in reset selftest
  drm/i915/selftests: Limit stolen reset test to usable stolen
  drm/i915/selftests: take error_mutex in stolen reset test

 drivers/gpu/drm/i915/gt/selftest_reset.c | 52 ++++++++++++++++--------
 1 file changed, 34 insertions(+), 18 deletions(-)

-- 
2.56.1


             reply	other threads:[~2026-11-18 13:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 13:02 Sebastian Brzezinka [this message]
2026-11-18 13:02 ` [PATCH v6 1/3] drm/i915/selftests: Fix unlocked mm.stolen in reset selftest Sebastian Brzezinka
2026-11-18 13:31   ` sashiko-bot
2026-11-18 13:02 ` [PATCH v6 2/3] drm/i915/selftests: Limit stolen reset test to usable stolen Sebastian Brzezinka
2026-11-18 13:09   ` sashiko-bot
2026-11-18 13:02 ` [PATCH v6 3/3] drm/i915/selftests: take error_mutex in stolen reset test Sebastian Brzezinka
2026-11-18 13:13   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1795006734.git.sebastian.brzezinka@intel.com \
    --to=sebastian.brzezinka@intel.com \
    --cc=andi.shyti@linux.intel.com \
    --cc=chris.p.wilson@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=krzysztof.karas@intel.com \
    --cc=krzysztof.niemiec@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox