Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Sebastian Brzezinka" <sebastian.brzezinka@intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v6 2/3] drm/i915/selftests: Limit stolen reset test to usable stolen
Date: Wed, 18 Nov 2026 13:09:45 +0000	[thread overview]
Message-ID: <sashiko-outbox-220979@kernel.org> (raw)
In-Reply-To: <d8bba118ef131fa452570776a29606d469e151b4.1795006734.git.sebastian.brzezinka@intel.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/i915/selftests: missing Fixes trailer for
  __igt_reset_stolen() fix
--

commit b10bdf167e49f764d1b458f21032c5d7c411774c
Author: Sebastian Brzezinka <sebastian.brzezinka@intel.com>

> drm/i915/selftests: Limit stolen reset test to usable stolen
>
> The test pokes every page of the DSM, but the hardware reserved region
> is not part of mm.stolen and must not be written.
>
> Only scan the usable part of stolen memory (dsm.usable_size) instead of
> the whole DSM.
>
> Signed-off-by: Sebastian Brzezinka <sebastian.brzezinka@intel.com>

[Severity: Low]
__igt_reset_stolen() has scanned the entire DSM since it was introduced.
Should this bug fix include:

  Fixes: 3da3c5c1c982 ("drm/i915: Exclude low pages (128KiB) of stolen from use")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/c47b0ea2093da73a92e9e6d62b062f9cc52851d1.1795006734.git.sebastian.brzezinka@intel.com?part=2

  reply	other threads:[~2026-11-18 13:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 13:02 [PATCH v6 0/3] drm/i915/selftests: fix stolen reset test races Sebastian Brzezinka
2026-11-18 13:02 ` [PATCH v6 1/3] drm/i915/selftests: Fix unlocked mm.stolen in reset selftest Sebastian Brzezinka
2026-11-18 13:31   ` sashiko-bot
2026-11-18 13:02 ` [PATCH v6 2/3] drm/i915/selftests: Limit stolen reset test to usable stolen Sebastian Brzezinka
2026-11-18 13:09   ` sashiko-bot [this message]
2026-11-18 13:02 ` [PATCH v6 3/3] drm/i915/selftests: take error_mutex in stolen reset test Sebastian Brzezinka
2026-11-18 13:13   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-220979@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=sebastian.brzezinka@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox