From: Chris Wilson <chris@chris-wilson.co.uk>
To: Eric Anholt <eric@anholt.net>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/5] drm/i915: Bump the inactive LRU on set-to-GTT-domain
Date: Mon, 27 Feb 2012 19:00:54 +0000 [thread overview]
Message-ID: <d08817$3ag2q5@azsmga001.ch.intel.com> (raw)
In-Reply-To: <87k438jek6.fsf@eliezer.anholt.net>
On Mon, 27 Feb 2012 10:50:49 -0800, Eric Anholt <eric@anholt.net> wrote:
> On Fri, 24 Feb 2012 21:13:39 +0000, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > @@ -2923,6 +2914,9 @@ i915_gem_object_set_to_gtt_domain(struct drm_i915_gem_object *obj, bool write)
> > old_read_domains,
> > old_write_domain);
> >
> > + /* And bump the LRU for this access */
> > + list_move_tail(&obj->mm_list, &dev_priv->mm.inactive_list);
>
> I don't think you know that !obj->active here. For example, going to
> GTT read of something that was currently active and in the SAMPLER read
> domain.
You're right, I was thinking the wait_rendering() was unconditional like
for set-to-cpu-domain. Oh well, at least we can still benefit from not
having to worry about being inactive-but-pinned...
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-02-27 19:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-24 21:13 [RFC] Try harder to allocate an mmap offset Chris Wilson
2012-02-24 21:13 ` [PATCH 1/5] drm/i915: Release the mmap offset when purging a buffer Chris Wilson
2012-03-23 10:06 ` Daniel Vetter
2012-02-24 21:13 ` [PATCH 2/5] drm/i915: Bump the inactive LRU on set-to-GTT-domain Chris Wilson
2012-02-27 18:50 ` Eric Anholt
2012-02-27 19:00 ` Chris Wilson [this message]
2012-02-24 21:13 ` [PATCH 3/5] drm/i915: Remove the list of pinned inactive objects Chris Wilson
2012-02-24 21:13 ` [PATCH 4/5] drm/i915: Remove the deferred-free list Chris Wilson
2012-02-24 21:30 ` Chris Wilson
2012-03-20 13:38 ` Daniel Vetter
2012-03-20 13:59 ` Chris Wilson
2012-02-24 21:13 ` [PATCH 5/5] drm/i915: Try harder to allocate an mmap_offset Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='d08817$3ag2q5@azsmga001.ch.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=eric@anholt.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox