From: Chris Wilson <chris@chris-wilson.co.uk>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 4/5] drm/i915: Remove the deferred-free list
Date: Tue, 20 Mar 2012 13:59:19 +0000 [thread overview]
Message-ID: <e39f63$47a0nf@fmsmga002.fm.intel.com> (raw)
In-Reply-To: <20120320133851.GA27231@phenom.ffwll.local>
On Tue, 20 Mar 2012 14:38:51 +0100, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Fri, Feb 24, 2012 at 09:30:33PM +0000, Chris Wilson wrote:
> I haven't looked much at the patch, but the deferred-free looks more bogus
> the more I stare at it. As long as an object is active, we /should/ have a
> reference on it, so we should never fail to wait for outstanding rendering
> on the final free. The only execption is the ilk/vt-d unbind w/a, but that
> one is already uninterruptible.
>
> So I think we should just drop the deferred free list, check for any
> errors from unbind with a WARN_ON and bail out (leaking the bo) in that
> case.
Right. I am just worried because we did have a bug with a case where it
appeared that we did free an active object. I will have to dig through
that and see if could be explained by some other use-after-free.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-03-20 13:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-24 21:13 [RFC] Try harder to allocate an mmap offset Chris Wilson
2012-02-24 21:13 ` [PATCH 1/5] drm/i915: Release the mmap offset when purging a buffer Chris Wilson
2012-03-23 10:06 ` Daniel Vetter
2012-02-24 21:13 ` [PATCH 2/5] drm/i915: Bump the inactive LRU on set-to-GTT-domain Chris Wilson
2012-02-27 18:50 ` Eric Anholt
2012-02-27 19:00 ` Chris Wilson
2012-02-24 21:13 ` [PATCH 3/5] drm/i915: Remove the list of pinned inactive objects Chris Wilson
2012-02-24 21:13 ` [PATCH 4/5] drm/i915: Remove the deferred-free list Chris Wilson
2012-02-24 21:30 ` Chris Wilson
2012-03-20 13:38 ` Daniel Vetter
2012-03-20 13:59 ` Chris Wilson [this message]
2012-02-24 21:13 ` [PATCH 5/5] drm/i915: Try harder to allocate an mmap_offset Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='e39f63$47a0nf@fmsmga002.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox