From: Matthew Auld <matthew.auld@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/gt: Onion unwind for scratch page allocation failure
Date: Mon, 19 Oct 2020 11:51:22 +0100 [thread overview]
Message-ID: <d0c62faa-78d7-6ce0-fa04-776f752f281c@intel.com> (raw)
In-Reply-To: <20201019083444.1286-1-chris@chris-wilson.co.uk>
On 19/10/2020 09:34, Chris Wilson wrote:
> In switching to using objects for our ppGTT scratch pages, care was not
> taken to avoid trying to unref NULL objects on failure. And for gen6
> ppGTT, it appears we forgot entirely to unwind after a partial allocation
> failure.
>
> Fixes: 89351925a477 ("drm/i915/gt: Switch to object allocations for page directories")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Matthew Auld <matthew.auld@intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-10-19 10:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 8:34 [Intel-gfx] [PATCH] drm/i915/gt: Onion unwind for scratch page allocation failure Chris Wilson
2020-10-19 9:09 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-10-19 10:51 ` Matthew Auld [this message]
2020-10-19 11:30 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-10-19 16:10 ` [Intel-gfx] [PATCH] " Tang, CQ
2020-10-20 16:27 ` Tang, CQ
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0c62faa-78d7-6ce0-fa04-776f752f281c@intel.com \
--to=matthew.auld@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox