* [Intel-gfx] [PATCH] drm/i915/hdcp: Modify hdcp_gsc_message msg sending mechanism
@ 2023-06-02 10:51 Suraj Kandpal
2023-06-02 12:15 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Suraj Kandpal @ 2023-06-02 10:51 UTC (permalink / raw)
To: intel-gfx; +Cc: Alan Previn
Allocate a multipage object that can be used for input
and output for intel_hdcp_gsc_message so that corruption of
output message can be avoided by the current overwriting method.
Modify intel_gsc_send_sync() to take into account header_out
and addr_out so as to use them to verify the message send status.
Check link for comment and review history
https://patchwork.freedesktop.org/series/118499/
--v2
-Change approach from allocating two objects to just one multipage
object [Daniele]
--v3
-Squash the two patches together [Daniele]
-No need to allocate twice the size of intel_hdcp_gsc_message [Daniele]
Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Cc: Alan Previn <alan.previn.teres.alexis@intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
---
drivers/gpu/drm/i915/display/intel_hdcp_gsc.c | 80 +++++++++++--------
drivers/gpu/drm/i915/display/intel_hdcp_gsc.h | 3 +-
2 files changed, 49 insertions(+), 34 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c b/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c
index 7e52aea6aa17..a0eb49dfa133 100644
--- a/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c
+++ b/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c
@@ -621,24 +621,26 @@ static int intel_hdcp_gsc_initialize_message(struct drm_i915_private *i915,
struct intel_gt *gt = i915->media_gt;
struct drm_i915_gem_object *obj = NULL;
struct i915_vma *vma = NULL;
- void *cmd;
+ void *cmd_in, *cmd_out;
int err;
- /* allocate object of one page for HDCP command memory and store it */
- obj = i915_gem_object_create_shmem(i915, PAGE_SIZE);
+ /* allocate object of two page for HDCP command memory and store it */
+ obj = i915_gem_object_create_shmem(i915, 2 * PAGE_SIZE);
if (IS_ERR(obj)) {
drm_err(&i915->drm, "Failed to allocate HDCP streaming command!\n");
return PTR_ERR(obj);
}
- cmd = i915_gem_object_pin_map_unlocked(obj, i915_coherent_map_type(i915, obj, true));
- if (IS_ERR(cmd)) {
+ cmd_in = i915_gem_object_pin_map_unlocked(obj, i915_coherent_map_type(i915, obj, true));
+ if (IS_ERR(cmd_in)) {
drm_err(&i915->drm, "Failed to map gsc message page!\n");
- err = PTR_ERR(cmd);
+ err = PTR_ERR(cmd_in);
goto out_unpin;
}
+ cmd_out = cmd_in + PAGE_SIZE;
+
vma = i915_vma_instance(obj, >->ggtt->vm, NULL);
if (IS_ERR(vma)) {
err = PTR_ERR(vma);
@@ -649,9 +651,10 @@ static int intel_hdcp_gsc_initialize_message(struct drm_i915_private *i915,
if (err)
goto out_unmap;
- memset(cmd, 0, obj->base.size);
+ memset(cmd_in, 0, obj->base.size);
- hdcp_message->hdcp_cmd = cmd;
+ hdcp_message->hdcp_cmd_in = cmd_in;
+ hdcp_message->hdcp_cmd_out = cmd_out;
hdcp_message->vma = vma;
return 0;
@@ -691,6 +694,8 @@ static void intel_hdcp_gsc_free_message(struct drm_i915_private *i915)
struct intel_hdcp_gsc_message *hdcp_message =
i915->display.hdcp.hdcp_message;
+ hdcp_message->hdcp_cmd_in = NULL;
+ hdcp_message->hdcp_cmd_out = NULL;
i915_vma_unpin_and_release(&hdcp_message->vma, I915_VMA_RELEASE_MAP);
kfree(hdcp_message);
}
@@ -721,38 +726,42 @@ void intel_hdcp_gsc_fini(struct drm_i915_private *i915)
}
static int intel_gsc_send_sync(struct drm_i915_private *i915,
- struct intel_gsc_mtl_header *header, u64 addr,
+ struct intel_gsc_mtl_header *header_in,
+ struct intel_gsc_mtl_header *header_out,
+ u64 addr_in, u64 addr_out,
size_t msg_out_len)
{
struct intel_gt *gt = i915->media_gt;
int ret;
- header->flags = 0;
- ret = intel_gsc_uc_heci_cmd_submit_packet(>->uc.gsc, addr,
- header->message_size,
- addr,
- msg_out_len + sizeof(*header));
+ ret = intel_gsc_uc_heci_cmd_submit_packet(>->uc.gsc, addr_in,
+ header_in->message_size,
+ addr_out,
+ msg_out_len + sizeof(*header_out));
if (ret) {
drm_err(&i915->drm, "failed to send gsc HDCP msg (%d)\n", ret);
return ret;
}
/*
- * Checking validity marker for memory sanity
+ * Checking validity marker and header status to see if some error has
+ * blocked us from sending message to gsc cs
*/
- if (header->validity_marker != GSC_HECI_VALIDITY_MARKER) {
+ if (header_out->validity_marker != GSC_HECI_VALIDITY_MARKER) {
drm_err(&i915->drm, "invalid validity marker\n");
return -EINVAL;
}
- if (header->status != 0) {
+ if (header_out->status != 0) {
drm_err(&i915->drm, "header status indicates error %d\n",
- header->status);
+ header_out->status);
return -EINVAL;
}
- if (header->flags & GSC_OUTFLAG_MSG_PENDING)
+ if (header_out->flags & GSC_OUTFLAG_MSG_PENDING) {
+ header_in->gsc_message_handle = header_out->gsc_message_handle;
return -EAGAIN;
+ }
return 0;
}
@@ -769,11 +778,11 @@ ssize_t intel_hdcp_gsc_msg_send(struct drm_i915_private *i915, u8 *msg_in,
size_t msg_out_len)
{
struct intel_gt *gt = i915->media_gt;
- struct intel_gsc_mtl_header *header;
- const size_t max_msg_size = PAGE_SIZE - sizeof(*header);
+ struct intel_gsc_mtl_header *header_in, *header_out;
+ const size_t max_msg_size = PAGE_SIZE - sizeof(*header_in);
struct intel_hdcp_gsc_message *hdcp_message;
- u64 addr, host_session_id;
- u32 reply_size, msg_size;
+ u64 addr_in, addr_out, host_session_id;
+ u32 reply_size, msg_size_in, msg_size_out;
int ret, tries = 0;
if (!intel_uc_uses_gsc_uc(>->uc))
@@ -782,16 +791,20 @@ ssize_t intel_hdcp_gsc_msg_send(struct drm_i915_private *i915, u8 *msg_in,
if (msg_in_len > max_msg_size || msg_out_len > max_msg_size)
return -ENOSPC;
+ msg_size_in = msg_in_len + sizeof(*header_in);
+ msg_size_out = msg_out_len + sizeof(*header_out);
hdcp_message = i915->display.hdcp.hdcp_message;
- header = hdcp_message->hdcp_cmd;
- addr = i915_ggtt_offset(hdcp_message->vma);
+ header_in = hdcp_message->hdcp_cmd_in;
+ header_out = hdcp_message->hdcp_cmd_out;
+ addr_in = i915_ggtt_offset(hdcp_message->vma);
+ addr_out = addr_in + PAGE_SIZE;
- msg_size = msg_in_len + sizeof(*header);
- memset(header, 0, msg_size);
+ memset(header_in, 0, msg_size_in);
+ memset(header_out, 0, msg_size_out);
get_random_bytes(&host_session_id, sizeof(u64));
- intel_gsc_uc_heci_cmd_emit_mtl_header(header, HECI_MEADDRESS_HDCP,
- msg_size, host_session_id);
- memcpy(hdcp_message->hdcp_cmd + sizeof(*header), msg_in, msg_in_len);
+ intel_gsc_uc_heci_cmd_emit_mtl_header(header_in, HECI_MEADDRESS_HDCP,
+ msg_size_in, host_session_id);
+ memcpy(hdcp_message->hdcp_cmd_in + sizeof(*header_in), msg_in, msg_in_len);
/*
* Keep sending request in case the pending bit is set no need to add
@@ -800,7 +813,8 @@ ssize_t intel_hdcp_gsc_msg_send(struct drm_i915_private *i915, u8 *msg_in,
* 20 times each message 50 ms apart
*/
do {
- ret = intel_gsc_send_sync(i915, header, addr, msg_out_len);
+ ret = intel_gsc_send_sync(i915, header_in, header_out, addr_in,
+ addr_out, msg_out_len);
/* Only try again if gsc says so */
if (ret != -EAGAIN)
@@ -814,7 +828,7 @@ ssize_t intel_hdcp_gsc_msg_send(struct drm_i915_private *i915, u8 *msg_in,
goto err;
/* we use the same mem for the reply, so header is in the same loc */
- reply_size = header->message_size - sizeof(*header);
+ reply_size = header_out->message_size - sizeof(*header_out);
if (reply_size > msg_out_len) {
drm_warn(&i915->drm, "caller with insufficient HDCP reply size %u (%d)\n",
reply_size, (u32)msg_out_len);
@@ -824,7 +838,7 @@ ssize_t intel_hdcp_gsc_msg_send(struct drm_i915_private *i915, u8 *msg_in,
reply_size, (u32)msg_out_len);
}
- memcpy(msg_out, hdcp_message->hdcp_cmd + sizeof(*header), msg_out_len);
+ memcpy(msg_out, hdcp_message->hdcp_cmd_out + sizeof(*header_out), msg_out_len);
err:
return ret;
diff --git a/drivers/gpu/drm/i915/display/intel_hdcp_gsc.h b/drivers/gpu/drm/i915/display/intel_hdcp_gsc.h
index 5cc9fd2e88f6..cbf96551e534 100644
--- a/drivers/gpu/drm/i915/display/intel_hdcp_gsc.h
+++ b/drivers/gpu/drm/i915/display/intel_hdcp_gsc.h
@@ -13,7 +13,8 @@ struct drm_i915_private;
struct intel_hdcp_gsc_message {
struct i915_vma *vma;
- void *hdcp_cmd;
+ void *hdcp_cmd_in;
+ void *hdcp_cmd_out;
};
bool intel_hdcp_gsc_cs_required(struct drm_i915_private *i915);
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/hdcp: Modify hdcp_gsc_message msg sending mechanism
2023-06-02 10:51 [Intel-gfx] [PATCH] drm/i915/hdcp: Modify hdcp_gsc_message msg sending mechanism Suraj Kandpal
@ 2023-06-02 12:15 ` Patchwork
2023-06-04 13:00 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-06-15 10:41 ` [Intel-gfx] [PATCH] " Nautiyal, Ankit K
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2023-06-02 12:15 UTC (permalink / raw)
To: Suraj Kandpal; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 8020 bytes --]
== Series Details ==
Series: drm/i915/hdcp: Modify hdcp_gsc_message msg sending mechanism
URL : https://patchwork.freedesktop.org/series/118769/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13218 -> Patchwork_118769v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118769v1/index.html
Participating hosts (38 -> 37)
------------------------------
Missing (1): bat-dg1-5
Known issues
------------
Here are the changes found in Patchwork_118769v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-hsw-4770: [PASS][1] -> [SKIP][2] ([fdo#109271])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/fi-hsw-4770/igt@i915_pm_rpm@basic-pci-d3-state.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118769v1/fi-hsw-4770/igt@i915_pm_rpm@basic-pci-d3-state.html
* igt@i915_pm_rpm@basic-rte:
- fi-hsw-4770: [PASS][3] -> [FAIL][4] ([i915#7364])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/fi-hsw-4770/igt@i915_pm_rpm@basic-rte.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118769v1/fi-hsw-4770/igt@i915_pm_rpm@basic-rte.html
* igt@i915_selftest@live@gt_heartbeat:
- fi-kbl-soraka: [PASS][5] -> [DMESG-FAIL][6] ([i915#5334] / [i915#7872])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118769v1/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@gt_pm:
- bat-rpls-2: [PASS][7] -> [DMESG-FAIL][8] ([i915#4258] / [i915#7913])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/bat-rpls-2/igt@i915_selftest@live@gt_pm.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118769v1/bat-rpls-2/igt@i915_selftest@live@gt_pm.html
* igt@i915_suspend@basic-s2idle-without-i915:
- bat-rpls-2: NOTRUN -> [ABORT][9] ([i915#6687])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118769v1/bat-rpls-2/igt@i915_suspend@basic-s2idle-without-i915.html
* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1:
- bat-dg2-8: [PASS][10] -> [FAIL][11] ([i915#7932]) +1 similar issue
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118769v1/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1.html
* igt@kms_pipe_crc_basic@nonblocking-crc@pipe-c-dp-1:
- fi-kbl-7567u: [PASS][12] -> [FAIL][13] ([i915#7932])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/fi-kbl-7567u/igt@kms_pipe_crc_basic@nonblocking-crc@pipe-c-dp-1.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118769v1/fi-kbl-7567u/igt@kms_pipe_crc_basic@nonblocking-crc@pipe-c-dp-1.html
#### Possible fixes ####
* igt@core_auth@basic-auth:
- {bat-adlp-11}: [ABORT][14] ([i915#4423] / [i915#8011]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/bat-adlp-11/igt@core_auth@basic-auth.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118769v1/bat-adlp-11/igt@core_auth@basic-auth.html
* igt@i915_module_load@load:
- {bat-adlp-11}: [DMESG-WARN][16] ([i915#4423]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/bat-adlp-11/igt@i915_module_load@load.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118769v1/bat-adlp-11/igt@i915_module_load@load.html
* igt@i915_selftest@live@gt_heartbeat:
- fi-apl-guc: [DMESG-FAIL][18] ([i915#5334]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118769v1/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@hugepages:
- fi-apl-guc: [DMESG-FAIL][20] -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/fi-apl-guc/igt@i915_selftest@live@hugepages.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118769v1/fi-apl-guc/igt@i915_selftest@live@hugepages.html
* igt@i915_selftest@live@requests:
- bat-rpls-2: [ABORT][22] ([i915#4983] / [i915#7913]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/bat-rpls-2/igt@i915_selftest@live@requests.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118769v1/bat-rpls-2/igt@i915_selftest@live@requests.html
#### Warnings ####
* igt@i915_selftest@live@reset:
- bat-rpls-1: [ABORT][24] ([i915#4983] / [i915#7461] / [i915#7981] / [i915#8347] / [i915#8384]) -> [ABORT][25] ([i915#4983] / [i915#7461] / [i915#8347] / [i915#8384])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/bat-rpls-1/igt@i915_selftest@live@reset.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118769v1/bat-rpls-1/igt@i915_selftest@live@reset.html
* igt@kms_psr@sprite_plane_onoff:
- bat-rplp-1: [SKIP][26] ([i915#1072]) -> [ABORT][27] ([i915#8442])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/bat-rplp-1/igt@kms_psr@sprite_plane_onoff.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118769v1/bat-rplp-1/igt@kms_psr@sprite_plane_onoff.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#4093]: https://gitlab.freedesktop.org/drm/intel/issues/4093
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4258]: https://gitlab.freedesktop.org/drm/intel/issues/4258
[i915#4309]: https://gitlab.freedesktop.org/drm/intel/issues/4309
[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
[i915#7364]: https://gitlab.freedesktop.org/drm/intel/issues/7364
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7872]: https://gitlab.freedesktop.org/drm/intel/issues/7872
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7932]: https://gitlab.freedesktop.org/drm/intel/issues/7932
[i915#7981]: https://gitlab.freedesktop.org/drm/intel/issues/7981
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
[i915#8384]: https://gitlab.freedesktop.org/drm/intel/issues/8384
[i915#8442]: https://gitlab.freedesktop.org/drm/intel/issues/8442
[i915#8497]: https://gitlab.freedesktop.org/drm/intel/issues/8497
Build changes
-------------
* Linux: CI_DRM_13218 -> Patchwork_118769v1
CI-20190529: 20190529
CI_DRM_13218: 42043133c83c69e384fb66060c97b093df67aed7 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7317: c902b72df45aa49faa38205bc5be3c748d33a3e0 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_118769v1: 42043133c83c69e384fb66060c97b093df67aed7 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
902e14a7d065 drm/i915/hdcp: Modify hdcp_gsc_message msg sending mechanism
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118769v1/index.html
[-- Attachment #2: Type: text/html, Size: 9085 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/hdcp: Modify hdcp_gsc_message msg sending mechanism
2023-06-02 10:51 [Intel-gfx] [PATCH] drm/i915/hdcp: Modify hdcp_gsc_message msg sending mechanism Suraj Kandpal
2023-06-02 12:15 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2023-06-04 13:00 ` Patchwork
2023-06-15 10:41 ` [Intel-gfx] [PATCH] " Nautiyal, Ankit K
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2023-06-04 13:00 UTC (permalink / raw)
To: Suraj Kandpal; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 9983 bytes --]
== Series Details ==
Series: drm/i915/hdcp: Modify hdcp_gsc_message msg sending mechanism
URL : https://patchwork.freedesktop.org/series/118769/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13218_full -> Patchwork_118769v1_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (7 -> 7)
------------------------------
No changes in participating hosts
Known issues
------------
Here are the changes found in Patchwork_118769v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-apl: [PASS][1] -> [FAIL][2] ([i915#2346])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118769v1/shard-apl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_hdmi_inject@inject-audio:
- shard-snb: [PASS][3] -> [SKIP][4] ([fdo#109271])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/shard-snb4/igt@kms_hdmi_inject@inject-audio.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118769v1/shard-snb5/igt@kms_hdmi_inject@inject-audio.html
* igt@kms_plane_scaling@plane-upscale-with-modifiers-factor-0-25@pipe-b-hdmi-a-1:
- shard-snb: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#4579]) +13 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118769v1/shard-snb1/igt@kms_plane_scaling@plane-upscale-with-modifiers-factor-0-25@pipe-b-hdmi-a-1.html
* igt@kms_plane_scaling@planes-downscale-factor-0-75@pipe-a-hdmi-a-1:
- shard-snb: NOTRUN -> [SKIP][6] ([fdo#109271]) +18 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118769v1/shard-snb1/igt@kms_plane_scaling@planes-downscale-factor-0-75@pipe-a-hdmi-a-1.html
#### Possible fixes ####
* igt@drm_fdinfo@most-busy-check-all@rcs0:
- {shard-rkl}: [FAIL][7] ([i915#7742]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/shard-rkl-6/igt@drm_fdinfo@most-busy-check-all@rcs0.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118769v1/shard-rkl-3/igt@drm_fdinfo@most-busy-check-all@rcs0.html
* igt@gem_ctx_freq@sysfs:
- {shard-dg1}: [FAIL][9] ([i915#6786]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/shard-dg1-19/igt@gem_ctx_freq@sysfs.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118769v1/shard-dg1-18/igt@gem_ctx_freq@sysfs.html
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [FAIL][11] ([i915#2842]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/shard-apl7/igt@gem_exec_fair@basic-none-solo@rcs0.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118769v1/shard-apl6/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@gem_exec_fair@basic-none@vecs0:
- {shard-rkl}: [FAIL][13] ([i915#2842]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/shard-rkl-1/igt@gem_exec_fair@basic-none@vecs0.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118769v1/shard-rkl-7/igt@gem_exec_fair@basic-none@vecs0.html
* igt@i915_pm_rpm@dpms-mode-unset-lpsp:
- {shard-rkl}: [SKIP][15] ([i915#1397]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/shard-rkl-1/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118769v1/shard-rkl-7/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html
* igt@i915_pm_rpm@modeset-non-lpsp:
- {shard-dg1}: [SKIP][17] ([i915#1397]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/shard-dg1-19/igt@i915_pm_rpm@modeset-non-lpsp.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118769v1/shard-dg1-18/igt@i915_pm_rpm@modeset-non-lpsp.html
* igt@kms_big_fb@y-tiled-32bpp-rotate-90:
- shard-glk: [DMESG-WARN][19] -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/shard-glk9/igt@kms_big_fb@y-tiled-32bpp-rotate-90.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118769v1/shard-glk1/igt@kms_big_fb@y-tiled-32bpp-rotate-90.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-glk: [FAIL][21] ([i915#2346]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/shard-glk3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118769v1/shard-glk9/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_cursor_legacy@single-move@pipe-b:
- {shard-dg1}: [INCOMPLETE][23] ([i915#8011] / [i915#8347]) -> [PASS][24] +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/shard-dg1-19/igt@kms_cursor_legacy@single-move@pipe-b.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118769v1/shard-dg1-14/igt@kms_cursor_legacy@single-move@pipe-b.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-dp1:
- shard-apl: [FAIL][25] ([i915#79]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/shard-apl3/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-dp1.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118769v1/shard-apl7/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-dp1.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6786]: https://gitlab.freedesktop.org/drm/intel/issues/6786
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213
[i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
[i915#8398]: https://gitlab.freedesktop.org/drm/intel/issues/8398
Build changes
-------------
* Linux: CI_DRM_13218 -> Patchwork_118769v1
CI-20190529: 20190529
CI_DRM_13218: 42043133c83c69e384fb66060c97b093df67aed7 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7317: c902b72df45aa49faa38205bc5be3c748d33a3e0 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_118769v1: 42043133c83c69e384fb66060c97b093df67aed7 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118769v1/index.html
[-- Attachment #2: Type: text/html, Size: 8347 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/hdcp: Modify hdcp_gsc_message msg sending mechanism
2023-06-02 10:51 [Intel-gfx] [PATCH] drm/i915/hdcp: Modify hdcp_gsc_message msg sending mechanism Suraj Kandpal
2023-06-02 12:15 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2023-06-04 13:00 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
@ 2023-06-15 10:41 ` Nautiyal, Ankit K
2 siblings, 0 replies; 4+ messages in thread
From: Nautiyal, Ankit K @ 2023-06-15 10:41 UTC (permalink / raw)
To: Suraj Kandpal, intel-gfx; +Cc: Alan Previn
On 6/2/2023 4:21 PM, Suraj Kandpal wrote:
> Allocate a multipage object that can be used for input
> and output for intel_hdcp_gsc_message so that corruption of
> output message can be avoided by the current overwriting method.
> Modify intel_gsc_send_sync() to take into account header_out
> and addr_out so as to use them to verify the message send status.
> Check link for comment and review history
> https://patchwork.freedesktop.org/series/118499/
>
> --v2
> -Change approach from allocating two objects to just one multipage
> object [Daniele]
>
> --v3
> -Squash the two patches together [Daniele]
> -No need to allocate twice the size of intel_hdcp_gsc_message [Daniele]
>
> Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> Cc: Alan Previn <alan.previn.teres.alexis@intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
> Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Patch merged in drm-intel-next. Thanks for the patch and reviews.
Regards,
Ankit
> ---
> drivers/gpu/drm/i915/display/intel_hdcp_gsc.c | 80 +++++++++++--------
> drivers/gpu/drm/i915/display/intel_hdcp_gsc.h | 3 +-
> 2 files changed, 49 insertions(+), 34 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c b/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c
> index 7e52aea6aa17..a0eb49dfa133 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c
> @@ -621,24 +621,26 @@ static int intel_hdcp_gsc_initialize_message(struct drm_i915_private *i915,
> struct intel_gt *gt = i915->media_gt;
> struct drm_i915_gem_object *obj = NULL;
> struct i915_vma *vma = NULL;
> - void *cmd;
> + void *cmd_in, *cmd_out;
> int err;
>
> - /* allocate object of one page for HDCP command memory and store it */
> - obj = i915_gem_object_create_shmem(i915, PAGE_SIZE);
> + /* allocate object of two page for HDCP command memory and store it */
> + obj = i915_gem_object_create_shmem(i915, 2 * PAGE_SIZE);
>
> if (IS_ERR(obj)) {
> drm_err(&i915->drm, "Failed to allocate HDCP streaming command!\n");
> return PTR_ERR(obj);
> }
>
> - cmd = i915_gem_object_pin_map_unlocked(obj, i915_coherent_map_type(i915, obj, true));
> - if (IS_ERR(cmd)) {
> + cmd_in = i915_gem_object_pin_map_unlocked(obj, i915_coherent_map_type(i915, obj, true));
> + if (IS_ERR(cmd_in)) {
> drm_err(&i915->drm, "Failed to map gsc message page!\n");
> - err = PTR_ERR(cmd);
> + err = PTR_ERR(cmd_in);
> goto out_unpin;
> }
>
> + cmd_out = cmd_in + PAGE_SIZE;
> +
> vma = i915_vma_instance(obj, >->ggtt->vm, NULL);
> if (IS_ERR(vma)) {
> err = PTR_ERR(vma);
> @@ -649,9 +651,10 @@ static int intel_hdcp_gsc_initialize_message(struct drm_i915_private *i915,
> if (err)
> goto out_unmap;
>
> - memset(cmd, 0, obj->base.size);
> + memset(cmd_in, 0, obj->base.size);
>
> - hdcp_message->hdcp_cmd = cmd;
> + hdcp_message->hdcp_cmd_in = cmd_in;
> + hdcp_message->hdcp_cmd_out = cmd_out;
> hdcp_message->vma = vma;
>
> return 0;
> @@ -691,6 +694,8 @@ static void intel_hdcp_gsc_free_message(struct drm_i915_private *i915)
> struct intel_hdcp_gsc_message *hdcp_message =
> i915->display.hdcp.hdcp_message;
>
> + hdcp_message->hdcp_cmd_in = NULL;
> + hdcp_message->hdcp_cmd_out = NULL;
> i915_vma_unpin_and_release(&hdcp_message->vma, I915_VMA_RELEASE_MAP);
> kfree(hdcp_message);
> }
> @@ -721,38 +726,42 @@ void intel_hdcp_gsc_fini(struct drm_i915_private *i915)
> }
>
> static int intel_gsc_send_sync(struct drm_i915_private *i915,
> - struct intel_gsc_mtl_header *header, u64 addr,
> + struct intel_gsc_mtl_header *header_in,
> + struct intel_gsc_mtl_header *header_out,
> + u64 addr_in, u64 addr_out,
> size_t msg_out_len)
> {
> struct intel_gt *gt = i915->media_gt;
> int ret;
>
> - header->flags = 0;
> - ret = intel_gsc_uc_heci_cmd_submit_packet(>->uc.gsc, addr,
> - header->message_size,
> - addr,
> - msg_out_len + sizeof(*header));
> + ret = intel_gsc_uc_heci_cmd_submit_packet(>->uc.gsc, addr_in,
> + header_in->message_size,
> + addr_out,
> + msg_out_len + sizeof(*header_out));
> if (ret) {
> drm_err(&i915->drm, "failed to send gsc HDCP msg (%d)\n", ret);
> return ret;
> }
>
> /*
> - * Checking validity marker for memory sanity
> + * Checking validity marker and header status to see if some error has
> + * blocked us from sending message to gsc cs
> */
> - if (header->validity_marker != GSC_HECI_VALIDITY_MARKER) {
> + if (header_out->validity_marker != GSC_HECI_VALIDITY_MARKER) {
> drm_err(&i915->drm, "invalid validity marker\n");
> return -EINVAL;
> }
>
> - if (header->status != 0) {
> + if (header_out->status != 0) {
> drm_err(&i915->drm, "header status indicates error %d\n",
> - header->status);
> + header_out->status);
> return -EINVAL;
> }
>
> - if (header->flags & GSC_OUTFLAG_MSG_PENDING)
> + if (header_out->flags & GSC_OUTFLAG_MSG_PENDING) {
> + header_in->gsc_message_handle = header_out->gsc_message_handle;
> return -EAGAIN;
> + }
>
> return 0;
> }
> @@ -769,11 +778,11 @@ ssize_t intel_hdcp_gsc_msg_send(struct drm_i915_private *i915, u8 *msg_in,
> size_t msg_out_len)
> {
> struct intel_gt *gt = i915->media_gt;
> - struct intel_gsc_mtl_header *header;
> - const size_t max_msg_size = PAGE_SIZE - sizeof(*header);
> + struct intel_gsc_mtl_header *header_in, *header_out;
> + const size_t max_msg_size = PAGE_SIZE - sizeof(*header_in);
> struct intel_hdcp_gsc_message *hdcp_message;
> - u64 addr, host_session_id;
> - u32 reply_size, msg_size;
> + u64 addr_in, addr_out, host_session_id;
> + u32 reply_size, msg_size_in, msg_size_out;
> int ret, tries = 0;
>
> if (!intel_uc_uses_gsc_uc(>->uc))
> @@ -782,16 +791,20 @@ ssize_t intel_hdcp_gsc_msg_send(struct drm_i915_private *i915, u8 *msg_in,
> if (msg_in_len > max_msg_size || msg_out_len > max_msg_size)
> return -ENOSPC;
>
> + msg_size_in = msg_in_len + sizeof(*header_in);
> + msg_size_out = msg_out_len + sizeof(*header_out);
> hdcp_message = i915->display.hdcp.hdcp_message;
> - header = hdcp_message->hdcp_cmd;
> - addr = i915_ggtt_offset(hdcp_message->vma);
> + header_in = hdcp_message->hdcp_cmd_in;
> + header_out = hdcp_message->hdcp_cmd_out;
> + addr_in = i915_ggtt_offset(hdcp_message->vma);
> + addr_out = addr_in + PAGE_SIZE;
>
> - msg_size = msg_in_len + sizeof(*header);
> - memset(header, 0, msg_size);
> + memset(header_in, 0, msg_size_in);
> + memset(header_out, 0, msg_size_out);
> get_random_bytes(&host_session_id, sizeof(u64));
> - intel_gsc_uc_heci_cmd_emit_mtl_header(header, HECI_MEADDRESS_HDCP,
> - msg_size, host_session_id);
> - memcpy(hdcp_message->hdcp_cmd + sizeof(*header), msg_in, msg_in_len);
> + intel_gsc_uc_heci_cmd_emit_mtl_header(header_in, HECI_MEADDRESS_HDCP,
> + msg_size_in, host_session_id);
> + memcpy(hdcp_message->hdcp_cmd_in + sizeof(*header_in), msg_in, msg_in_len);
>
> /*
> * Keep sending request in case the pending bit is set no need to add
> @@ -800,7 +813,8 @@ ssize_t intel_hdcp_gsc_msg_send(struct drm_i915_private *i915, u8 *msg_in,
> * 20 times each message 50 ms apart
> */
> do {
> - ret = intel_gsc_send_sync(i915, header, addr, msg_out_len);
> + ret = intel_gsc_send_sync(i915, header_in, header_out, addr_in,
> + addr_out, msg_out_len);
>
> /* Only try again if gsc says so */
> if (ret != -EAGAIN)
> @@ -814,7 +828,7 @@ ssize_t intel_hdcp_gsc_msg_send(struct drm_i915_private *i915, u8 *msg_in,
> goto err;
>
> /* we use the same mem for the reply, so header is in the same loc */
> - reply_size = header->message_size - sizeof(*header);
> + reply_size = header_out->message_size - sizeof(*header_out);
> if (reply_size > msg_out_len) {
> drm_warn(&i915->drm, "caller with insufficient HDCP reply size %u (%d)\n",
> reply_size, (u32)msg_out_len);
> @@ -824,7 +838,7 @@ ssize_t intel_hdcp_gsc_msg_send(struct drm_i915_private *i915, u8 *msg_in,
> reply_size, (u32)msg_out_len);
> }
>
> - memcpy(msg_out, hdcp_message->hdcp_cmd + sizeof(*header), msg_out_len);
> + memcpy(msg_out, hdcp_message->hdcp_cmd_out + sizeof(*header_out), msg_out_len);
>
> err:
> return ret;
> diff --git a/drivers/gpu/drm/i915/display/intel_hdcp_gsc.h b/drivers/gpu/drm/i915/display/intel_hdcp_gsc.h
> index 5cc9fd2e88f6..cbf96551e534 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdcp_gsc.h
> +++ b/drivers/gpu/drm/i915/display/intel_hdcp_gsc.h
> @@ -13,7 +13,8 @@ struct drm_i915_private;
>
> struct intel_hdcp_gsc_message {
> struct i915_vma *vma;
> - void *hdcp_cmd;
> + void *hdcp_cmd_in;
> + void *hdcp_cmd_out;
> };
>
> bool intel_hdcp_gsc_cs_required(struct drm_i915_private *i915);
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-06-15 10:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-02 10:51 [Intel-gfx] [PATCH] drm/i915/hdcp: Modify hdcp_gsc_message msg sending mechanism Suraj Kandpal
2023-06-02 12:15 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2023-06-04 13:00 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-06-15 10:41 ` [Intel-gfx] [PATCH] " Nautiyal, Ankit K
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox