[Intel-gfx] [PATCH 1/4] drm/i915: Add missing forward declarations/includes to display power headers

[Intel-gfx] [PATCH 1/4] drm/i915: Add missing forward declarations/includes to display power headers

[Imre Deak]

Add the seq_file struct forward declaration to intel_display_power.h
fixing the build error below. While at it add the rest of missing
forward declarations/includes to the display power header files.

In file included from <command-line>:
./../drivers/gpu/drm/i915/display/intel_display_power.h:255:70: error: 'struct seq_file'
declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
  255 | void intel_display_power_debug(struct drm_i915_private *i915, struct seq_file *m);
      |                                                                      ^~~~~~~~

Reported-by: Randy Dunlap <rdunlap@infradead.org>
Closes: https://lore.kernel.org/intel-gfx/89adc1ac-25a0-6eb6-4cc9-ab6cc8d49730@infradead.org/
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display_power.h      | 4 ++++
 drivers/gpu/drm/i915/display/intel_display_power_well.h | 2 ++
 2 files changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_display_power.h b/drivers/gpu/drm/i915/display/intel_display_power.h
index be1a87bde0c9d..df38632c62371 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power.h
+++ b/drivers/gpu/drm/i915/display/intel_display_power.h
@@ -6,6 +6,9 @@
 #ifndef __INTEL_DISPLAY_POWER_H__
 #define __INTEL_DISPLAY_POWER_H__
 
+#include <linux/mutex.h>
+#include <linux/workqueue.h>
+
 #include "intel_wakeref.h"
 
 enum aux_ch;
@@ -16,6 +19,7 @@ enum port;
 struct drm_i915_private;
 struct i915_power_well;
 struct intel_encoder;
+struct seq_file;
 
 /*
  * Keep the pipe, transcoder, port (DDI_LANES,DDI_IO,AUX) domain instances
diff --git a/drivers/gpu/drm/i915/display/intel_display_power_well.h b/drivers/gpu/drm/i915/display/intel_display_power_well.h
index e494df379e6c2..1015bba4af01e 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power_well.h
+++ b/drivers/gpu/drm/i915/display/intel_display_power_well.h
@@ -12,6 +12,8 @@
 
 struct drm_i915_private;
 struct i915_power_well;
+struct i915_power_well_ops;
+struct intel_encoder;
 
 #define for_each_power_well(__dev_priv, __power_well)				\
 	for ((__power_well) = (__dev_priv)->display.power.domains.power_wells;	\
-- 
2.37.2

[Intel-gfx] [PATCH 2/4] drm/i915: Remove redundant forward declarations from display power headers

[Imre Deak]

Remove the forward declarations for enums and structs from display power
header files that aren't used in prototypes.

Signed-off-by: Imre Deak <imre.deak@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display_power.h      | 3 ---
 drivers/gpu/drm/i915/display/intel_display_power_well.h | 1 -
 2 files changed, 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display_power.h b/drivers/gpu/drm/i915/display/intel_display_power.h
index df38632c62371..83ceab091468e 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power.h
+++ b/drivers/gpu/drm/i915/display/intel_display_power.h
@@ -12,9 +12,6 @@
 #include "intel_wakeref.h"
 
 enum aux_ch;
-enum dpio_channel;
-enum dpio_phy;
-enum i915_drm_suspend_mode;
 enum port;
 struct drm_i915_private;
 struct i915_power_well;
diff --git a/drivers/gpu/drm/i915/display/intel_display_power_well.h b/drivers/gpu/drm/i915/display/intel_display_power_well.h
index 1015bba4af01e..a8736588314d9 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power_well.h
+++ b/drivers/gpu/drm/i915/display/intel_display_power_well.h
@@ -11,7 +11,6 @@
 #include "intel_dpio_phy.h"
 
 struct drm_i915_private;
-struct i915_power_well;
 struct i915_power_well_ops;
 struct intel_encoder;
 
-- 
2.37.2

[Intel-gfx] [PATCH 3/4] drm/i915: Add way to specify the power-off delay of a display power domain

[Imre Deak]

Add support for specifying a delay different than the current 100 ms
default for powering off a display power domain. This is needed by the
next patch which delays re-enabling DC states during modesets to avoid
the off->on->off toggling overhead of the DC_off power well, but does
this using a < 100 ms delay for a better utilization of DC power saving
states.

Signed-off-by: Imre Deak <imre.deak@intel.com>
---
 .../drm/i915/display/intel_display_power.c    | 41 +++++++++++++++----
 .../drm/i915/display/intel_display_power.h    | 26 ++++++++++--
 2 files changed, 55 insertions(+), 12 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
index d3310c7205320..38225e5d311e5 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power.c
+++ b/drivers/gpu/drm/i915/display/intel_display_power.c
@@ -458,6 +458,17 @@ async_put_domains_clear_domain(struct i915_power_domains *power_domains,
 	clear_bit(domain, power_domains->async_put_domains[1].bits);
 }
 
+static void
+cancel_async_put_work(struct i915_power_domains *power_domains, bool sync)
+{
+	if (sync)
+		cancel_delayed_work_sync(&power_domains->async_put_work);
+	else
+		cancel_delayed_work(&power_domains->async_put_work);
+
+	power_domains->async_put_next_delay = 0;
+}
+
 static bool
 intel_display_power_grab_async_put_ref(struct drm_i915_private *dev_priv,
 				       enum intel_display_power_domain domain)
@@ -478,7 +489,7 @@ intel_display_power_grab_async_put_ref(struct drm_i915_private *dev_priv,
 	if (!bitmap_empty(async_put_mask.bits, POWER_DOMAIN_NUM))
 		goto out_verify;
 
-	cancel_delayed_work(&power_domains->async_put_work);
+	cancel_async_put_work(power_domains, false);
 	intel_runtime_pm_put_raw(&dev_priv->runtime_pm,
 				 fetch_and_zero(&power_domains->async_put_wakeref));
 out_verify:
@@ -609,7 +620,8 @@ static void __intel_display_power_put(struct drm_i915_private *dev_priv,
 
 static void
 queue_async_put_domains_work(struct i915_power_domains *power_domains,
-			     intel_wakeref_t wakeref)
+			     intel_wakeref_t wakeref,
+			     int delay_ms)
 {
 	struct drm_i915_private *i915 = container_of(power_domains,
 						     struct drm_i915_private,
@@ -618,7 +630,7 @@ queue_async_put_domains_work(struct i915_power_domains *power_domains,
 	power_domains->async_put_wakeref = wakeref;
 	drm_WARN_ON(&i915->drm, !queue_delayed_work(system_unbound_wq,
 						    &power_domains->async_put_work,
-						    msecs_to_jiffies(100)));
+						    msecs_to_jiffies(delay_ms)));
 }
 
 static void
@@ -681,13 +693,15 @@ intel_display_power_put_async_work(struct work_struct *work)
 		bitmap_zero(power_domains->async_put_domains[1].bits,
 			    POWER_DOMAIN_NUM);
 		queue_async_put_domains_work(power_domains,
-					     fetch_and_zero(&new_work_wakeref));
+					     fetch_and_zero(&new_work_wakeref),
+					     power_domains->async_put_next_delay);
+		power_domains->async_put_next_delay = 0;
 	} else {
 		/*
 		 * Cancel the work that got queued after this one got dequeued,
 		 * since here we released the corresponding async-put reference.
 		 */
-		cancel_delayed_work(&power_domains->async_put_work);
+		cancel_async_put_work(power_domains, false);
 	}
 
 out_verify:
@@ -706,19 +720,25 @@ intel_display_power_put_async_work(struct work_struct *work)
  * @i915: i915 device instance
  * @domain: power domain to reference
  * @wakeref: wakeref acquired for the reference that is being released
+ * @delay_ms: delay of powering down the power domain
  *
  * This function drops the power domain reference obtained by
  * intel_display_power_get*() and schedules a work to power down the
  * corresponding hardware block if this is the last reference.
+ * The power down is delayed by @delay_ms if this is >= 0, or by a default
+ * 100 ms otherwise.
  */
 void __intel_display_power_put_async(struct drm_i915_private *i915,
 				     enum intel_display_power_domain domain,
-				     intel_wakeref_t wakeref)
+				     intel_wakeref_t wakeref,
+				     int delay_ms)
 {
 	struct i915_power_domains *power_domains = &i915->display.power.domains;
 	struct intel_runtime_pm *rpm = &i915->runtime_pm;
 	intel_wakeref_t work_wakeref = intel_runtime_pm_get_raw(rpm);
 
+	delay_ms = delay_ms >= 0 ? delay_ms : 100;
+
 	mutex_lock(&power_domains->lock);
 
 	if (power_domains->domain_use_count[domain] > 1) {
@@ -732,10 +752,13 @@ void __intel_display_power_put_async(struct drm_i915_private *i915,
 	/* Let a pending work requeue itself or queue a new one. */
 	if (power_domains->async_put_wakeref) {
 		set_bit(domain, power_domains->async_put_domains[1].bits);
+		power_domains->async_put_next_delay = max(power_domains->async_put_next_delay,
+							  delay_ms);
 	} else {
 		set_bit(domain, power_domains->async_put_domains[0].bits);
 		queue_async_put_domains_work(power_domains,
-					     fetch_and_zero(&work_wakeref));
+					     fetch_and_zero(&work_wakeref),
+					     delay_ms);
 	}
 
 out_verify:
@@ -775,7 +798,7 @@ void intel_display_power_flush_work(struct drm_i915_private *i915)
 
 	async_put_domains_mask(power_domains, &async_put_mask);
 	release_async_put_domains(power_domains, &async_put_mask);
-	cancel_delayed_work(&power_domains->async_put_work);
+	cancel_async_put_work(power_domains, false);
 
 out_verify:
 	verify_async_put_domains_state(power_domains);
@@ -799,7 +822,7 @@ intel_display_power_flush_work_sync(struct drm_i915_private *i915)
 	struct i915_power_domains *power_domains = &i915->display.power.domains;
 
 	intel_display_power_flush_work(i915);
-	cancel_delayed_work_sync(&power_domains->async_put_work);
+	cancel_async_put_work(power_domains, true);
 
 	verify_async_put_domains_state(power_domains);
 
diff --git a/drivers/gpu/drm/i915/display/intel_display_power.h b/drivers/gpu/drm/i915/display/intel_display_power.h
index 83ceab091468e..d3b5d04b7b077 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power.h
+++ b/drivers/gpu/drm/i915/display/intel_display_power.h
@@ -151,6 +151,7 @@ struct i915_power_domains {
 	struct delayed_work async_put_work;
 	intel_wakeref_t async_put_wakeref;
 	struct intel_power_domain_mask async_put_domains[2];
+	int async_put_next_delay;
 
 	struct i915_power_well *power_wells;
 };
@@ -197,7 +198,8 @@ intel_display_power_get_if_enabled(struct drm_i915_private *dev_priv,
 				   enum intel_display_power_domain domain);
 void __intel_display_power_put_async(struct drm_i915_private *i915,
 				     enum intel_display_power_domain domain,
-				     intel_wakeref_t wakeref);
+				     intel_wakeref_t wakeref,
+				     int delay_ms);
 void intel_display_power_flush_work(struct drm_i915_private *i915);
 #if IS_ENABLED(CONFIG_DRM_I915_DEBUG_RUNTIME_PM)
 void intel_display_power_put(struct drm_i915_private *dev_priv,
@@ -208,7 +210,16 @@ intel_display_power_put_async(struct drm_i915_private *i915,
 			      enum intel_display_power_domain domain,
 			      intel_wakeref_t wakeref)
 {
-	__intel_display_power_put_async(i915, domain, wakeref);
+	__intel_display_power_put_async(i915, domain, wakeref, -1);
+}
+
+static inline void
+intel_display_power_put_async_delay(struct drm_i915_private *i915,
+				    enum intel_display_power_domain domain,
+				    intel_wakeref_t wakeref,
+				    int delay_ms)
+{
+	__intel_display_power_put_async(i915, domain, wakeref, delay_ms);
 }
 #else
 void intel_display_power_put_unchecked(struct drm_i915_private *dev_priv,
@@ -227,7 +238,16 @@ intel_display_power_put_async(struct drm_i915_private *i915,
 			      enum intel_display_power_domain domain,
 			      intel_wakeref_t wakeref)
 {
-	__intel_display_power_put_async(i915, domain, -1);
+	__intel_display_power_put_async(i915, domain, -1, -1);
+}
+
+static inline void
+intel_display_power_put_async_delay(struct drm_i915_private *i915,
+				    enum intel_display_power_domain domain,
+				    intel_wakeref_t wakeref,
+				    int delay_ms)
+{
+	__intel_display_power_put_async(i915, domain, -1, delay_ms);
 }
 #endif
 
-- 
2.37.2

[Intel-gfx] [PATCH 4/4] drm/i915: Prevent needless toggling of DC states during modesets

[Imre Deak]

DC states are disabled / re-enabled around each modeset, which may lead
to a needless off->on->off toggling of the DC_off power well. This has
some overhead as toggling DC states involves running a DMC firmware
handler and also running a periodic firmware handler while DC states are
enabled. The limit of when DC states have a benefit is at 30 FPS (using
DC3co) and below 30 FPS (using DC5/6), where the firmware can actually
disable clocks / power off power wells. Accordingly delay powering off
the DC_off powerwell (which re-enables DC states) by 17 ms at the end of
a modeset to avoid the above overhead at or above 60 FPS.

Signed-off-by: Imre Deak <imre.deak@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index dd52c689267f4..de77d130d6f9f 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -7148,7 +7148,11 @@ static void intel_atomic_commit_tail(struct intel_atomic_state *state)
 		 */
 		intel_uncore_arm_unclaimed_mmio_detection(&dev_priv->uncore);
 	}
-	intel_display_power_put(dev_priv, POWER_DOMAIN_DC_OFF, wakeref);
+	/*
+	 * Delay re-enabling DC states by 17 ms to avoid the off->on->off
+	 * toggling overhead at and above 60 FPS.
+	 */
+	intel_display_power_put_async_delay(dev_priv, POWER_DOMAIN_DC_OFF, wakeref, 17);
 	intel_runtime_pm_put(&dev_priv->runtime_pm, state->wakeref);
 
 	/*
-- 
2.37.2

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915: Add missing forward declarations/includes to display power headers

[Patchwork]

== Series Details ==

Series: series starting with [1/4] drm/i915: Add missing forward declarations/includes to display power headers
URL   : https://patchwork.freedesktop.org/series/119480/
State : warning

== Summary ==

Error: dim checkpatch failed
0fa1731f78bd drm/i915: Add missing forward declarations/includes to display power headers
-:13: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#13: 
declared inside parameter list will not be visible outside of this definition or declaration [-Werror]

total: 0 errors, 1 warnings, 0 checks, 24 lines checked
bb70c02d041a drm/i915: Remove redundant forward declarations from display power headers
30b20e115fd7 drm/i915: Add way to specify the power-off delay of a display power domain
f69fb91dbeb7 drm/i915: Prevent needless toggling of DC states during modesets

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/4] drm/i915: Add missing forward declarations/includes to display power headers

[Patchwork]

== Series Details ==

Series: series starting with [1/4] drm/i915: Add missing forward declarations/includes to display power headers
URL   : https://patchwork.freedesktop.org/series/119480/
State : warning

== Summary ==

Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Add missing forward declarations/includes to display power headers

[Randy Dunlap]

Hi--

On 6/16/23 11:51, Imre Deak wrote:
> Add the seq_file struct forward declaration to intel_display_power.h
> fixing the build error below. While at it add the rest of missing
> forward declarations/includes to the display power header files.
> 
> In file included from <command-line>:
> ./../drivers/gpu/drm/i915/display/intel_display_power.h:255:70: error: 'struct seq_file'
> declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
>   255 | void intel_display_power_debug(struct drm_i915_private *i915, struct seq_file *m);
>       |                                                                      ^~~~~~~~
> 
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Closes: https://lore.kernel.org/intel-gfx/89adc1ac-25a0-6eb6-4cc9-ab6cc8d49730@infradead.org/
> Signed-off-by: Imre Deak <imre.deak@intel.com>

Acked-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org> # build-tested

Thanks.

> ---
>  drivers/gpu/drm/i915/display/intel_display_power.h      | 4 ++++
>  drivers/gpu/drm/i915/display/intel_display_power_well.h | 2 ++
>  2 files changed, 6 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display_power.h b/drivers/gpu/drm/i915/display/intel_display_power.h
> index be1a87bde0c9d..df38632c62371 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_power.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_power.h
> @@ -6,6 +6,9 @@
>  #ifndef __INTEL_DISPLAY_POWER_H__
>  #define __INTEL_DISPLAY_POWER_H__
>  
> +#include <linux/mutex.h>
> +#include <linux/workqueue.h>
> +
>  #include "intel_wakeref.h"
>  
>  enum aux_ch;
> @@ -16,6 +19,7 @@ enum port;
>  struct drm_i915_private;
>  struct i915_power_well;
>  struct intel_encoder;
> +struct seq_file;
>  
>  /*
>   * Keep the pipe, transcoder, port (DDI_LANES,DDI_IO,AUX) domain instances
> diff --git a/drivers/gpu/drm/i915/display/intel_display_power_well.h b/drivers/gpu/drm/i915/display/intel_display_power_well.h
> index e494df379e6c2..1015bba4af01e 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_power_well.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_power_well.h
> @@ -12,6 +12,8 @@
>  
>  struct drm_i915_private;
>  struct i915_power_well;
> +struct i915_power_well_ops;
> +struct intel_encoder;
>  
>  #define for_each_power_well(__dev_priv, __power_well)				\
>  	for ((__power_well) = (__dev_priv)->display.power.domains.power_wells;	\

-- 
~Randy

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915: Add missing forward declarations/includes to display power headers

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 11139 bytes --]

== Series Details ==

Series: series starting with [1/4] drm/i915: Add missing forward declarations/includes to display power headers
URL   : https://patchwork.freedesktop.org/series/119480/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_13279 -> Patchwork_119480v1
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/index.html

Participating hosts (42 -> 41)
------------------------------

  Missing    (1): fi-snb-2520m 

Known issues
------------

  Here are the changes found in Patchwork_119480v1 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@core_auth@basic-auth:
    - bat-adlp-11:        NOTRUN -> [ABORT][1] ([i915#4423] / [i915#8011])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/bat-adlp-11/igt@core_auth@basic-auth.html

  * igt@gem_lmem_swapping@parallel-random-engines:
    - fi-bsw-nick:        NOTRUN -> [SKIP][2] ([fdo#109271]) +19 similar issues
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/fi-bsw-nick/igt@gem_lmem_swapping@parallel-random-engines.html
    - bat-mtlp-8:         NOTRUN -> [SKIP][3] ([i915#4613]) +3 similar issues
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/bat-mtlp-8/igt@gem_lmem_swapping@parallel-random-engines.html

  * igt@i915_pm_rps@basic-api:
    - bat-mtlp-8:         NOTRUN -> [SKIP][4] ([i915#6621])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/bat-mtlp-8/igt@i915_pm_rps@basic-api.html

  * igt@i915_selftest@live@execlists:
    - fi-bsw-n3050:       [PASS][5] -> [ABORT][6] ([i915#7911] / [i915#7913])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/fi-bsw-n3050/igt@i915_selftest@live@execlists.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/fi-bsw-n3050/igt@i915_selftest@live@execlists.html

  * igt@i915_selftest@live@hangcheck:
    - bat-dg2-11:         [PASS][7] -> [ABORT][8] ([i915#7913] / [i915#7979])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/bat-dg2-11/igt@i915_selftest@live@hangcheck.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/bat-dg2-11/igt@i915_selftest@live@hangcheck.html

  * igt@i915_selftest@live@migrate:
    - bat-dg2-11:         [PASS][9] -> [DMESG-WARN][10] ([i915#7699])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/bat-dg2-11/igt@i915_selftest@live@migrate.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/bat-dg2-11/igt@i915_selftest@live@migrate.html

  * igt@i915_selftest@live@requests:
    - bat-mtlp-8:         NOTRUN -> [DMESG-FAIL][11] ([i915#8497])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/bat-mtlp-8/igt@i915_selftest@live@requests.html

  * igt@i915_selftest@live@slpc:
    - bat-rpls-2:         NOTRUN -> [DMESG-WARN][12] ([i915#6367])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/bat-rpls-2/igt@i915_selftest@live@slpc.html

  * igt@i915_suspend@basic-s2idle-without-i915:
    - bat-rpls-2:         NOTRUN -> [ABORT][13] ([i915#6687] / [i915#8668])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/bat-rpls-2/igt@i915_suspend@basic-s2idle-without-i915.html

  * igt@i915_suspend@basic-s3-without-i915:
    - bat-mtlp-8:         NOTRUN -> [SKIP][14] ([i915#6645])
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/bat-mtlp-8/igt@i915_suspend@basic-s3-without-i915.html

  * igt@kms_chamelium_hpd@common-hpd-after-suspend:
    - bat-mtlp-8:         NOTRUN -> [SKIP][15] ([i915#7828])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/bat-mtlp-8/igt@kms_chamelium_hpd@common-hpd-after-suspend.html

  * igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:
    - bat-dg2-11:         NOTRUN -> [SKIP][16] ([i915#1845] / [i915#5354]) +3 similar issues
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/bat-dg2-11/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html

  * igt@kms_setmode@basic-clone-single-crtc:
    - fi-bsw-nick:        NOTRUN -> [SKIP][17] ([fdo#109271] / [i915#4579])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/fi-bsw-nick/igt@kms_setmode@basic-clone-single-crtc.html

  * igt@prime_vgem@basic-fence-read:
    - bat-mtlp-8:         NOTRUN -> [SKIP][18] ([i915#3708]) +2 similar issues
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/bat-mtlp-8/igt@prime_vgem@basic-fence-read.html

  * igt@prime_vgem@basic-gtt:
    - bat-mtlp-8:         NOTRUN -> [SKIP][19] ([i915#3708] / [i915#4077]) +1 similar issue
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/bat-mtlp-8/igt@prime_vgem@basic-gtt.html

  
#### Possible fixes ####

  * igt@i915_pm_rpm@basic-rte:
    - bat-mtlp-8:         [ABORT][20] -> [PASS][21]
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/bat-mtlp-8/igt@i915_pm_rpm@basic-rte.html
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/bat-mtlp-8/igt@i915_pm_rpm@basic-rte.html

  * igt@i915_selftest@live@gt_mocs:
    - bat-mtlp-6:         [DMESG-FAIL][22] ([i915#7059]) -> [PASS][23]
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/bat-mtlp-6/igt@i915_selftest@live@gt_mocs.html
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/bat-mtlp-6/igt@i915_selftest@live@gt_mocs.html

  * igt@i915_selftest@live@requests:
    - bat-rpls-2:         [ABORT][24] ([i915#4983] / [i915#7913]) -> [PASS][25]
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/bat-rpls-2/igt@i915_selftest@live@requests.html
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/bat-rpls-2/igt@i915_selftest@live@requests.html

  * igt@i915_selftest@live@slpc:
    - bat-mtlp-6:         [DMESG-WARN][26] ([i915#6367]) -> [PASS][27]
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/bat-mtlp-6/igt@i915_selftest@live@slpc.html
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/bat-mtlp-6/igt@i915_selftest@live@slpc.html

  * igt@kms_force_connector_basic@force-connector-state:
    - fi-bsw-nick:        [ABORT][28] ([i915#8139]) -> [PASS][29]
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/fi-bsw-nick/igt@kms_force_connector_basic@force-connector-state.html
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/fi-bsw-nick/igt@kms_force_connector_basic@force-connector-state.html

  * igt@kms_pipe_crc_basic@nonblocking-crc@pipe-d-dp-1:
    - bat-dg2-8:          [FAIL][30] ([i915#7932]) -> [PASS][31]
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc@pipe-d-dp-1.html
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc@pipe-d-dp-1.html

  
#### Warnings ####

  * igt@i915_module_load@load:
    - bat-adlp-11:        [ABORT][32] ([i915#4423]) -> [DMESG-WARN][33] ([i915#4423])
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/bat-adlp-11/igt@i915_module_load@load.html
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/bat-adlp-11/igt@i915_module_load@load.html

  * igt@i915_selftest@live@reset:
    - bat-rpls-1:         [ABORT][34] ([i915#7461] / [i915#7981] / [i915#8347] / [i915#8384]) -> [ABORT][35] ([i915#4983] / [i915#7461] / [i915#8347] / [i915#8384])
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/bat-rpls-1/igt@i915_selftest@live@reset.html
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/bat-rpls-1/igt@i915_selftest@live@reset.html

  * igt@kms_psr@sprite_plane_onoff:
    - bat-rplp-1:         [SKIP][36] ([i915#1072]) -> [ABORT][37] ([i915#8442])
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/bat-rplp-1/igt@kms_psr@sprite_plane_onoff.html
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/bat-rplp-1/igt@kms_psr@sprite_plane_onoff.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
  [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
  [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
  [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
  [i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
  [i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
  [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
  [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
  [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
  [i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
  [i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
  [i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
  [i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
  [i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059
  [i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
  [i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
  [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
  [i915#7911]: https://gitlab.freedesktop.org/drm/intel/issues/7911
  [i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
  [i915#7932]: https://gitlab.freedesktop.org/drm/intel/issues/7932
  [i915#7979]: https://gitlab.freedesktop.org/drm/intel/issues/7979
  [i915#7981]: https://gitlab.freedesktop.org/drm/intel/issues/7981
  [i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
  [i915#8139]: https://gitlab.freedesktop.org/drm/intel/issues/8139
  [i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
  [i915#8384]: https://gitlab.freedesktop.org/drm/intel/issues/8384
  [i915#8442]: https://gitlab.freedesktop.org/drm/intel/issues/8442
  [i915#8497]: https://gitlab.freedesktop.org/drm/intel/issues/8497
  [i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668


Build changes
-------------

  * Linux: CI_DRM_13279 -> Patchwork_119480v1

  CI-20190529: 20190529
  CI_DRM_13279: 2998419e79e4f902b49309915b475d5a0e3db8a7 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_7335: b7d168f61bef72a3e84e72eeee1767fac577d70d @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  Patchwork_119480v1: 2998419e79e4f902b49309915b475d5a0e3db8a7 @ git://anongit.freedesktop.org/gfx-ci/linux


### Linux commits

38bbac0e38c2 drm/i915: Prevent needless toggling of DC states during modesets
7082427e54d6 drm/i915: Add way to specify the power-off delay of a display power domain
811dc2bd1e02 drm/i915: Remove redundant forward declarations from display power headers
008cb84e8acd drm/i915: Add missing forward declarations/includes to display power headers

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/index.html

[-- Attachment #2: Type: text/html, Size: 13102 bytes --]

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/4] drm/i915: Add missing forward declarations/includes to display power headers

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 23963 bytes --]

== Series Details ==

Series: series starting with [1/4] drm/i915: Add missing forward declarations/includes to display power headers
URL   : https://patchwork.freedesktop.org/series/119480/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_13279_full -> Patchwork_119480v1_full
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_119480v1_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_119480v1_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  

Participating hosts (8 -> 7)
------------------------------

  Missing    (1): shard-rkl0 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_119480v1_full:

### IGT changes ###

#### Possible regressions ####

  * igt@kms_flip@2x-flip-vs-dpms-off-vs-modeset-interruptible:
    - shard-snb:          NOTRUN -> [ABORT][1]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-snb5/igt@kms_flip@2x-flip-vs-dpms-off-vs-modeset-interruptible.html

  
Known issues
------------

  Here are the changes found in Patchwork_119480v1_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_close_race@multigpu-basic-process:
    - shard-rkl:          NOTRUN -> [SKIP][2] ([i915#7697])
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@gem_close_race@multigpu-basic-process.html

  * igt@gem_eio@hibernate:
    - shard-snb:          [PASS][3] -> [SKIP][4] ([fdo#109271])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/shard-snb6/igt@gem_eio@hibernate.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-snb6/igt@gem_eio@hibernate.html
    - shard-rkl:          NOTRUN -> [ABORT][5] ([i915#7975] / [i915#8213])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@gem_eio@hibernate.html

  * igt@gem_exec_fair@basic-none-solo@rcs0:
    - shard-apl:          [PASS][6] -> [FAIL][7] ([i915#2842])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/shard-apl2/igt@gem_exec_fair@basic-none-solo@rcs0.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-apl3/igt@gem_exec_fair@basic-none-solo@rcs0.html

  * igt@gem_exec_fair@basic-pace-share@rcs0:
    - shard-tglu:         [PASS][8] -> [FAIL][9] ([i915#2842])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/shard-tglu-5/igt@gem_exec_fair@basic-pace-share@rcs0.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-tglu-9/igt@gem_exec_fair@basic-pace-share@rcs0.html

  * igt@gem_exec_fair@basic-pace@rcs0:
    - shard-rkl:          [PASS][10] -> [FAIL][11] ([i915#2842]) +2 similar issues
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/shard-rkl-6/igt@gem_exec_fair@basic-pace@rcs0.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@gem_exec_fair@basic-pace@rcs0.html

  * igt@gem_exec_reloc@basic-wc-read:
    - shard-rkl:          NOTRUN -> [SKIP][12] ([i915#3281])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@gem_exec_reloc@basic-wc-read.html

  * igt@gem_ppgtt@blt-vs-render-ctx0:
    - shard-snb:          [PASS][13] -> [INCOMPLETE][14] ([i915#8295])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/shard-snb6/igt@gem_ppgtt@blt-vs-render-ctx0.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-snb6/igt@gem_ppgtt@blt-vs-render-ctx0.html

  * igt@gem_set_tiling_vs_blt@untiled-to-tiled:
    - shard-rkl:          NOTRUN -> [SKIP][15] ([i915#8411])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@gem_set_tiling_vs_blt@untiled-to-tiled.html

  * igt@gem_spin_batch@spin-each:
    - shard-apl:          [PASS][16] -> [FAIL][17] ([i915#2898])
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/shard-apl6/igt@gem_spin_batch@spin-each.html
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-apl3/igt@gem_spin_batch@spin-each.html

  * igt@gem_userptr_blits@unsync-unmap-cycles:
    - shard-rkl:          NOTRUN -> [SKIP][18] ([i915#3297])
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@gem_userptr_blits@unsync-unmap-cycles.html

  * igt@i915_pm_dc@dc9-dpms:
    - shard-tglu:         [PASS][19] -> [SKIP][20] ([i915#4281])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/shard-tglu-10/igt@i915_pm_dc@dc9-dpms.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-tglu-6/igt@i915_pm_dc@dc9-dpms.html

  * igt@i915_pm_freq_api@freq-reset:
    - shard-rkl:          NOTRUN -> [SKIP][21] ([i915#8399])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@i915_pm_freq_api@freq-reset.html

  * igt@i915_pm_rpm@dpms-lpsp:
    - shard-rkl:          [PASS][22] -> [SKIP][23] ([i915#1397])
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/shard-rkl-7/igt@i915_pm_rpm@dpms-lpsp.html
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-1/igt@i915_pm_rpm@dpms-lpsp.html

  * igt@i915_selftest@live@gt_heartbeat:
    - shard-apl:          [PASS][24] -> [DMESG-FAIL][25] ([i915#5334])
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/shard-apl6/igt@i915_selftest@live@gt_heartbeat.html
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-apl4/igt@i915_selftest@live@gt_heartbeat.html

  * igt@kms_big_fb@x-tiled-64bpp-rotate-90:
    - shard-rkl:          NOTRUN -> [SKIP][26] ([fdo#111614] / [i915#3638]) +1 similar issue
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@kms_big_fb@x-tiled-64bpp-rotate-90.html

  * igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip:
    - shard-tglu:         [PASS][27] -> [FAIL][28] ([i915#3743]) +1 similar issue
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/shard-tglu-5/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-tglu-6/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html

  * igt@kms_big_fb@yf-tiled-32bpp-rotate-90:
    - shard-rkl:          NOTRUN -> [SKIP][29] ([fdo#110723])
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@kms_big_fb@yf-tiled-32bpp-rotate-90.html

  * igt@kms_ccs@pipe-a-bad-pixel-format-4_tiled_mtl_rc_ccs:
    - shard-rkl:          NOTRUN -> [SKIP][30] ([i915#5354] / [i915#6095])
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@kms_ccs@pipe-a-bad-pixel-format-4_tiled_mtl_rc_ccs.html

  * igt@kms_ccs@pipe-b-missing-ccs-buffer-yf_tiled_ccs:
    - shard-rkl:          NOTRUN -> [SKIP][31] ([i915#3734] / [i915#5354] / [i915#6095]) +1 similar issue
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@kms_ccs@pipe-b-missing-ccs-buffer-yf_tiled_ccs.html

  * igt@kms_ccs@pipe-d-missing-ccs-buffer-y_tiled_gen12_mc_ccs:
    - shard-rkl:          NOTRUN -> [SKIP][32] ([i915#5354]) +6 similar issues
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@kms_ccs@pipe-d-missing-ccs-buffer-y_tiled_gen12_mc_ccs.html

  * igt@kms_chamelium_edid@dp-mode-timings:
    - shard-rkl:          NOTRUN -> [SKIP][33] ([i915#7828]) +2 similar issues
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@kms_chamelium_edid@dp-mode-timings.html

  * igt@kms_color@deep-color:
    - shard-rkl:          NOTRUN -> [SKIP][34] ([i915#3555] / [i915#4579]) +1 similar issue
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@kms_color@deep-color.html

  * igt@kms_content_protection@uevent:
    - shard-rkl:          NOTRUN -> [SKIP][35] ([i915#4579] / [i915#7118])
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@kms_content_protection@uevent.html

  * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
    - shard-apl:          [PASS][36] -> [FAIL][37] ([i915#2346])
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/shard-apl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-apl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html

  * igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-2:
    - shard-rkl:          NOTRUN -> [SKIP][38] ([i915#3804] / [i915#4579])
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-1/igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-2.html

  * igt@kms_dsc@dsc-basic:
    - shard-rkl:          NOTRUN -> [SKIP][39] ([i915#3840] / [i915#4579])
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@kms_dsc@dsc-basic.html

  * igt@kms_flip@2x-flip-vs-panning:
    - shard-rkl:          NOTRUN -> [SKIP][40] ([fdo#111825]) +2 similar issues
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@kms_flip@2x-flip-vs-panning.html

  * igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a2:
    - shard-glk:          [PASS][41] -> [FAIL][42] ([i915#79])
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/shard-glk6/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a2.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-glk3/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a2.html

  * igt@kms_flip@plain-flip-ts-check-interruptible@a-hdmi-a1:
    - shard-glk:          [PASS][43] -> [FAIL][44] ([i915#2122])
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/shard-glk5/igt@kms_flip@plain-flip-ts-check-interruptible@a-hdmi-a1.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-glk9/igt@kms_flip@plain-flip-ts-check-interruptible@a-hdmi-a1.html

  * igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-upscaling@pipe-a-valid-mode:
    - shard-rkl:          NOTRUN -> [SKIP][45] ([i915#2672] / [i915#4579])
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-upscaling@pipe-a-valid-mode.html

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-indfb-plflip-blt:
    - shard-rkl:          NOTRUN -> [SKIP][46] ([fdo#111825] / [i915#1825]) +8 similar issues
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-indfb-plflip-blt.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt:
    - shard-rkl:          NOTRUN -> [SKIP][47] ([i915#3023]) +6 similar issues
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt.html

  * igt@kms_frontbuffer_tracking@fbcpsr-stridechange:
    - shard-tglu:         NOTRUN -> [SKIP][48] ([fdo#110189])
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-tglu-6/igt@kms_frontbuffer_tracking@fbcpsr-stridechange.html

  * igt@kms_hdr@invalid-hdr:
    - shard-rkl:          NOTRUN -> [SKIP][49] ([i915#4579] / [i915#6953] / [i915#8228])
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-2/igt@kms_hdr@invalid-hdr.html

  * igt@kms_plane_lowres@tiling-4:
    - shard-rkl:          NOTRUN -> [SKIP][50] ([i915#4579])
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@kms_plane_lowres@tiling-4.html

  * igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-a-hdmi-a-1:
    - shard-rkl:          NOTRUN -> [SKIP][51] ([i915#5176]) +5 similar issues
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-a-hdmi-a-1.html

  * igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-rotation@pipe-b-hdmi-a-2:
    - shard-rkl:          NOTRUN -> [SKIP][52] ([i915#4579] / [i915#5176]) +5 similar issues
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-1/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-rotation@pipe-b-hdmi-a-2.html

  * igt@kms_plane_scaling@planes-downscale-factor-0-5-unity-scaling@pipe-b-vga-1:
    - shard-snb:          NOTRUN -> [SKIP][53] ([fdo#109271] / [i915#4579]) +13 similar issues
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-snb5/igt@kms_plane_scaling@planes-downscale-factor-0-5-unity-scaling@pipe-b-vga-1.html

  * igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-75@pipe-a-hdmi-a-1:
    - shard-snb:          NOTRUN -> [SKIP][54] ([fdo#109271]) +27 similar issues
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-snb1/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-75@pipe-a-hdmi-a-1.html

  * igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-a-hdmi-a-2:
    - shard-rkl:          NOTRUN -> [SKIP][55] ([i915#5235]) +1 similar issue
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-1/igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-a-hdmi-a-2.html

  * igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-b-hdmi-a-2:
    - shard-rkl:          NOTRUN -> [SKIP][56] ([i915#4579] / [i915#5235]) +1 similar issue
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-1/igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-b-hdmi-a-2.html

  * igt@kms_psr@sprite_blt:
    - shard-rkl:          NOTRUN -> [SKIP][57] ([i915#1072]) +1 similar issue
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@kms_psr@sprite_blt.html

  * igt@kms_vblank@pipe-d-wait-busy-hang:
    - shard-rkl:          NOTRUN -> [SKIP][58] ([i915#4070] / [i915#533] / [i915#6768])
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@kms_vblank@pipe-d-wait-busy-hang.html

  * igt@v3d/v3d_submit_cl@bad-in-sync:
    - shard-rkl:          NOTRUN -> [SKIP][59] ([fdo#109315])
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@v3d/v3d_submit_cl@bad-in-sync.html

  * igt@vc4/vc4_perfmon@get-values-valid-perfmon:
    - shard-rkl:          NOTRUN -> [SKIP][60] ([i915#7711]) +1 similar issue
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@vc4/vc4_perfmon@get-values-valid-perfmon.html

  
#### Possible fixes ####

  * igt@drm_fdinfo@most-busy-check-all@rcs0:
    - shard-rkl:          [FAIL][61] ([i915#7742]) -> [PASS][62]
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/shard-rkl-2/igt@drm_fdinfo@most-busy-check-all@rcs0.html
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-6/igt@drm_fdinfo@most-busy-check-all@rcs0.html

  * igt@drm_read@empty-nonblock:
    - shard-snb:          [SKIP][63] ([fdo#109271]) -> [PASS][64]
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/shard-snb2/igt@drm_read@empty-nonblock.html
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-snb2/igt@drm_read@empty-nonblock.html

  * igt@gem_eio@reset-stress:
    - {shard-dg1}:        [FAIL][65] ([i915#5784]) -> [PASS][66]
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/shard-dg1-19/igt@gem_eio@reset-stress.html
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-dg1-19/igt@gem_eio@reset-stress.html

  * igt@gem_eio@throttle:
    - {shard-dg1}:        [DMESG-WARN][67] ([i915#4423]) -> [PASS][68]
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/shard-dg1-13/igt@gem_eio@throttle.html
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-dg1-18/igt@gem_eio@throttle.html

  * igt@gem_exec_fair@basic-deadline:
    - shard-rkl:          [FAIL][69] ([i915#2846]) -> [PASS][70]
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/shard-rkl-7/igt@gem_exec_fair@basic-deadline.html
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-1/igt@gem_exec_fair@basic-deadline.html

  * igt@gem_exec_suspend@basic-s4-devices@smem:
    - shard-tglu:         [ABORT][71] ([i915#7975] / [i915#8213]) -> [PASS][72]
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/shard-tglu-10/igt@gem_exec_suspend@basic-s4-devices@smem.html
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-tglu-6/igt@gem_exec_suspend@basic-s4-devices@smem.html

  * igt@gem_mmap_gtt@fault-concurrent-x:
    - shard-snb:          [ABORT][73] ([i915#5161]) -> [PASS][74]
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/shard-snb7/igt@gem_mmap_gtt@fault-concurrent-x.html
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-snb1/igt@gem_mmap_gtt@fault-concurrent-x.html

  * igt@i915_pm_rc6_residency@rc6-idle@vcs0:
    - {shard-dg1}:        [FAIL][75] ([i915#3591]) -> [PASS][76] +1 similar issue
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/shard-dg1-16/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-dg1-12/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html

  * igt@i915_pm_rpm@dpms-non-lpsp:
    - {shard-dg1}:        [SKIP][77] ([i915#1397]) -> [PASS][78] +1 similar issue
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/shard-dg1-19/igt@i915_pm_rpm@dpms-non-lpsp.html
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-dg1-16/igt@i915_pm_rpm@dpms-non-lpsp.html

  * igt@kms_cursor_legacy@forked-move@pipe-b:
    - {shard-dg1}:        [INCOMPLETE][79] ([i915#8011] / [i915#8347]) -> [PASS][80] +1 similar issue
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/shard-dg1-19/igt@kms_cursor_legacy@forked-move@pipe-b.html
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-dg1-16/igt@kms_cursor_legacy@forked-move@pipe-b.html

  * igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ac-hdmi-a1-hdmi-a2:
    - shard-glk:          [FAIL][81] ([i915#2122]) -> [PASS][82]
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/shard-glk5/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ac-hdmi-a1-hdmi-a2.html
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-glk7/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ac-hdmi-a1-hdmi-a2.html

  
#### Warnings ####

  * igt@kms_fbcon_fbt@psr:
    - shard-rkl:          [SKIP][83] ([i915#3955]) -> [SKIP][84] ([fdo#110189] / [i915#3955])
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/shard-rkl-7/igt@kms_fbcon_fbt@psr.html
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-1/igt@kms_fbcon_fbt@psr.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
  [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
  [fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
  [fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
  [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
  [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
  [i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
  [i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
  [i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
  [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
  [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
  [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
  [i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
  [i915#2898]: https://gitlab.freedesktop.org/drm/intel/issues/2898
  [i915#3023]: https://gitlab.freedesktop.org/drm/intel/issues/3023
  [i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
  [i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
  [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
  [i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
  [i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
  [i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
  [i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
  [i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804
  [i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
  [i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
  [i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
  [i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
  [i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
  [i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
  [i915#5161]: https://gitlab.freedesktop.org/drm/intel/issues/5161
  [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
  [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
  [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
  [i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
  [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
  [i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493
  [i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
  [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
  [i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
  [i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
  [i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
  [i915#7178]: https://gitlab.freedesktop.org/drm/intel/issues/7178
  [i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
  [i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
  [i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
  [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
  [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
  [i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
  [i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
  [i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213
  [i915#8228]: https://gitlab.freedesktop.org/drm/intel/issues/8228
  [i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
  [i915#8295]: https://gitlab.freedesktop.org/drm/intel/issues/8295
  [i915#8304]: https://gitlab.freedesktop.org/drm/intel/issues/8304
  [i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
  [i915#8399]: https://gitlab.freedesktop.org/drm/intel/issues/8399
  [i915#8411]: https://gitlab.freedesktop.org/drm/intel/issues/8411
  [i915#8502]: https://gitlab.freedesktop.org/drm/intel/issues/8502


Build changes
-------------

  * Linux: CI_DRM_13279 -> Patchwork_119480v1

  CI-20190529: 20190529
  CI_DRM_13279: 2998419e79e4f902b49309915b475d5a0e3db8a7 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_7335: b7d168f61bef72a3e84e72eeee1767fac577d70d @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  Patchwork_119480v1: 2998419e79e4f902b49309915b475d5a0e3db8a7 @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/index.html

[-- Attachment #2: Type: text/html, Size: 27427 bytes --]

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/4] drm/i915: Add missing forward declarations/includes to display power headers

[Imre Deak]

On Sat, Jun 17, 2023 at 01:10:42PM +0000, Patchwork wrote:
> == Series Details ==
> 
> Series: series starting with [1/4] drm/i915: Add missing forward declarations/includes to display power headers
> URL   : https://patchwork.freedesktop.org/series/119480/
> State : failure
> 
> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_13279_full -> Patchwork_119480v1_full
> ====================================================
> 
> Summary
> -------
> 
>   **FAILURE**
> 
>   Serious unknown changes coming with Patchwork_119480v1_full absolutely need to be
>   verified manually.
>   
>   If you think the reported changes have nothing to do with the changes
>   introduced in Patchwork_119480v1_full, please notify your bug team to allow them
>   to document this new failure mode, which will reduce false positives in CI.
> 
>   
> 
> Participating hosts (8 -> 7)
> ------------------------------
> 
>   Missing    (1): shard-rkl0 
> 
> Possible new issues
> -------------------
> 
>   Here are the unknown changes that may have been introduced in Patchwork_119480v1_full:
> 
> ### IGT changes ###
> 
> #### Possible regressions ####
> 
>   * igt@kms_flip@2x-flip-vs-dpms-off-vs-modeset-interruptible:
>     - shard-snb:          NOTRUN -> [ABORT][1]
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-snb5/igt@kms_flip@2x-flip-vs-dpms-off-vs-modeset-interruptible.html

DEBUG_LOCKS_WARN_ON(debug_atomic_read(nr_unused_locks) != nr_unused)

SNB doesn't support DC states, so the change on this machine causes only
dropping the runtime PM reference after a 17 ms delay. However the
corresponding runtime suspend happens anyway in a delayed manner
already, so it's hard to imagine how the change would be related to the
other failure.

There is a ticket for the same WARN at
https://gitlab.freedesktop.org/drm/intel/-/issues/8189

which also happened on SNB.

> Known issues
> ------------
> 
>   Here are the changes found in Patchwork_119480v1_full that come from known issues:
> 
> ### IGT changes ###
> 
> #### Issues hit ####
> 
>   * igt@gem_close_race@multigpu-basic-process:
>     - shard-rkl:          NOTRUN -> [SKIP][2] ([i915#7697])
>    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@gem_close_race@multigpu-basic-process.html
> 
>   * igt@gem_eio@hibernate:
>     - shard-snb:          [PASS][3] -> [SKIP][4] ([fdo#109271])
>    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/shard-snb6/igt@gem_eio@hibernate.html
>    [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-snb6/igt@gem_eio@hibernate.html
>     - shard-rkl:          NOTRUN -> [ABORT][5] ([i915#7975] / [i915#8213])
>    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@gem_eio@hibernate.html
> 
>   * igt@gem_exec_fair@basic-none-solo@rcs0:
>     - shard-apl:          [PASS][6] -> [FAIL][7] ([i915#2842])
>    [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/shard-apl2/igt@gem_exec_fair@basic-none-solo@rcs0.html
>    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-apl3/igt@gem_exec_fair@basic-none-solo@rcs0.html
> 
>   * igt@gem_exec_fair@basic-pace-share@rcs0:
>     - shard-tglu:         [PASS][8] -> [FAIL][9] ([i915#2842])
>    [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/shard-tglu-5/igt@gem_exec_fair@basic-pace-share@rcs0.html
>    [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-tglu-9/igt@gem_exec_fair@basic-pace-share@rcs0.html
> 
>   * igt@gem_exec_fair@basic-pace@rcs0:
>     - shard-rkl:          [PASS][10] -> [FAIL][11] ([i915#2842]) +2 similar issues
>    [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/shard-rkl-6/igt@gem_exec_fair@basic-pace@rcs0.html
>    [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@gem_exec_fair@basic-pace@rcs0.html
> 
>   * igt@gem_exec_reloc@basic-wc-read:
>     - shard-rkl:          NOTRUN -> [SKIP][12] ([i915#3281])
>    [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@gem_exec_reloc@basic-wc-read.html
> 
>   * igt@gem_ppgtt@blt-vs-render-ctx0:
>     - shard-snb:          [PASS][13] -> [INCOMPLETE][14] ([i915#8295])
>    [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/shard-snb6/igt@gem_ppgtt@blt-vs-render-ctx0.html
>    [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-snb6/igt@gem_ppgtt@blt-vs-render-ctx0.html
> 
>   * igt@gem_set_tiling_vs_blt@untiled-to-tiled:
>     - shard-rkl:          NOTRUN -> [SKIP][15] ([i915#8411])
>    [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@gem_set_tiling_vs_blt@untiled-to-tiled.html
> 
>   * igt@gem_spin_batch@spin-each:
>     - shard-apl:          [PASS][16] -> [FAIL][17] ([i915#2898])
>    [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/shard-apl6/igt@gem_spin_batch@spin-each.html
>    [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-apl3/igt@gem_spin_batch@spin-each.html
> 
>   * igt@gem_userptr_blits@unsync-unmap-cycles:
>     - shard-rkl:          NOTRUN -> [SKIP][18] ([i915#3297])
>    [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@gem_userptr_blits@unsync-unmap-cycles.html
> 
>   * igt@i915_pm_dc@dc9-dpms:
>     - shard-tglu:         [PASS][19] -> [SKIP][20] ([i915#4281])
>    [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/shard-tglu-10/igt@i915_pm_dc@dc9-dpms.html
>    [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-tglu-6/igt@i915_pm_dc@dc9-dpms.html
> 
>   * igt@i915_pm_freq_api@freq-reset:
>     - shard-rkl:          NOTRUN -> [SKIP][21] ([i915#8399])
>    [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@i915_pm_freq_api@freq-reset.html
> 
>   * igt@i915_pm_rpm@dpms-lpsp:
>     - shard-rkl:          [PASS][22] -> [SKIP][23] ([i915#1397])
>    [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/shard-rkl-7/igt@i915_pm_rpm@dpms-lpsp.html
>    [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-1/igt@i915_pm_rpm@dpms-lpsp.html
> 
>   * igt@i915_selftest@live@gt_heartbeat:
>     - shard-apl:          [PASS][24] -> [DMESG-FAIL][25] ([i915#5334])
>    [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/shard-apl6/igt@i915_selftest@live@gt_heartbeat.html
>    [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-apl4/igt@i915_selftest@live@gt_heartbeat.html
> 
>   * igt@kms_big_fb@x-tiled-64bpp-rotate-90:
>     - shard-rkl:          NOTRUN -> [SKIP][26] ([fdo#111614] / [i915#3638]) +1 similar issue
>    [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@kms_big_fb@x-tiled-64bpp-rotate-90.html
> 
>   * igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip:
>     - shard-tglu:         [PASS][27] -> [FAIL][28] ([i915#3743]) +1 similar issue
>    [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/shard-tglu-5/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html
>    [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-tglu-6/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html
> 
>   * igt@kms_big_fb@yf-tiled-32bpp-rotate-90:
>     - shard-rkl:          NOTRUN -> [SKIP][29] ([fdo#110723])
>    [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@kms_big_fb@yf-tiled-32bpp-rotate-90.html
> 
>   * igt@kms_ccs@pipe-a-bad-pixel-format-4_tiled_mtl_rc_ccs:
>     - shard-rkl:          NOTRUN -> [SKIP][30] ([i915#5354] / [i915#6095])
>    [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@kms_ccs@pipe-a-bad-pixel-format-4_tiled_mtl_rc_ccs.html
> 
>   * igt@kms_ccs@pipe-b-missing-ccs-buffer-yf_tiled_ccs:
>     - shard-rkl:          NOTRUN -> [SKIP][31] ([i915#3734] / [i915#5354] / [i915#6095]) +1 similar issue
>    [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@kms_ccs@pipe-b-missing-ccs-buffer-yf_tiled_ccs.html
> 
>   * igt@kms_ccs@pipe-d-missing-ccs-buffer-y_tiled_gen12_mc_ccs:
>     - shard-rkl:          NOTRUN -> [SKIP][32] ([i915#5354]) +6 similar issues
>    [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@kms_ccs@pipe-d-missing-ccs-buffer-y_tiled_gen12_mc_ccs.html
> 
>   * igt@kms_chamelium_edid@dp-mode-timings:
>     - shard-rkl:          NOTRUN -> [SKIP][33] ([i915#7828]) +2 similar issues
>    [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@kms_chamelium_edid@dp-mode-timings.html
> 
>   * igt@kms_color@deep-color:
>     - shard-rkl:          NOTRUN -> [SKIP][34] ([i915#3555] / [i915#4579]) +1 similar issue
>    [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@kms_color@deep-color.html
> 
>   * igt@kms_content_protection@uevent:
>     - shard-rkl:          NOTRUN -> [SKIP][35] ([i915#4579] / [i915#7118])
>    [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@kms_content_protection@uevent.html
> 
>   * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
>     - shard-apl:          [PASS][36] -> [FAIL][37] ([i915#2346])
>    [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/shard-apl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
>    [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-apl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
> 
>   * igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-2:
>     - shard-rkl:          NOTRUN -> [SKIP][38] ([i915#3804] / [i915#4579])
>    [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-1/igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-2.html
> 
>   * igt@kms_dsc@dsc-basic:
>     - shard-rkl:          NOTRUN -> [SKIP][39] ([i915#3840] / [i915#4579])
>    [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@kms_dsc@dsc-basic.html
> 
>   * igt@kms_flip@2x-flip-vs-panning:
>     - shard-rkl:          NOTRUN -> [SKIP][40] ([fdo#111825]) +2 similar issues
>    [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@kms_flip@2x-flip-vs-panning.html
> 
>   * igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a2:
>     - shard-glk:          [PASS][41] -> [FAIL][42] ([i915#79])
>    [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/shard-glk6/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a2.html
>    [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-glk3/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a2.html
> 
>   * igt@kms_flip@plain-flip-ts-check-interruptible@a-hdmi-a1:
>     - shard-glk:          [PASS][43] -> [FAIL][44] ([i915#2122])
>    [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/shard-glk5/igt@kms_flip@plain-flip-ts-check-interruptible@a-hdmi-a1.html
>    [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-glk9/igt@kms_flip@plain-flip-ts-check-interruptible@a-hdmi-a1.html
> 
>   * igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-upscaling@pipe-a-valid-mode:
>     - shard-rkl:          NOTRUN -> [SKIP][45] ([i915#2672] / [i915#4579])
>    [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-upscaling@pipe-a-valid-mode.html
> 
>   * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-indfb-plflip-blt:
>     - shard-rkl:          NOTRUN -> [SKIP][46] ([fdo#111825] / [i915#1825]) +8 similar issues
>    [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-indfb-plflip-blt.html
> 
>   * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt:
>     - shard-rkl:          NOTRUN -> [SKIP][47] ([i915#3023]) +6 similar issues
>    [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt.html
> 
>   * igt@kms_frontbuffer_tracking@fbcpsr-stridechange:
>     - shard-tglu:         NOTRUN -> [SKIP][48] ([fdo#110189])
>    [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-tglu-6/igt@kms_frontbuffer_tracking@fbcpsr-stridechange.html
> 
>   * igt@kms_hdr@invalid-hdr:
>     - shard-rkl:          NOTRUN -> [SKIP][49] ([i915#4579] / [i915#6953] / [i915#8228])
>    [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-2/igt@kms_hdr@invalid-hdr.html
> 
>   * igt@kms_plane_lowres@tiling-4:
>     - shard-rkl:          NOTRUN -> [SKIP][50] ([i915#4579])
>    [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@kms_plane_lowres@tiling-4.html
> 
>   * igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-a-hdmi-a-1:
>     - shard-rkl:          NOTRUN -> [SKIP][51] ([i915#5176]) +5 similar issues
>    [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-a-hdmi-a-1.html
> 
>   * igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-rotation@pipe-b-hdmi-a-2:
>     - shard-rkl:          NOTRUN -> [SKIP][52] ([i915#4579] / [i915#5176]) +5 similar issues
>    [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-1/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-rotation@pipe-b-hdmi-a-2.html
> 
>   * igt@kms_plane_scaling@planes-downscale-factor-0-5-unity-scaling@pipe-b-vga-1:
>     - shard-snb:          NOTRUN -> [SKIP][53] ([fdo#109271] / [i915#4579]) +13 similar issues
>    [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-snb5/igt@kms_plane_scaling@planes-downscale-factor-0-5-unity-scaling@pipe-b-vga-1.html
> 
>   * igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-75@pipe-a-hdmi-a-1:
>     - shard-snb:          NOTRUN -> [SKIP][54] ([fdo#109271]) +27 similar issues
>    [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-snb1/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-75@pipe-a-hdmi-a-1.html
> 
>   * igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-a-hdmi-a-2:
>     - shard-rkl:          NOTRUN -> [SKIP][55] ([i915#5235]) +1 similar issue
>    [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-1/igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-a-hdmi-a-2.html
> 
>   * igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-b-hdmi-a-2:
>     - shard-rkl:          NOTRUN -> [SKIP][56] ([i915#4579] / [i915#5235]) +1 similar issue
>    [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-1/igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-b-hdmi-a-2.html
> 
>   * igt@kms_psr@sprite_blt:
>     - shard-rkl:          NOTRUN -> [SKIP][57] ([i915#1072]) +1 similar issue
>    [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@kms_psr@sprite_blt.html
> 
>   * igt@kms_vblank@pipe-d-wait-busy-hang:
>     - shard-rkl:          NOTRUN -> [SKIP][58] ([i915#4070] / [i915#533] / [i915#6768])
>    [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@kms_vblank@pipe-d-wait-busy-hang.html
> 
>   * igt@v3d/v3d_submit_cl@bad-in-sync:
>     - shard-rkl:          NOTRUN -> [SKIP][59] ([fdo#109315])
>    [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@v3d/v3d_submit_cl@bad-in-sync.html
> 
>   * igt@vc4/vc4_perfmon@get-values-valid-perfmon:
>     - shard-rkl:          NOTRUN -> [SKIP][60] ([i915#7711]) +1 similar issue
>    [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-7/igt@vc4/vc4_perfmon@get-values-valid-perfmon.html
> 
>   
> #### Possible fixes ####
> 
>   * igt@drm_fdinfo@most-busy-check-all@rcs0:
>     - shard-rkl:          [FAIL][61] ([i915#7742]) -> [PASS][62]
>    [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/shard-rkl-2/igt@drm_fdinfo@most-busy-check-all@rcs0.html
>    [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-6/igt@drm_fdinfo@most-busy-check-all@rcs0.html
> 
>   * igt@drm_read@empty-nonblock:
>     - shard-snb:          [SKIP][63] ([fdo#109271]) -> [PASS][64]
>    [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/shard-snb2/igt@drm_read@empty-nonblock.html
>    [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-snb2/igt@drm_read@empty-nonblock.html
> 
>   * igt@gem_eio@reset-stress:
>     - {shard-dg1}:        [FAIL][65] ([i915#5784]) -> [PASS][66]
>    [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/shard-dg1-19/igt@gem_eio@reset-stress.html
>    [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-dg1-19/igt@gem_eio@reset-stress.html
> 
>   * igt@gem_eio@throttle:
>     - {shard-dg1}:        [DMESG-WARN][67] ([i915#4423]) -> [PASS][68]
>    [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/shard-dg1-13/igt@gem_eio@throttle.html
>    [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-dg1-18/igt@gem_eio@throttle.html
> 
>   * igt@gem_exec_fair@basic-deadline:
>     - shard-rkl:          [FAIL][69] ([i915#2846]) -> [PASS][70]
>    [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/shard-rkl-7/igt@gem_exec_fair@basic-deadline.html
>    [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-1/igt@gem_exec_fair@basic-deadline.html
> 
>   * igt@gem_exec_suspend@basic-s4-devices@smem:
>     - shard-tglu:         [ABORT][71] ([i915#7975] / [i915#8213]) -> [PASS][72]
>    [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/shard-tglu-10/igt@gem_exec_suspend@basic-s4-devices@smem.html
>    [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-tglu-6/igt@gem_exec_suspend@basic-s4-devices@smem.html
> 
>   * igt@gem_mmap_gtt@fault-concurrent-x:
>     - shard-snb:          [ABORT][73] ([i915#5161]) -> [PASS][74]
>    [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/shard-snb7/igt@gem_mmap_gtt@fault-concurrent-x.html
>    [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-snb1/igt@gem_mmap_gtt@fault-concurrent-x.html
> 
>   * igt@i915_pm_rc6_residency@rc6-idle@vcs0:
>     - {shard-dg1}:        [FAIL][75] ([i915#3591]) -> [PASS][76] +1 similar issue
>    [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/shard-dg1-16/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html
>    [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-dg1-12/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html
> 
>   * igt@i915_pm_rpm@dpms-non-lpsp:
>     - {shard-dg1}:        [SKIP][77] ([i915#1397]) -> [PASS][78] +1 similar issue
>    [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/shard-dg1-19/igt@i915_pm_rpm@dpms-non-lpsp.html
>    [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-dg1-16/igt@i915_pm_rpm@dpms-non-lpsp.html
> 
>   * igt@kms_cursor_legacy@forked-move@pipe-b:
>     - {shard-dg1}:        [INCOMPLETE][79] ([i915#8011] / [i915#8347]) -> [PASS][80] +1 similar issue
>    [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/shard-dg1-19/igt@kms_cursor_legacy@forked-move@pipe-b.html
>    [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-dg1-16/igt@kms_cursor_legacy@forked-move@pipe-b.html
> 
>   * igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ac-hdmi-a1-hdmi-a2:
>     - shard-glk:          [FAIL][81] ([i915#2122]) -> [PASS][82]
>    [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/shard-glk5/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ac-hdmi-a1-hdmi-a2.html
>    [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-glk7/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ac-hdmi-a1-hdmi-a2.html
> 
>   
> #### Warnings ####
> 
>   * igt@kms_fbcon_fbt@psr:
>     - shard-rkl:          [SKIP][83] ([i915#3955]) -> [SKIP][84] ([fdo#110189] / [i915#3955])
>    [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13279/shard-rkl-7/igt@kms_fbcon_fbt@psr.html
>    [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/shard-rkl-1/igt@kms_fbcon_fbt@psr.html
> 
>   
>   {name}: This element is suppressed. This means it is ignored when computing
>           the status of the difference (SUCCESS, WARNING, or FAILURE).
> 
>   [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
>   [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
>   [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
>   [fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
>   [fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
>   [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
>   [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
>   [i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
>   [i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
>   [i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
>   [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
>   [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
>   [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
>   [i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
>   [i915#2898]: https://gitlab.freedesktop.org/drm/intel/issues/2898
>   [i915#3023]: https://gitlab.freedesktop.org/drm/intel/issues/3023
>   [i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
>   [i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
>   [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
>   [i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
>   [i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
>   [i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
>   [i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
>   [i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804
>   [i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
>   [i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
>   [i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
>   [i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
>   [i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
>   [i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
>   [i915#5161]: https://gitlab.freedesktop.org/drm/intel/issues/5161
>   [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
>   [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
>   [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
>   [i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
>   [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
>   [i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493
>   [i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
>   [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
>   [i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
>   [i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
>   [i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
>   [i915#7178]: https://gitlab.freedesktop.org/drm/intel/issues/7178
>   [i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
>   [i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
>   [i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
>   [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
>   [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
>   [i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
>   [i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
>   [i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213
>   [i915#8228]: https://gitlab.freedesktop.org/drm/intel/issues/8228
>   [i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
>   [i915#8295]: https://gitlab.freedesktop.org/drm/intel/issues/8295
>   [i915#8304]: https://gitlab.freedesktop.org/drm/intel/issues/8304
>   [i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
>   [i915#8399]: https://gitlab.freedesktop.org/drm/intel/issues/8399
>   [i915#8411]: https://gitlab.freedesktop.org/drm/intel/issues/8411
>   [i915#8502]: https://gitlab.freedesktop.org/drm/intel/issues/8502
> 
> 
> Build changes
> -------------
> 
>   * Linux: CI_DRM_13279 -> Patchwork_119480v1
> 
>   CI-20190529: 20190529
>   CI_DRM_13279: 2998419e79e4f902b49309915b475d5a0e3db8a7 @ git://anongit.freedesktop.org/gfx-ci/linux
>   IGT_7335: b7d168f61bef72a3e84e72eeee1767fac577d70d @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
>   Patchwork_119480v1: 2998419e79e4f902b49309915b475d5a0e3db8a7 @ git://anongit.freedesktop.org/gfx-ci/linux
>   piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
> 
> == Logs ==
> 
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v1/index.html

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Prevent needless toggling of DC states during modesets

[Hogander, Jouni]

On Fri, 2023-06-16 at 21:51 +0300, Imre Deak wrote:
> DC states are disabled / re-enabled around each modeset, which may
> lead
> to a needless off->on->off toggling of the DC_off power well. This
> has
> some overhead as toggling DC states involves running a DMC firmware
> handler and also running a periodic firmware handler while DC states
> are
> enabled. The limit of when DC states have a benefit is at 30 FPS
> (using
> DC3co) and below 30 FPS (using DC5/6), where the firmware can
> actually
> disable clocks / power off power wells. Accordingly delay powering
> off
> the DC_off powerwell (which re-enables DC states) by 17 ms at the end
> of
> a modeset to avoid the above overhead at or above 60 FPS.

I'm wondering in which case this toggling would happen and how the
patch helps it. We have PSR idle frames configured > 6. I.e. Only after
6 frames without changes our HW is supposed to enter DC5/6. This is
purely with PSR glasses on. Do we have some other (than PSR) use-case
this is targeting where DC5/DC6 would be possible while display is on?


> Signed-off-by: Imre Deak <imre.deak@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_display.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c
> b/drivers/gpu/drm/i915/display/intel_display.c
> index dd52c689267f4..de77d130d6f9f 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -7148,7 +7148,11 @@ static void intel_atomic_commit_tail(struct
> intel_atomic_state *state)
>                  */
>                 intel_uncore_arm_unclaimed_mmio_detection(&dev_priv-
> >uncore);
>         }
> -       intel_display_power_put(dev_priv, POWER_DOMAIN_DC_OFF,
> wakeref);
> +       /*
> +        * Delay re-enabling DC states by 17 ms to avoid the off->on-
> >off
> +        * toggling overhead at and above 60 FPS.
> +        */
> +       intel_display_power_put_async_delay(dev_priv,
> POWER_DOMAIN_DC_OFF, wakeref, 17);
>         intel_runtime_pm_put(&dev_priv->runtime_pm, state->wakeref);
>  
>         /*

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Prevent needless toggling of DC states during modesets

[Imre Deak]

On Thu, Jun 22, 2023 at 12:38:17PM +0300, Hogander, Jouni wrote:
> On Fri, 2023-06-16 at 21:51 +0300, Imre Deak wrote:
> > DC states are disabled / re-enabled around each modeset, which may
> > lead to a needless off->on->off toggling of the DC_off power well.
> > This has some overhead as toggling DC states involves running a DMC
> > firmware handler and also running a periodic firmware handler while
> > DC states are enabled. The limit of when DC states have a benefit is
> > at 30 FPS (using DC3co) and below 30 FPS (using DC5/6), where the
> > firmware can actually disable clocks / power off power wells.
> > Accordingly delay powering off the DC_off powerwell (which
> > re-enables DC states) by 17 ms at the end of a modeset to avoid the
> > above overhead at or above 60 FPS.
> 
> I'm wondering in which case this toggling would happen and how the
> patch helps it.

It happens around each modeset in cases DC states are allowed by the
enabled outputs. For instance a single eDP output enabled and user space
doing back-to-back page flipping (issuing a new flip once the previous
one completes). The reason to avoid the
disable DC state -> flip -> re-enable DC state
toggling of DC states around each flip in this case is to avoid the
overhead of the DMC FW handlers running I described above (as the
firmware won't actually get to enter DC states anyway).

> We have PSR idle frames configured > 6. I.e. Only after 6 frames
> without changes our HW is supposed to enter DC5/6. This is purely with
> PSR glasses on. Do we have some other (than PSR) use-case this is
> targeting where DC5/DC6 would be possible while display is on?

DC3co would allow the DMC FW to enter DC states (actually disabling
clocks/power wells) after each frame at 30 FPS.

> > Signed-off-by: Imre Deak <imre.deak@intel.com>
> > ---
> >  drivers/gpu/drm/i915/display/intel_display.c | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_display.c
> > b/drivers/gpu/drm/i915/display/intel_display.c
> > index dd52c689267f4..de77d130d6f9f 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display.c
> > +++ b/drivers/gpu/drm/i915/display/intel_display.c
> > @@ -7148,7 +7148,11 @@ static void intel_atomic_commit_tail(struct
> > intel_atomic_state *state)
> >                  */
> >                 intel_uncore_arm_unclaimed_mmio_detection(&dev_priv-
> > >uncore);
> >         }
> > -       intel_display_power_put(dev_priv, POWER_DOMAIN_DC_OFF,
> > wakeref);
> > +       /*
> > +        * Delay re-enabling DC states by 17 ms to avoid the off->on-
> > >off
> > +        * toggling overhead at and above 60 FPS.
> > +        */
> > +       intel_display_power_put_async_delay(dev_priv,
> > POWER_DOMAIN_DC_OFF, wakeref, 17);
> >         intel_runtime_pm_put(&dev_priv->runtime_pm, state->wakeref);
> >
> >         /*
> 

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Prevent needless toggling of DC states during modesets

[Hogander, Jouni]

On Thu, 2023-06-22 at 15:05 +0300, Imre Deak wrote:
> On Thu, Jun 22, 2023 at 12:38:17PM +0300, Hogander, Jouni wrote:
> > On Fri, 2023-06-16 at 21:51 +0300, Imre Deak wrote:
> > > DC states are disabled / re-enabled around each modeset, which
> > > may
> > > lead to a needless off->on->off toggling of the DC_off power
> > > well.
> > > This has some overhead as toggling DC states involves running a
> > > DMC
> > > firmware handler and also running a periodic firmware handler
> > > while
> > > DC states are enabled. The limit of when DC states have a benefit
> > > is
> > > at 30 FPS (using DC3co) and below 30 FPS (using DC5/6), where the
> > > firmware can actually disable clocks / power off power wells.
> > > Accordingly delay powering off the DC_off powerwell (which
> > > re-enables DC states) by 17 ms at the end of a modeset to avoid
> > > the
> > > above overhead at or above 60 FPS.
> > 
> > I'm wondering in which case this toggling would happen and how the
> > patch helps it.
> 
> It happens around each modeset in cases DC states are allowed by the
> enabled outputs. For instance a single eDP output enabled and user
> space
> doing back-to-back page flipping (issuing a new flip once the
> previous
> one completes). The reason to avoid the
> disable DC state -> flip -> re-enable DC state
> toggling of DC states around each flip in this case is to avoid the
> overhead of the DMC FW handlers running I described above (as the
> firmware won't actually get to enter DC states anyway).
> 
> > We have PSR idle frames configured > 6. I.e. Only after 6 frames
> > without changes our HW is supposed to enter DC5/6. This is purely
> > with
> > PSR glasses on. Do we have some other (than PSR) use-case this is
> > targeting where DC5/DC6 would be possible while display is on?
> 
> DC3co would allow the DMC FW to enter DC states (actually disabling
> clocks/power wells) after each frame at 30 FPS.

Thank you for the clarification. For the whole set:

Reviewed-by: Jouni Högander <jouni.hogander@intel.com>

> 
> > > Signed-off-by: Imre Deak <imre.deak@intel.com>
> > > ---
> > >  drivers/gpu/drm/i915/display/intel_display.c | 6 +++++-
> > >  1 file changed, 5 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c
> > > b/drivers/gpu/drm/i915/display/intel_display.c
> > > index dd52c689267f4..de77d130d6f9f 100644
> > > --- a/drivers/gpu/drm/i915/display/intel_display.c
> > > +++ b/drivers/gpu/drm/i915/display/intel_display.c
> > > @@ -7148,7 +7148,11 @@ static void
> > > intel_atomic_commit_tail(struct
> > > intel_atomic_state *state)
> > >                  */
> > >                
> > > intel_uncore_arm_unclaimed_mmio_detection(&dev_priv-
> > > > uncore);
> > >         }
> > > -       intel_display_power_put(dev_priv, POWER_DOMAIN_DC_OFF,
> > > wakeref);
> > > +       /*
> > > +        * Delay re-enabling DC states by 17 ms to avoid the off-
> > > >on-
> > > > off
> > > +        * toggling overhead at and above 60 FPS.
> > > +        */
> > > +       intel_display_power_put_async_delay(dev_priv,
> > > POWER_DOMAIN_DC_OFF, wakeref, 17);
> > >         intel_runtime_pm_put(&dev_priv->runtime_pm, state-
> > > >wakeref);
> > > 
> > >         /*
> > 

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915: Add missing forward declarations/includes to display power headers (rev2)

[Patchwork]

== Series Details ==

Series: series starting with [1/4] drm/i915: Add missing forward declarations/includes to display power headers (rev2)
URL   : https://patchwork.freedesktop.org/series/119480/
State : warning

== Summary ==

Error: dim checkpatch failed
5ccc66939606 drm/i915: Add missing forward declarations/includes to display power headers
-:13: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#13: 
declared inside parameter list will not be visible outside of this definition or declaration [-Werror]

total: 0 errors, 1 warnings, 0 checks, 24 lines checked
ebc86a34d481 drm/i915: Remove redundant forward declarations from display power headers
9c4f62e76330 drm/i915: Add way to specify the power-off delay of a display power domain
02c2d3bd104b drm/i915: Prevent needless toggling of DC states during modesets

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/4] drm/i915: Add missing forward declarations/includes to display power headers (rev2)

[Patchwork]

== Series Details ==

Series: series starting with [1/4] drm/i915: Add missing forward declarations/includes to display power headers (rev2)
URL   : https://patchwork.freedesktop.org/series/119480/
State : warning

== Summary ==

Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915: Add missing forward declarations/includes to display power headers (rev2)

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 6425 bytes --]

== Series Details ==

Series: series starting with [1/4] drm/i915: Add missing forward declarations/includes to display power headers (rev2)
URL   : https://patchwork.freedesktop.org/series/119480/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_13309 -> Patchwork_119480v2
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_119480v2 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_119480v2, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/index.html

Participating hosts (43 -> 41)
------------------------------

  Missing    (2): fi-kbl-soraka fi-snb-2520m 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_119480v2:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_pm_rpm@basic-pci-d3-state:
    - bat-mtlp-8:         [PASS][1] -> [ABORT][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13309/bat-mtlp-8/igt@i915_pm_rpm@basic-pci-d3-state.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/bat-mtlp-8/igt@i915_pm_rpm@basic-pci-d3-state.html

  
Known issues
------------

  Here are the changes found in Patchwork_119480v2 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_selftest@live@guc:
    - bat-rpls-1:         [PASS][3] -> [DMESG-WARN][4] ([i915#7852])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13309/bat-rpls-1/igt@i915_selftest@live@guc.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/bat-rpls-1/igt@i915_selftest@live@guc.html

  * igt@i915_selftest@live@hangcheck:
    - bat-adlp-9:         [PASS][5] -> [ABORT][6] ([i915#7677] / [i915#7913])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13309/bat-adlp-9/igt@i915_selftest@live@hangcheck.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/bat-adlp-9/igt@i915_selftest@live@hangcheck.html

  * igt@i915_selftest@live@requests:
    - bat-mtlp-6:         [PASS][7] -> [DMESG-FAIL][8] ([i915#7269])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13309/bat-mtlp-6/igt@i915_selftest@live@requests.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/bat-mtlp-6/igt@i915_selftest@live@requests.html

  * igt@i915_selftest@live@slpc:
    - bat-rpls-2:         NOTRUN -> [DMESG-WARN][9] ([i915#6367])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/bat-rpls-2/igt@i915_selftest@live@slpc.html
    - bat-rpls-1:         [PASS][10] -> [DMESG-WARN][11] ([i915#6367])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13309/bat-rpls-1/igt@i915_selftest@live@slpc.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/bat-rpls-1/igt@i915_selftest@live@slpc.html

  * igt@i915_suspend@basic-s2idle-without-i915:
    - bat-rpls-2:         NOTRUN -> [ABORT][12] ([i915#6687] / [i915#8668])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/bat-rpls-2/igt@i915_suspend@basic-s2idle-without-i915.html

  * igt@kms_chamelium_hpd@common-hpd-after-suspend:
    - bat-dg2-11:         NOTRUN -> [SKIP][13] ([i915#7828])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/bat-dg2-11/igt@kms_chamelium_hpd@common-hpd-after-suspend.html

  
#### Possible fixes ####

  * igt@i915_selftest@live@requests:
    - bat-dg2-11:         [ABORT][14] ([i915#7913]) -> [PASS][15]
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13309/bat-dg2-11/igt@i915_selftest@live@requests.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/bat-dg2-11/igt@i915_selftest@live@requests.html

  * igt@i915_selftest@live@reset:
    - bat-rpls-2:         [ABORT][16] ([i915#4983] / [i915#7461] / [i915#7913] / [i915#8347]) -> [PASS][17]
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13309/bat-rpls-2/igt@i915_selftest@live@reset.html
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/bat-rpls-2/igt@i915_selftest@live@reset.html

  
#### Warnings ####

  * igt@kms_psr@primary_mmap_gtt:
    - bat-rplp-1:         [SKIP][18] ([i915#1072]) -> [ABORT][19] ([i915#8442])
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13309/bat-rplp-1/igt@kms_psr@primary_mmap_gtt.html
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/bat-rplp-1/igt@kms_psr@primary_mmap_gtt.html

  
  [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
  [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
  [i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
  [i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
  [i915#7269]: https://gitlab.freedesktop.org/drm/intel/issues/7269
  [i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
  [i915#7677]: https://gitlab.freedesktop.org/drm/intel/issues/7677
  [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
  [i915#7852]: https://gitlab.freedesktop.org/drm/intel/issues/7852
  [i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
  [i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
  [i915#8442]: https://gitlab.freedesktop.org/drm/intel/issues/8442
  [i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668


Build changes
-------------

  * Linux: CI_DRM_13309 -> Patchwork_119480v2

  CI-20190529: 20190529
  CI_DRM_13309: af67b02abf56a5018cd885c94d7611241052e98f @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_7346: 29302a0d57bcf10cb553f5d7ff5bb99166a19bba @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  Patchwork_119480v2: af67b02abf56a5018cd885c94d7611241052e98f @ git://anongit.freedesktop.org/gfx-ci/linux


### Linux commits

00c643450930 drm/i915: Prevent needless toggling of DC states during modesets
18d2155db09b drm/i915: Add way to specify the power-off delay of a display power domain
d7dab5293389 drm/i915: Remove redundant forward declarations from display power headers
1088d3e9cdc5 drm/i915: Add missing forward declarations/includes to display power headers

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/index.html

[-- Attachment #2: Type: text/html, Size: 7509 bytes --]

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915: Add missing forward declarations/includes to display power headers (rev2)

[Imre Deak]

On Thu, Jun 22, 2023 at 05:35:06PM +0000, Patchwork wrote:
> == Series Details ==
> 
> Series: series starting with [1/4] drm/i915: Add missing forward declarations/includes to display power headers (rev2)
> URL   : https://patchwork.freedesktop.org/series/119480/
> State : failure
> 
> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_13309 -> Patchwork_119480v2
> ====================================================
> 
> Summary
> -------
> 
>   **FAILURE**
> 
>   Serious unknown changes coming with Patchwork_119480v2 absolutely need to be
>   verified manually.
>   
>   If you think the reported changes have nothing to do with the changes
>   introduced in Patchwork_119480v2, please notify your bug team to allow them
>   to document this new failure mode, which will reduce false positives in CI.
> 
>   External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/index.html
> 
> Participating hosts (43 -> 41)
> ------------------------------
> 
>   Missing    (2): fi-kbl-soraka fi-snb-2520m 
> 
> Possible new issues
> -------------------
> 
>   Here are the unknown changes that may have been introduced in Patchwork_119480v2:
> 
> ### IGT changes ###
> 
> #### Possible regressions ####
> 
>   * igt@i915_pm_rpm@basic-pci-d3-state:
>     - bat-mtlp-8:         [PASS][1] -> [ABORT][2]
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13309/bat-mtlp-8/igt@i915_pm_rpm@basic-pci-d3-state.html
>    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/bat-mtlp-8/igt@i915_pm_rpm@basic-pci-d3-state.html

The test passes, however there is a lockdep problem:
<4>[  396.831915] kworker/20:1H/251 is trying to acquire lock:
<4>[  396.837189] ffffffff82761100 (fs_reclaim){+.+.}-{0:0}, at: __kmem_cache_alloc_node+0x30/0x1b0
<4>[  396.845661]
                  but task is already holding lock:
<4>[  396.851448] ffff8881043c5840 (&gt->reset.backoff_srcu){++++}-{0:0}, at: _intel_gt_reset_lock+0x172/0x330 [i915]

Can't see it related (as the only relevant thing is runtime suspend,
getting delayed by 17ms after this change, which shouldn't make a
difference).

Looks like some GuC vs. memory shrinker lockdep problem, filed already
on other platforms at:
https://gitlab.freedesktop.org/drm/intel/-/issues/8668

> Known issues
> ------------
> 
>   Here are the changes found in Patchwork_119480v2 that come from known issues:
> 
> ### IGT changes ###
> 
> #### Issues hit ####
> 
>   * igt@i915_selftest@live@guc:
>     - bat-rpls-1:         [PASS][3] -> [DMESG-WARN][4] ([i915#7852])
>    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13309/bat-rpls-1/igt@i915_selftest@live@guc.html
>    [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/bat-rpls-1/igt@i915_selftest@live@guc.html
> 
>   * igt@i915_selftest@live@hangcheck:
>     - bat-adlp-9:         [PASS][5] -> [ABORT][6] ([i915#7677] / [i915#7913])
>    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13309/bat-adlp-9/igt@i915_selftest@live@hangcheck.html
>    [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/bat-adlp-9/igt@i915_selftest@live@hangcheck.html
> 
>   * igt@i915_selftest@live@requests:
>     - bat-mtlp-6:         [PASS][7] -> [DMESG-FAIL][8] ([i915#7269])
>    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13309/bat-mtlp-6/igt@i915_selftest@live@requests.html
>    [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/bat-mtlp-6/igt@i915_selftest@live@requests.html
> 
>   * igt@i915_selftest@live@slpc:
>     - bat-rpls-2:         NOTRUN -> [DMESG-WARN][9] ([i915#6367])
>    [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/bat-rpls-2/igt@i915_selftest@live@slpc.html
>     - bat-rpls-1:         [PASS][10] -> [DMESG-WARN][11] ([i915#6367])
>    [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13309/bat-rpls-1/igt@i915_selftest@live@slpc.html
>    [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/bat-rpls-1/igt@i915_selftest@live@slpc.html
> 
>   * igt@i915_suspend@basic-s2idle-without-i915:
>     - bat-rpls-2:         NOTRUN -> [ABORT][12] ([i915#6687] / [i915#8668])
>    [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/bat-rpls-2/igt@i915_suspend@basic-s2idle-without-i915.html
> 
>   * igt@kms_chamelium_hpd@common-hpd-after-suspend:
>     - bat-dg2-11:         NOTRUN -> [SKIP][13] ([i915#7828])
>    [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/bat-dg2-11/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
> 
>   
> #### Possible fixes ####
> 
>   * igt@i915_selftest@live@requests:
>     - bat-dg2-11:         [ABORT][14] ([i915#7913]) -> [PASS][15]
>    [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13309/bat-dg2-11/igt@i915_selftest@live@requests.html
>    [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/bat-dg2-11/igt@i915_selftest@live@requests.html
> 
>   * igt@i915_selftest@live@reset:
>     - bat-rpls-2:         [ABORT][16] ([i915#4983] / [i915#7461] / [i915#7913] / [i915#8347]) -> [PASS][17]
>    [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13309/bat-rpls-2/igt@i915_selftest@live@reset.html
>    [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/bat-rpls-2/igt@i915_selftest@live@reset.html
> 
>   
> #### Warnings ####
> 
>   * igt@kms_psr@primary_mmap_gtt:
>     - bat-rplp-1:         [SKIP][18] ([i915#1072]) -> [ABORT][19] ([i915#8442])
>    [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13309/bat-rplp-1/igt@kms_psr@primary_mmap_gtt.html
>    [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/bat-rplp-1/igt@kms_psr@primary_mmap_gtt.html
> 
>   
>   [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
>   [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
>   [i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
>   [i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
>   [i915#7269]: https://gitlab.freedesktop.org/drm/intel/issues/7269
>   [i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
>   [i915#7677]: https://gitlab.freedesktop.org/drm/intel/issues/7677
>   [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
>   [i915#7852]: https://gitlab.freedesktop.org/drm/intel/issues/7852
>   [i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
>   [i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
>   [i915#8442]: https://gitlab.freedesktop.org/drm/intel/issues/8442
>   [i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668
> 
> 
> Build changes
> -------------
> 
>   * Linux: CI_DRM_13309 -> Patchwork_119480v2
> 
>   CI-20190529: 20190529
>   CI_DRM_13309: af67b02abf56a5018cd885c94d7611241052e98f @ git://anongit.freedesktop.org/gfx-ci/linux
>   IGT_7346: 29302a0d57bcf10cb553f5d7ff5bb99166a19bba @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
>   Patchwork_119480v2: af67b02abf56a5018cd885c94d7611241052e98f @ git://anongit.freedesktop.org/gfx-ci/linux
> 
> 
> ### Linux commits
> 
> 00c643450930 drm/i915: Prevent needless toggling of DC states during modesets
> 18d2155db09b drm/i915: Add way to specify the power-off delay of a display power domain
> d7dab5293389 drm/i915: Remove redundant forward declarations from display power headers
> 1088d3e9cdc5 drm/i915: Add missing forward declarations/includes to display power headers
> 
> == Logs ==
> 
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/index.html

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915: Add missing forward declarations/includes to display power headers (rev2)

[Imre Deak]

On Thu, Jun 22, 2023 at 08:57:28PM +0300, Imre Deak wrote:
> On Thu, Jun 22, 2023 at 05:35:06PM +0000, Patchwork wrote:
> > == Series Details ==
> > 
> > Series: series starting with [1/4] drm/i915: Add missing forward declarations/includes to display power headers (rev2)
> > URL   : https://patchwork.freedesktop.org/series/119480/
> > State : failure

Patchset is pushed to drm-intel-next, thanks for the reviews.

The failure is unrelated, see below.

> > 
> > == Summary ==
> > 
> > CI Bug Log - changes from CI_DRM_13309 -> Patchwork_119480v2
> > ====================================================
> > 
> > Summary
> > -------
> > 
> >   **FAILURE**
> > 
> >   Serious unknown changes coming with Patchwork_119480v2 absolutely need to be
> >   verified manually.
> >   
> >   If you think the reported changes have nothing to do with the changes
> >   introduced in Patchwork_119480v2, please notify your bug team to allow them
> >   to document this new failure mode, which will reduce false positives in CI.
> > 
> >   External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/index.html
> > 
> > Participating hosts (43 -> 41)
> > ------------------------------
> > 
> >   Missing    (2): fi-kbl-soraka fi-snb-2520m 
> > 
> > Possible new issues
> > -------------------
> > 
> >   Here are the unknown changes that may have been introduced in Patchwork_119480v2:
> > 
> > ### IGT changes ###
> > 
> > #### Possible regressions ####
> > 
> >   * igt@i915_pm_rpm@basic-pci-d3-state:
> >     - bat-mtlp-8:         [PASS][1] -> [ABORT][2]
> >    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13309/bat-mtlp-8/igt@i915_pm_rpm@basic-pci-d3-state.html
> >    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/bat-mtlp-8/igt@i915_pm_rpm@basic-pci-d3-state.html
> 
> The test passes, however there is a lockdep problem:
> <4>[  396.831915] kworker/20:1H/251 is trying to acquire lock:
> <4>[  396.837189] ffffffff82761100 (fs_reclaim){+.+.}-{0:0}, at: __kmem_cache_alloc_node+0x30/0x1b0
> <4>[  396.845661]
>                   but task is already holding lock:
> <4>[  396.851448] ffff8881043c5840 (&gt->reset.backoff_srcu){++++}-{0:0}, at: _intel_gt_reset_lock+0x172/0x330 [i915]
> 
> Can't see it related (as the only relevant thing is runtime suspend,
> getting delayed by 17ms after this change, which shouldn't make a
> difference).
> 
> Looks like some GuC vs. memory shrinker lockdep problem, filed already
> on other platforms at:
> https://gitlab.freedesktop.org/drm/intel/-/issues/8668
> 
> > Known issues
> > ------------
> > 
> >   Here are the changes found in Patchwork_119480v2 that come from known issues:
> > 
> > ### IGT changes ###
> > 
> > #### Issues hit ####
> > 
> >   * igt@i915_selftest@live@guc:
> >     - bat-rpls-1:         [PASS][3] -> [DMESG-WARN][4] ([i915#7852])
> >    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13309/bat-rpls-1/igt@i915_selftest@live@guc.html
> >    [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/bat-rpls-1/igt@i915_selftest@live@guc.html
> > 
> >   * igt@i915_selftest@live@hangcheck:
> >     - bat-adlp-9:         [PASS][5] -> [ABORT][6] ([i915#7677] / [i915#7913])
> >    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13309/bat-adlp-9/igt@i915_selftest@live@hangcheck.html
> >    [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/bat-adlp-9/igt@i915_selftest@live@hangcheck.html
> > 
> >   * igt@i915_selftest@live@requests:
> >     - bat-mtlp-6:         [PASS][7] -> [DMESG-FAIL][8] ([i915#7269])
> >    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13309/bat-mtlp-6/igt@i915_selftest@live@requests.html
> >    [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/bat-mtlp-6/igt@i915_selftest@live@requests.html
> > 
> >   * igt@i915_selftest@live@slpc:
> >     - bat-rpls-2:         NOTRUN -> [DMESG-WARN][9] ([i915#6367])
> >    [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/bat-rpls-2/igt@i915_selftest@live@slpc.html
> >     - bat-rpls-1:         [PASS][10] -> [DMESG-WARN][11] ([i915#6367])
> >    [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13309/bat-rpls-1/igt@i915_selftest@live@slpc.html
> >    [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/bat-rpls-1/igt@i915_selftest@live@slpc.html
> > 
> >   * igt@i915_suspend@basic-s2idle-without-i915:
> >     - bat-rpls-2:         NOTRUN -> [ABORT][12] ([i915#6687] / [i915#8668])
> >    [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/bat-rpls-2/igt@i915_suspend@basic-s2idle-without-i915.html
> > 
> >   * igt@kms_chamelium_hpd@common-hpd-after-suspend:
> >     - bat-dg2-11:         NOTRUN -> [SKIP][13] ([i915#7828])
> >    [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/bat-dg2-11/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
> > 
> >   
> > #### Possible fixes ####
> > 
> >   * igt@i915_selftest@live@requests:
> >     - bat-dg2-11:         [ABORT][14] ([i915#7913]) -> [PASS][15]
> >    [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13309/bat-dg2-11/igt@i915_selftest@live@requests.html
> >    [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/bat-dg2-11/igt@i915_selftest@live@requests.html
> > 
> >   * igt@i915_selftest@live@reset:
> >     - bat-rpls-2:         [ABORT][16] ([i915#4983] / [i915#7461] / [i915#7913] / [i915#8347]) -> [PASS][17]
> >    [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13309/bat-rpls-2/igt@i915_selftest@live@reset.html
> >    [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/bat-rpls-2/igt@i915_selftest@live@reset.html
> > 
> >   
> > #### Warnings ####
> > 
> >   * igt@kms_psr@primary_mmap_gtt:
> >     - bat-rplp-1:         [SKIP][18] ([i915#1072]) -> [ABORT][19] ([i915#8442])
> >    [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13309/bat-rplp-1/igt@kms_psr@primary_mmap_gtt.html
> >    [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/bat-rplp-1/igt@kms_psr@primary_mmap_gtt.html
> > 
> >   
> >   [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
> >   [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
> >   [i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
> >   [i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
> >   [i915#7269]: https://gitlab.freedesktop.org/drm/intel/issues/7269
> >   [i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
> >   [i915#7677]: https://gitlab.freedesktop.org/drm/intel/issues/7677
> >   [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
> >   [i915#7852]: https://gitlab.freedesktop.org/drm/intel/issues/7852
> >   [i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
> >   [i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
> >   [i915#8442]: https://gitlab.freedesktop.org/drm/intel/issues/8442
> >   [i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668
> > 
> > 
> > Build changes
> > -------------
> > 
> >   * Linux: CI_DRM_13309 -> Patchwork_119480v2
> > 
> >   CI-20190529: 20190529
> >   CI_DRM_13309: af67b02abf56a5018cd885c94d7611241052e98f @ git://anongit.freedesktop.org/gfx-ci/linux
> >   IGT_7346: 29302a0d57bcf10cb553f5d7ff5bb99166a19bba @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
> >   Patchwork_119480v2: af67b02abf56a5018cd885c94d7611241052e98f @ git://anongit.freedesktop.org/gfx-ci/linux
> > 
> > 
> > ### Linux commits
> > 
> > 00c643450930 drm/i915: Prevent needless toggling of DC states during modesets
> > 18d2155db09b drm/i915: Add way to specify the power-off delay of a display power domain
> > d7dab5293389 drm/i915: Remove redundant forward declarations from display power headers
> > 1088d3e9cdc5 drm/i915: Add missing forward declarations/includes to display power headers
> > 
> > == Logs ==
> > 
> > For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119480v2/index.html