Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/slpc: Update min_freq_softlimit when ignore_eff_freq is enabled
@ 2025-09-09 13:28 Sk Anirban
  2025-09-09 18:35 ` ✓ i915.CI.BAT: success for drm/i915/slpc: Update min_freq_softlimit when ignore_eff_freq is enabled (rev2) Patchwork
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Sk Anirban @ 2025-09-09 13:28 UTC (permalink / raw)
  To: intel-gfx
  Cc: anshuman.gupta, badal.nilawar, riana.tauro, karthik.poosa,
	raag.jadav, vinay.belgaumkar, Sk Anirban

When slpc_ignore_eff_freq is enabled, min frequency is set to RPn but
min_freq_softlimit is not updated, causing sysfs to show stale
values.

Update min freq softlimit when ignore_eff_freq is successfully enabled.

Signed-off-by: Sk Anirban <sk.anirban@intel.com>
---
 drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
index d5ee6e5e1443..07fa0423b1a3 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
@@ -495,10 +495,13 @@ int intel_guc_slpc_set_ignore_eff_freq(struct intel_guc_slpc *slpc, bool val)
 		slpc->ignore_eff_freq = val;
 
 		/* Set min to RPn when we disable efficient freq */
-		if (val)
+		if (val) {
 			ret = slpc_set_param(slpc,
 					     SLPC_PARAM_GLOBAL_MIN_GT_UNSLICE_FREQ_MHZ,
 					     slpc->min_freq);
+			if (!ret)
+				slpc->min_freq_softlimit = slpc->min_freq;
+		}
 	}
 
 	intel_runtime_pm_put(&i915->runtime_pm, wakeref);
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [PATCH] drm/i915/slpc: Update min_freq_softlimit when ignore_eff_freq is enabled
@ 2025-09-09 10:06 Sk Anirban
  0 siblings, 0 replies; 7+ messages in thread
From: Sk Anirban @ 2025-09-09 10:06 UTC (permalink / raw)
  To: intel-gfx
  Cc: anshuman.gupta, badal.nilawar, riana.tauro, karthik.poosa,
	raag.jadav, vinay.belgaumkar, Sk Anirban

When slpc_ignore_eff_freq is enabled, min frequency is set to RPn but
min_freq_softlimit is not updated, causing sysfs to show stale
values.

Update min freq softlimit when ignore_eff_freq is successfully enabled.

Signed-off-by: Sk Anirban <sk.anirban@intel.com>
---
 drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
index d5ee6e5e1443..a4d8279dbe8a 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
@@ -499,6 +499,8 @@ int intel_guc_slpc_set_ignore_eff_freq(struct intel_guc_slpc *slpc, bool val)
 			ret = slpc_set_param(slpc,
 					     SLPC_PARAM_GLOBAL_MIN_GT_UNSLICE_FREQ_MHZ,
 					     slpc->min_freq);
+			if (!ret)
+				slpc->min_freq_softlimit = slpc->min_freq;
 	}
 
 	intel_runtime_pm_put(&i915->runtime_pm, wakeref);
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2025-09-10 23:49 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-09 13:28 [PATCH] drm/i915/slpc: Update min_freq_softlimit when ignore_eff_freq is enabled Sk Anirban
2025-09-09 18:35 ` ✓ i915.CI.BAT: success for drm/i915/slpc: Update min_freq_softlimit when ignore_eff_freq is enabled (rev2) Patchwork
2025-09-09 22:37 ` [PATCH] drm/i915/slpc: Update min_freq_softlimit when ignore_eff_freq is enabled Belgaumkar, Vinay
2025-09-10  6:22   ` Anirban, Sk
2025-09-10 23:49     ` Belgaumkar, Vinay
2025-09-10  5:59 ` ✗ i915.CI.Full: failure for drm/i915/slpc: Update min_freq_softlimit when ignore_eff_freq is enabled (rev2) Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2025-09-09 10:06 [PATCH] drm/i915/slpc: Update min_freq_softlimit when ignore_eff_freq is enabled Sk Anirban

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox