Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Nilawar, Badal" <badal.nilawar@intel.com>
To: Sk Anirban <sk.anirban@intel.com>, <intel-gfx@lists.freedesktop.org>
Cc: <karthik.poosa@intel.com>, <anshuman.gupta@intel.com>
Subject: Re: [PATCH v2] drm/i915/selftests: Add delay to stabilize frequency in live_rps_power
Date: Tue, 3 Dec 2024 14:53:02 +0530	[thread overview]
Message-ID: <dc5330e1-d9ef-4f93-89e2-4318f64d3838@intel.com> (raw)
In-Reply-To: <20241203061114.2790448-1-sk.anirban@intel.com>



On 03-12-2024 11:41, Sk Anirban wrote:
> Add delays to allow frequency stabilization before power measurement
> to fix sporadic power conservation issues in live_rps_power test.
> 
> v2:
>    - Move delay to respective function (Badal)
> 
> Signed-off-by: Sk Anirban <sk.anirban@intel.com>
> ---
>   drivers/gpu/drm/i915/gt/selftest_rps.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/i915/gt/selftest_rps.c b/drivers/gpu/drm/i915/gt/selftest_rps.c
> index dcef8d498919..c207a4fb03bf 100644
> --- a/drivers/gpu/drm/i915/gt/selftest_rps.c
> +++ b/drivers/gpu/drm/i915/gt/selftest_rps.c
> @@ -1125,6 +1125,7 @@ static u64 measure_power(struct intel_rps *rps, int *freq)
>   static u64 measure_power_at(struct intel_rps *rps, int *freq)
>   {
>   	*freq = rps_set_check(rps, *freq);
> +	msleep(100);

Reviewed-by: Badal Nilawar <badal.nilawar@intel.com>

Regards,
Badal
>   	return measure_power(rps, freq);
>   }
>   


  parent reply	other threads:[~2024-12-03  9:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-03  6:11 [PATCH v2] drm/i915/selftests: Add delay to stabilize frequency in live_rps_power Sk Anirban
2024-12-03  7:16 ` ✓ i915.CI.BAT: success for drm/i915/selftests: Add delay to stabilize frequency in live_rps_power (rev2) Patchwork
2024-12-03  8:28 ` ✗ i915.CI.Full: failure " Patchwork
2024-12-03  9:23 ` Nilawar, Badal [this message]
2024-12-03 10:46 ` [PATCH v2] drm/i915/selftests: Add delay to stabilize frequency in live_rps_power Jani Nikula
2024-12-05  6:37   ` Anirban, Sk
2024-12-07  6:22     ` Raag Jadav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dc5330e1-d9ef-4f93-89e2-4318f64d3838@intel.com \
    --to=badal.nilawar@intel.com \
    --cc=anshuman.gupta@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=karthik.poosa@intel.com \
    --cc=sk.anirban@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox