Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH] drm/i915/gem: Fix error path to unlock if the GEM context is closed
Date: Wed, 6 Nov 2019 15:42:39 +0000	[thread overview]
Message-ID: <de2d913d-f02c-c18e-9090-ff054460b63a@linux.intel.com> (raw)
In-Reply-To: <20191106144155.25727-1-chris@chris-wilson.co.uk>


On 06/11/2019 14:41, Chris Wilson wrote:
> When inside the lock, remember to unlock even if you want to leave
> early.
> 
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Fixes: a4e7ccdac38e ("drm/i915: Move context management under GEM")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
>   drivers/gpu/drm/i915/gem/i915_gem_context.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c
> index a06cc8e63281..774d71b1ea9b 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_context.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c
> @@ -1168,7 +1168,7 @@ static int set_ppgtt(struct drm_i915_file_private *file_priv,
>   
>   	if (i915_gem_context_is_closed(ctx)) {
>   		err = -ENOENT;
> -		goto out;
> +		goto unlock;
>   	}
>   
>   	if (vm == rcu_access_pointer(ctx->vm))
> 

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/gem: Fix error path to unlock if the GEM context is closed
Date: Wed, 6 Nov 2019 15:42:39 +0000	[thread overview]
Message-ID: <de2d913d-f02c-c18e-9090-ff054460b63a@linux.intel.com> (raw)
Message-ID: <20191106154239.wKowhXNEDvIybTEwudPNmp_l4bV_XdbarbWLrd3gNFI@z> (raw)
In-Reply-To: <20191106144155.25727-1-chris@chris-wilson.co.uk>


On 06/11/2019 14:41, Chris Wilson wrote:
> When inside the lock, remember to unlock even if you want to leave
> early.
> 
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Fixes: a4e7ccdac38e ("drm/i915: Move context management under GEM")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
>   drivers/gpu/drm/i915/gem/i915_gem_context.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c
> index a06cc8e63281..774d71b1ea9b 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_context.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c
> @@ -1168,7 +1168,7 @@ static int set_ppgtt(struct drm_i915_file_private *file_priv,
>   
>   	if (i915_gem_context_is_closed(ctx)) {
>   		err = -ENOENT;
> -		goto out;
> +		goto unlock;
>   	}
>   
>   	if (vm == rcu_access_pointer(ctx->vm))
> 

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-11-06 15:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-06 14:41 [PATCH] drm/i915/gem: Fix error path to unlock if the GEM context is closed Chris Wilson
2019-11-06 14:41 ` [Intel-gfx] " Chris Wilson
2019-11-06 15:42 ` Tvrtko Ursulin [this message]
2019-11-06 15:42   ` Tvrtko Ursulin
2019-11-06 18:55 ` ✗ Fi.CI.BAT: failure for " Patchwork
2019-11-06 18:55   ` [Intel-gfx] " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=de2d913d-f02c-c18e-9090-ff054460b63a@linux.intel.com \
    --to=tvrtko.ursulin@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=dan.carpenter@oracle.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox